- Nov 14, 2020
-
-
Eric Chavaillaz authored
If the loading text of the login box is too large, the text exceeds the size of the login button. This patch allow the button to grow vertically. Resolves: #92622 Releases: master, 10.4 Change-Id: I9aa7858fd23c5f5848657c6c029769e9fa8de179 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66554 Tested-by:
Martin Kutschker <mkutschker-typo3@yahoo.com> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Helmut Hummel authored
Change the implementation of backend deferred image processing to use a file processor, which is only but always used in the backend. By doing so all limitations of the current implementation are resolved, which means, width and height of the image can be set in HTML, to avoid layout shifts and once the images are processed, they will simply be delivered by the web server. Inconsistencies with thumbnail ratio (depending on crop being defined or not) are also tackled on the go. While this changes processing configuration for some files, which triggers a re-generation, it should not matter, as image processing will be done in parallel on request, making such changes viable in a bugfix release. The introduced database field is neither used nor required for the current implementation, but is introduced to provide a possibility for third party processors to replace the current implementation with simple (and persisted) URLs to third party SaaS image processing services. Resolves: #92188 Releases: master, 10.4 Change-Id: I8d1e14324085c5b6ba646475206c8cb10a1fc10d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65237 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Back in 6.2 at ExtJS times, a feature has been introduced to the workspace module to extend the shown 'data grid' with custom columns. This implementation has been done for one specific customer who nowadays does not use the feature anymore. The feature broke when the transition to a native JavaScript implementation has been done in v8. There is not a single bug report this feature broke in forge, and it is hard to resurrect it with the new client side implementation. The patch drops related code from the extension. This gives core development more freedom to improve the workspace module with other patches. Change-Id: Ie66b172484cdd08de06e019aa004055975948e85 Resolves: #92838 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66632 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Georg Ringer authored
The TSconfig setting `mod.web_layout.disableAdvanced` has been used to disable the "clear cache"-button in the page module. Since this behaviour can be triggered through various other ways, like the context menu or by just saving the page record, this feature is removed completely. Resolves: #92837 Releases: master Change-Id: Ie4c563d89280bc494265611924e2b02727aed644 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66631 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Nov 13, 2020
-
-
Christian Kuhn authored
SqlServer can not handle a transaction for a table, if the same table is queried currently. The install tool database row updater does this. Solution is to skip the transaction on this platform. Additionally, an update query is fixed to hint for proper field types. Resolves: #92832 Releases: master, 10.4 Change-Id: I5fc76705088a727dc1ff41410d6e2cd02b3d9655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66622 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Hader authored
* replace string states with specific StatusMessage models * combine file path and base URL in new FileLocation model * streamline responsibilities of classes Resolves: #92834 Releases: master, 10.4, 9.5 Change-Id: Ib1a24fb00d4362062e88f93f236b3fd385015c3c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66624 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The package @typo3/icons can be updated to version 2.0.4 which adds some new icons and reverts the icons "actions-edit-hide" and "actions-edit-unhide" to their v1 variants. Executed commands: cd Build yarn add "@typo3/icons@^2.0.4" yarn build Resolves: #92833 Releases: master, 10.4 Change-Id: I78933010cb2d36b0d412b20c5e0d63976cc77035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66623 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Benni Mack authored
This change adds the methods * setRequest() * getRequest() * getUriBuilder() to the RenderingContext of EXT:Fluid. The main goal is to reduce the usages of the ControllerContext as much as possible to decouple Extbase from Fluid. When the "setRequest" method is used in the renderingContext, the controllerContext is filled as well, in order to be backwards-compatible. Resolves: #92826 Releases: master Change-Id: I41b8741e947c78895317ef2235959ceb251e103c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66323 Tested-by:
-
- Nov 12, 2020
-
-
Peter Kraume authored
Resolves: #92821 Releases: master, 10.4, 9.5 Change-Id: Ife0999560d3da75051b663b55d46e0f6a5e03dfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66617 Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
Benni Mack authored
Creating a new record in a workspace adds two database rows. One that is the "placeholder", which - since v10.4 - contains the same metadata as the other record: * t3ver_wsid = workspaceID * t3ver_oid = 0 (simulating behavior of an "online pendant record") * t3ver_state = 1 And the "versionized" record, identified by: * t3ver_wsid = workspaceID * t3ver_oid = uid of the new placeholder record * t3ver_state = -1 As of TYPO3 v10, the first record is not needed anymore, the versioned record can be queried directly, however, since the relations (except MM) point to the placeholder record, this one is kept. As result, only one record is created from now on: * t3ver_wsid = workspaceID * t3ver_oid = 0 (no online counterpart) * t3ver_state = 1 On reading, the record is queried directly (no overlay needed anymore!) with the existing Database Doctrine Restrictions. On publishing, the record just gets the state/stage/wsid set and is "live". This brings fundamental benefits: * No overlays needed when querying * Fewer database records (placeholders are not helpful) * Conceptual problems with placeholder and shadowed fields are removed Resolves: #92791 Releases: master Change-Id: I0288cc63fe72d8442d586f309bd4054ac44e829b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65587 Tested-by:
-
Oliver Bartsch authored
In #92659 the tt_content fields `imagewidth` and `imageheight` have been adjusted to not limit user input per default. This improves the corresponding rst to properly describe the changes made. Resolves: #92825 Relates: #92659 Releases: master Change-Id: I61b1ee1fed95251d1a3be4dc9e3c996fb033aa04 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66611 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
- Nov 11, 2020
-
-
Guido Schmechel authored
Use the current W3C recommended mime types for fonts in htaccess base file, see https://www.iana.org/assignments/media-types/media-types.xhtml#font Releases: master, 10.4 Resolves: #92743 Change-Id: I8abc5abe703ef02ed678e8f7b7b28a3544ce239e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66513 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benjamin Franzke authored
No need to use a fully qualified namespace for 3rd party modules that are placed in TYPO3/CMS/Core/Contrib. There are usually aliases configured in the requirejs configuration, and if they are missing, we add them now. This change additionally drops an unneded module declaration for "TYPO3/CMS/Core/Contrib/imagesloaded.pkgd.min" which is not needed when simply using "imagesloaded" as module name. Commands used: grunt build Releases: master, 10.4 Resolves: #92725 Change-Id: I6e7c02104050202d5c1a8bd0d7546a1496f5636c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65693 Tested-by:
-
Alexander Nitsche authored
Only tables with TCA configurations are available for the export of a TYPO3 instance. The stored export configurations - so called presets - were missing the TCA configuration and thus had to be exported and imported separately in a database client. This patch adds a TCA configuration for the export configurations and thus makes them exportable and importable along with the main dump. The presets are saved on PID=0 and hidden from record lists to force the user to continue managing them with the export module. Resolves: #92346 Releases: master, 10.4 Change-Id: Ic5a9babc91a93f8bf1561b697c4fca0ad548f734 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65770 Reviewed-by:
Rémy DANIEL <dogawaf@no-log.org> Reviewed-by:
-
Xavier Perseguers authored
Due to a refactoring and "unrolling" of buttons in TYPO3 v9, the TSconfig options.saveDocNew has been forgotten when adding a button to create a new record right while editing another one. Even if the new button nowadays is physically not a "Save and create new" action in the label, the behaviour is strictly the same as any unchanged edit will trigger a modal asking whether the changes should be persisted. Releases: master, 10.4, 9.5 Resolves: #87321 Resolves: #92788 Change-Id: Ic79f7ff06afef0cf9423780eef2d5324e5613664 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66559 Tested-by:
Eric Chavaillaz <eric@hemmer.ch> Tested-by:
-
Anja Leichsenring authored
Two new options for the famous Build/Scripts/runTests.sh script have been added, that allow to quickly set up local environment for composer min and max testing. There is now - Build/Scripts/runTests.sh -s composerInstallMax for no platform.php setting and `composer update` preset and - Build/Scripts/runTests.sh -s composerInstallMin for platform.php set to current PHP version bugfix version 0 (like 7.2.0 or 8.0.0) and `composer update --prefer-lowest` preset Resolves: #92795 Releases: master, 10.4, 9.5 Change-Id: I13f782f2e73bb89404fcd2e18d507e2c39e4eba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66570 Tested-by:
-
Christian Kuhn authored
Contains a change for an upcoming workspace related core patch. composer require --dev typo3/testing-framework ^6.4.7 Change-Id: I11980b635e3a2b00de481a8d73b69368554c08d3 Releases: master, 10.4 Resolves: #92818 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66604 Tested-by:
-
Sybille Peters authored
The Developer page explained how link handling is done in the RTE. This is not specific to linkvalidator and may change in the future. Understanding how the existing events work can be better done by looking in the core. Resolves: #92720 Releases: master Change-Id: I88bdf27c2045c29c0f93bcc3f394cb21471e0b73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66274 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Nov 10, 2020
-
-
Sybille Peters authored
Previously, if there were too many redirects, an error message "A redirect loop occurred" was displayed. This was misleading. A redirect loop is different from "too many redirects". "Too many redirects simply means that the maximum number of redirects used by the underlying HTTP request library (Guzzle) is reached before reaching the destination. This happens by default after 5 redirects. Therefore, the "too many redirects" error is now being displayed with its own message. Resolves: #92741 Releases: master Change-Id: I69e191e1f2c771eb83b8c82b2be12dd58730d8e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66363 Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
spthiel authored
The renderType `selectCheckbox` allows for grouping of items, which are rendered as collapsed per default. A new TCA setting now allows to define this behavior for all groups at once. By adding the new setting `expandAll=true`, all groups are initially expanded. If not set or set to FALSE the current behvahiour remains and all groups are collapsed. Releases: master Resolves: #91859 Change-Id: I9db196a7bfa6b1399358afdc785814425a764e80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65081 Tested-by:
-
Torben Hansen authored
Adds a focus style to the button on the login form so it is visible that the button has the focus. Resolves: #92620 Releases: master, 10.4 Change-Id: I1e98ed780cfbf2744cbf3646317f74911a8deeb2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66259 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Torben Hansen authored
Removed an unknown aria attribute from the modules menu and added an `aria-controls` attribute to 1st level menu items. Resolves: #92634 Releases: master, 10.4 Change-Id: Id15f902053e091add3e1321dbf6e6d23d9a0805d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66261 Tested-by:
-
Benni Mack authored
It is recommended for <style> and <link> HTML tags to not use the "type" attribute anymore. Details: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style The patch drops the attribute from rendering. The patch is marked as a breaking since it changes frontend output. Resolves: #45512 Releases: master Change-Id: I073d7ef6c40a824755768d33fcc71c9f26090801 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65548 Tested-by:
-
Benni Mack authored
The feature flag "security.frontend.keepSessionDataOnLogout" was introduced as part of a security bugfix to still enable frontend users to keep their session data even if they have logged out, where the session data was transferred and migrated to an anonymous session. Since this feature in general is insecure, as people who log off from a public computer would keep session data on that machine, the functionality is fully removed. Resolves: #92807 Releases: master Change-Id: Ieaebcc33e85e1df6e359a7eae318712896800bca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66596 Tested-by:
-
Anja Leichsenring authored
The formerly hard coded DBMS versions the local testing script Build/Scripts/runTests.sh received more options to run almost all supported DBMS versions by passing addidional parameters. Resolves: #92794 Releases: master, 10.4 Change-Id: I402a605782c1063f4ec336d6279b768a79d1cc2b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66569 Tested-by:
Patrick Schriner <patrick.schriner@diemedialen.de> Tested-by:
-
- Nov 09, 2020
-
-
Benni Mack authored
One of TYPO3's major "fat" classes AbstractUserAuthentication is now thinned out as the "email when X failed login have been reached within a certain period of time" is moved to a hook implementation. AbstractUserAuthentication now does not have - public property $warningEmail - public property $warningPeriod - public property $warningMax - public method checkLogFailures() anymore, as this functionality were only used for this separate logic. Resolves: #92801 Releases: master Change-Id: Ib022af408a740bc6c5bbbb219f23e665182ae83c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66594 Tested-by:
-
Benni Mack authored
The AbstractUserAuthentication property "auth_timeout_field" was used in the past (until TYPO3 8.0) to be filled for backend purposes with "$GLOBALS['TYPO3_CONF_VARS']['BE']['sessionTimeout']" and for backend with the lifetime field. This field was not properly filled since TYPO3 v8.0, see issue #68890 for details. As the field had a dual-use but now is unused, it is properly removed as TYPO3 Core never implemented this on a per-userrecord-basis but handles this via the sessionTimeout propery now. Resolves: #92802 Related: #68890 Releases: master Change-Id: I760b50a292b93229bbebffac08e11393fe53393f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66595 Tested-by:
-
Christian Kuhn authored
* (v10) Moving a page that exists in live within workspaces multiple times does not upate the pid of the t3ver_state=4 overlay. * (v10, master) Moving a page that has translations in workspaces multiple times does not always properly update the pid of the translation overlay records to the new location. The patch fixes both issues and adds a series of functional tests to verify db state of these more complex / chained scenarios. It also marks one scenario as todo where a delete overlay is wrongly turned into a move overlay, effectively loosing the 'shall be deleted in live during publish' information. This can be fixed with another patch. Change-Id: If678440c980b8847232a6d146855025ff0091795 Resolves: #92779 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66452 Tested-by:
-
Benni Mack authored
In order to ensure best practices security-wise, it is recommended to have the flag "disableNoCacheParameter" enabled by default. The change enables this option for new installations. Resolves: #92792 Releases: master, 10.4 Change-Id: Ifdb2ad46e456f76c8cd78e027068d24f73dbb55c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66567 Tested-by:
-
- Nov 07, 2020
-
-
Oliver Hader authored
PHP versions 8.0-RC1, 7.4.12, 7.3.24 introduced a different behavior for `stream_wrapper_restore()` and would throw a PHP notice which is mitigated with this phar stream wrapper release. see https://github.com/TYPO3/phar-stream-wrapper/releases/tag/v3.1.6 composer require typo3/phar-stream-wrapper:^3.1.6 Resolves: #92789 Releases: master, 10.4, 9.5 Change-Id: Ia2bc9b4fd7f568b9a4390205e1d332050904a15b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66560 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Daniel Siepmann authored
When using renderType textTable for text fields in TCA, the controller will pass the currently stored value to underlying API. This API always expects a string. Most of the time those fields might have null as default in persistence leading to a PHP TypeError. Therefore a check is added which will fall back to empty string as proper default for internal API. Resolves: #92761 Releases: master, 10.4, 9.5 Change-Id: I29ef4076e21a1f93f9b6834afcc163c4041a0909 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66381 Tested-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
-
- Nov 06, 2020
-
-
Benni Mack authored
The TCA definitions for sys_file.fileinfo and sys_file_metadata.fileinfo were marked "user" but without any database definition, leading to side-effects when automating translations (e.g. in l10nmgr). However, they only provide information (= a virtual field), so the definition should be of type "none". Resolves: #92312 Releases: master, 10.4 Change-Id: I9941e07a304ecade5c8b0de7ce82591178172d68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66378 Tested-by:
Jo Hasenau <info@cybercraft.de> Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92111 Change-Id: I28058d9e9e9886f1156a0124f0b360d9788dfdc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65466 Tested-by:
-
manuel_winkelhofer authored
Add autocomplete attributes to Login form and ForgetPasswordForm Inputs Use `autocomplete="email"`, `autocomplete="username"` and `autocomplete="current-password"` for the form fields before logged in. Resolves: #92624 Releases: master Change-Id: Iff12afc08f30e82fd6fafc559c04c51a654c0c1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66312 Tested-by:
-
Alexander Schnitzler authored
With this patch, Extbase does no longer handle/return extbase responses whose api was defined by the extbase ResponseInterfacer. Instead, Extbase does create a PSR-7 compatible response object and passes it back through the request handling stack. Since PSR-7 requires response objects to be immutable, the response object is no longer accessible as property of class ActionController. It is also no longer accessible through the ControllerContext class. In fact, the response is completely hidden from the user and can no longer be changed. To address this issue, an upcoming patch will enable users to return user controlled responses from within controller actions instead of just returning content strings. User will then be forced to return response objects with the content and all necessary headers, such as the content-type, set. Since the Response class has been deleted, it is no longer usable in user land code. It should be replaced with PSR-7 compatible response objects to stay compatible with response handlers of both the core and extbase. Releases: master Resolves: #92502 Change-Id: I4d5dc1478be6dd25b43f6249139eeb4ce5cc3094 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66070 Tested-by:
-
Torben Hansen authored
Increased contrast ratio to at least 3:1 for input fields of the class "input-login" and also a box shadow has been added to those elements. Resolves: #92623 Releases: master Change-Id: I9ca741a1a308077bcf05092de52c56133e83d355 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66260 Tested-by:
-
- Nov 05, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #91576 Change-Id: Idb80fced22515fbd25365ff43b64b6618d5cedc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64449 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Olaf Schmidt-Wischhöfer authored
The dropzone for file uploads now uses two <button> tags instead of <div> tags. One for the dropzone itself and the other one for the close button. The dropzone button now has got an `aria-labelledby` attribute pointing to the dropzone title. The close button got an `aria-label` attribute. Both to support screen readers. Resolves: #92680 Releases: master, 10.4 Change-Id: I32ce15dfc8c36c6fbfd17ef993ceacb8e5aaf3e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66270 Tested-by:
-
Oliver Bartsch authored
The "select all" and "deselect all" buttons in the "Send to stage" modal in workspaces are now proper button tags. This also allowed to remove the superfluous preventDefault() call in JavaScript. Resolves: #92776 Releases: master, 10.4 Change-Id: I1480ad06df501a4064609e516c8b10d6b4567425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66453 Tested-by:
-
Christian Kuhn authored
In workspace frontend preview, clicking the "Send to stage" button renders a modal to select mail recipients to notify recipients. The two "Check all" / "Uncheck all" buttons don't work since the click events are not registered in preview mode. The patch adds them. Resolves: #92759 Releases: master, 10.4 Change-Id: I9b97f9a5f476d8abc4f846af297ec60049abcd69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66380 Reviewed-by:
-
