[!!!][TASK] Make Extbase handle PSR-7 responses only
With this patch, Extbase does no longer handle/return extbase responses whose api was defined by the extbase ResponseInterfacer. Instead, Extbase does create a PSR-7 compatible response object and passes it back through the request handling stack. Since PSR-7 requires response objects to be immutable, the response object is no longer accessible as property of class ActionController. It is also no longer accessible through the ControllerContext class. In fact, the response is completely hidden from the user and can no longer be changed. To address this issue, an upcoming patch will enable users to return user controlled responses from within controller actions instead of just returning content strings. User will then be forced to return response objects with the content and all necessary headers, such as the content-type, set. Since the Response class has been deleted, it is no longer usable in user land code. It should be replaced with PSR-7 compatible response objects to stay compatible with response handlers of both the core and extbase. Releases: master Resolves: #92502 Change-Id: I4d5dc1478be6dd25b43f6249139eeb4ce5cc3094 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66070 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de>
Showing
- typo3/sysext/beuser/Classes/Controller/BackendUserController.php 2 additions, 2 deletions...ysext/beuser/Classes/Controller/BackendUserController.php
- typo3/sysext/core/Documentation/Changelog/master/Breaking-92502-MakeExtbaseHandlePSR7ResponsesOnly.rst 57 additions, 0 deletions...ter/Breaking-92502-MakeExtbaseHandlePSR7ResponsesOnly.rst
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/irre_tutorial/Classes/Controller/AbstractController.php 2 additions, 2 deletions...s/irre_tutorial/Classes/Controller/AbstractController.php
- typo3/sysext/extbase/Classes/Core/Bootstrap.php 12 additions, 32 deletionstypo3/sysext/extbase/Classes/Core/Bootstrap.php
- typo3/sysext/extbase/Classes/Event/Mvc/AfterRequestDispatchedEvent.php 1 addition, 1 deletion...extbase/Classes/Event/Mvc/AfterRequestDispatchedEvent.php
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php 39 additions, 34 deletions...ysext/extbase/Classes/Mvc/Controller/ActionController.php
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerContext.php 0 additions, 26 deletions...sext/extbase/Classes/Mvc/Controller/ControllerContext.php
- typo3/sysext/extbase/Classes/Mvc/Controller/ControllerInterface.php 2 additions, 2 deletions...xt/extbase/Classes/Mvc/Controller/ControllerInterface.php
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php 2 additions, 2 deletionstypo3/sysext/extbase/Classes/Mvc/Dispatcher.php
- typo3/sysext/extbase/Classes/Mvc/Exception/StopActionException.php 2 additions, 2 deletions...ext/extbase/Classes/Mvc/Exception/StopActionException.php
- typo3/sysext/extbase/Classes/Mvc/RequestHandlerInterface.php 2 additions, 0 deletionstypo3/sysext/extbase/Classes/Mvc/RequestHandlerInterface.php
- typo3/sysext/extbase/Classes/Mvc/Response.php 0 additions, 379 deletionstypo3/sysext/extbase/Classes/Mvc/Response.php
- typo3/sysext/extbase/Classes/Mvc/ResponseInterface.php 0 additions, 50 deletionstypo3/sysext/extbase/Classes/Mvc/ResponseInterface.php
- typo3/sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php 3 additions, 3 deletions...sysext/extbase/Classes/Mvc/Web/FrontendRequestHandler.php
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php 2 additions, 2 deletions...nsions/blog_example/Classes/Controller/BlogController.php
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php 2 additions, 2 deletions...ons/blog_example/Classes/Controller/ContentController.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerArgumentTest.php 3 additions, 3 deletions...unctional/Mvc/Controller/ActionControllerArgumentTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ActionControllerTest.php 6 additions, 0 deletions.../Tests/Functional/Mvc/Controller/ActionControllerTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Controller/ControllerArgumentsMappingTest.php 7 additions, 1 deletion...ctional/Mvc/Controller/ControllerArgumentsMappingTest.php
- typo3/sysext/extbase/Tests/Functional/Mvc/Validation/ActionControllerValidationTest.php 4 additions, 4 deletions...ctional/Mvc/Validation/ActionControllerValidationTest.php
Please register or sign in to comment