- Feb 07, 2019
-
-
Benni Mack authored
All PSR-15 middlewares now do not set the $GLOBALS['TYPO3_REQUEST'] object anymore. Instead, the RequestHandlers are using them for all other logic (e.g. GP etc) where the request object or any other attribute has not been handed in yet. It is now safe to say that PSR-7 request/response objects have to be used within middlewares to access or manipulate GET/POST data. Also, the safety net for overriding GET/POST again is still in place for FE (data = GP:id) in order for existing TypoScript to work still, until all other code gets global-free. There are still places in TYPO3 Core where $TYPO3_REQUEST is necessary (TypoScriptConditionMatcher, Error Handling) which are added accordingly. Resolves: #87661 Releases: master Change-Id: Ibe499b6fda86ccd3abefcb3c8be294a7cb765d74 Reviewed-on: https://review.typo3.org/59490 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The accepted change adds an ugly side-effect when using the same controller/action in multiple route variants. This reverts commit 977ed578. Resolves: #87668 Reverts: #87337 Releases: master, 9.5 Change-Id: I7167b42cb26538e676256c9d2e36d1ec18f2bd40 Reviewed-on: https://review.typo3.org/59658 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Guido Schmechel authored
If the controller of a route in a routeEnhancer differs from the default controller, it will now be used for the generation of enhancers. Resolves: #87337 Releases: master, 9.5 Change-Id: Iea3d15bbc99cb17c640e6a4824d3dd42176295d1 Reviewed-on: https://review.typo3.org/59343 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
Richard Haeser <richard@maxserv.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Georg Ringer authored
InputOption::VALUE_REQUIRED must be used instead of InputArgument::REQUIRED. Resolves: #87648 Releases: master, 9.5 Change-Id: Ifd727ec26af0e1e2237e9ca5ae480b9ed2fd5b6f Reviewed-on: https://review.typo3.org/59643 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Markus Klein <markus.klein@typo3.org>
-
- Feb 06, 2019
-
-
Oliver Hader authored
Adds DataHandler tests that were available for TCA type inline/FF for inline/CSV as well (initially introduced with issue ##79856). Resolves: #87666 Releases: master, 9.5, 8.7 Change-Id: I01eadae3fc00a0ba037e1c8ef7e92b6de467266d Reviewed-on: https://review.typo3.org/59652 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Alexander Schnitzler authored
Class QueryFactory does no longer use setter injection but constructor injection instead. Releases: master Resolves: #87642 Change-Id: I5d595ff2c9b5b7e81f5d6380eef1284e0e2d9739 Reviewed-on: https://review.typo3.org/59631 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Benni Mack authored
The logic within EXT:felogin for validating proper redirect/referer URLs is extracted into a new PHP class, which can now be called separately. This is useful for further refactorings within the Controller, and it lays the foundation to use proper validation in various places other than Extbase. Resolves: #87660 Releases: master Change-Id: I79aab5908bde869b7ee3cf730fbf61d658f2ee88 Reviewed-on: https://review.typo3.org/59648 Tested-by:
-
- Feb 05, 2019
-
-
Josef Glatz authored
All occurrences of APC (without suffix "u") are removed from the TYPO3 core since APC is discontinued and does not work with PHP 7.x. This changes does not affect the PHP OPcache related area. Releases: master Resolves: #87583 Change-Id: Ie724f8343dae9bdc4721d35c6d384c1de51f365e Reviewed-on: https://review.typo3.org/59588 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Stephan Großberndt authored
When editing a fe_group show its subgroups even if those are set to hidden in order to avoid losing the subgroup relation on saving the fe_group. Resolves: #87649 Releases: master, 9.5 Change-Id: Ic39f32b47327202a848827bd9d6b4935c35edcdd Reviewed-on: https://review.typo3.org/59640 Tested-by:
Xavier Perseguers <xavier@typo3.org> Tested-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Alexander Schnitzler authored
ObjectAccess had two kinds of runtime reflection calls: 1) To gather data about object properties and methods 2) To make non public properties accessible The first one is tackled by using class schema instances and by using the property accessor of symfony/property-access. The latter is tackled by deprecating all method arguments that trigger reflection to make properties accessible. In the future, gettable/settable properties need to be either public or have a getter (get*/has*/is*) or setter. Releases: master Resolves: #87332 Change-Id: I6ecef81de7aa4cc1244166d683874a1a87ac6bb7 Reviewed-on: https://review.typo3.org/59331 Reviewed-by:
André Schließer <andy.schliesser@gmail.com> Tested-by:
-
- Feb 03, 2019
-
-
Alexander Schnitzler authored
This patch introduces the requirement to symfony/property-info which provides a neat api to extract information about properties via several different extractors. The package comes with a PhpDocExtractor, which is kind of a drop in replacement (functional wise) for the extbase DocCommentParser which has been removed. Along with the replacement of the doc block extractor the package comes with an api to fetch context data that enables us to resolve non fully qualified class names. This is now possible: ``` use TYPO3\CMS\Extbase\Persistence\ObjectStorage; use ExtbaseTeam\BlogExample\Domain\Model\Comment; class Post { /* * @var ObjectStorage<Comment> */ public $comments; } ``` Important: This only works in extbase models as the reflection costs are high and the information is only needed in this case. The non fully qualified class name is now also supported for injection properties, although it is still recommended to avoid injection properties in favor of injection methods or constructor injection. Example: ``` use TYPO3\CMS\Extbase\Annotation as Extbase; use TYPO3\CMS\Extbase\Configuration\ConfigurationManager; class Service { /* * @Extbase\Inject * @var ConfigurationManager */ public $configurationManager; } ``` Releases: master Resolves: #87457 Change-Id: I006aeb737b4bb9790fda257e12ba46a105d9b113 Reviewed-on: https://review.typo3.org/59454 Tested-by:Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Feb 02, 2019
-
-
Benjamin Franzke authored
The recently introduced `object` type declarations for extbase classes require a minimum version of prophecy 1.7.5. Previous versions trigger the following error: Scalar type declaration 'object' must be unqualified Prophecy added support for object type declarations in 1.7.4 and for return type object declarations in 1.7.5. Therefore we add an explicit dev dependency to prophecy in composer.json now (previously it was transitively required as ^1.7 by phpunit 7.1). composer require --no-update --dev phpspec/prophecy:^1.7.5 composer update --lock Releases: master Resolves: #87622 Change-Id: Ic35db424d1ea46143839ec3f4bd3c10e39c99b4e Reviewed-on: https://review.typo3.org/59620 Reviewed-by:
Alexander Schnitzler <typo3@alexanderschnitzler.de> Tested-by:
-
- Feb 01, 2019
-
-
Markus Klösges authored
When saving and retrieving object from the persistence session, implementation class names set via \TYPO3\CMS\Extbase\Object\Container are now respected by storing and retrieving them with that overridden class name. Resolves: #77617 Releases: master, 9.5 Change-Id: I887cb164328afe789dc274c92c8f8774b2098a40 Reviewed-on: https://review.typo3.org/58959 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
André Schließer authored
Use default language as fallback for records with sys_language_uid = -1 Resolves: #87067 Releases: master, 9.5 Change-Id: If57d5566b83f4bba79451e8595337ca6c0eb3fc9 Reviewed-on: https://review.typo3.org/59029 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Reviewed-by:
-
Georg Ringer authored
Resolves: #87580 Releases: master Change-Id: I5a384707d0c0ecd9b797ce89dced25f0738942c6 Reviewed-on: https://review.typo3.org/59584 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Anja Leichsenring authored
The ImageService::getImage requires a string as first and a boolean as third parameter. The ThumbnailViewHelper must respect this requirement. Resolves: #87621 Relates: #87599 Releases: master Change-Id: Ib84f88665fd692629efdb54a33ff83263abe6bfe Reviewed-on: https://review.typo3.org/59617 Reviewed-by:
-
Andreas Fernandez authored
Meta data of files handled by FAL is fetched, created and updated in various places, which makes it hard to maintain the current code base. Albeit the method `_getMetaData()` is marked as internal, it has been marked as deprecated as well, because the method is widely used in the TYPO3 extension universe. For this reason, a MetaDataAspect is introduced that takes care of meta data handling on a low-level basis. In the same run, FAL's `Indexer` is now responsible for creating or updating such meta data records, the `ResourceStorage` now only tells whether auto-extraction is enabled. The meta data extraction, based on registered extractors implementing the `ExtractorInterface` interface, has been moved into a separate service class. Resolves: #85895 Releases: master Change-Id: Icb929a6226777dcea3868ee5c083cf13ff5a71f6 Reviewed-on: https://review.typo3.org/57908 Tested-by:
-
Andreas Fernandez authored
The scheduler now catches any error implementing the `\Throwable` interface thrown by a task to be able to mark such task as executed. Resolves: #87502 Releases: master, 9.5, 8.7 Change-Id: I1f1bebee922c864ce8d7bfc3f0aa6e9434228e98 Reviewed-on: https://review.typo3.org/59504 Tested-by:
-
Stefanos Karasavvidis authored
Use a proper message in case a non existent uid was passed and correctly handle the case where no task uid was passed and no task is overdue. Resolves: #87375 Releases: master, 9.5, 8.7 Change-Id: I69d2798cc185451c889bf37d8a007eacf572c163 Reviewed-on: https://review.typo3.org/59385 Reviewed-by:
Fabien Udriot <fabien.udriot@ecodev.ch> Tested-by:
-
Harald Atteneder authored
substr returns a boolean instead of an empty string. A typecast fixes this problem (See http://php.net/manual/de/function.substr.php#90369) Resolves: #87387 Releases: master, 9.5 Change-Id: I14aa49c18ae028dc27b94bfdbfc3dfb643c18746 Reviewed-on: https://review.typo3.org/59395 Tested-by:
-
Andreas Fernandez authored
The FieldControl `EditPopup` now uses a dedicated module for its handling and no longer uses inline `onclick` handlers nor inline FormEngine calls. Resolves: #86644 Releases: master Change-Id: I46e5d3dbfcb4c187afb6cd1c0692b4e728bfaf26 Reviewed-on: https://review.typo3.org/58887 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Johannes Seipelt authored
- Use strict type mode - Use type hints whereever possible - fix test of creating viewhelper instance using object manager Releases: master Resolves: #87605 Change-Id: Ia626ae1156dacd7c9ddcfefed9bb03d26ba91404 Reviewed-on: https://review.typo3.org/59600 Reviewed-by:
Johannes Seipelt <johannes.seipelt@3m5.de> Reviewed-by:
Felix Döring <Felix.Doering@3m5.de> Reviewed-by:
-
Frank Naegler authored
This patch adds a new ViewHelper to render thumbnails deferred in the backend. This increase the performance of the file list. Resolves: #85607 Related: #85605 Releases: master Change-Id: Id97876e889605d7d8d3075ee98a4fc34b002f395 Reviewed-on: https://review.typo3.org/57646 Tested-by:
-
Josef Glatz authored
Reduce information disclosure of the used TYPO3 version by adding a dynamic 4-digit year in the TYPO3_copyright_year constant. That makes it more difficult to find out the used TYPO3 version just by looking at the frontend source code of a website. Releases: master, 9.5 Resolves: #87543 Change-Id: Ic169548c7111715eecedfce4ced5c8a3564d102a Reviewed-on: https://review.typo3.org/59565 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
-
Ralf Zimmermann authored
Use the real finisher identifiers as they are configured in the form definition instead the finisher implementation class name. This requires a change of the public AbstractFinisher implementation which implements the FinisherInterface. The interface is not changed, as this would be a breaking change. Therefore, the existence of the new method is checked. If it does not exist in a finisher implementation, a fallback to the previous behavior happens. Releases: master, 9.5 Resolves: #87615 Change-Id: I962502f0601845a5f9793751e87c97b3b902caa1 Reviewed-on: https://review.typo3.org/59606 Tested-by:
-
Gerrit Mohrmann authored
Fixes missing output in ifAuthenticatedViewHelper after cache clearing and erroneous replication of field properties to subsequent fields. composer command used: composer update typo3fluid/fluid Resolves: #86930 Resolves: #86890 Resolves: #87430 Resolves: #86910 Resolves: #87586 Releases: master, 9.5 Change-Id: I8d1abd0aa08d7d7399ec23675dcf07d08dbdd2f2 Reviewed-on: https://review.typo3.org/59554 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Alexander Schnitzler authored
This patch introduces a new Method class to have an easier and more stable api to get information about class methods from ClassSchema objects. The reflection data fetched and stored by/in the ClassSchema objects is no longer publicly available as an array. Instead, Method objects are returned for the following calls: - getMethod - getMethods - getInjectMethods Also it removes the following method: - getConstructorArguments The following constants are marked as private: - ClassSchema::MODELTYPE_ENTITY - ClassSchema::MODELTYPE_VALUEOBJECT Releases: master Resolves: #87427 Change-Id: I38e8a7287896e9303fad1fa8f8f9182895365adc Reviewed-on: https://review.typo3.org/59422 Reviewed-by:
-
Frank Naegler authored
Resolves: #87607 Related: #87193 Releases: master Change-Id: I5c1ce876cd6ad5edeecefce03d7a1e3619f9d54c Reviewed-on: https://review.typo3.org/59491 Tested-by:
-
Anja Leichsenring authored
The ImageService::getImage requires a string as first and a boolean as third parameter. The Image ViewHelpers must respect this requirement. Resolves: #87619 Relates: #87599 Releases: master Change-Id: I0d8f57c2bef62dcc6b4d6e6684bbbb1593bff98f Reviewed-on: https://review.typo3.org/59608 Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87599 Change-Id: I8840b7fad16c4fffb7f50973fb97a498e0f683e4 Reviewed-on: https://review.typo3.org/59594 Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87597 Change-Id: Ic4cfb5512f49b3e20fa16c782301b8dcb2ba5dec Reviewed-on: https://review.typo3.org/59592 Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87601 Change-Id: I087fcb4a87e12ac3d4345a4514dae674b8551460 Reviewed-on: https://review.typo3.org/59596 Reviewed-by:
Rudy Gnodde <rgn@windinternet.nl> Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87596 Change-Id: I99fe661ff7ee0c29d34c0fde7c5c2c83f0f39201 Reviewed-on: https://review.typo3.org/59591 Reviewed-by:
-
Alexander Schnitzler authored
The caches of extbase have been consolidated as both of them shared the same caching frontend. Cache identifiers `extbase_reflection` and `extbase_datamapfactory_datamap` do no longer exist. A single cache `extbase` is pre-configured and used for class schemata and data maps instead. Releases: master Resolves: #87558 Change-Id: I4d7ec53cfd1b4900998fa2d01db1d8f2c1730633 Reviewed-on: https://review.typo3.org/59573 Reviewed-by:
-
Georg Ringer authored
Resolves: #87579 Releases: master Change-Id: I04e8d291a030dac0a0df526e46aa40ba27a24b39 Reviewed-on: https://review.typo3.org/59583 Tested-by:
-
Benni Mack authored
TYPO3 uses $GLOBALS['LANG'] directly in some places, but since TYPO3 v7, new code started to use a short hand protected method "getLanguageService" in order to get IDE code completion and better analysis of code. This patch replaces all left-over places of $GLOBALS['LANG'] and encapsulates this into a short-hand method to streamline TYPO3 Core's code base. Resolves: #87571 Releases: master Change-Id: Ie15e320713fe65d40552a19e0a517d5739abbb41 Reviewed-on: https://review.typo3.org/59578 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87595 Change-Id: If59546093176c5a7725725aad8e619de70fd43cd Reviewed-on: https://review.typo3.org/59590 Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87603 Change-Id: I3430b59e93133d9b19d6520d3fd7cca83c0fdb49 Reviewed-on: https://review.typo3.org/59598 Reviewed-by:
-
Alexander Schnitzler authored
- Use strict type mode - Use type hints whereever possible Releases: master Resolves: #87608 Change-Id: I3fc153c68bb29aa85517965c6d4d8414d25af35b Reviewed-on: https://review.typo3.org/59602 Reviewed-by:
-
Alexander Schnitzler authored
The following methods used controller aliases: - \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin - \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule This means, that while configuring plugins or modules, a list of controllers (and their actions) had to be provided, so they could be registered as available controllers for said plugin or module. The controller name used for the registration, was kind of an alias for that controller. It was the class name without the namespace and without the "Controller" suffix. By a certain convention a proper class name could be derived from that alias. All this was necessary back then when TYPO3 didn't have a proper autoloader and when the class location was derived from the class name. These circumstances do not exist any more and since it's only important that a controller class exists, the registration of plugins must now use the fully qualified controller class name as array key. The former syntax \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'TYPO3.CMS.IndexedSearch', 'Pi2', ['Search' => 'form,search,noTypoScript'], ['Search' => 'form,search'] ); has to be converted to \TYPO3\CMS\Extbase\Utility\ExtensionUtility::configurePlugin( 'IndexedSearch', 'Pi2', [ \TYPO3\CMS\IndexedSearch\Controller\SearchController::class => 'form,search,noTypoScript' ], [ \TYPO3\CMS\IndexedSearch\Controller\SearchController::class => 'form,search' ] ); Please note, that not only the controller configuration changed. The vendor `TYPO3.CMS` in `TYPO3.CMS.IndexedSearch`, must no longer be set. Instead, the vendor will be evaluated by looking at the controller namespace. Releases: master Resolves: #87550 Change-Id: If47d087836c4345a8180dae3d4e4b8cd384e684c Reviewed-on: https://review.typo3.org/59566 Tested-by:Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
