- Jan 30, 2023
-
-
Christian Kuhn authored
* Render "Available constants from site settings" if any * Render used conditions if any * Allow to show comments and constant substitutions * Improve client side search * Do not persist expand/collapse state when searching, to go back to previous expand/collapse state when clearing search term * Codebase overhaul avoiding of intermediate view helpers * Minor adaptions and cleanups in related modules Resolves: #99747 Related: #99563 Related: #99602 Releases: main Change-Id: Ib52fa51295adff5470b8b62a702a236390410a7b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77599 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
core-ci <typo3@b13.com> Tested-by:
-
Nikita Hovratov authored
Includes a preparation patch for #99739 > composer u typo3/cms-styleguide Releases: main Resolves: #99748 Change-Id: If78dc21d1c6f28e001a308329112e900b5e1ea74 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77635 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Annett Jähnichen authored
Use checkbox icons instead of eye icon to select show/hide columns in list view. Resolves: #99714 Releases: main Change-Id: If20c2dc1a6aba30346c1b96f869f3353b93162da Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77603 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
Torben Hansen authored
The change #99575 introduced a bug in formengine related to input fields with a "null" checkbox placeholder. This change fixes the bug by using the original CSS class in `initializeNullWithPlaceholderCheckboxes()` Resolves: #99743 Releases: main Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: Ie47cd70f062def8ca6c2b62b6e15cfc0cc4ce4de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77629 Reviewed-by:
-
- Jan 29, 2023
-
-
Lina Wolf authored
Releases: main Resolves: #99745 Change-Id: I54d8ef297acacbe9d45faf0f03ca2cf5cdaba9bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77631 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Jan 27, 2023
-
-
Andreas Fernandez authored
The class `PageLayoutController` has some custom methods to fetch data of localized pages: * `getLocalizedPageRecord()` * `getLocalizedPageTitle()` The same data can be retrieved using the standardized method `PageRepository->getPageOverlay()`, which replaces the aforementioned methods. Resolves: #99613 Releases: main, 11.5 Change-Id: I06a374411b34211ed45d57f30d142ead7c7e6fba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77475 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Eric Chavaillaz authored
This allows extensions to blind options from any site configuration (YAML) in the configuration module. This is achieved by dispatching the ModifyBlindedConfigurationOptionsEvent, which got introduced in #99717. Additionaly, the PSR-14 Event is extended to provide the identifier of the provider, dispatching the event. Resolves: #99713 Related: #99626 Related: #99717 Releases: main Change-Id: I1afbcec0af689747f6f8604a55f14daca51650d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77602 Tested-by:
-
- Jan 26, 2023
-
-
Thomas Hohn authored
If fe_groups are deleted building the labels for the fe_groups in titleAttribForPages will throw a PHP warning. Resolves: #99712 Releases: main, 11.5 Change-Id: I61a340b74096c0da6eccc2eb0cd425c9fe02b71c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77600 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Oliver Bartsch authored
The "titleLen" setting is now respected in the page modules' "language mode" to prevent overlapping of long page titles. Note: Overlapping might still happen, depending on the configured "titleLen" value, the current display resolution and the number of languages being displayed (when "All languages" is selected). Resolves: #99729 Releases: main, 11.5 Change-Id: I02458e5b7b0d136303499a83fb6c2fcb5bbc0ef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77616 Reviewed-by:
Daniel Goerz <daniel.goerz@b13.com> Tested-by:
-
Oliver Bartsch authored
When calculating the number of hidden elements for the currently displayed language columns in the page module, the corresponding language constraint is now properly set. Considering more then one language is now only done, in case language mode with a language > 0 is selected. Additionally, L=-1 is now properly taken into account. Some further cleanup of the method is done. The actually defined field names of corresponding enable columns are now used instead of the static ones. Resolves: #99720 Releases: main, 11.5 Change-Id: I751ea0d2f2de88d5eb208215bb81543fc01ca32b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77607 Tested-by:
-
Andreas Fernandez authored
The method `sendChangeCommand()` now builds a proper payload by pushing data into `params.data.copy` prior to the non-exisiting `data.copy` array. Resolves: #99726 Releases: main, 11.5 Change-Id: I96f279cb2f5eedc4a6658f89f0975c8a14bd42c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77610 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Oliver Bartsch authored
The backend user module contains of different sub modules. All those sub modules contain a "create new record" button in the doc header. This button does now contain the actual record to be created, instead of a general label. Additionally does this patch add the missing "resname" attribute to newly added locallang labels and cleans up LocalizationUtility::translate() usages in the BackendUserController. Resolves: #99707 Related: #99038 Releases: main Change-Id: I6eef95ab6dcf083faf1f0a0659c82c3a49bf485b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77594 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Andreas Fernandez authored
This patch removes jQuery from the `@typo3/backend/page-actions` module used in the Page module to hide "hidden" content elements completely. Since jQuery's sliding was used which has no native API, `requestAnimationFrame()` is used to achieve the same behavior. To have a fluent CSS-based animation, positioning of `.t3-page-ce` needs to be fixed, making futher adjustments necessary. Additionally, an unused class is removed. Resolves: #99716 Releases: main Change-Id: If520858db7dfe8c50d8cad477d169a1d8e896ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77510 Tested-by:
-
Oliver Bartsch authored
This introduces the new PSR-14 ModifyBlindedConfigurationOptionsEvent, which allows to blind any (global) configuration option, before being displayed in the configuration module. The new Event is a direct replacement for the now deprecated hook $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Lowlevel\Controller\ConfigurationController']['modifyBlindedConfigurationOptions']. Resolves: #99717 Releases: main Change-Id: I8fe34e47400b1fc5530c11f8377ecb69b78658e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77606 Reviewed-by:
Eric Chavaillaz <eric.chavaillaz@gmail.com> Reviewed-by:
-
- Jan 25, 2023
-
-
Achim Fritz authored
EXT:frontend's Preview simulation already sets the userGroup values properly, which allows to simulate a usergroup. However, this change also needs to be set in EXT:adminpanel in order to allow usergroups. This change adds the same change (see #96381) as in PreviewSimulator in EXT:adminpanel. This is required as otherwise, the Frontend user would re-set the userGroup in FrontendUserAuthentication->createUserAspect() Resolves: #99718 Related: #96381 Releases: main, 11.5 Change-Id: I346f14e2c7bd655efe3883c3a1543bddff8364e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77605 Reviewed-by:
-
Oliver Bartsch authored
In case module access is restricted to "admin" it's now ensured that the corresponding check in the ModuleProvider fails for non-admin users. Resolves: #99715 Releases: main Change-Id: Iff42e101c9c3b0f5dd1e755b384cc92b1c824c62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77604 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #99709 Related: #99694 Releases: main Change-Id: I5117bb39a016ae9acc7e6a4b42d8feff1d3ae05c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77598 Reviewed-by:
-
Benni Mack authored
$TSFE->settingLanguage() resolve possibly language overlays when a page is accessed. This method has been around for a long time, and with the introduction of Site handling and its language handling, this method can be simplified. * sys_page->getPageOverlay() now is handed in the full default language record which is tried to be overlaid, but also resolves the full fallback chain. This way, including all the caching information from sys_page is used, TSFE does not need to retrieve the full record from sys_page->getPageOverlay() manually anymore. * FallbackChain "ignore" can be removed, as it is not possible anymore since at least TYPO3 v10 to ignore the fallback logic, and the condition can be removed. Resolves: #99711 Releases: main Change-Id: I056e12f1a2d0805eb9c9cfb211a37fb83974c661 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77422 Tested-by:
-
Benni Mack authored
Previously, the controller / action pairs of an Extbase Backend Module were defined via corresponding GET parameters. Thanks to the new Module Registration API and the support for individual sub routes, it's now also possible to define explicit routes for each controller / action pair. This is done automatically, as long as the "enableNamespacedArgumentsForBackend" feature toggle is turned off, which is the default. This therefore results in following change: http://example.com/typo3/module/system/BeuserTxBeuser?controller=BackendUser&action=filemounts becomes http://example.com/typo3/module/system/BeuserTxBeuser/BackendUser/filemounts Resolves: #99704 Related: #99647 Related: #96733 Releases: main Change-Id: Ie7bbf70793f7e3da17db3ab1a322ba8ad7bcc5b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77508 Reviewed-by:
-
Oliver Bartsch authored
Prior to the introduction of the column selector in #84184, did a boolean flag "$addDateFields" define whether record date fields (tstamp and crdate) should be added to the available field list. Actually, those fields were always added, because all usages of the corresponding method set either "$addDateFields" or "$dontCheckUser" to TRUE. This fact is now restored by always adding the mentioned fields. Resolves: #98574 Related: #84184 Releases: main, 11.5 Change-Id: I4f212aaf62d9dec26530f6f7a39f1135d684d015 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77568 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Jan 24, 2023
-
-
Oliver Bartsch authored
This adds a constructor to the BackendUserGroup DTO, allowing the extbase ObjectConverter to determine the correct target type of the "title" property. Additionally, some cleanup in the DTO is done. Resolves: #99708 Releases: main Change-Id: I318e2ea30edee5f38e286ddf95603a983e681de2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77595 Reviewed-by:
-
Annett Jähnichen authored
Use only italic style for non sortable table cols. Set 'Control' label to hidden in table header. Resolves: #99701 Releases: main Change-Id: Idad54b5c8860a9103171778e7925041f9a9fef1c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77566 Tested-by:
-
Thomas Hohn authored
Since $conf['externalBlocks.'][$tagName . '.'] can be null, added a null coalescing check to ensure that $cfg contains a valid value. Resolves: #99706 Releases: main, 11.5 Change-Id: Ia80bc50504e27eb0155232e1f1eb956f9b88ac79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77593 Reviewed-by:
-
Benni Mack authored
A new locale class is added in order to migrate the code base and the configuration towards real locales in form of RFC 5646 language tag (en-AT) and optional script code ("Hans") and optional country / region based on ISO 3166-1. This unifies handling of locales instead of dealing with "default" or other TYPO3-specific namings in user-land code and configuration. This locale functionality at first serves to handle "label files" (XLF), but will be further extended to also work with the locale to be used in the SiteLanguage object to simplify configuration and Date/Time Formatting based on php-intl. Thus, the first and foremost topic is to allow to create custom "LanguageService" objects out of a defined Locale instead of a string. The locale class contains the actual locale (such as "de-AT" or "en") but also allows to use the backwards-compatibility for the labels internally. It also contains the dependencies, so they do not need to be evaluated in various places and makes the public facing API much easier to understand. Next to the introduction of the Locale object, this patch also adapts various places which touch current LanguageService instantiations to use the Locale. Next Steps: * SiteLanguage.locale should use the object, as Locale uses a \Stringable interface. * Reduce optional settings in Site Language object and editing interface * A new languageService ($GLOBALS[LANG]) could and should be instantiated where it is needed, and not by re-using the same $GLOBALS[LANG] as this is needed This Reduce usages on $GLOBALS[LANG] by building a new LanguageService object based on the Context everywhere. * Ideally deprecate $GLOBALS[LANG] in TYPO3 v12 LTS. Resolves: #99694 Releases: main Change-Id: I9e2464699a2e53f4e3b136e0b66351f9f3aaf71f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77558 Tested-by: -
Annett Jähnichen authored
Replace database export icon with the correct download icon. Resolves: #99702 Releases: main Change-Id: I7666b1c772d82d9adc9101c89fe37dfb974b1ebb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77569 Reviewed-by:
-
Benni Mack authored
Resolves: #98630 Releases: main, 11.5 Change-Id: Iae48bf68a9f18a33e86d79cf7826617e2b3d48c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77565 Reviewed-by:
-
Benni Mack authored
Resolves: #99270 Related: #99572 Releases: main, 11.5 Change-Id: I0b3aed81b7ee5d8449c1db962b423fc4fb542287 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77561 Tested-by:
-
Benni Mack authored
Resolves: #99255 Releases: main, 11.5 Change-Id: I10981e55a9efe2a891bf61ca304a287ec2759aad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77562 Tested-by:
-
Benni Mack authored
Resolves: #98681 Releases: main, 11.5 Change-Id: I4d7bc72efe4256c5e5d9009afd9327428f2661d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77564 Tested-by:
-
Benni Mack authored
Resolves: #98966 Resolves: #98425 Releases: main, 11.5 Change-Id: Idd8b3d7db8c7455cfbdd39a534a3995d33c651cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77563 Reviewed-by:
-
Benni Mack authored
Resolves: #99315 Releases: main, 11.5 Change-Id: Ib6bae3be83742212d063bd7b746bb2885d79222b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77560 Tested-by:
-
Jasmina Ließmann authored
The "Page TSconfig" backend module now has a search that allows an integrator to search PageTS either by a settings identifier (e.g. "mod.linkval") or a value (e.g. "textpic"). Partial searches are also supported, "wizardItems" resolves to "mod.wizards.newContentElement.wizardItems". The search value is stored in the browser session and retained when the module is visited again. To avoid conflicts with the internal `collapse-state-persister` module, a new setting is introduced to disable the modules recovery behavior if a specific key is available in localStorage or sessionStorage. Resolves: #99602 Releases: main Change-Id: If1b91d936597406b3d553e81b2ced1076bc054cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77481 Tested-by:
-
Benni Mack authored
TYPO3 can now handle language keys with a given region, such as "de-AT" without extending TYPO3's native language handling. When a "de-AT.locallang.xlf" file exists, it is used, but will fall back to "de.locallang.xlf" itself. The language is based on ISO 639-1, whereas the region should be used from ISO 3166-1. For backwards-compatibility, locales with underscore are also possible "de_AT". Resolves: #86913 Releases: main Change-Id: I1bb97f7f36053c17bf919a92b3739e59b20d65c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77375 Reviewed-by:
-
Oliver Bartsch authored
According to the code, $request might be NULL, leading to a null pointer exception on calling `getAttribute()`. This got noticed on following CI run: https://git.typo3.org/typo3/CI/cms/-/jobs/1917011. Resolves: #99698 Related: #99017 Releases: main Change-Id: I12502623b6fd81cabb7202e6c175d9dedf8a1339 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77559 Reviewed-by:
-
Christian Kuhn authored
Table sys_messenger_messages introduced with #97700 declares a bigint(20) as primary key in ext_tables.sql. ext_tables.sql is essentially mysql syntax, the core SchemaMigrator creates a doctrine object structure from it, and struggles with bigint on sqlite, found by a nightly test. A simple fix is to declare a "casual" int(11), which should be more than big enough for this table and is in line with our other "uid" column primary keys of other tables. Resolves: #99689 Related: #97700 Releases: main Change-Id: I5322aefe0f8e9b93015eaf2fb7af1ae8536b94ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77555 Reviewed-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Benni Mack authored
Over the past few commits, a lot of changes happened with LanguageService-related code, mainly to streamline the initialization and creation of LanguageService code. For this reason, various parts have now been sorted out: * Proper injection of Locales class * Consistent usage of LanguageService->init() * Avoid additional pageRendererSetupTrait call in LoginController * Avoid using LanguageService->init() if Factory is used * Leftover "ISOcode" value is removed Resolves: #99693 Releases: main Change-Id: Ib4bbc5b38505d712c86eb7e6a3c8455ba49225de Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77557 Tested-by:
-
Benni Mack authored
With the introduction of feature #98528, multiple locations for ENABLE_INSTALL_TOOL files were allowed. This change ensures that all files are always removed. Resolves: #99688 Related: #98528 Releases: main Change-Id: I4ada34731d6c367ed4178d78ecb4b1224f8fbc6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77553 Reviewed-by:
-
- Jan 23, 2023
-
-
Josef Glatz authored
Resolves: #99687 Related: #99652 Releases: main Change-Id: I39349c6362ce409a2f1d0c8e763a6ed4d94bf954 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77542 Tested-by:
-
Oliver Bartsch authored
The SiteInterface provides the "getDefaultLanguage()" method, which will always return the first configured language - usually L=0. However, this language might be disabled, which means, it should not be visible in frontend context. The PageContentErrorHandler therefore now tries to fetch the first enabled language, in case the requested language id does not exist in the current site and the sites' default language is disabled. Resolves: #99530 Releases: main, 11.5 Change-Id: Ib02cbd8f01a4fc1a69be46ad2015e8863553fae0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77538 Tested-by:
-
Christian Kuhn authored
Site Management > TypoScript > Included TypoScript: Show correct open / close triangle icon after load. Resolves: #99686 Related: #99577 Related: #99576 Releases: main Change-Id: I1f74fa34ad7233794f7f558476846506efaa627c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77541 Reviewed-by:
-
