- Jun 30, 2021
-
-
Christian Kuhn authored
The patch changes the extbase Mvc/Request to implement PSR-7 ServerRequestInterface: The former extbase request details like 'controllerAction' are changed to an PSR-7 attribute and the Request class is now a decorator - it receives the original PSR-7 request as constructor argument, then implements both the extbase RequestInterface plus PSR-7 ServerRequestInterface. This way, the Request object itself does not hold state (except the original request), but channels all get* and with* calls to the PSR-7 request object. This avoids creating a new standalone object and moving all data from the PSR-7 object into the new object. The patch is relatively conservative. The extbase related set* methods are kept even though they're all @internal and violate immutability, and various method signatures are not adapted towards strict typing, yet. The reason for that are various chain- and loop dependencies especially in fluid view that should be solved with single patches before extbase Request can be streamlined further. Current usages also rely on fallback layers within __construct(), which can be solved when consuming places are adapted - The patch would have become much bigger if that would be mixed in. Change-Id: I218de0ee30d16245e7d562d0aba2795ccc439901 Resolves: #94428 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69545 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #94442 Relates: #94441 Releases: master Change-Id: Iaebd23d0031917c5c5c121c4123cf24304c47169 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69669 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Bartsch authored
The method getCollectionValueType() is deprecated since symfony 5.3 and has therefore been replaced by getCollectionValueTypes(). Resolves: #94435 Releases: master Change-Id: I05427349f738cb328d547b221ee0224aa04ca57a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69658 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Bartsch authored
Resolves: #94437 Related: #92784 Releases: master Change-Id: I759b39fe7b04365293f55a3847a071e7fbfe3308 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69660 Tested-by:
-
Oliver Bartsch authored
Resolves: #94436 Related: #92784 Releases: master Change-Id: I98d1a8d08e44ebf3b9626d6ead686059acd95db2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69659 Tested-by:
-
Jochen Roth authored
Open the table wizard with empty test in the text area or a click on the save button on table wizard page thow undefined key warning. This will avoid php warnings by adding a fallback value or a check if the key is present. Added acceptance tests for the table wizard to make sure the wizard will work as expected. Resolves: #94417 Releases: master Change-Id: I9283c9203f71710c8bffcc74432781d2159dcde7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69575 Tested-by:
-
Christian Kuhn authored
This currently logs a deprecation entry since LanguageService shouldn't be injected any longer. The property is unused and can be dropped. Resolves: #94438 Related: #94414 Releases: master Change-Id: I2e56982eeb6b33c36de107199293244672b6bf4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69661 Tested-by:
-
Nikita Hovratov authored
The TCA option showRemovedLocalizationRecords was former used to enable showing 'dangling' records (localized records without parent). Because it was subject to a broken db structure, its usage was removed in patch f6f36d3f. But there was still code mentioning this key without using it. A TCA migration removes this option and logs a message which pinpoints the lack of usage. Resolves: #94441 Releases: master Change-Id: I8c32bb845512585a6314d92f8fcafffd959279ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69665 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
- Jun 29, 2021
-
-
Torben Hansen authored
Since #92784 Extbase controller actions must return a PSR-7 response. With this patch, all actions in LoginController now return a proper PSR-7 response object. Note: A patch for PasswordRecoveryController will be handled in a separate patch. Resolves: #94434 Releases: master Change-Id: I0db06db312c91b01395a3e0d57b9d2f1087a6326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69657 Tested-by:
-
Oliver Bartsch authored
This adds a new modal to the recordlist export functionality, allowing users to configure export settings such as format, filename, selected columns / all columns and raw values / processed values. Also some options, depending on the chosen format, are configurable (e.g. delimiter for CSV). To make the format selection useful and to further improve the exisiting export functionality, JSON is added as another possible export format. Resolves: #94411 Releases: master Change-Id: I224a93b6bdd855018aedfdae1375b16339f9f583 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69550 Tested-by:
-
Christian Kuhn authored
Brings minor adaptions and a patch to unblock #94417 composer req --dev typo3/cms-styleguide:~11.3.1 composer req --dev typo3/cms-styleguide:~11.3.1 -d typo3/sysext/core --no-update Change-Id: I26a6e66fe42ee37e247873f68a135ce87c68fee4 Resolves: #94431 Related: #94417 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69654 Tested-by:
-
Christian Kuhn authored
Blocks current development since other tests fail now in pre-merge. Disable the tests to unblock development. Clean fix patch will follow. Resolves: #94432 Related: #94425 Releases: master Change-Id: Iae897972ea6dee72c1d8013fcb20be69f846e8f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69655 Tested-by:
-
Oliver Bartsch authored
The switch user handling was previously placed in EXT:beuser, more precisely in the BackendUserControllers' indexAction. It was therefore necessary to link to the extbase based controller with a mix of prefixed arguments and the non prefixed "switchUser" argument. Latter was internally evaluated with GU:_GP(). This means, switching users was done via GET requests in an extbase action, but only in case a non extbase prefixed argument was set. In #94209 this got worse when the BackendUserGroupController was merged into BackendUserController. Since this controller features a "remember my last action" functionality, switch user could no longer reliably be triggered. The evaluation of the non extbase prefixed "switchUser" argument only took place in the "user listing" (indexAction) and the success of the call therefore depended on the users' last called action, as this action was automatically used. This patch now extracts the switch user functionality from EXT:beuser into a dedicated EXT:backend controller, featuring two ajax routes "/switch/user" and "/switch/user/exit". Both accessible via POST requests only. To trigger those requests, a new JS module "TYPO3/CMS/Backend/SwitchUser" is introduced. This also allows to completely remove the logout hook by using the concrete markup (custom element) for the "exit" button. Resolves: #94426 Related: #94209 Releases: master Change-Id: I556b323fe6ae77cf696e7e34dbbe269eb4f9927a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69635 Tested-by:
-
Oliver Bartsch authored
This patch removes the last remains of sys_language in the site configurations' TCA. Therefore, the TCA of `site` and `site_langauge` is changed to always retrieve possible site languages via an itemsProcFunc, instead of using a relation to sys_language. As new site languages now have to be created in the module directly, a new internal TCA type "siteLanguage" is introduced. The new type behaves similar to type "inline", but contains some necessary features, e.g. unique record selector box next to a "create new" button, which are not available in type "inline". Also some not needed functionality is omitted. Instead of the sys_language records, all available site languages from all existing site configurations are now presented in the selector box. On selecting one of them, a new site language record is created, with most of the fields pre filled. Resolves: #94399 Releases: master Change-Id: I60ac5b4259aa3c9d90a4aba9881bc1dc2341b464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69188 Tested-by:
-
Jochen Roth authored
A click on "Image Processing", "Configure Installation-Wide Options" or "Configuration Presets" in the install tool returns an error in PHP8. Add fallback for unefined array keys to workaround the array undefined key warnings. Add acceptance tests for InstallTool -> Settings module to make sure settings of each card can be loaded and saved. Resolves: #94425 Releases: master Change-Id: Icf3b11b0e4c490f8054605cd531f77906dfa7ac6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69633 Tested-by:
-
Christian Kuhn authored
Patch #94414 broke a case in ext:form leading to a fatal, easily reproducible when opening a content element having a form. The class is internal and only used in backend through a hook and can thus rely on GLOBALS['LANG'] like so many other backend classes do. Resolves: #94429 Related: #94414 Releases: master Change-Id: I578d3b1d61894c210bb0fb20cddf44307cb40ae2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69653 Tested-by:
-
- Jun 28, 2021
-
-
Benni Mack authored
This change adds a wrapper around BackendUtility::getRecord() when fetching pages (for permissions) or be_users (for "cruser_id" information) in the list module, effectively speeding up larger lists with records on the same page. Resolves: #94413 Releases: master Change-Id: I2084980bdb94bc4b5d8fda7a502d2238d459e465 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69573 Tested-by:
-
Benni Mack authored
In order to make TYPO3 Core compatible with doctrine/dbal 3.0, Core now requires doctrine/dbal 2.13 to allow to track all deprecations and use the forward-facing APIs. Used composer commands: * composer req doctrine/dbal:^2.13 * composer req doctrine/dbal:^2.13 -d typo3/sysext/core --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/install --no-update * composer req doctrine/dbal:^2.13 -d typo3/sysext/redirects --no-update Resolves: #94423 Releases: master Change-Id: Ifede8ebdac0b47a0db0ba5d304878c91c3579f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69632 Tested-by:
-
Benni Mack authored
This change moves state for caching purposes from $GLOBALS[LANG] into the runtime cache allowing for further reducing the need to keep the LanguageService in a global state. Resolves: #94415 Releases: master Change-Id: Id8bc974fc65e630695d5f86a13ff0c137cd8f3ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69551 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Benjamin Franzke authored
Only the container entry – which acts as backend for GeneralUtility::makeInstance(LanguageService::class) is deprecated. The class is left as-is, but should be factored via LanguageServiceFactory. Therefore also all the factory methods are deprecated in order for the LanguageServiceFactory to be used instead. Resolves: #94414 Releases: master Change-Id: Iab0f713a5baf95c419338748e8df4102d46c37a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69367 Tested-by:
-
Oliver Bartsch authored
Resolves: #94416 Releases: master Change-Id: Id11afdd6d7ba00cd9ed1712aa43543dfc85d7725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69574 Tested-by:
-
- Jun 27, 2021
-
-
Simon Gilli authored
In the install tool context $GLOBALS['BE_USER'] is not available and any access must be avoided especially from PHP 8.0. Resolves: #94418 Releases: master Change-Id: I1df52aedd9ba1149e4009c9cc3a6707ba114c607 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69576 Tested-by:
-
Larry Garfield authored
Resolves: #94382 Related: #94315 Releases: master Change-Id: I250ccfa09863f7cdc48ad58bb7d9d5fc922d76c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69523 Tested-by:
-
Benni Mack authored
In order to help support upgrade paths, some key information is kept until TYPO3 v12 (= not yet removed), so this documented properly now. Resolves: #94412 Releases: master, 10.4 Change-Id: I5ce94d24dfd57008374272e48ee9132974f6a562 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69572 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
-
Simon Gilli authored
A new TCA property "description" is available to be added to palette configurations. It allows to provide additional text, which will be rendered by FormEngine between the palette label and the corresponding fields. It is similar to the TCA field description, introduced in #85410. This will support editors as specific field usages can be clarified directly in the UI. In contrast to the palette label, the new description property can not be overwritten on a record type basis. Resolves: #89507 Releases: master Change-Id: I4390e13830d359d54c37a347b91960de5639da4c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62109 Tested-by:
-
- Jun 26, 2021
-
-
Lina Wolf authored
Resolves: #94419 Releases: master Change-Id: I933abbda5a3420a11a4f1ac3fe6501acdc796727 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69592 Tested-by:
-
- Jun 25, 2021
-
-
Oliver Bartsch authored
This fixes "Undefined array key" warnings, triggered in recordlist and related areas. Resolves: #94401 Releases: master Change-Id: I34490cd8390fc3a2d0a9a40d666e2dc5a00e3e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69546 Tested-by:
-
- Jun 24, 2021
-
-
Benni Mack authored
For TYPO3 v10, in 81660b4c (see https://review.typo3.org/c/Packages/TYPO3.CMS/+/61385) the JavaScript global variable T3_THIS_LOCATION has been deprecated and successfully removed in TYPO3 v11.0. However a few places are left, so they are removed now. Relates: #88854 Resolves: #94410 Releases: master Change-Id: Id61eb1bd28c140415cca01cd1a21e2b9e6076425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69549 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Jochen Roth authored
A click on inline fal ElementInformation button leads to Undefined array key "returnUrl". Fixed by adding empty string as fallback and add an acceptance test to make sure it will not appear again. Resolves: #94400 Releases: master Change-Id: I7e44b026f81b0d484e3b8a1af5522fece228d5d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69544 Tested-by:
-
Oliver Bartsch authored
This fixes a TypeError by type-casting the $pageId argument. Resolves: #94409 Related: #89700 Related: #94210 Releases: master Change-Id: I0840ace1fbcaf62e4a5d2883e1d50a511e949d81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69548 Tested-by:
-
- Jun 22, 2021
-
-
Sybille Peters authored
In the select list in "Info > Page TSconfig" the technical representation of the terms (as they are used when setting TSconfig) is now shown in brackets, e.g. [RTE.]. This is consistent with showing the technical representation in other places in the backend, such as the page id in the page layout or page tree, the table fields and Flexform fields in the edit forms etc. Where there are descriptive terms, (such as "Module: Web>Page") a combination of the descriptive terms and the technical terms is used, such as "Module: Web>Page [mod.web_layout.]" The explanation "with overruling user settings" for mod is omitted. This would make the list more cluttered and visually distracting. If it is necessary to point this out, it might be added as a note in the results. Resolves: #94323 Related: #94322 Releases: master, 10.4 Change-Id: I728f3d6399f040356d7bee4e30c3f33baf9703d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69467 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Since the method has to return true in case the page translations should be displayed, the TCA "hideTable" check must be negated. This would otherwise lead to page translations not being displayed if the "hideTable" key is not defined in pages TCA. Furthermore, the TSconfig option "hideTable" also contains the `table.` key. Note: Only master is affected as backport was not yet merged and will therefore contain the correct check. Resolves: #94398 Related: #94386 Releases: master Change-Id: I96b2676b3acde6bfc3436fd16fc31ca76ba3d185 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69539 Tested-by:
-
Jochen Roth authored
When a user opens Info -> Page TSconfig it will throw an error "Undefined array key tsconf_alphaSort". Fixed by adding 0 as fallback to the array access. Another test was added which checks if modules in the toolbar dropdown are callable. Resolves: #94392 Releases: master Change-Id: I2e1f2e4b687155fa1d1c13791f46f10915c834f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69536 Tested-by:
-
Christian Kuhn authored
Extbase Request setDispatched() and isDispatched() violate the PSR-7 'immutable' concept and need to fall. With the changes from #92502 where extbase actions usually return a ResponseInterface, together with the deprecation of StopActionException in #94351, we don't need this information in the Request anymore: It can be handled internally within the dispatcher, depending on the type of the response. The patch deprecates the two methods in extbase request and adapts usages towards an internal flag. We throw a deprecation warning since the flag is needed for b/w compat in v11, though. Resolves: #94394 Related: #94351 Related: #92502 Releases: master Change-Id: I1c70daa7f5b0c55e17e4b7c815d260ca68cef23c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69470 Tested-by:
-
Rico Sonntag authored
PHP Warning: array_key_exists() expects parameter 2 to be array, null given in ArrayUtility.php line 297, when an longer path than exists in given array is set. Releases: master, 10.4 Resolves: #94379 Change-Id: I9ef40d2cf82f777b3a289dfaa4f8cbfcc2a5bba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69521 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Oliver Bartsch authored
Since #27471 it's possible to hide all or specific tables within the recordlist. However, the special "page translations" table did not respect those settings, making it impossible to hide this table. This is now fixed by respecting the corresponding settings. Resolves: #94386 Releases: master, 10.4 Change-Id: I33575624ade9ecf840b6fde713a7d3214d6506be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69535 Tested-by:
-
- Jun 21, 2021
-
-
Benni Mack authored
This change replaces the "collapse-horizontal" functionality of the extended view icons into a dropdown from Bootstrap, allowing users to understand the icons better because the text is now also written next to the icon (similar to the Context Menu). The horizontal collapsing is removed as a UX improvement to a) give consistency around other areas in TYPO3 Backend b) was intended as a workaround to solve the Extended View rendering and to avoid button-hell c) avoid confusion around editors when buttons are visually moving horizontally d) the Extended View feature was unclear for editors when to enable it In addition the "View" link is now moved into the secondary button group. The Extended View checkbox is therefore removed as all secondary options are always available. Same functionality is also replaced in the File List module to use the "..." icon to show that there are more actions available. Side note: The dropdown needs a position-static due to overflow-x: auto - see https://github.com/twbs/bootstrap/issues/29313#issuecomment-758412385 Resolves: #94390 Releases: master Change-Id: I925aa7690068fbde3f3aa5217f3f5629a2a890d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67458 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Torben Hansen authored
Since the removal of the old pi-based plugin some of the old TypoScript constants in styles.content.loginform were left unassigned. With this patch, all TypoScript constants are assigned to their associated setup variables, so users updating from the pi-based plugin and mainly using constants for configuration can easily migrate to the Extbase version of the plugin. The following unused TypoScript constants are removed: * templateFile * feloginBaseURL The constants `pid` and `recursive` are mapped to the TypoScript setup `pages` and `recursive`. The TypoScript setup variable `replyTo` is removed, since it is unused in the extension and the settings has been replaced previously by `TYPO3_CONF_VARS.MAIL.defaultMailReplyToAddress` The documentation is adapted to match the current state of the extension and existing images have been replaced with current versions. Resolves: #94328 Releases: master Change-Id: I509201b1e2ce1194e70af3a618b42ba6c5d80ce3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69471 Tested-by:
-
Oliver Bartsch authored
A display bug is fixed by using the correct closing tag for a link inside a button group in recordlists' single table view. Resolves: #94391 Related: #92652 Releases: master Change-Id: I7634aa6566674a5d0ae9c0683e6b633c196006cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69534 Tested-by:
-
Christian Kuhn authored
Finish ObjectManager removal / fallback works in ext:form. The validators are no issue since they have been postulated of not being autowire DI aware in v11.0 with #92238 already, so we can follow this. Resolves: #94384 Related: #90803 Related: #92238 Releases: master Change-Id: I1115d2eaa595fa5685f6549843b4f388d5d07c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69525 Tested-by:
-
