- Apr 17, 2023
-
-
Anja Leichsenring authored
All usage of globally loaded labels has been replaced, so the usage of the function to load the labels globally can safely be removed. Resolves: #100627 Releases: main Change-Id: Iaac8c84bd1bf951703a38176e9b634da44df42a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78674 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Albrecht Köhnlein authored
Set the variable `$linkParts['tableName']` even if the currently linked record could not be found. The variable is required in later step to show information, which also should be present for deleted records. Resolves: #100611 Releases: main, 11.5 Change-Id: I3f5d1e53d8c6889c8907af5ff56c76eb74efa5fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78654 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de>
-
Anja Leichsenring authored
The extension does not use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100625 Releases: main Change-Id: I653b2d47efd0fe8ece707e0b362edd33790befd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78671 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Benni Mack authored
Resolves: #98985 Releases: main, 11.5 Change-Id: Id886584f8fa57b30f54257d79a6eca4465906a86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78675 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Anja Leichsenring authored
The wizards don't use any globally loaded labels, so the usage of the function to load the labels globally can safely be removed. Resolves: #100626 Releases: main Change-Id: I317869dec080e8ce59c4a0903e9564bc5fe96ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78673 Reviewed-by:
-
- Apr 16, 2023
-
-
Albrecht Koehnlein authored
The HTML parser failed to correctly detect single tags with closing `/` and without white space, e.g. `<br/>`. The old tag name detection only splitted the tag content by white spaces, which is not enough to correctly find these valid tags. So the new way is to also remove trailing slashes from the tag name. Resolves: #96347 Related: #96307 Releases: main, 11.5 Change-Id: I3acefcbf046600bf118764b873f15b2a1678932d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72641 Tested-by:
-
Albrecht Köhnlein authored
Set the array index `$linkDetails['typoLinkParameter']` in `\TYPO3\CMS\Redirects\Service\RedirectService` to pass it through. That information is needed for the LinkBuilder. For example, `DatabaseRecordLinkBuilder` would trigger an array key access error, in case the linked record cannot be found and no link can be generated. This array value is use there for the thrown exception message. The team play between `LinkService->resolve()` and the `LinkBuilder->build()` should be reviewed in a dedicated change. It may be useful, that the resolver directly adds this information to the result, making the manual adding at several placed through out the core obsolete. Comments are added to document this. Resolves: #100612 Releases: main, 11.5 Change-Id: I74cbf5cbb1b91e0045207873554aec4477986c4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78656 Reviewed-by:
-
Christian Kuhn authored
Extbase has an own feature toggle system. This is based on TypoScript configuration and the awful ConfigurationManager. TYPO3 v10 introduces a core-based feature toggle system based on TYPO3_CONF_VARS, so extbase overlaps here, and we should get rid of it. Current extbase uses feature toggles for two ancient details, and one option that has been added with TYPO3 v12. The patch deprecates the PHP API and all toggles. In case extbase implements functionality again that needs to be toggled, it should be based on the core feature toggle API instead. Doing this per-extension can be done by prefixing them accordingly if needed. Resolves: #100622 Related: #97096 Releases: main Change-Id: I5776c57af85aa01c97bc0d7fe7eeaf148a3e5016 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78670 Tested-by:
-
Christian Kuhn authored
extensionmanager/ext_typoscript_setup.typoscript file is obsolete since it only sets an extbase feature toggle to the same value as the default value. Resolves: #100620 Releases: main Change-Id: Id05de448194f85adf887c0b4b9f5a7cdfc1077a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78667 Reviewed-by:
-
Benni Mack authored
When using TYPO3_PATH_ROOT and TYPO3_PATH_APP from apache/modules, the prefix is usually "REDIRECT_", so this also needs to be checked for both environment variables, as already done in TYPO3_CONTEXT. Typical use-case is by setting this via .htaccess rules. Resolves: #91798 Releases: main Change-Id: I6392860af8ff5d5016cb473ab6f47787beac39f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78496 Tested-by:
-
Stefan Bürk authored
The docker container image hub is slowly becoming more and more problematic for open source organisations, it's time to move to another container registry for core-testing images. Images are now build and published to both Docker HUB and GitHub Container Registry (`ghcr.io`). To test the ghcr.io images, the patch changes runTests.sh to use them them for local (non CI) execution already. We can not fully switch to ghcr.io yet, since CI uses the docker registry container as mirror for images to heavily reduce network load and increase performance. The registry container however can only mirror hub.docker.io images, so we need a different solution for CI first. When this is done, we'll stop uploading images to docker hub later. Resolves: #100617 Releases: main, 11.5, 10.4 Change-Id: Ia309826618696dc25b15527b73fa704235285479 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78665 Reviewed-by:
-
Christian Kuhn authored
Feature #97096 introduced a toggle to skip namespaces in extbase backend modules to beautify backend links. The default is to enabled shortened links, but ext:form toggles this off. The patch removes the default override and adapts some ext:form links to make it work. Note the ext:form module currently suffers from a regression of #98604 - the form editor JS init logic seems to have a race condition and crashes "sometimes". This is not related to this patch and needs to be handled with another patch. Resolves: #100619 Related: #97096 Related: #98604 Releases: main Change-Id: I594df4fdc3fac325b345f0501bc4ef6f9e075733 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78666 Tested-by:
-
Oliver Hader authored
In case an empty array is passed to ContentObjectRenderer::cObjGet(), the process returns early, without invoking any array processing and variable assignments. Resolves: #100615 Releases: main Change-Id: I0c21bb02007a5e013861b62437cde40d7cc41fe5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78659 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Apr 15, 2023
-
-
Jasmina Ließmann authored
The naming of the table headers has been updated, as well as label 'Page title' in the pages TCA itself. The spacing of the table cell containing the page title and icon has been corrected to match the appearance of other tables containing this information. Also, the context menu has been added back and the page title link has been removed. Resolves: #100613 Releases: main Change-Id: I404644f21acb23b3eea33636e9b979a2732c3666 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78657 Tested-by:
-
Jasmina Ließmann authored
With this patch we now stricly use .form-label as class for form field labels in both modules. The width of the option fields in both modules has been optimized for a responsive display. Some wrapping div's with no uses have also been removed. Resolves: #100610 Releases: main Change-Id: I1549b8f7d36000b5deb5cd0a345e18a66e86a9d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78653 Reviewed-by:
-
Jasmina Ließmann authored
The markup of the form to create multiple pages was updated to match the regular markup. After creation, the new and existing pages are now displayed in a table. The displayed page entries now contain a context menu and an edit button to provide a possibility to jump directly to the page settings. Resolves: #100604 Releases: main Change-Id: Ib4377c99f4d0a78de37df9c2f7cc56384f696f82 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78645 Reviewed-by:
-
Christian Kuhn authored
People tend to run extbase in context it is not designed to be run in. TYPO3 v11 and before has been forgiving in such cases and falls back to a broken (empty) TypoScript configution. TYPO3 v12 is more picky in this regard, and throws an exception. With current TYPO3 v12 frontend bootstrap, extension developers are a bit limited in their options to solve this. The patch adds a hack to extbase bootstrap code to be as forgiving as TYPO3 v11 has been. However, the case is logged as deprecated, and a comment is added to explain the scenario and options. Resolves: #99417 Related: #97816 Releases: main Change-Id: I0bbe3bdfe1dd942e2aecd633cc19f907b739bdac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78007 Tested-by:
-
Česlav Przywara authored
Releases: main Resolves: #100609 Change-Id: Idc1acf2e4cfd776d89517227c1c9e32d2bdf1830 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78651 Tested-by:
-
Christian Kuhn authored
Switch to phpunit:^10.1.0 as minimum version, removing phpunit:^9 in core main. Clean up a test case, clean up temporary CI setup, switch to new phpunit xml config files, raise some acceptance test related dependencies. > composer req --dev phpunit/phpunit:^10.1.0 -w > composer req --dev codeception/module-webdriver:^4.0.0 > composer req --dev php-webdriver/webdriver:^1.14.0 Change-Id: I3f11355aa5a11f3ca879b09c64821ce3f89fe1c1 Resolves: #100608 Resolves: #100249 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78649 Tested-by:
-
Stefan Bürk authored
PhpUnit 10.1 changed again some things from 10.0 -> 10.1, like removing `RiskyTestError` exception and moving the PhpUnit ErrorHandler to another namespace. Beside this, phpunit 10.1 also needs a further config file migration to additionl changed config file requirements. This change updates typo3/testing-framework which contains the fixes to be phpunit 10.1 compat, adjusts the config files and ensures 10.1 for the unit10 and functional10 tests. Additionally, the phpunit 10 unit and function config files are adjusted to let notices and deprecations fail again and therefore restore the wanted behaviour from phpunit 9 and the removed `convert*ToException` options. Used command(s): > composer update typo3/testing-framework > Build/Scripts/runTests.sh -s unit10 \ -e '--migrate-configuration' > Build/Scripts/runTests.sh -s unitDeprecated10 \ -e '--migrate-configuration' > Build/Scripts/runTests.sh -s functional10 \ -e '--migrate-configuration' > Build/Scripts/runTests.sh -s functionalDeprecated10 \ -e '--migrate-configuration' Resolves: #100600 Related: #100585 Related: #100249 Releases: main Change-Id: I5bb372e12a39b77f1c371e54d6dd729ce81573c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78631 Reviewed-by:
-
Stefan Bürk authored
External "enshrined/svg-sanitize" package uses `libxml_use_internal_errors()`, but fails to clear errors using libxml_clear_errors(). This can lead to side effects with subsequest libxml usages. An upstream patch to fix this is pending, but it needs to be merged and released. In the meantime, we mitigate the issue in our wrapper class. See: https://github.com/darylldoyle/svg-sanitizer/pull/90 Resolves: #100607 Releases: main, 11.5 Change-Id: I911119b498a4dda8312c5ca940b5fdf6410a1a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78647 Reviewed-by:
-
- Apr 14, 2023
-
-
Oliver Klee authored
This update fixes some PHPStan warnings for us. > composer req doctrine/dbal:^3.6.2 > composer req doctrine/dbal:^3.6.2 --no-update -d typo3/sysext/core > composer req doctrine/dbal:^3.6.2 --no-update -d typo3/sysext/install > composer req doctrine/dbal:^3.6.2 --no-update -d \ typo3/sysext/redirects > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100602 Releases: main Change-Id: I41832c6615e944933bdbd23f447df4a84651ed84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78644 Tested-by:
-
Oliver Bartsch authored
With #100567, the return type of the getPageArguments() method in RequestWrapper and DeprecatingRequestWrapper was changed to PageArguments, while the actual return value was only adjusted in the RequestWrapper. This is now also done in DeprecatingRequestWrapper. Resolves: #100599 Related: #100567 Releases: main Change-Id: I678451ccc31b7e3b72ab03bfb6b7ce1c0ba05138 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78642 Tested-by:
-
Oliver Klee authored
Simplify `initialize` using a guard clause. Resolves: #100598 Releases: main, 11.5 Change-Id: Ic53d190a139bc4c74517fc680adf43a8daadb6d9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78640 Reviewed-by:
-
Benni Mack authored
The BackendUtility methods getThumbnailUrl() and getLinkToDataHandlerAction() are deprecated as they are just wrapper methods with limited extra value. The functionality can easily be implementend by using the corresponding APIs directly. Resolves: #100597 Releases: main Change-Id: I7f72504559c0c9c1f61b77362a7fbfd43c001883 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78610 Reviewed-by:
-
Benjamin Kott authored
- Drop default override styling for <hr> without classes - Drop unused/obsolete scss variables - Drop variable `$text-color` in favor of `$body-color`. - Drop class `.text-muted` in favor of `.text-body-secondary` - Drop class `.form-inline` from usage in the backend - Icons are now displayed correctly next to text for login provider Note: Some spacings were hotfixed for now. It is planned to clean the `mb-*` classes up at a later point. Resolves: #100437 Releases: main Change-Id: I88f1d891a18acaba6a82ca498fef45b37117758e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78448 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
-
Christian Kuhn authored
This deprecates GeneralUtility::_GET() as last member of the get/post related family, next to GU::_POST(), GU::_GP() and GU::_GPmerged(): The request object has to be used instead. This patch is the end of a journey that took us various years. The last main one left is GeneralUtility::getIndpEnv(), but that's a story for TYPO3 v13. Resolves: #100596 Related: #99633 Related: #99615 Related: #100053 Related: #100584 Releases: main Change-Id: I591dd289289f5e4d7d35b74f853b067fbe975624 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78639 Tested-by:
-
Benjamin Kott authored
There is no need to add a non-breaking space as a fallback if the label is empty for checkboxes. This results in unnecessary occupied space. We prefer just an empty string. To ensure we only occupy the space we need to, we are trimming unnecessary whitespaces from the final label. Resolves: #100594 Releases: main Change-Id: I941a197dc9e756c978b19dc8275449fcb1874c31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78637 Tested-by:
-
Oliver Hader authored
Deprecates form engine result property `additionalJavaScriptPost`, which was used by custom evaluation that provided inline JavaScript (`$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tce']['formevals']`). Resolves: #100587 Releases: main Change-Id: Ic68583a9cbd898acfd219c2848013d4442f9ab9d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78636 Reviewed-by:
-
Christian Kuhn authored
ServerRequestFactory is essentially the only place with a legit access to $_GET super global. Avoid using GeneralUtility::_GET() here. Resolves: #100593 Releases: main Change-Id: I04bbf6f278a1581d667120aceeda94b9e1935ac4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78638 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Kott authored
The special handling for a.disabled is obsolete, is was introduced to prevent the default link handling for the new content element wizard links while the component was not loaded. The wizard button is now a webcomponent and then handling and special styling is already handled through the boostrap css framework. The styling can be dropped. Resolves: #100592 Releases: main Change-Id: Icca02cc9f1cc84c19681149e764854fe426d103f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78635 Tested-by:
-
Benjamin Kott authored
The class .text-normal is not used at all and can be dropped. The class .text-pre-wrap was only used on .alert-message since it is make sense here to unify the behaviour the applied styles were moved to .alert-message directly. The class .text-wrap-allowed provided no benefits for the context it was rendered in and can be dropped. Resolves: #100591 Releases: main Change-Id: Ibf6562265da3010d24b5096a00eb1611d6f77279 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78634 Reviewed-by:
-
Christian Kuhn authored
The ext:install uri.action ViewHelper is - after various previous refactorings - only used within standalone install tool to create the main module links. The code can be simplified nowadays, avoiding the view helper entirely. The patch takes care of this and simplifies the templates by removing one partial entirely. Change-Id: I2d5a5f535973a1bac90362fa741795edf1ff0673 Resolves: #100590 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78632 Tested-by:
-
Benjamin Kott authored
This patch cleans up the a workaround for the Bootstrap CSS Framework 5.1 update where `.text-monospace` was dropped and replaced with `.font-monospace`. Resolves: #100589 Releases: main Change-Id: I8fbc01af2b6d6fe7c84a2e60e2a692ce62df0f8d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78633 Tested-by:
-
Benjamin Kott authored
The Bootstrap CSS Framework changed the handling of media queries with version 4.6 but the core never adapted to this. We are now finishing the migration and dropping all `$screen-` variables. All media queries that are bound to bootstrap breakpoints are now using the provided mixins. In addition the unused `.dl-horizontal` was dropped. Resolves: #100588 Releases: main Change-Id: I2d47d62f4d110a290607708ebb496dc23249ee17 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78630 Reviewed-by:
-
Benjamin Kott authored
- Migrate checkboxes to form-check - Rebuild indention of rows - Add icons to buttons - Add sections to tabs - Add missing input classes Resolves: #100561 Releases: main Change-Id: If1c7fbb62b9541404090ad5cf849e3eba9da9643 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78596 Tested-by:
-
Andreas Fernandez authored
The multi selection actions available in the file list are wrapped by `.multi-record-selection-actions-wrapper` now to reserve their necessary space and to avoid layout shifts when using multi selection. Resolves: #100579 Releases: main Change-Id: I91cf6f50a06adff3f3227543c5cec5a44fa7529a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78618 Reviewed-by:
-
Oliver Bartsch authored
With the upgrade of symfony/expression-language 6.2 in TYPO3 v12.1, a new user-facing feature for TypoScript conditions was added, which only popped up recently. It is now possible to use [getTSFE()?.id == 13] which is handy, and should be documented. Resolves: #100586 Related: #99239 Releases: main Change-Id: Icba26809497684036a253130f56a022cc1a11166 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78629 Tested-by:
-
Christian Kuhn authored
GeneralUtility::linkThisScript() is one of the last usages that access $_GET() from globals. The patch removes a last usage and marks the method @deprecated. Resolves: #100584 Releases: main Change-Id: I9555ef7345fc001bcada367e32eeec1b7d00782a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78625 Tested-by:
-
Christian Kuhn authored
FormDataCompiler pollutes __construct(), making it impossible to be injected. The patch changes compile() to receive the FormDataGroup, which will free the constructor of this class in v13. Change-Id: If591a8785534318b60a1846559c86444ea7bf1e9 Resolves: #100581 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78619 Tested-by:
-
