- Jul 12, 2022
-
-
Frank Naegler authored
Since TYPO3 version 10.4, the custom page type is not restricted to any range of numbers. This limitation no longer exists, and any number is allowed. The ElementBrowserPageTreeView just now also respect this and allows to link to other any doktype beside: - PageRepository::DOKTYPE_RECYCLER - PageRepository::DOKTYPE_SYSFOLDER Resolves: #97626 Releases: main, 11.5, 10.4 Change-Id: Iffc3f705f74cc7516464fdb00adb456141657948 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75133 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Apr 15, 2020
-
-
Alexander Schnitzler authored
With this patch, the header comment of php files is automatically added by the php-cs-fixer, which guarantees that its format and place of occurrence remain the same in all files. Files that are copied over from other projects are excluded. Furthermore, files that are kind of inspired by other projects also get the same header comment but may have a second, additional comment explaining its origin. Used command: bin/php-cs-fixer fix --config=Build/php-cs-fixer/header-comment.php Releases: master Resolves: #91024 Change-Id: I5a040517e0fbde6e5a27d589bf2f222078326dc8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64159 Tested-by:TYPO3com <noreply@typo3.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Apr 14, 2020
-
-
Benni Mack authored
This change adds two changes 'blank_line_after_opening_tag' => true, 'single_trait_insert_per_statement' => true, to our PHP-CS Fixer configuration, adopting more rules related to PSR-12. Resolves: #91020 Releases: master Change-Id: I180b2cbceb077911bddeb42d9f131e5b32244ed2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64158 Tested-by:Josef Glatz <josefglatz@gmail.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
- Sep 04, 2019
-
-
Andreas Fernandez authored
This patch deprecated the well-known `jumpToUrl()` function which simply does a redirect nowadays. Any occurence may be replaced by either using `window.location.href` or using simple `<a>` tags. Resolves: #89033 Releases: master Change-Id: I213d89825b8ee4736e168653cddb1929ceb9844e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61389 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
- Jul 17, 2019
-
-
Benni Mack authored
Since Context API was introduced in TYPO3 v9, PageRepository is highly decoupled from $TSFE->sys_page, and fully works standalone. It is also used in various places where TSFE is not needed, or required, but also in places of EXT:core. Especially parts like RootlineUtility, which depends on PageRepository very much, cannot live without it. I propose to move this highly important PHP class into EXT:core, in order to allow to decouple EXT:frontend even further from EXT:core. The FQCN is moved from - \TYPO3\CMS\Frontend\Page\PageRepository to - TYPO3\CMS\Core\Domain\Repository\PageRepository It can be assumed to use PageRepository for any use-case and actually reduce usages towards BackendUtility::get... by using this API more and more. Further adaptions could be to reduce the logic within PageRepository and move this into QueryBuilder and assimilate especially the "versionOL" behavior. Resolves: #88746 Releases: master Change-Id: Id8225100ac60bd77fc7e1303efb4c46b741d3415 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61166 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Nov 05, 2018
-
-
Stefan Neufeind authored
Adds a new method HttpUtility::buildQueryString() using http_build_query() instead of reimplementing the encoding-process like the old method GeneralUtility::implodeArrayForUrl() did. As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set to "false" by default and used in several places without manually setting it to "true" using that method could lead to potentially unsafe non-encoded parameter names. Some unit-tests had wrong URLs with non-encoded braces [...], which were adapted to be properly escaped as well. Resolves: #83334 Releases: master Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df Reviewed-on: https://review.typo3.org/55079 Reviewed-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
-
- Oct 26, 2016
-
-
Michael Stucki authored
If options.pageTree.showPathAboveMounts is enabled in UserTS, respect the setting also in record and link browsers. Resolves: #77734 Releases: master, 7.6 Change-Id: I492d8a7eb3a8c557c231be7aaf58dfa8dd90cc7d Reviewed-on: https://review.typo3.org/49750 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Aug 10, 2016
-
-
Benni Mack authored
A new and unified syntax to link to pages, files, folders within a TYPO3 instance is added. All links are prefixed with "t3://". This patch adds a LinkService to convert from the "old" typolink syntax to the new syntax, and also allows to add the new syntax to typolink syntax. The further steps are * Don't replace the <a> tags with <links-tags inside the RTE transformations anymore * Make the frontend lib.parseFunc_RTE deal with <a> tags directly * Add a migration wizard for existing content Resolves: #74365 Releases: master Change-Id: I95a68c5770f4e4c5d9f8b3973817f1a270353217 Reviewed-on: https://review.typo3.org/47094 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Nov 18, 2015
-
-
Marco Huber authored
Show the nav title instead of the page title in the element browser (f.e. in the link wizard), if the user TSconfig setting "options.pageTree.showNavTitle=1" is set. Resolves: #71625 Related: #64492 Releases: master Change-Id: Id6721edf9741d05596342f0fee920cf8068e1354 Reviewed-on: https://review.typo3.org/44747 Reviewed-by:
Marco Huber <mail@marco-huber.de> Tested-by:
Gianluigi Martino <gmartino27@gmail.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Nov 03, 2015
-
-
Markus Klein authored
Resolves: #71276 Releases: master Change-Id: I472284e9c4617e614122867373c74c771af3e83b Reviewed-on: https://review.typo3.org/44504 Reviewed-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Markus Klein authored
Adjust link browser integration of RTE. This removes the dedicated tree classes for RTE as those are useless by now. Additionally the ElementBrowser class is finally removed. Resolves: #66369 Releases: master Change-Id: I8f42228cb3c4b3008d3f0acaa014d01733f6186d Reviewed-on: https://review.typo3.org/43938 Reviewed-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Oct 08, 2015
-
-
Markus Klein authored
This change refactors the ElementBrowser and splits it into multiple dedicated classes for each mode. The former modes for file, folder and record selection are now placed in dedicated *Browser classes. The former mode "wizard", which defines its actual functionality via the "act" variable, is a separate controller now, which provides the API to be exensible. The integration of the various trees and lists is solved by a dedicated LinkParameterProviderInterface. Any class can provides link parameters now by implementing this interface. Other than that: * Lots of unused code is removed * All JS is moved into requireJS modules * Tree code is simplified by properly using constructors Part 2 will: * add Breaking and Feature documentation * finalize RTE re-integration * finally delete unused classes Resolves: #66369 Releases: master Change-Id: I0a28663ce4c91c2405abc9e2a13063699c6bb231 Reviewed-on: http://review.typo3.org/42951 Reviewed-by:
-
- Aug 25, 2015
-
-
Markus Klein authored
The back-reference to the underlying instance of ElementBrowser is now stored as member of the tree. Resolves: #69276 Releases: master Change-Id: Ie48a77cd01269ea7e13905d651663424dbb616a1 Reviewed-on: http://review.typo3.org/42853 Reviewed-by:
-
- Aug 18, 2015
-
-
Markus Klein authored
The TreeViews access the controllers via the global SOBE. This patch adds typehints to easily identify those usages. Resolves: #69139 Releases: master Change-Id: Ib280d4f9a2eeeb347893d1a9ab761760d993cac5 Reviewed-on: http://review.typo3.org/42691 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Aug 13, 2015
-
-
Markus Klein authored
Resolves: #68394 Releases: master Change-Id: I539f9b063db55d677f47fc01a7691e8e9e2496e0 Reviewed-on: http://review.typo3.org/41760 Reviewed-by:
-
- Aug 04, 2015
-
-
Josef Glatz authored
Module Filelist -> Folder Tree: prevents the line break between icon and text. Element Browser: Missing space between tree item text and .list-tree-show icon added. Change-Id: I96907290dc49106b3a466fbd70656c51d61b4c39 Releases: master Related: #68649 Reviewed-on: http://review.typo3.org/42232 Reviewed-by:
Alexander Grein <mail@mediaessenz.de> Tested-by:
-
Josef Glatz authored
Let the open/close icons for the tree root elements reappear. Releases: master Resolves: #68649 Change-Id: I0a7c9065b5773a8266a7df6587887dfcd59aa416 Reviewed-on: http://review.typo3.org/42210 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
- Jul 18, 2015
-
-
Sebastian Michaelsen authored
In english you have to use "an" before any spoken vowel. Resolves: #68326 Releases: master Change-Id: I2f8996d14eb532bd297b7035a6daaee4fea3f140 Reviewed-on: http://review.typo3.org/41651 Reviewed-by:
Helmut Hummel <helmut.hummel@typo3.org> Tested-by:
-
- Jul 15, 2015
-
-
Benjamin Mack authored
Remove some last styling topics and leftover snippets. Resolves: #68147 Releases: master Change-Id: I2170b5407be897d5e2e28d8a24d668ea5617bc01 Reviewed-on: http://review.typo3.org/41260 Reviewed-by:
-
- Jul 14, 2015
-
-
Wouter Wolters authored
Resolves: #68135 Releases: master Change-Id: I48bb8fe1b5c94ed7c22710053ad7252a1fd648c1 Reviewed-on: http://review.typo3.org/41227 Reviewed-by:
-
Wouter Wolters authored
Resolves: #68121 Releases: master Change-Id: I7822981c26d8ceae1ea51cf11aa75e2a8b94731d Reviewed-on: http://review.typo3.org/41189 Reviewed-by:
-
- Jul 13, 2015
-
-
Markus Klein authored
An old implementations expected icons to be img-tags, which is not the case anymore. The regex for replacing parts of the tag do not work with the span tags anymore and therefore all calls to the function are dropped. This also renders a whole class useless, which is therefore removed as well. Resolves: #68086 Releases: master, 6.2 Change-Id: I073e6e2d640ac5f53ae13ec564e6f8903b65e8b8 Reviewed-on: http://review.typo3.org/41141 Reviewed-by:
-
- Jul 09, 2015
-
-
Thomas Schlumberger authored
Renders all folder and page trees in the same HTML manner. These are located in: - Link Wizards - RTE popups - Select / Group Field Selector Popups (e.g. Insert Record) Next steps: - Rework the impexp tree - Rework the Move Tree and the New Element Position Maps - Add highlighting - Simplify the calls to each method and remove "old" parameters to methods, rename the methods to make them speaking. Releases: master Resolves: #68018 Change-Id: I675368039f2065dcd9e4bb2555da4495f84eb87b Reviewed-on: http://review.typo3.org/41001 Reviewed-by:
-
Thomas Schlumberger authored
All custom typo3-classes (typo3-red, typo3-dimmed) are replaced with bootstrap alternatives. Through that, some PHP Tree classes don't need to overload the method anymore from the AbstractTreeView and are removed. Resolves: #67994 Releases: master Change-Id: Ie95b70e9b402a7a66eb6c5a2dbe2e2a87c96c5aa Reviewed-on: http://review.typo3.org/41012 Reviewed-by:
-
- Jun 16, 2015
-
-
Frank Nägler authored
Resolves: #67480 Releases: master Change-Id: Ic59854fb05fa3b1593ecc37e49d91042be9b0d3a Reviewed-on: http://review.typo3.org/40275 Reviewed-by:
-
- May 09, 2015
-
-
Andreas Fernandez authored
Due to wrong quoting, the links to anchors are broken. Resolves: #66854 Releases: master, 6.2 Change-Id: I4a52dc6cead27fc499e93618dfaefd824ebd525c Reviewed-on: http://review.typo3.org/39363 Reviewed-by:
-
- Apr 30, 2015
-
-
Wouter Wolters authored
Extension backend is done with this patch except FormEngine classes. Resolves: #66115 Releases: master Change-Id: I0dc335b0193566b9d14e4b8fdafc116a81e0f5cc Reviewed-on: http://review.typo3.org/38324 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
- Jan 29, 2015
-
-
Benjamin Mack authored
There are a few leftover classes inside typo3/ which haven't been moved or migrated yet into the according places. 1. typo3/move_el.php. The extension classes to PagePositionMap are now moved to EXT:backend/Classes/Tree/View with according names. 2. typo3/class.browse_links.php - several extensions to the PageTreeView and the FolderTreeView. 3. typo3/db_new.php - an extension to the PageTreeView is now located in EXT:backend/Tree/View/NewRecordPageTreeView The base classes (localPageTree and localFolderTree) have been moved to EXT:backend/Classes/Tree/View/ElementBrowser*. The subclasses for recordlist (regular record picker) are moved into EXT:recordlist. The subclasses used in RTEhtmlarea are adopted to use the new naming scheme. All calls within the core have been adopted. As backwards compatibility, the old class names are added to EXT:compatibility6. 3. The ext_autoload.php inside EXT:core is therefore not needed anymore, the call inside Bootstrap is not needed anymore. Resolves: #64516 Releases: master Change-Id: I926baace282d6e95d73607f974cd91296d2df890 Reviewed-on: http://review.typo3.org/36276 Reviewed-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
