[FEATURE] Improve creation of URL query strings from arrays
Adds a new method HttpUtility::buildQueryString() using http_build_query() instead of reimplementing the encoding-process like the old method GeneralUtility::implodeArrayForUrl() did. As the parameter $rawurlencodeParamName of implodeArrayForUrl() was set to "false" by default and used in several places without manually setting it to "true" using that method could lead to potentially unsafe non-encoded parameter names. Some unit-tests had wrong URLs with non-encoded braces [...], which were adapted to be properly escaped as well. Resolves: #83334 Releases: master Change-Id: Ifbaad912f0d658671356dc7bdf1579dacff272df Reviewed-on: https://review.typo3.org/55079 Reviewed-by:Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Showing
- typo3/sysext/backend/Classes/Controller/ContentElement/NewContentElementController.php 2 additions, 1 deletion...Controller/ContentElement/NewContentElementController.php
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php 4 additions, 7 deletions...ext/backend/Classes/Controller/EditDocumentController.php
- typo3/sysext/backend/Classes/Controller/LinkBrowserController.php 2 additions, 1 deletion...sext/backend/Classes/Controller/LinkBrowserController.php
- typo3/sysext/backend/Classes/Routing/UriBuilder.php 2 additions, 1 deletiontypo3/sysext/backend/Classes/Routing/UriBuilder.php
- typo3/sysext/backend/Classes/Template/DocumentTemplate.php 6 additions, 2 deletionstypo3/sysext/backend/Classes/Template/DocumentTemplate.php
- typo3/sysext/backend/Classes/Template/ModuleTemplate.php 3 additions, 2 deletionstypo3/sysext/backend/Classes/Template/ModuleTemplate.php
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserFolderTreeView.php 10 additions, 5 deletions...ackend/Classes/Tree/View/ElementBrowserFolderTreeView.php
- typo3/sysext/backend/Classes/Tree/View/ElementBrowserPageTreeView.php 3 additions, 2 deletions.../backend/Classes/Tree/View/ElementBrowserPageTreeView.php
- typo3/sysext/backend/Classes/Utility/BackendUtility.php 3 additions, 2 deletionstypo3/sysext/backend/Classes/Utility/BackendUtility.php
- typo3/sysext/backend/Classes/View/PageLayoutView.php 1 addition, 4 deletionstypo3/sysext/backend/Classes/View/PageLayoutView.php
- typo3/sysext/core/Classes/Database/QueryView.php 2 additions, 1 deletiontypo3/sysext/core/Classes/Database/QueryView.php
- typo3/sysext/core/Classes/TypoScript/TemplateService.php 2 additions, 1 deletiontypo3/sysext/core/Classes/TypoScript/TemplateService.php
- typo3/sysext/core/Classes/Utility/GeneralUtility.php 4 additions, 7 deletionstypo3/sysext/core/Classes/Utility/GeneralUtility.php
- typo3/sysext/core/Classes/Utility/HttpUtility.php 32 additions, 0 deletionstypo3/sysext/core/Classes/Utility/HttpUtility.php
- typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-83334-AddImprovedBuildQueryString.rst 23 additions, 0 deletions...gelog/9.5.x/Feature-83334-AddImprovedBuildQueryString.rst
- typo3/sysext/core/Tests/Unit/Utility/HttpUtilityTest.php 85 additions, 1 deletiontypo3/sysext/core/Tests/Unit/Utility/HttpUtilityTest.php
- typo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php 2 additions, 1 deletiontypo3/sysext/extbase/Classes/Mvc/Web/Routing/UriBuilder.php
- typo3/sysext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php 2 additions, 2 deletions...ext/extbase/Tests/Unit/Mvc/Web/Routing/UriBuilderTest.php
- typo3/sysext/felogin/Classes/Controller/FrontendLoginController.php 7 additions, 12 deletions...xt/felogin/Classes/Controller/FrontendLoginController.php
- typo3/sysext/felogin/Tests/Unit/Controller/FrontendLoginControllerTest.php 42 additions, 15 deletions...gin/Tests/Unit/Controller/FrontendLoginControllerTest.php
Please register or sign in to comment