- Oct 01, 2018
-
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:core - EXT:extensionmanager - EXT:install All @api annotations have been removed. Resolves: #86517 Releases: master Change-Id: I7869d8e3b6e8a4365529cc7c98b99cde7ca1495f Reviewed-on: https://review.typo3.org/58532 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Daniel Goerz authored
Resolves: #86504 Releases: master Change-Id: I115d1fcce00142b5e0eb34dbb840c785cf1b59f4 Reviewed-on: https://review.typo3.org/58523 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:indexed_search - EXT:info - EXT:linkvalidator - EXT:lowlevel - EXT:opendocs - EXT:recordlist - EXT:recycler - EXT:redirects - EXT:reports - EXT:scheduler All @api annotations have been removed. Resolves: #86511 Releases: master Change-Id: I80de460142266305c1af3ad437f939b7e4448676 Reviewed-on: https://review.typo3.org/58530 Reviewed-by:
-
Benni Mack authored
EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:fluid: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever. Resolves: #86507 Releases: master Change-Id: I5deba0ba2b868743e7eda8f0e32cda40ef008046 Reviewed-on: https://review.typo3.org/58525 Tested-by:
-
Susanne Moog authored
Resolves: #86498 Releases: master Change-Id: I8605215706406a0a7826a1fe401ccd11d46ead73 Reviewed-on: https://review.typo3.org/58516 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:seo - EXT:setup - EXT:rte_ckeditor - EXT:workspaces - EXT:viewpage - EXT:tstemplate - EXT:taskcenter - EXT:t3editor - EXT:sys_action - EXT:sys_note All leftover @api methods have been removed. Resolves: #86509 Releases: master Change-Id: I6e5ee2302055de9ea4c124ca913e4677d62721fe Reviewed-on: https://review.typo3.org/58529 Tested-by:
-
Benni Mack authored
Two new Exceptions are now thrown when routing does not work, one being thrown when a URL is generated but could not be generated, and one when a URL could not be resolved. This is much cleaner than the distinction of a nullable return type, so the new interface is adapted as well. As a drive-by fix, the Backend routing exception now inherits from this new exception. Resolves: #86500 Releases: master Change-Id: Ifaf7b61422dfd49df18399c3bcbdf735bc522cba Reviewed-on: https://review.typo3.org/58519 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Markus Klein authored
Releases: master Resolves: #86481 Change-Id: I87b9a07b6cc10c4379a6bf3e1c0e1695354b574a Reviewed-on: https://review.typo3.org/58505 Tested-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
Andreas Wolf <andreas.wolf@typo3.org> Tested-by:
-
Markus Klein authored
This reverts commit 2124bba4. The feature is reverted as the functionality can't be provided in a fully working manner to work in all possible cases the FE may be called. Change-Id: Ia7caf3770b12737fd195da9d9f66bdc179981de8 Resolves: #86492 Reverts: #23494 Releases: master Reviewed-on: https://review.typo3.org/58517 Reviewed-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Benjamin Kott authored
Resolves: #86510 Releases: master Change-Id: I80692b806c3a7b51de3fad4947102e34956114a2 Reviewed-on: https://review.typo3.org/58528 Reviewed-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:felogin - EXT:feedit - EXT:filelist - EXT:frontend - EXT:fluid_styled_content - EXT:impexp All leftover @api methods have been removed. Resolves: #86508 Releases: master Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266 Reviewed-on: https://review.typo3.org/58527 Tested-by:
-
Benni Mack authored
All specific controllers for specific Backend actions, Backend-module related modules, all hook implementations (where the core uses hooks by itself), and module-specific ViewHelpers are now marked as @internal to ensure developers what is part of the public TYPO3 Core API. within - EXT:backend (except ViewHelpers) - EXT:beuser - EXT:about - EXT:belog All @api methods have been removed. Resolves: #86505 Releases: master Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b Reviewed-on: https://review.typo3.org/58524 Reviewed-by:
-
Josef Glatz authored
This patch adds the newly added CKEditor v4 icon (via #86499) to ext:rte_ckeditor as new extension icon. `yarn && yarn build` was used to copy the file to the final location. Releases: master Resolves: #86501 Change-Id: I5225805f195eb2efe29a5deac6bb5426c313b604 Reviewed-on: https://review.typo3.org/58520 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
Benni Mack authored
EXT:form uses @api and @internal phpDoc annotations. Going with a cleaner approach with marking code as just @internal, and everything not annotated as @internal is public, is the way to go, also the way PSR-5 is heading. For EXT:form: Every PHP class that had nothing marked, is now @internal, everything that was @api is now implicitly part of TYPO3 Core API. Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever. Resolves: #86502 Releases: master Change-Id: I2c1efdd11f0fbaa992315a90049eb109e2620c76 Reviewed-on: https://review.typo3.org/58521 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Benjamin Kott authored
Following commands were used to update the external package and copy the files/folders to the final location: `yarn upgrade @typo3/icons@1.8.0 && yarn build` Resolves: #86499 Releases: master Change-Id: I87b571234257d82b1f2f09f523817c2eea2b26d2 Reviewed-on: https://review.typo3.org/58518 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Daniel Siepmann authored
Use proper code highlighting syntax for yaml and typoscript within 86160 changelog entry. Resolves: #86160 Releases: master Change-Id: I791956413885cabdfdf5693e9d0ad6c4be41a29d Reviewed-on: https://review.typo3.org/58515 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Daniel Siepmann authored
Define default highlighting for 86365 changelog entry to be yaml. Adjust all yaml occurrences within this entry to use default highlighting. Releases: master Resolves: #86365 Change-Id: I9063311830330d55ae051c8a0d38da78a2a91831 Reviewed-on: https://review.typo3.org/58514 Reviewed-by:
-
Frank Naegler authored
This patch adds a request queue for the massive amount of AJAX calls in the extension scanner. This patch mitigates the problem of massive server load in case the amount of files to be scanned is very high. This patch mitigates the problem by allowing a maximum of 10 concurrent requests. After the release of TYPO3 v9 LTS, this scanner module should be refactored further. Resolves: #86436 Releases: master Change-Id: I824dfb74aae46d6b00690e7ca6553305c4221f0f Reviewed-on: https://review.typo3.org/58510 Tested-by:
-
Benni Mack authored
A new PageTypeEnhancer is added to map the internal TYPO3 GET parameter `type` to a speaking URL suffix. The PageTypeEnhancer only does suffixes, if other You can configure it like this: routeEnhancers: PageType: type: PageType default: '' map: '.html': 1 'menu.json': 13 Resolves: #86160 Releases: master Change-Id: Ie4b387963012946272568a69c9581e8d345dbe4c Reviewed-on: https://review.typo3.org/58478 Reviewed-by: -
Benni Mack authored
Resolves: #86489 Releases: master Change-Id: I721c89b8afdc248b040a5e82cfd8c209dc84dbab Reviewed-on: https://review.typo3.org/58511 Reviewed-by:
-
Benni Mack authored
This patch streamlines all deprecation messages and follow the following rules. 1. All @deprecated should contain @deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10" 2. trigger_error() - All trigger_error() messages MUST end with a "." (dot). - Never use "This method" but the method name (enjoy the logs otherwise) - "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file. - Do not use "__METHOD__" or some other "magic". Resolves: #86488 Releases: master Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c Reviewed-on: https://review.typo3.org/58494 Reviewed-by:
-
- Sep 30, 2018
-
-
Benni Mack authored
HTTP Headers are added to the PSR-7 response object now within TSFE. They are then sent at the very end of the request process. A bw compat layer is added as well. Resolves: #86486 Releases: master Change-Id: Ifdeaab26868d0cf60dd87d52046a2565c4971488 Reviewed-on: https://review.typo3.org/58499 Reviewed-by:
-
Frank Naegler authored
Resolves: #86326 Releases: master Change-Id: Ifbe8c5067c5a7e47188ea89f4e6df3db9192ac61 Reviewed-on: https://review.typo3.org/58387 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Nikita Hovratov authored
When hovering over a page-icon in the pagetree, a tooltip with the id and status is now shown instead of a browser default title tooltip. Resolves: #86314 Releases: master Change-Id: I7d39841fa5085ea5bedb138e1d3e0eb036a3f402 Reviewed-on: https://review.typo3.org/58481 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Benjamin Franzke authored
A new driver method streamFile() is added (specified in a new, internal StreamableDriverInterface). streamFile() returns a PSR-7 response which serves the contents of the file. Once this interface will be marked as public, third party drivers will be allowed to return an own response (e.g. containing a redirect to a CDN), providing full controls to headers. It also opens possibilties for optimizations like X-SendFile (apache) or X-Accell-Redirect (nginx) to be used by drivers. We also add SelfEmittableStreamInterface (marked as internal) to support the same fast file sending using readfile() – the interface provides a hook which is called by the AbstractApplication in sendResponse. That means that file contents do not need to be read into memory, stored into a stream, and then read again, but can be piped to stdout by php directly. For all existing drivers backward compatibility is provided by wrapping their dumpFileContents() method into a decorator stream which calls dumpFileContents *when* the response is sent. That means middlewares are able to prevent/stop/enhance the response, but the driver method dumpFileContents is still used – it's delayed until Application::sendResponse. The dumpFileContents method of the ResourceStorage class is now deprecated. ResourceStorage->streamFile() should be used instead. Change-Id: I64e707c1f8350e409ff2505b98531b92b2936e02 Releases: master Resolves: #83793 Reviewed-on: https://review.typo3.org/55585 Reviewed-by:
-
Nikita Hovratov authored
The tooltip is not shown now, when you move the cursor away, while the spinning icon is active. The new label still updates, if you keep the cursor the whole time on the button. Resolves: #85319 Releases: master, 8.7 Change-Id: Id653a9f6d43c1ca1f6a24112edde18b50286843f Reviewed-on: https://review.typo3.org/58479 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
Use your own instance of PageRepository instead of depending on TSFE, and use the menu by using the global context and restrictions by using PageRepository instead of custom DB queries. Resolves: #86472 Releases: master Change-Id: Ia480caace4d7415a8b43abc36b7dda5e314c0712 Reviewed-on: https://review.typo3.org/58492 Tested-by:
-
Susanne Moog authored
Labels have been rewritten to consequently use title case. Additionally, the layout of the main site tab has been adjusted. Resolves: #86485 Releases: master Change-Id: I5186c3a4506d546dc61ef8e4e9e41491b123ace4 Reviewed-on: https://review.typo3.org/58508 Tested-by:
-
Benni Mack authored
This patch also streamlines the Context API usage of Workspaces in the main AbstractDataHandlerActionTestCase class. Resolves: #86465 Releases: master Change-Id: I99e2a379e745494f9c23cca40ca4ad7ee1fc887f Reviewed-on: https://review.typo3.org/58484 Tested-by:
-
Benni Mack authored
In #79777 a new "tx_scheduler_task.deleted" field was added, but is not always considered when tasks are run. Resolves: #86420 Related: #79777 Releases: master Change-Id: Ide025bda13504bd56dc5f9cc090f5e7e54da6695 Reviewed-on: https://review.typo3.org/58439 Tested-by:
Alexander Opitz <opitz.alexander@googlemail.com> Tested-by:
-
Benni Mack authored
PageArguments are fetched and added on top of PSR-7 request queryParams right after they are validated from the PageRouter. They are also re-populated after config.defaultGetVars has modified global state. But they do not need to be set to TSFE again within the the PageArgumentValidator middleware. Resolves: #86483 Releases: master Change-Id: I03df4223832845038d4207417cfcab7cbcc687dc Reviewed-on: https://review.typo3.org/58507 Tested-by:
-
Benni Mack authored
The Installer uses a full grid which is a lot of white space if not needed. So, the whole layout is put into a col-md-6 grid with a col-md-offset-3 offset. Resolves: #86482 Releases: master Change-Id: If2e409deae98c0cf23eb7606a6cf35b950834874 Reviewed-on: https://review.typo3.org/58506 Reviewed-by:
-
Nikita Hovratov authored
* The last item in panel-collapse has now proper padding to its bottom. * With a different behaviour of firefox a container having overflow-y ignores padding-bottom. A workaround is a pseudo-element reserving the same space as the padding attribute would have. Resolves: #86445 Releases: master Change-Id: I55b6318f1b59ceda65857726828deab5bc8a306f Reviewed-on: https://review.typo3.org/58460 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Benni Mack authored
When checking the parent page for an existing slug, the parent page should not be used if the parent page is a sys folder, spacer or recycler (pages.doktype), but the traversal goes up. This makes it a bit easier for editors to work with better-speaking URLs and keep the rootline traversal as best practice. Resolves: #86456 Releases: master Change-Id: I2c46d096e41fb3a325fd42bf86b8968b79d6305b Reviewed-on: https://review.typo3.org/58473 Tested-by:
-
Benni Mack authored
While introducing Page URL handling, the workspace functionality still built the URL with `/index.php` although the Router should take care of that now. As drive-by fix, the BackendUtility preview URL hook now works again due to some refactoring back in TYPO3 9.2. Another drive-by fix allows to register the middleware at the right place to render the workspace preview in general. Resolves: #86480 Releases: master Change-Id: Icfa5a5eee304c27db39cf25903b9a14452c81168 Reviewed-on: https://review.typo3.org/58502 Tested-by:
-
Oliver Hader authored
When generating slugs it might happen, that double slashes are generated. This basically results from both prepending and appending slashes at the same time. Resolves: #86479 Releases: master Change-Id: I441fee333cd0b3fbad3dde1a130eb08356bd4c2d Reviewed-on: https://review.typo3.org/58503 Tested-by:
-
Oliver Hader authored
Improve processing by deferring those mappers that invoke persistence the latest possible time. In case mappers do not match the processing is stopped earlier to avoid superfluous checks and invocations. Resolves: #86464 Releases: master Change-Id: I4f9ec66611e84b49a54223f77aee824033a2fb7a Reviewed-on: https://review.typo3.org/58483 Tested-by:
-
Wouter Wolters authored
Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase Resolves: #86478 Releases: master Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e Reviewed-on: https://review.typo3.org/58501 Tested-by:
-
Jigal van Hemert authored
In the fieldWizard defaultLanguageDifferences the opposite value must be displayed if invertStateDisplay is active in fields of type "check". Resolves: #86205 Releases: master Change-Id: Iac8fa73406b076b3d26a6ed3aed7e21b79220750 Reviewed-on: https://review.typo3.org/58238 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Resolves: #86476 Releases: master Change-Id: I182bd77895744d13ba535b43e46b802def49cb45 Reviewed-on: https://review.typo3.org/58498 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
