- May 04, 2021
-
-
Benjamin Franzke authored
In case the TYPO3 backend is loaded inside the content frame, which is a result of a programming error, the inner backend overwrites state of the outer one, making the backend unusable because references to javascript singletons are mixed between outer and inner frame. Releases: master Resolves: #94062 Change-Id: Ia3b75d949ec94ebdce317208e87917206769de48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68930 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Nikita Hovratov authored
This removes all parts in the button component which are exactly the same as in bootstrap. Resolves: #94046 Releases: master Change-Id: Ie3efb386a4e2cce970fc46155c6ae3b8b9acc82a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68979 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Anja Leichsenring authored
There is no valid reason anymore to separate functional test stages into 2 runs, so they get merged again. Resolves: #94064 Releases: master, 10.4 Change-Id: I02385b2332b62ac9f637442b2500b214bd66b357 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69019 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Christian Kuhn authored
Needs a phpdocumentor/type-resolver raise: composer req phpdocumentor/type-resolver:^1.4 Change-Id: Iffecb88d34a4c04816eff5543611192fcc3b8296 Resolves: #94063 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69018 Tested-by:
-
Nikita Hovratov authored
In case an infobox has an icon but no title and the text is just one line, the text is now vertically centered. Also remove the css property "vertical-align: middle" as it has no effect anymore. Resolves: #93998 Releases: master Change-Id: I58c75fb6c7004101a9598307ac8385a023fd2426 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68890 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Daniel Goerz authored
Resolves: #94059 Releases: master Change-Id: I9687dddef9889d79359e64987e8886a305d3149f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69016 Tested-by:
-
Christian Kuhn authored
Next to pre-merge test suite, nightlies now especially run the composer min/max functionals with PHP8. Using mariadb 10.5 to cover another DBMS variant. Needs a friendsoftypo3/phpstan-typo3 raise: composer require --dev friendsoftypo3/phpstan-typo3:^0.7.0 Change-Id: Iea86496e32a586b20d4d6eeb6db84ec5a06d0767 Resolves: #94061 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68991 Tested-by:
-
Benjamin Franzke authored
The namespace of "felogin" was partially changed to \TYPO3\CMS\FrontendLogin with #84262, but was kept with \TYPO3\CMS\FeLogin for backwards compatibility in some places. Now that deprecated functionality has been removed, the code is streamlined to use the new FrontendLogin namespace solely. Resolves: #94041 Related: #84262 Releases: master Change-Id: Ie315d413b6b81a1be3f6c6574e103c61d172be3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68974 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
This change raises the dev dependency PHP-CS-Fixer to 2.19 (forward-compatible to 3.0) and 3.0, allowing to run PHP-CS-Fixer with PHP8. This change adapts the config file to use the latest syntax. Using PSR-12 will be handled in a separate followup. Used composer commands: - composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" --dev - composer req friendsofphp/php-cs-fixer:"^2.19 || ^3.0" -d typo3/sysext/core --dev --no-update Resolves: #94053 Releases: master, 10.4 Change-Id: I47d4ca1b09728599782883fb4958908446fd7cfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68989 Tested-by:
-
Larry Garfield authored
PHP 8 deprecated a number of very old bits of the Reflection API. This patch updates ClassSchema to use the newer equivalents. Also fixes some unrelated PHP 8.0 errors around undefined value handling. Resolves: #94001 Releases: master, 10.4 Change-Id: Id235fa830894e9a2dc6465444ec2c6808f18c3aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68898 Tested-by:
-
Nikita Hovratov authored
This fixes the alignment of the rows in the doc header and the size of horizontal lines in dropdowns. Replace the hardcoded 15px margin with the bootstrap grid-gutter-width variable. The row margin override for .module-docheader-bar can be removed completely. Resolves: #94044 Releases: master Change-Id: Iefa02fed9c00a31676d296e86e1bc75049810795 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68976 Tested-by:
-
Remo Häusler authored
If an argument on a plugin namespace is not an array, Extbase failed hard with an type error exception. Resolves: #91040 Releases: master, 10.4, 9.5 Change-Id: Ib613081aeb99232f1254a431fec57f15bb88b1c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65351 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Guido Schmechel authored
If a TYPO3 integrator creates the scheduler command language:update and defines multiple languages, e.g. de fr pt, then this is now interpreted. Releases: master, 10.4 Resolves: #91876 Change-Id: Ia7639f322e5f693aa59f83dacf908b15f2d265ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67394 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Benni Mack authored
When using ?MP=12-13,345-673 some could also add a letter or a "/" symbol in the GET parameter, effectively showing a 503 instead of 404 page. This change ensures that $TSFE->MP only contains numbers, commas or dashes. Resolves: #94045 Releases: master, 10.4 Change-Id: I9d47153495701eb36bd9eb0c9936c0956b075560 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68977 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Bartsch authored
Improves the overall look and feel of the filters in various backend modules, thanks to the new bootstrap v5 grid. We can therefore now rely on flex-form instead of float technology. By using the `g-X` gutter classes and the `align-items-X` arrangement classes, we ensure the positioning and spacing is the same in each module. This allows to effectively remove the `form-inline-spaced` class since this can easily be done with flex-form and the mentioned classes in bootstrap v5. Adjustments done: * Use of flex-form to align and position form fields * Add missing labels and unify arrangement * Adjust size and position of form components * Unify select field size * Unify search field display * Unify submit and reset button styles Resolves: #94042 Resolves: #94026 Releases: master Change-Id: Iae95a3e90179c6708ce6e1f0f272f267b6cae645 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68926 Tested-by:
-
Oliver Hader authored
Change-Id: Ib8345499805813806ead6c0068fb0db6834b8f34 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68984 Tested-by:
-
Benni Mack authored
Change-Id: If9e35910fbf5556a93557ae17c2f3dba23748080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68982 Tested-by:
-
Guido Schmechel authored
Due to a regression the LanguagePackCommand wasn't schedulable. The command registration is now extended to re-add the flag. Releases: master Resolves: #94048 Related: #93174 Change-Id: I61c315229472a733be4e1d28c42d23be7fba0fb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68981 Tested-by:
-
- May 03, 2021
-
-
Markus Klein authored
Ensure that changes done to session records in the respective backends are updated by building a new session object, so specifically the ses_tstamp value is updated. Besides that, set the ipLock information on the session object instead of the deduced session record making consecutive session updates idempotent. Resolves: #93421 Resolves: #93386 Releases: master Change-Id: I9715c82bb147348d8bc7526b29c790bc59ac8a0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67637 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Laurent Foulloy <yolf.typo3@orange.fr> Tested-by:
-
Anja Leichsenring authored
Resolves: #94038 Releases: master Change-Id: Iff2a240929531c69fcd4f833efb3f673b7737405 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68961 Tested-by:
-
Nikita Hovratov authored
The MultiStepWizard has some obvious programming errors, which surprisingly didn't cause any problems in TYPO3 v10. It was built primarily with the multi step wizard of the form module in mind. This fact reflects on some parts of the code. As the direct commits to the module didn't change anything dramatically it's reasonable to conclude the bootstrap v5 update revealed the flaws. Most notably all 4 slides are now visible in the progress bar. Before only 3 slides were visible (Step 3 was overridden with finish). This patch fixes the prev and next logic to work properly with any size of slides in a clear and understandable way. Other notable changes: - The missing progress bar titles in the form module multi step wizard are added. - The jQuery slideUp and slideDown of the buttons when going back to the first step are removed as it serves no meaningful purpose. - The hard coded forceSelection change when switching to first slide (=true) and last slide (=false) is removed. Resolves: #94037 Releases: master Change-Id: I4f70dd30b3caf29a71491a69b18c6753666ccef4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68960 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Simon Gilli authored
The usage of Address::create instead of a plain new ensures compatibility with all Symfony releases. Since Symfony 5.2.6 the behavior was changed to always return email addresses properly quoted but this change broke our Mailer. Resolves: #93843 Related: #93831 Releases: master, 10.4 Change-Id: Ia8d35c220be0ba46cf75dec51585158760fad26d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68888 Tested-by:
-
Benni Mack authored
With the change https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237 an accidental hard-coded clickTitleMode got added, which changes the default behavior. This change reverts the hard-coded setting. Resolves: #94040 Related: #92652 Releases: master Change-Id: I10c9db85ba0aab831d0aaf7d5c6e514b3c2bb7c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68972 Tested-by:
-
Oliver Bartsch authored
The AbstractItemProvider method for fetching records from `foreign_table`, e.g. used in selectSingle types, missed proper workspace handling and therefore listed the same record (online and offline) multiple times. This is now fixed by adding the WorkspaceRestriction, and applying proper overlay handling (e.g. removing delete placeholder and move pointers). Resolves: #90392 Releases: master, 10.4 Change-Id: Idd6ee40c7422f3b234afc2025b248f1c18a9cf98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68925 Tested-by:
-
Georg Ringer authored
Differentiate between tags 'a' and 'button' in the record list. An a-tag opens a page, a button triggers an action. Additionally the change includes 3 accessibility related issues: Implement browser "tooltips" (ie title attributes) on a-tags and button-tags as Bootstrap tooltips. Add aria-haspopup="dialog" on buttons that open a Bootstrap modal which are implemented as ARIA role dialog. Remove attribute role="group" from elements without accessible name. Resolves: #92652 Releases: master Change-Id: I685c7713edc4a4dfc6568c59c3e921ce951d26f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66237 Tested-by:
-
- May 02, 2021
-
-
Nikita Hovratov authored
This fixes the popover position after clicking on a csh link. Side note: The popover loads in two steps: First it shows a "loading ..." text and when the content is fetched the popover must be updated. Before it was achieved by hiding and then immediately showing the popover again. This doesn't quite work with bootstrap v5 anymore. The popover is stuck in the middle of the process before the positioning applies. New method: Use the "setContent" method of the bootstrap popover instance. This method is not documented, but it can be used. Nevertheless we should keep an eye on that, as it's not public API. Resolves: #93984 Resolves: #93152 Releases: master Change-Id: If96028bd70bead243af1937cd2f87afed3b61c5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68962 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
- May 01, 2021
-
-
Benjamin Franzke authored
With the history-synchronization introduced in #93988, window.currentSubScript has been unconditionally overwritten after loading a new module in the content frame. This causes an empty currentSubScript string to be stored for secondary modules (modules not linked in the module menu), and results in subsequent faults, when currentSubScript is used to open a different page with the current module context. Releases: master Resolves: #94036 Related: #93988 Change-Id: Id957e72da5eb39437f35d19469dcdbd8a36c2b7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68959 Tested-by:
-
flicstar authored
This change should allow users to: * Discover the extension via docs.typo3.org * Allow different target groups like administrator, integrator and editor to get an idea about the feature set and how to use the extension. Resolves: #93260 Releases: master, 10.4 Change-Id: I90a8f356231cc49baf3c8fbedd9625300827c094 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68908 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Christian Kuhn authored
The values "_serialNumber", "_scrollPosition", "viewId_addParams" are hidden form fields that are relics from TYPO3 Core v3.x, long unused and obsolete. Same goes for "uc" which just parks an incoming value (where the FormEngineUtility::updateInlineView() can also be moved inside the EditDocumentController), and unused values such as "newC". Resolves: #94009 Releases: master Change-Id: I049a3f2b656affaa7860ad2ca4a9746438739881 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68902 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Benni Mack authored
Some very old code is removed in CSS definitions back from TYPO3 v7 (where we had <img> tags). In addition, some more Bootstrap 5 adaptions are made from the initial update to increase contrast. Resolves: #93179 Releases: master Change-Id: If303c5a891e3b833f448fce65259c2751a4f7124 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68952 Tested-by:
-
Christian Kuhn authored
gerrit voting and slack nightly reporting is now done with a gitlab webhook instead of a CI stage. Change-Id: I6498c41229cb3b6a9178d2a91dbbfbb657034cce Resolves: #94035 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68956 Tested-by:
-
Jochen Roth authored
The extension manager now provides a new module, which allows an integrator to display all available extensions with composer deficits, like missing composer.json or missing extension-key. The new module informs about the deficit and automatically generates a valid composer.json. proposal. In case no composer.json exists, the corresponding ext_emconf is sent to a new TER endpoint (https://extensions.typo3.org/composerize). This endpoint then generates a new composer.json proposal by resolving all dependencies. Furthermore, a new report is added to EXT:reports which also informs about such extensions by directly linking to the new EM module. This helps especially in non-composer-mode installations to ease the upgrade path for future TYPO3 versions which (hopefully) will rely on composer.json only for e.g. PackageStates.php. Resolves: #93931 Releases: master, 10.4 Change-Id: I1230363d5d03e03bff39e7070faf4e331532a292 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68778 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Chris Müller authored
This change adds the decoding attribute to images. For better rendering performance the default value is set to "async" (which decodes images in content elements asynchronously from the main rendering thread). See also: https://html.spec.whatwg.org/multipage/images.html#decoding-images Resolves: #93908 Releases: master Change-Id: I6e8f3985b9ab60de5cf203c36295be29eb6e876c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68764 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Benni Mack authored
If TCAdefaults.pages.categories = 4 is used in userTSconfig, and a new page is created via Drag&Drop or via "Create Multiple New Pages" via ClickMenu, TCAdefaults are now added to the incomingFieldArray and not just the fieldArray. This is also great for translations (using "Just Localized"(tm) technology), where the defaults are respected as well now. Resolves: #92146 Resolves: #77847 Related: #89211 Releases: master, 10.4 Change-Id: I87a2f2d486831f9bda9a979c4ff99d4e8b2ada2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68918 Tested-by:
-
Alexander Schnitzler authored
EnvironmentService is an API class for constant TYPO3_MODE, which has been deprecated with v11. Core API class ApplicationType can be used instead, which obsoletes EnvironmentService. The code adapts usages and deprecates EnvironmentService. Releases: master Resolves: #92494 Related: #92947 Change-Id: Id6f818a8f312e735904d79e7b372fe70db97c9a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66060 Tested-by:
-
Christian Kuhn authored
Jobs are sometimes stuck, for instance when they run into infinite loops. With the default job timeout of one hour and a default retry, it takes two hours until those report negative. Jobs are usually done in less than 15 minutes. We now set the timeout to generous 30 minutes, a pipeline with a stuck job will thus report after one hour, latest. Resolves: #94033 Related: #94001 Releases: master, 10.4, 9.5 Change-Id: I80c26783f5ff0a5900c849d84f57c77e22ca4f63 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68954 Tested-by:
-
- Apr 30, 2021
-
-
Benjamin Franzke authored
A custom Lit-based web componenent router is added which reflects module URLs into the browser adress bar and at the same time prepares for native web components to be used as future iframe module alternatives. Such modules will be implemented as JavaScript modules, that provide an implementation for a custom HTML Web Component. The first of such components (added within this change) is a wrapper component for traditional iframe-based backend modules. Module state changes are advertised via DOM events and propagated to the browser address bar, browser title, and the module menu. Adress bar updates ================== The module URL to address bar synchronisation enables sharable module deeplinks to be copied from the browser address bar. Whenever a component advertises a state change (e.g. iframe change), a sharable deep link is generated and shown in the browser adressbar. Technical preparation for the required deeplinking has been added with #93674. History Management ================== Browser history state is managed via the iframe history context of the content module frame (that is unlike other modern Single Page Applications which use history.pushState and history.replaceState). This approach required some synchronisation work, but there are technical limitations that prevent a combination of iframe history updates in combination for newer API like history.pushState. (The limitation is: state added by history.pushState is skipped by iframe history handling). The advantage of this compromise is: All "traditional" modules will preserve their state handling as before, no breaking/behavioral changes for iframe-based modules. Routing ======= The router uses two parameters to perform routing: * module – Module name as defined in ext_tables.php * endpoint – (json) api to be used by the component (= module URL) The module attribute is used to perform the actual routing to the respective backend module component, while the endpoint attribute serves as API to parse/fetch the state of the module. A named slot is used to switch between the available module components. That means only one of the routers childNodes will be visible at a time, while all modules are actively attached to the DOM. State is therefore preserved when switching between modules and the iframe is always kept active, allowing to act as history state-container (as described in "History Management"). Example of two modules that are attached to the DOM, where only <typo3-configuration-module> is visible as the <slot> in the shadow root puts a reference to this childNode: <typo3-backend-module-router module="system_config" endpoint="…"> #shadow-root <slot name="TYPO3/CMS/Lowlevel/ConfigurationModule"></slot> <typo3-iframe-module endpoint="…" slot="TYPO3/CMS/Backend/Module/Iframe"></…> <typo3-configuration-module endpoint="…" slot="TYPO3/CMS/Lowlevel/ConfigurationModule"></…> </typo3-backend-module-router> Note: The "TYPO3/CMS/Lowlevel/ConfigurationModule" component is not yet part of this commit, and only serves as an example (will be implemented later on). The slot name is resolved from the module key. Out of scope for this patch (will follow later) =============================================== * Link based routing interception via data-module tag for anchor tags. To be added as an additional convenience API on top of the router module and endpoint attribute (current API). * Convenience components for module layout * Integration into shortcut handler * Install-tool URLs do not reflect into addressbar right now Install-tool modules are redirected, therefore url updates can not be mapped as backend URLs right now Solution will probably be to integrate the install tool components as web component into the backend. Resolves: #93988 Related: #93674 Releases: master Change-Id: I682e89649b597c8c74b6a0a8f198f6bcf5bbc347 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67464 Tested-by: -
Christian Kuhn authored
* Store an array in uc instead of serialized objects * PHP 7.4 strictness in some classes * Simplified inheritance chain * Drop a service class of little use by merging calls to controller * Avoid another ObjectManager->get() call * Minor bugfix that a shortcut to 'compare users' is not reflected in module menu drop down * Minor cosmetics Change-Id: I73bd2f884573807a819e4ae0d68c93897641b0f1 Resolves: #94025 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68924 Tested-by:
-
Oliver Bartsch authored
The tablist inside the element information modal in the workspaces module did not longer set the active state on the correct tab item. This is due to a change in bootstrap 5, since an active tab is highlighted by setting the `active` class on the tab item link (`nav-link`) instead of the tab item (`nav-item`) itself. This is fixed by adding the `active` class to the correct element again. Further reference: https://getbootstrap.com/docs/5.0/components/navs-tabs Resolves: #94028 Related: #93119 Releases: master Change-Id: I21ee8ede69876feef047c6303c4fbe890f898a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68928 Tested-by:
-
Benni Mack authored
When having JOINs in SQL selects, which typically happens when a MM property is resolved via Extbase's ORM, versionOL() threw an SQL error because versionOL() also queried "uid_local" which did not exist in e.g. sys_category. This change splits up the massive "overlayLanguageAndWorkspace()" method into smaller chunks and takes a different route when doing workspace overlays for JOINs. By re-fetching the main tables' record, all known fields can be identified via array_key_intersect() and then chunked together again with the JOINed information via array_replace(). The added tests show that the assertion for MM relations now work (if the fix is not applied, the included tests fail due to a SQL error in tests), but deliver a wrong result, which will be fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/68913 Resolves: #81208 Resolves: #93484 Releases: master, 10.4 Change-Id: Iaba70be0cf5b7a36ab13380940286628ac976f9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68915 Tested-by:
Ralf Merz <mail@merzilla.de> Reviewed-by:
-
