- Mar 11, 2024
-
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:form are replaced by the new HashService. Resolves: #103249 Related: #102761 Related: #103245 Releases: main Change-Id: I636d224764890e31ef33038eb7ec2dd0472786c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83266 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:core are replaced by the new HashService. Resolves: #103248 Related: #102761 Related: #103245 Releases: main Change-Id: Iccec4e857790916aa53fb2505c340cde4da8cf9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83295 Reviewed-by:
-
Georg Ringer authored
Allow empty strings as valid input for the page id in the log module. Resolves: #103290 Releases: main, 12.4 Change-Id: I5b4cc0970db927ae1510124d30348059016165a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83221 Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Reviewed-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Andreas Kienast authored
Executed commands: npm install --save-dev \ @typescript-eslint/eslint-plugin@^7.1.1 \ @typescript-eslint/parser@^7.1.1 \ @typescript-eslint/typescript-estree@7.1.1 \ eslint@^8.57.0 \ typescript@^5.4.2 npm run build Resolves: #103354 Releases: main, 12.4 Change-Id: I1c3d53002012153541cd34f9ceae546536b4aacc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83271 Reviewed-by:Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Torben Hansen authored
Currently, the variables `name`, `email`, `language`, `resetLink` and `username` are available in the template of the password recovery email for backend users. It is not possible to add custom user related data from the `be_users` table to the password recovery email. To enable the possibility to add custom user related data, this change adds the new variable `userData` to the FluidEmail object, which contains all userdata of the affected backend user. Additionally, a superfluous `is_array` check has been removed, since it is ensured, that the `$users` variable at this point already is an array. Resolves: #103147 Releases: main Change-Id: I72eb8796a15f5dd9dbb8682555777915f880bc96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83031 Reviewed-by:
Garvin Hicking <gh@faktor-e.de> Reviewed-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Mar 09, 2024
-
-
linawolf authored
This prevents warnings during rendering and also looks better. Resolves: #103355 Releases: main, 12.4, 11.5 Change-Id: I0a677f4f1c5ee8253538dd414fe23384ad49b6e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83394 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
linawolf authored
All files ending on .rst are interpreted as documents in both the new and old rendering. This leads to warnings and errors. So all files to be included are renamend to .rst.txt as is standard. Additionally include files should not include the Includes.rst.txt as it is already included in the main file. Those includes are removed. Resolves: #103353 Releases: main, 12.4 Change-Id: I42850eddf788fabf04e8f51b88e4f053d947a63a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83393 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove superfluous genindex, it is not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backports need manual changes to the guides.xml. Resolves: #103329 Releases: main, 12.4, 11.5 Change-Id: I7ed40a0f5ce1d96003e78ac8860e6dda4c12b225 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83316 Reviewed-by:
-
linawolf authored
* .gitignore files contain files that are not created during rendering * .editorconfig conatains old styling, there is a main .editorconfig with the containing the correct styling Resolves: #103352 Releases: main, 12.4, 11.5 Change-Id: Ic3189d5f10b8e6f8aa8903cd0924a4a4b4fab191 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83392 Tested-by:
-
Chris Müller authored
Resolves: #103350 Related: #103304 Releases: main, 12.4, 11.5 Change-Id: I228f946b8bca26b5c334b352ecd48edfd72c620b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83360 Tested-by:
-
- Mar 08, 2024
-
-
Benni Mack authored
All PageTsConfig options are now in DrawingConfiguration and named properly. All plain labels are now moved to Fluid directly via <f:translate> Random id="{uniqueId}" are removed from markup, reducing the usages to the AbstractGridObject, which hopefully will vanish in the near future. RecordRememberer is a singleton and injected as much as possible. The "languageMode" is now resolved into a PageViewMode enum. Resolves: #103345 Releases: main Change-Id: I78f33fed409db2a1c5528e734ed19ad67aeb4e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83322 Reviewed-by:Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Benjamin Franzke authored
With #90418 the container cache has been excluded from the regular cache-flush-pipeline. Therefore flushing has been explicitly performed when writing a new cache entry (with the intent to clean up old cache entries). Issue is: Cleaning up the entire folder by deleting the folder means a concurrent request – that is creating the same DI cache as well – will fail to write the cache when the folder is (re)moved in that moment. It turns out this cache-flush is not needed at all, since the cache identifier is stable for an TYPO3 instance, therefore a pre-flight flush can be dropped. Releases: main, 12.4, 11.5 Resolves: #103294 Change-Id: I1267d794291899e2b0d551b1725bd4a3354823bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83228 Tested-by:
-
Benjamin Franzke authored
While refactoring the cropping information calculation in September 2023 by Benni Mack, the cropWidth / cropHeight and the offsets were set to the wrong constructor arguments. The patch reverses the order of the constructor of the CropArea object. Resolves: #103330 Related: #101957 Releases: main Change-Id: I74b3b5fed604962b323e1017cf66695eb11d0a92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83298 Reviewed-by:
Simon Praetorius <simon@praetorius.me> Reviewed-by:
-
Andreas Kienast authored
The "Move page" wizard is still based on the dusted `PagePositionMap`. In order to modernize the clunky UI, the wizard is migrated to a modal window that offers a drastically slimmed down interface, offering a page tree to make the selection of the target page easier. It is always possible to paste the to-be-moved page above and below a target page, or inside a page if there are no children, yet. Resolves: #103344 Releases: main Change-Id: I745abb7b34e318275ae95abb689a6024e47b166e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83269 Reviewed-by:
-
Garvin Hicking authored
The Symfony CLI Command `backend:user:create` already offers shortcut options like "-u XXX" instead of "--username=XXX" as an alternative. This was broken, because the ENV/interactive fallback check only performed a check on the full option name. This check is now enhanced to also consider the shortcut. Resolves: #103134 Releases: main, 12.4 Change-Id: I33713dda5f03b96b78c6fc4fb78aa289be064330 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83018 Tested-by:
-
Benjamin Franzke authored
Load TypoScript dependencies via include_static_file.txt which is the defined pattern for loading dependencies of a static template, ensuring that both constants and typoscript setup of dependencies are loaded, without having to load all required dependencies both in constants.typoscript and setup.typoscript. Releases: main Resolves: #103278 Change-Id: I5bd007b15ca410d704ae1347c3ec90c7fdf7a4d4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83124 Reviewed-by:
-
Chris Müller authored
Moving the code snippets into separate files has the advantage that code highlighting of the IDE is used, and errors may be spotted easier. Additionally, captions are added to the code blocks. Resolves: #103318 Releases: main, 12.4 Change-Id: Ia11a6de48176f5e8f890fddc68692cde5c7e74b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83300 Tested-by:
-
Torben Hansen authored
With #102761, the new `HashService` has been introduced to ensure that HMAC generation will always use an additional secret. As a follow-up patch, `GeneralUtility::hmac` will be deprecated when all usages in the core have been replaced with the new `HashService`. With this change, usages of `GeneralUtility::hmac` in ext:frontend are replaced by the new HashService. Resolves: #103250 Related: #102761 Related: #103245 Releases: main Change-Id: I077cf02a170178c750662c8491bf725ce234c036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83260 Reviewed-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103341 Releases: main Change-Id: Ie7eea104f996882b07017e6965a95cd8aa966a5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83353 Tested-by:
-
linawolf authored
Additionally, resolve rendering warnings No Backports needed, v12 is already fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/833513 Resolves: #103349 Releases: main Change-Id: I20a0a556dd1e00a3d4db754d7fcf5e55c90f68c5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83359 Reviewed-by:
-
linawolf authored
No Backports needed, v11 and v12 are already fixed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/83374 and https://review.typo3.org/c/Packages/TYPO3.CMS/+/83373 Resolves: #103347 Releases: main Change-Id: I0d3a88a83d8c8f6a9c6ec9181c1cffb961f51ab7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83358 Tested-by:
-
Andreas Nedbal authored
Resolves: #102431 Releases: main Change-Id: Id28a4f0fc68cb6cb740443f7688694a3a5b04a26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83308 Tested-by:
-
Stefan Bürk authored
Since #98503 the new TypoScript parser is used in the frontend, which used a value list trick to minimize database queries. That required to do proper value casting for each list element, which has been implementend manually with dbms vendor aware handling. Recently #103309 enriched the `ExpressionBuilder` with a couple of additional expression methods, including `castInt()` expression. This change replaces the manual db aware integer casting with the new `ExpressionBuilder::castInt()` method within the TypoScript parser classes along with the corresponding `@todo` marker. Resolves: #103343 Related: #103309 Related: #98503 Releases: main Change-Id: I462a6b0bb8195c6c0db7b70fb72ac1890ee4aadb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83355 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Andreas Nedbal authored
interactjs was introduced in page module drag&drop handling with #98471. It turned out that the library is not necessarily required and is therefore replaced with native drag&drop API. Co-authored-by:
-
Georg Ringer authored
Not only the fieldname but also the tablename must be set for references. This is especially needed if dealing with extbase file uploads. Resolves: #103319 Releases: main, 12.4 Change-Id: Ia7b7941cc6ff165e1f39b83a149a579c9bc7d3f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83302 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103338 Releases: main, 12.4, 11.5 Change-Id: Ia5eae156685428c525fd6e3f27b1c8583b64dd84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83329 Reviewed-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103337 Releases: main, 12.4, 11.5 Change-Id: Ieb11f8a14c159953d0b6412b7cf2745f221ab788 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83328 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. This manual exists since TYPO3 v12 Resolves: #103333 Releases: main, 12.4 Change-Id: I6815646569ac3dd792156518633c6e5881342d90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83324 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103334 Releases: main, 12.4, 11.5 Change-Id: If2086510e19ca5dc682d9ff0e45c545a458bdfc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83325 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. This manual exists since TYPO3 v12 Resolves: #103332 Releases: main, 12.4 Change-Id: Ief1b99941b36f76189281423caa9f5badd292711 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83323 Tested-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103336 Releases: main, 12.4, 11.5 Change-Id: I31f40444705530a3a9219fde6530cc46f3888df7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83327 Reviewed-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103340 Releases: main, 12.4, 11.5 Change-Id: Id690e98fb30595e36eb6d573c7a03098668222dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83352 Reviewed-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103342 Releases: main, 12.4, 11.5 Change-Id: I8d29012e8be9e999129d04c5e84d6a531a9a6b28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83354 Reviewed-by:
-
linawolf authored
* Introduce a guides.xml, the presence of this file triggers the new rendering. * Remove outdated genindex: not supported anymore * Remove old Settings.cfg, was only used for Sphinx Attention: Backport needs manual changes to the guides.xml. Resolves: #103339 Releases: main, 12.4, 11.5 Change-Id: Ifde54f6d21ae29ba8c3e8543601048cab2469744 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83330 Tested-by:
-
Andreas Kienast authored
The CSS classes `.diff-[r|g]` were used in the old `DiffUtility` that was removed in the v7 development cycle, but it was missed to remove the CSS as well. This patch removes the CSS classes and it's remaining reference in a language label. Resolves: #103335 Releases: main Change-Id: Ie1fb7122fc906b160cbda7bd96979bc4c97549a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83326 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Stefan Bürk authored
This change adds additional helpful expression methods to the TYPO3 ExpressionBuilder to allow building more advanced database queries with cross database vendor support for supported vendors. These expression are required for advanced query building and prepare the future implementation of an `Common Table Expression` builder API, but can be helpful in other scopes as well. This change adds `ExpressionBuilder` * `->as()` alias a value, field value or sub-expression `foo AS identifier`. * `->concat()` concatenate multiple static values or field data into one string. * `->castVarchar()` allows casting a field or value to varchar type with dynamic length. * `->castInt()` allows casting a field or value to integer type. * `->repeat()` create a string value with x-times repeated value. * `->space()` create a string value with x-times of spaces. * `->left()` create an expression returning a sub string of specified length from the left side. * `->right()` create an expression returning a sub string of specified length from the right side, where sub-expressions can be used for length and value. * `->leftPad()` pad a value or expression to a specific length and fill up with specified padding value on the left side. * `->rightPad()` pad a value or expression to a specific length and fill up with specified padding value on the right side. The patch covers the implementations with functional tests. Resolves: #103309 Releases: main Change-Id: I65349b286d65d7026611d828f8365247b51d90b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83209 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
- Mar 07, 2024
-
-
Benni Mack authored
This change adapts various places where there are cross-dependencies between objects that contain state when rendering the page module. Resolves: #103326 Releases: main Change-Id: I09db90bc4c47f0a15d9890ed40d6cb65b2dff30d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83313 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
-
Markus Klein authored
Ensure recuid is always int+ as the underlying DB field is `unsigned`. Resolves: #103101 Releases: main, 12.4, 11.5 Change-Id: I8fa06fa40260bffc5b01eedc4207aec150e7c849 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82897 Reviewed-by:
-
Daniel H authoredThis patch adds the `gbraid` and `wbraid` parameters to the cHash parameter exclusion list. Resolves: #103327 Releases: main, 12.4, 11.5 Change-Id: Ife0f7886980812a6082224a6385a4393782f938b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83314 Tested-by:
Marvin Buchmann <marvin_buchmann@web.de> Reviewed-by:
-
Chris Müller authored
Rendering the changelog with the PHP-based rendering the following warning is thrown: The code-block has no content. Did you properly indent the code? {"rst-file":"Changelog/7.5/Feature-68166-RenderTypeForRsaEncryptedInputFields.rst","currentLineNumber":29} Additionally, typos in another changelog have been fixed. Resolves: #103324 Releases: main, 12.4 Change-Id: I9efd66834a18f4a0b94feb7f1f2c776ff0fb260f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83309 Reviewed-by:
-
