- Jun 30, 2017
-
-
Mathias Brodala authored
Resolves: #81760 Releases: master, 8.7 Change-Id: Ib04e7bd994ae32f02649112e838115003a4a42c0 Reviewed-on: https://review.typo3.org/53370 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
Copying workspace version records fails in Doctrine DBAL exception due to using computed properties directly in the database - which do not exist. This misbehavior has been introduced in issue #79515 which switched to use BackendUtility:workspaceOL() without further sanitization. Resolves: #81747 Releases: master, 8.7 Change-Id: Iabc67f9a7375d4246289e50205aac6dc8c750259 Reviewed-on: https://review.typo3.org/53357 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Jun 29, 2017
-
-
Daniel Goerz authored
This ensures that spaces can be used to format the list of file extensions for <INCLUDE_TYPOSCRIPT>. Resolves: #81709 Releases: master, 8.7 Change-Id: Ia0c830df52b18a3dae7bd724c4bd5ee3b845e00f Reviewed-on: https://review.typo3.org/53337 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Frank Naegler authored
Add the QueryBuilder object to list module buildQueryParameters hook allowing direct operation on this object including proper named parameter usage and quoting. The old array/string based parameter handling still works but is deprecated. Resolves: #81651 Releases: master Change-Id: Ib17ba9383c29b5b48540203e6952b9670c6244f3 Reviewed-on: https://review.typo3.org/53263 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Henrik Elsner <helsner@dfau.de> Tested-by:
-
Anja Leichsenring authored
Only the AuthenticationService and its abstract class are left in sysext:sv. Move those, the tests and the service registration over to sysext:core. All mentions of sysext:sv are hereby removed from the core. Change-Id: I699ace33a7d5a0e7ddff4d3c9ed4e595e40677af Resolves: #81735 Releases: master Reviewed-on: https://review.typo3.org/53351 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jun 28, 2017
-
-
Anja Leichsenring authored
The extension name and folder is lang, not language. Change-Id: Ieb11fa16af67a9e203c3c4e5dc96acca5501567f Resolves: #81733 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53348 Tested-by:
-
Benni Mack authored
There are a lot PHP exception classes which are not in use inside Extbase. Some come from the fact that Fluid got more mature and standalone, some from refactorings within ObjectManager, PropertyManager, RequestHash and Persistence. One highlight is the InvalidMarkerException which dates back to the backport of Flow before Fluid was invented and Flow was using the same marker-based approach as TYPO3 v4 had - and was never used in TYPO3 v4 at all. Class aliases are in place for all of them, so no breaking change. Resolves: #81600 Releases: master Change-Id: Ic1c3fc309954750f8c2e664ab94fa0e6f9336bea Reviewed-on: https://review.typo3.org/53224 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Preparing the git split for better composer integration we end up with single repos for all extensions and single packagist packages. All extensions thus need a specific LICENSE.txt now. Change-Id: Ia77ae3e413e479ec7fa9438cbfc2abf808738111 Resolves: #81730 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53345 Tested-by:
-
Sascha Egerer authored
The array key 'uploadfolder' is initialized on a non existing array. It must be initialized on the processed tca array Resolves: #81681 Releases: master, 8.7 Change-Id: Ied776e4b0d0d4c33cf0894a2c4c95ceb6c03bb18 Reviewed-on: https://review.typo3.org/53311 Reviewed-by:
-
- Jun 27, 2017
-
-
Torsten Schrade authored
Add a call to the start function of ContentObjectRenderer after instantiation. This is necessary to get all hooks fully initialized. Resolves: #81624 Resolves: #75314 Releases: master, 8.7, 7.6 Change-Id: I75d30e860cd77a1b233d4383a3e57afe9a34ec54 Reviewed-on: https://review.typo3.org/53264 Reviewed-by:
-
- Jun 26, 2017
-
-
Andreas Fernandez authored
The original patch removed variables that were assumed to be unused. The assumption was wrong, as the variables are used in JavaScript context and are thus now undefined. This patch revert the changes done back then, but uses the f:format.json view helper. Resolves: #81692 Related: #81301 Releases: master Change-Id: I21e4d737f6205c6c7d7f29dd08358c39806002e3 Reviewed-on: https://review.typo3.org/53318 Tested-by:
-
Andreas Fernandez authored
Since PHPUnit 6.2, exceptions are namespaced. The tests are adjusted to catch these exceptions properly again. Resolves: #81705 Related: #81696 Releases: master, 8.7 Change-Id: I786248b9ca3f4fcef37ab9dd4fd29d696eef438b Reviewed-on: https://review.typo3.org/53333 Reviewed-by:
-
Josef Glatz authored
An iconIdentifier is needed since the icon generation is moved to the Fluid template. The third parameter of addSystemInformation() needs to be an iconIdentifier instead of an rendered icon html markup. Resolves: #81694 Related: #80554 Releases: master, 8.7 Change-Id: Ib6b07281196b5ecda2de07b8d6328b524e08f038 Reviewed-on: https://review.typo3.org/53321 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Christian Kuhn authored
New phpunit throws happy little exception if locales tested for are not available on given platform. travis-ci is affected, install it. Change-Id: Iaf11dc884b32b8c81042aaacad2f301a3f39fad2 Resolves: #81697 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53326 Tested-by:
-
- Jun 25, 2017
-
-
Christian Kuhn authored
Switching from 1.0 to 1.1 dependency for typo3/testing-framework brings phpunit v6.2 which comes with namespaced classes. This change is considered non-braeking since it is only a core require-dev dependency. Minor changes throught the tests: * Fixing incomplete tests for exceptions * A couple of namespaced phpunit class usages Change-Id: Ia35dbfea37e3cba9fba1aad7dc84afad00ceda88 Resolves: #81696 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53324 Tested-by:
-
Christian Kuhn authored
codeception/codeception 2.3.3 se/selenium-server-standalone 2.4.0 enm1989/chromedriver 2.30 Resolves: #81695 Releases: master, 8.7 Change-Id: Ic145217a60beb4d8188d9f1bedc209313c3b39dc Reviewed-on: https://review.typo3.org/53322 Tested-by:
-
- Jun 23, 2017
-
-
Anja Leichsenring authored
A basic acceptance tests clicking through installer using a postgres sql db connection, checking backend login and installing the introduction package. Change-Id: I7408e8580d84e235a1f91399684a80025a62e0e8 Resolves: #81602 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53250 Tested-by:
-
Christian Kuhn authored
Brings base setup for an acceptance test that installs TYPO3 on postgres and loads the introduction distribution. Change-Id: I6e9e3c3175a6b4bfba51097622058f7d25dedbc3 Resolves: #81688 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53315 Tested-by:
-
Christian Kuhn authored
The cgl check is quick and fails rather often for pre-merge test runs in the beginning. Move the job to preparation stage for quicker test runs in those cases. Change-Id: Id73f93212d12e47fb2897893c2ea518aa6900888 Resolves: #81683 Releases: master Reviewed-on: https://review.typo3.org/53313 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Xavier Perseguers authored
Check for Frontend context has been omitted during refactoring and will have side effects in Backend in view configuration is overridden in Frontend context. Change-Id: I752baed15f0be6be59fcc37f12103f0a70caa427 Resolves: #81677 Related: #81340 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53309 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
- Jun 22, 2017
-
-
Tymoteusz Motylewski authored
Add functional tests for tt_content rendering with different combinations of TypoScript language settings sys_language_overlay and sys_language_mode. Resolves: #81185 Releases: master, 8.7 Change-Id: I7df5b48a2baa3a52f8c6103b0657b21226c6ea5c Reviewed-on: https://review.typo3.org/52750 Tested-by:
-
- Jun 21, 2017
-
-
Christian Kuhn authored
Change-Id: I15c7a21e1782d6d9fa433cf2f23669a851ffd85a Resolves: #81661 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53305 Tested-by:
-
Christian Kuhn authored
Configures a second build for core master that runs as nightly plan and has more combinations: The acceptance and functionals are explicitly executed on both php 7.0 and 7.1 with all DBMS, the cgl checker runs through whole core. This "full run" is too much for pre-merge tests, so the nightly now takes care of these time consuming things. Reporting will be added if that plan is stable. https://bamboo.typo3.com/browse/CORE-GTN Change-Id: Id77fc0acceca7af67960b67fd8b8700c98df888e Resolves: #81660 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53304 Tested-by:
-
Andreas Fernandez authored
Resolves: #81655 Releases: master, 8.7, 7.6 Change-Id: I4fe1b16b6e4c2bdd26fd05143e7b0ead91445223 Reviewed-on: https://review.typo3.org/53300 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Christian Kuhn authored
getParseTimeReturnsZeroIfNoValuesAreSet() tends to fail sometimes if $beUserInitialization is > 0 but $totalParseTime is 0. This edge case of method getParseTime() is avoided by rearranging the call order of $this->getMilliseconds() slightly. Change-Id: If5cf00196f6739224c34011b0f8c1ef1f5bbb39a Resolves: #81653 Related: #80742 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53297 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Anja Leichsenring <anja.leichsenring@typo3.com> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Stephan Großberndt authored
Releases: master, 8.7 Resolves: #81634 Change-Id: I48bc1885aec47a4dcc66bf556cd69d50a7781fd5 Reviewed-on: https://review.typo3.org/53291 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
-
- Jun 20, 2017
-
-
Christian Kuhn authored
Change-Id: I240ed28992cea31e04aa7451ef609c68eade7782 Resolves: #81635 Releases: master Reviewed-on: https://review.typo3.org/53292 Tested-by:
-
Benni Mack authored
Since the new link structure is in place with TYPO3 v8 all links are properly htmlspecialchar'ed in the database. This means, that links with an ampersand are now encoded and need to be decoded on output so ampersands are rendered as "&" and not as "&" in the frontend. Resolves: #80985 Resolves: #81625 Releases: master, 8.7 Change-Id: I213f84453a721b97c3238662febe10d0fb5a9bf7 Reviewed-on: https://review.typo3.org/53268 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
-
Benni Mack authored
Especially in TYPO3 v8, where TCA is not loaded at all times, running a CLI command with an empty cache will result in errors, but for the sake of clean structure, the commands will be populated when executing the actual command. Resolves: #80897 Releases: master, 8.7 Change-Id: I7ad33ca86724d94f451c44f68538d5d38e343636 Reviewed-on: https://review.typo3.org/53270 Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
Nicole Cordes authored
Currently an error is thrown if no post data was sent to the ImportExportController. This can easily happen if a t3d file should be uploaded but is larger than the configured post_max_size of the server. This patch checks the incoming information, sets the import action as default and displays an information to the user that he/she may have tried to upload a file that was too large. Resolves: #80681 Releases: master, 8.7, 7.6 Change-Id: I561dbf6abd74acace3eff179a513b4f9128d792d Reviewed-on: https://review.typo3.org/52363 Reviewed-by:
-
Christian Kuhn authored
The distribution installer selects current_version=1 extensions only and fails in core v7 since the current introduction version is not compatible with v7 anymore. The patch changes version selection a bit to first find all distribution extensions, then filters those suitable for given core version, then filters latest version of the distribution extension. Installing introduction package in 7.6 works again. Change-Id: I11f2def2ea606ada5f7c3efd3043f59bd4be0452 Resolves: #81068 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53262 Tested-by:
-
Jigal van Hemert authored
While parsing the input value for expressions inside curly brackets it must skip quoted field names which are also in curly brackets but start with a '#'. Resolves: #81492 Related: #80506 Releases: master, 8.7 Change-Id: Ic58fcdcbb68108ac77da746db3e6a442515ce7ea Reviewed-on: https://review.typo3.org/53172 Tested-by:
-
Benni Mack authored
This change introduced a flaw in the RteLinkBrowser JS file which needs to override LinkBrowser class instead of just writing RteLinkBrowser. See https://review.typo3.org/#/c/53062/ This reverts commit c5d75c15. Resolves: #81630 Reverts: #81444 Releases: master Change-Id: I4a3a9dc52bd6b9cee183ba6411389e8da2eebd21 Reviewed-on: https://review.typo3.org/53274 Reviewed-by:
-
Claus Due authored
Change methods inside ReferenceIndex to allow them to receive an existing record as array rather than a UID to avoid each method loading it from the database again to read record or record fields. For a copy operation on 25 pages with ~100 content elements total there are 1,500 SQL queries less leading to a ~40% time reduction and ~10% memory reduction. Change-Id: I0ed05478dfbc0535efc8d1d29b6a8298d475fb6b Releases: master, 8.7 Resolves: #78634 Reviewed-on: https://review.typo3.org/50566 Reviewed-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
-
Thomas Hohn authored
Wraps the functionality from doesRecordExist in a new method recordInfoWithPermissionCheck. The goal is a general cleanup and avoid unnecessary calls to the database in the case where the actual record is re-fetched from the database for processing just after a doesRecordExist call. Resolves: #79515 Releases: master, 8.7 Change-Id: I76d217a1690ee4b97e28b83f7591ebf8cba18e6e Reviewed-on: https://review.typo3.org/51447 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- Jun 19, 2017
-
-
Henrik Elsner authored
The quoting parameter constants \PDO::PARAM_* are in fact integers. The annotation shipped with doctrine says string, and the strict type processing in core leads to a wrong parameter error. Changing the strict type to int, as would be correct, solves the problem. Releases: master, 8.7 Resolves: #81613 Change-Id: Ic327b2d761b74868cc46d781acab1f4fd9e6cfdb Reviewed-on: https://review.typo3.org/53260 Reviewed-by:
-
- Jun 18, 2017
-
-
Christian Kuhn authored
If a records has not been persisted and a flex section container is added, the form compiler needs the "NEW123" uid of parent to prefix form fields correctly. Change-Id: Iab3945efa93d2becf636c5cf4f8596bc696cd2e0 Resolves: #80825 Related: #80100 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53215 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
Susanne Moog authored
Adjust grunt and tsconfig to allow writing unit tests in TypeScript. Test example is included. Additionally configuration was adjusted to allow running grunt tasks on windows and linux. Change-Id: Ibeb0c501242afbbe796726a85329d14257acfd1c Resolves: #81601 Releases: master Reviewed-on: https://review.typo3.org/53248 Tested-by:
-
Andreas Fernandez authored
The parameter `$errorMode` is removed from the method `GeneralUtility::callUserFunction()`. Thus, the checks agains this variable are removed as well, causing exceptions being always thrown now. Resolves: #74533 Releases: master Change-Id: Ibf8b0c9de55b4d8d210dac8fc6c82b14ca7c849d Reviewed-on: https://review.typo3.org/50996 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jun 17, 2017
-
-
Georg Ringer authored
Move the report as a first step to get rid of EXT:sv. Resolves: #81536 Releases: master Change-Id: I46e38b5c4bf8d5466e1bcc1db510b1cd660a7b38 Reviewed-on: https://review.typo3.org/53163 Reviewed-by:
-
