- Jun 23, 2017
-
-
Christian Kuhn authored
The cgl check is quick and fails rather often for pre-merge test runs in the beginning. Move the job to preparation stage for quicker test runs in those cases. Change-Id: Id73f93212d12e47fb2897893c2ea518aa6900888 Resolves: #81683 Releases: master Reviewed-on: https://review.typo3.org/53313 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Xavier Perseguers authored
Check for Frontend context has been omitted during refactoring and will have side effects in Backend in view configuration is overridden in Frontend context. Change-Id: I752baed15f0be6be59fcc37f12103f0a70caa427 Resolves: #81677 Related: #81340 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53309 Tested-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Jun 22, 2017
-
-
Tymoteusz Motylewski authored
Add functional tests for tt_content rendering with different combinations of TypoScript language settings sys_language_overlay and sys_language_mode. Resolves: #81185 Releases: master, 8.7 Change-Id: I7df5b48a2baa3a52f8c6103b0657b21226c6ea5c Reviewed-on: https://review.typo3.org/52750 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Jun 21, 2017
-
-
Christian Kuhn authored
Change-Id: I15c7a21e1782d6d9fa433cf2f23669a851ffd85a Resolves: #81661 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53305 Tested-by:
-
Christian Kuhn authored
Configures a second build for core master that runs as nightly plan and has more combinations: The acceptance and functionals are explicitly executed on both php 7.0 and 7.1 with all DBMS, the cgl checker runs through whole core. This "full run" is too much for pre-merge tests, so the nightly now takes care of these time consuming things. Reporting will be added if that plan is stable. https://bamboo.typo3.com/browse/CORE-GTN Change-Id: Id77fc0acceca7af67960b67fd8b8700c98df888e Resolves: #81660 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53304 Tested-by:
-
Andreas Fernandez authored
Resolves: #81655 Releases: master, 8.7, 7.6 Change-Id: I4fe1b16b6e4c2bdd26fd05143e7b0ead91445223 Reviewed-on: https://review.typo3.org/53300 Reviewed-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
Christian Kuhn authored
getParseTimeReturnsZeroIfNoValuesAreSet() tends to fail sometimes if $beUserInitialization is > 0 but $totalParseTime is 0. This edge case of method getParseTime() is avoided by rearranging the call order of $this->getMilliseconds() slightly. Change-Id: If5cf00196f6739224c34011b0f8c1ef1f5bbb39a Resolves: #81653 Related: #80742 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53297 Reviewed-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Anja Leichsenring <anja.leichsenring@typo3.com> Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Stephan Großberndt authored
Releases: master, 8.7 Resolves: #81634 Change-Id: I48bc1885aec47a4dcc66bf556cd69d50a7781fd5 Reviewed-on: https://review.typo3.org/53291 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Reviewed-by:
-
- Jun 20, 2017
-
-
Christian Kuhn authored
Change-Id: I240ed28992cea31e04aa7451ef609c68eade7782 Resolves: #81635 Releases: master Reviewed-on: https://review.typo3.org/53292 Tested-by:
-
Benni Mack authored
Since the new link structure is in place with TYPO3 v8 all links are properly htmlspecialchar'ed in the database. This means, that links with an ampersand are now encoded and need to be decoded on output so ampersands are rendered as "&" and not as "&" in the frontend. Resolves: #80985 Resolves: #81625 Releases: master, 8.7 Change-Id: I213f84453a721b97c3238662febe10d0fb5a9bf7 Reviewed-on: https://review.typo3.org/53268 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
-
Benni Mack authored
Especially in TYPO3 v8, where TCA is not loaded at all times, running a CLI command with an empty cache will result in errors, but for the sake of clean structure, the commands will be populated when executing the actual command. Resolves: #80897 Releases: master, 8.7 Change-Id: I7ad33ca86724d94f451c44f68538d5d38e343636 Reviewed-on: https://review.typo3.org/53270 Tested-by:
Thomas Maroschik <tmaroschik@dfau.de> Tested-by:
-
Nicole Cordes authored
Currently an error is thrown if no post data was sent to the ImportExportController. This can easily happen if a t3d file should be uploaded but is larger than the configured post_max_size of the server. This patch checks the incoming information, sets the import action as default and displays an information to the user that he/she may have tried to upload a file that was too large. Resolves: #80681 Releases: master, 8.7, 7.6 Change-Id: I561dbf6abd74acace3eff179a513b4f9128d792d Reviewed-on: https://review.typo3.org/52363 Reviewed-by:
-
Christian Kuhn authored
The distribution installer selects current_version=1 extensions only and fails in core v7 since the current introduction version is not compatible with v7 anymore. The patch changes version selection a bit to first find all distribution extensions, then filters those suitable for given core version, then filters latest version of the distribution extension. Installing introduction package in 7.6 works again. Change-Id: I11f2def2ea606ada5f7c3efd3043f59bd4be0452 Resolves: #81068 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53262 Tested-by:
-
Jigal van Hemert authored
While parsing the input value for expressions inside curly brackets it must skip quoted field names which are also in curly brackets but start with a '#'. Resolves: #81492 Related: #80506 Releases: master, 8.7 Change-Id: Ic58fcdcbb68108ac77da746db3e6a442515ce7ea Reviewed-on: https://review.typo3.org/53172 Tested-by:
-
Benni Mack authored
This change introduced a flaw in the RteLinkBrowser JS file which needs to override LinkBrowser class instead of just writing RteLinkBrowser. See https://review.typo3.org/#/c/53062/ This reverts commit c5d75c15. Resolves: #81630 Reverts: #81444 Releases: master Change-Id: I4a3a9dc52bd6b9cee183ba6411389e8da2eebd21 Reviewed-on: https://review.typo3.org/53274 Reviewed-by:
-
Claus Due authored
Change methods inside ReferenceIndex to allow them to receive an existing record as array rather than a UID to avoid each method loading it from the database again to read record or record fields. For a copy operation on 25 pages with ~100 content elements total there are 1,500 SQL queries less leading to a ~40% time reduction and ~10% memory reduction. Change-Id: I0ed05478dfbc0535efc8d1d29b6a8298d475fb6b Releases: master, 8.7 Resolves: #78634 Reviewed-on: https://review.typo3.org/50566 Reviewed-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Reviewed-by:
-
Thomas Hohn authored
Wraps the functionality from doesRecordExist in a new method recordInfoWithPermissionCheck. The goal is a general cleanup and avoid unnecessary calls to the database in the case where the actual record is re-fetched from the database for processing just after a doesRecordExist call. Resolves: #79515 Releases: master, 8.7 Change-Id: I76d217a1690ee4b97e28b83f7591ebf8cba18e6e Reviewed-on: https://review.typo3.org/51447 Tested-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Reviewed-by:
-
- Jun 19, 2017
-
-
Henrik Elsner authored
The quoting parameter constants \PDO::PARAM_* are in fact integers. The annotation shipped with doctrine says string, and the strict type processing in core leads to a wrong parameter error. Changing the strict type to int, as would be correct, solves the problem. Releases: master, 8.7 Resolves: #81613 Change-Id: Ic327b2d761b74868cc46d781acab1f4fd9e6cfdb Reviewed-on: https://review.typo3.org/53260 Reviewed-by:
-
- Jun 18, 2017
-
-
Christian Kuhn authored
If a records has not been persisted and a flex section container is added, the form compiler needs the "NEW123" uid of parent to prefix form fields correctly. Change-Id: Iab3945efa93d2becf636c5cf4f8596bc696cd2e0 Resolves: #80825 Related: #80100 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53215 Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Susanne Moog authored
Adjust grunt and tsconfig to allow writing unit tests in TypeScript. Test example is included. Additionally configuration was adjusted to allow running grunt tasks on windows and linux. Change-Id: Ibeb0c501242afbbe796726a85329d14257acfd1c Resolves: #81601 Releases: master Reviewed-on: https://review.typo3.org/53248 Tested-by:
-
Andreas Fernandez authored
The parameter `$errorMode` is removed from the method `GeneralUtility::callUserFunction()`. Thus, the checks agains this variable are removed as well, causing exceptions being always thrown now. Resolves: #74533 Releases: master Change-Id: Ibf8b0c9de55b4d8d210dac8fc6c82b14ca7c849d Reviewed-on: https://review.typo3.org/50996 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
- Jun 17, 2017
-
-
Georg Ringer authored
Move the report as a first step to get rid of EXT:sv. Resolves: #81536 Releases: master Change-Id: I46e38b5c4bf8d5466e1bcc1db510b1cd660a7b38 Reviewed-on: https://review.typo3.org/53163 Reviewed-by:
-
Ralf Hettinger authored
CKEditor fields now triggers FormEngine.Validation.markFieldAsChanged therefore a warning of unsaved changes on closing the form is raised based on changes within these CKEditor fields. Resolves: #68955 Releases: master, 8.7 Change-Id: I0da98c2204b20b0f6cd27a53b66f2df3d369a145 Reviewed-on: https://review.typo3.org/52968 Tested-by:
-
Benni Mack authored
Fixing one issue with the wrong variable name. Resolves: #81575 Releases: master, 8.7 Change-Id: I820a3bcfc9a250a35ca2bec69b71a40fc7c8d01a Reviewed-on: https://review.typo3.org/53245 Reviewed-by:
-
Georg Ringer authored
The method DocumentTemplate::formWidth() is not needed anymore as the styling can be done by using bootstrap and regular CSS classes. Resolves: #81540 Releases: master Change-Id: Id767665e71afc454f04002b6989876ca28354fe3 Reviewed-on: https://review.typo3.org/53185 Tested-by:
-
Christian Toffolo authored
In Extbase query expressions the second operand is converted to a plain value which is either an integer or a string. This type must also be specified when creating a named parameter in the query. Resolves: #79473 Resolves: #80978 Resolves: #81487 Resolves: #81019 Resolves: #81056 Releases: master, 8.7 Change-Id: I835643653e03b98bfcd5a8b35b5de750641ecb79 Reviewed-on: https://review.typo3.org/52802 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Johannes Goslar authored
Resolves: #81444 Releases: master Change-Id: I7247ef2c88ff60c484c3ca7ff0af48d3b8e72aac Reviewed-on: https://review.typo3.org/53062 Tested-by:
-
Morton Jonuschat authored
The errorCode() method returns a string representation of the error that happened. Comparing this to an integer value to determine is not reliable. In addition Doctrine throws Exceptions when database statements fail so this part of the code could not be reached. Catch the DBALException, extract the error message and let the re-raised extension bubble up to show the actual error message to the user. Change-Id: I042b94329e3d52f9520ded812247ee78a73ea402 Resolves: #79870 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53130 Tested-by:
-
Sascha Egerer authored
The backend list view must respect the selected pages even if the search level is set to infinite. This bug was introduced by the Doctrine migration. Resolves: #81278 Releases: master,8.7 Change-Id: I6ab0e93a019a001f9df08e00c01f7525a6621284 Reviewed-on: https://review.typo3.org/52873 Reviewed-by:
Manuel Selbach <manuel_selbach@yahoo.de> Tested-by:
-
Benni Mack authored
When removing the extbase query cache in 8.3, the TypoScript option was not removed which has no effect anymore since then. Resolves: #77460 Releases: master, 8.7 Change-Id: I72d3907fd1c3aa302a03cc1f41bfe28b97020216 Reviewed-on: https://review.typo3.org/53235 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Benni Mack authored
There are still places left in TYPO3 where methods are called with integers as parameters, although they are marked as boolean. These places are changed to the correct and necessary value. Resolves: #81595 Releases: master, 8.7 Change-Id: I1664e7d5e3962f0d2cf59ba6148812291d0b803b Reviewed-on: https://review.typo3.org/53236 Tested-by:
-
- Jun 16, 2017
-
-
Christian Kuhn authored
Atlassian bamboo allows to define test plans in files since version 6. The test plans are based on rather simple Java files. The patch delivers build information of default core pre-merge plan. Changes of bamboo test configuration for these plans are now coordinated via casual patch requests and can be reviewed just as all other code. This adds full transparency on what exactly the core test environment does and can be used by others as reference for local execution and extension test plan boilerplates. Upload to bamboo.typo3.com to update test plans can be done by a bamboo administrator. Change-Id: I756cb65eba3a58e9edf0995aa9f1f2d4f96f7926 Resolves: #81589 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53225 Reviewed-by:
-
Thorben Nissen authored
When entering a date string in the admin panel to simulate a certain date/time and clicking the "update" button an exception it thrown. Due to the names and ordering of the fields, the timestamp from the hidden field gets overridden by the date string. Move the hidden timestamp field after the human readable date string field to avoid the timestamp being overridden by the date string. Add a comment to explain the ordering and avoid future changes. Resolves: #81174 Releases: master, 8.7 Change-Id: I87236c9b8ef84dabb3ec63e0530f14582ecbe6fe Reviewed-on: https://review.typo3.org/53230 Tested-by:
-
Benni Mack authored
The mode "capitalWords" was just a todo statement that indicated a missing implementation. The implementation is now added. Resolves: #81588 Releases: master, 8.7 Change-Id: I12b733da703de34568c6b79c083031f0333cdb92 Reviewed-on: https://review.typo3.org/53221 Reviewed-by:
-
Benni Mack authored
There are several places where mb_* methods are still not used, although they are even better to use instead of the $csConv->parseCharset() method for instance, as it has more aliases defined already. Same goes for "entities_to_utf8" which is a PHP user-space implementation of html_entity_decode() dated back to Kaspers' change in 2003. Using native PHP methods should also increase performance marginally. Resolves: #81575 Releases: master, 8.7 Change-Id: I5e97881cc7107883a5ff53d534161a7ec17e1ee5 Reviewed-on: https://review.typo3.org/53208 Tested-by:
-
Benni Mack authored
There is a class called "ObjectManagerException" which was introduced very early with Extbase and was a clone of the (now further developed) object manager. It was originally used in the wrong place in workspaces and then changed in workspaces to the real object manager but the class was kept. This class was then wrongly renamed in TYPO3 6.0 with the change to namespaces and called "Exception" which it is definitively NOT and thus, plain wrong in the place as it is. The class (and the interface) should be removed as it is not just plain useless and a hard mistake we carried on for 7 years now. Resolves: #52825 Releases: master, 8.7 Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b Reviewed-on: https://review.typo3.org/53231 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
- Jun 15, 2017
-
-
Markus Klein authored
Releases: master, 8.7 Resolves: #80952 Change-Id: I94a5124a16c9ad9893c1c2346967089fd16ad142 Reviewed-on: https://review.typo3.org/52112 Tested-by:
Mario T <typoser@trashmail.de> Tested-by:
-
Claus Due authored
Followup patch to migrate f:widget.autocomplete which had been missed by the previous patch. Change-Id: I9e2552925df84f225144b1120a93bf65d9874047 Resolves: #81213 Releases: master Reviewed-on: https://review.typo3.org/53199 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
Markus Klein authored
Add more information about the table argument and when it should be set. Resolves: #81545 Releases: master, 8.7 Change-Id: Ic95794869b384e0932d59747df545f15afe2825f Reviewed-on: https://review.typo3.org/53188 Tested-by:
Robert Wildling <robertwildling@gmail.com> Tested-by:
-
Thorben Nissen authored
Due to the changed link syntax ("t3://...") instead of "<link ...>" the links to files and internal pages are not recognised anymore. Furthermore are external links now written with <a href="..."> and are therefore also not recognized anymore. Rewrite code for detecting "typolink_tags" correctly. When recognizing urls, e.g. from "external url" pages or plain urls in texts, include https and not only http and ftp. Resolves: #80991 Resolves: #80988 Releases: master, 8.7 Change-Id: I5a9267b1d4ab53a6a39efdbd411e610dc9233ead Reviewed-on: https://review.typo3.org/52592 Reviewed-by:Christer V <cvi@systime.dk> Tested-by:
-
