- Jul 10, 2023
-
-
Nicole Cordes authored
The GlobalEventHandler changes the location of the current (target) window. The location is set to a given destination without any ability to interrupt. The existing ConsumerScope API isn't used even if the current window is the ContentContainer. This patch extends the handling of a navigation action by checking its target window and using proper ContentContainer API to set the location. Therefore registered listener can deny a location change and trigger own functions. Resolves: #95474 Resolves: #100114 Releases: main, 12.4, 11.5 Change-Id: If6a3b1cc546e1f2ff0b8e9fed3f83055f3f55e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79922 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
-
Benjamin Franzke authored
Since #94084 all module URLs are automatically framed by the TYPO3 main controller whenever they are opened in a Sec-Fetch-Dest aware request. (HTTPS or localhost domain) The intention of API is to allow module-links to be opened in a new tab by user intent – but due to technical limitation that feature is limited to secure contexts, and must therefore not be relied on as an API for internal redirects. sudo mode made use of this API and redirected via top.location to the privileged module, relying on the fact that iframe module-requests where detected to be loaded in the wrong context, to produce a redirect to the proper backend-frame, this didn't work for non HTTPS requests. This workaround has been done to remove "sudo-mode" from the URL bar. That workaround is no longer needed as #101287 added support for installtool URL bar synchronisation. ContentContainer API is now used to set the URL. Releases: main, 12.4 Resolves: #101288 Related: #101287 ...
-
Benjamin Franzke authored
Map backend URLs like /typo3/install.php?install%5Bcontroller%5D=settings to /typo3/module/tools/settings for display in the browsers URL bar. Resolves: #101287 Releases: main, 12.4 Change-Id: I5177146e28b01011f946c578804a8141fe9a371f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79920 Reviewed-by:
-
- Jul 07, 2023
-
-
Andreas Fernandez authored
flatpickr doesn't provide an easy possibility to set the today's date. To solve this issue, the plugin `shortcut-buttons-flatpickr` is added with a configuration for the today's date. Resolves: #100635 Releases: main, 12.4 Change-Id: I882f05ab4486d1b3073008cadb1d0275dd77c8ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79867 Reviewed-by:
-
Benjamin Kott authored
Resolves: #101276 Releases: main, 12.4 Change-Id: Ie9941076dc54fc3c123241cf51a50a19a9145ec6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79866 Tested-by:
-
Benjamin Kott authored
With #10551 a pretty cool new feature was introduced which will show you information about the status of non versionable records in list module of TYPO3 backend. These messages are now only be displayed, if extension workspaces is activated. Resolves: #101282 Releases: main, 12.4 Change-Id: I428535a2e301fa38b639fed99d70c8052dfaa6fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79849 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Jul 06, 2023
-
-
Benjamin Kott authored
The backend layout representation in the backend implements a table based layout. While the columns spanning was interpreted correctly, the definition of how wide a column is in the defined grid was missing, causing the cells to take up an unexpected amount of space. Resolves: #101041 Resolves: #100961 Related: #97306 Related: #94629 Releases: main, 12.4 Change-Id: I8ab426e0c6e136135bf1bcf6bcc0368f76d4f4b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79827 Tested-by:
-
Andreas Fernandez authored
In non-SVG trees, there are currently two icons representing the node's expansion state rendered that get toggled via CSS rules based on hard-coded aria attributes and icon identifiers, which is a bad practice. To solve this, a new web component `typo3-backend-tree-node-toggle` is added whose only responsibility is to render the correct icon based on its `aria-expanded` attribute Resolves: #100549 Releases: main, 12.4 Change-Id: I1a955731fc21da01a914b1ef721d7eb2d1e18ed5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79826 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Andreas Fernandez authored
The FormEngine validation now accepts "00:00 01-01-1970" as an entered date, which evaluates to int 0. If string 0 is passed, the field is supposed to be empty. Previously, a too simple negation check was in place. In the long run, the whole date validation handling needs a major rewrite to not rely on timestamps anymore. Resolves: #101258 Releases: main, 12.4 Change-Id: I90a976088e01c23443369eff76f4c6401463715e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79819 Tested-by:
-
Georg Ringer authored
If a record is translated, the modal overlay is now closed. Resolves: #100833 Resolves: #100896 Resolves: #99936 Releases: main, 12.4 Change-Id: Ifd282c72c5df2c03920f3b7aba67976fdacf168d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79774 Tested-by:
-
- Jul 05, 2023
-
-
Oliver Hader authored
The backend login refresh dialog is now passing a request-token (which is required in `AbstractUserAuthentication`), which is fetched via AJAX before actually submitting the login credentials as well via AJAX. Resolves: #101209 Releases: main, 12.4 Change-Id: I0d3d8a927b7f02791d990eefb2faf98be8aa2efb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79727 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Bartsch authored
Resolves: #101238 Releases: main, 12.4 Change-Id: I3ff0ea07c5b4121d3b585215b13b4834de7838b4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79735 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Andreas Nedbal authored
Prepared nodes were not properly handled in the category element, causing the indetermination state recalculation to never trigger properly. Using the nodes from the nodes-prepared event fixes this issue. Resolves: #98689 Releases: main, 12.4, 11.5 Change-Id: I63f9618c596cdad343d4af8393120eabae3fdbd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79688 Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
-
- Jul 04, 2023
-
-
Christian Eßl authored
The new save notification currently lists all changes separately, when editing records in EditDocumentController. This leads to a huge notification box, when saving many records at once. The behaviour is now changed so that if more than 10 records were edited, a more generic message is shown instead: "x records have been successfully saved." Resolves: #100223 Releases: main, 12.4 Change-Id: Ic3db6a1937de8eb288a7ded0bce3e1a88f10cb1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79686 Tested-by:
Annett Jähnichen <mcmietz@web.de> Reviewed-by:
-
Oliver Bartsch authored
Maintaining the "disallowed" list in TCA for type=file previously was only respected in the DataHandler but the restriction was not displayed neither in FormEngine nor in the FileBrowser. Additionally, the file extension filter did not restrict available files to select and the list was also not used by the DragUploader. All those places are now unified. Resolves: #101231 Releases: main, 12.4 Change-Id: Iab187e8d9787469016e2110306e35ae4192f6323 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79709 Reviewed-by:
-
Oliver Bartsch authored
Since #97330, a form engine elements label might not be represented by a <label> tag, but by using a <legend> tag. This patch now ensures that those elements are also correctly considered within form engine validation. Resolves: #101221 Related: #97330 Releases: main, 12.4 Change-Id: Iac4ef9b198bd7a7b8c75e53b83e45117be348c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79636 Reviewed-by:
-
- Jul 03, 2023
-
-
Andreas Fernandez authored
With the dismissal of jQuery and jQuery UI from the image manipulation component, the event handling for the trigger button ("Open Editor") got borked as the event state toggling previously done via `.off(...).on(...)` was replaced with using a `signal` as documented at [1]. The `AbortController` instance is only built when the modal has been fully shown, way after the event handling took place, breaking the module's global state. To solve this issue we removed the `AbortController` and its usages again. Also, `initializeTrigger()` now uses event delegation to register the event handler on the trigger buttons. As a drive-by fixes, the `active` state of the ratio buttons is now properly toggled, and the ratio title field is correctly updated by comparing with the scoped `ratioTitleWindow.HTMLElement` prototype. [1] https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#add_an_abortable_listener Resolves: #101150 Resolves: #101199 Related: #100948 Releases: main, 12.4 Change-Id: I021c74bb67976468ebdc5226263c6441796bd65b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79632 Tested-by: -
Benni Mack authored
The site language's configuration setting "hreflang" was deprecated with #99908, however, it still serves a valid purpose. If working with EXT:seo and the <link rel="alternate"> tags, it is still valid and possible to set a specific "hreflang" attribute. Example setups: * You have "German (Germany)" (which is using de-DE as locale) and "German (Austria)" (which is using de-AT as locale). here you want to set "de" as generic fallback in the "de-DE" locale when using hreflang attributes. * You want to explicitly set "x-default" for a specific language, which is clearly not a valid language key. This change does the following: * It re-adds the hreflang property to be managed by the UI, however it is empty by default and will fallback to the $locale->getName(). * It is not used within the <html lang="..."> attribute anymore as this was a mis-use in the first place (and now properly using just the language key, see https://www.w3.org/International/questions/qa-html-language-declarations.en.html#attributes * The method "SiteLanguage->getHrefLang()" is not deprecated anymore. * The RST is adapted accordingly Still, the relevant information is: The site language configuration option "hreflang" is not relevant anymore for regular websites without rendering hreflang tags, but is now customizable, and has a proper fallback. Resolves: #101160 Resolves: #95798 Related: #99908 Releases: main, 12.4 Change-Id: Ifc5b5b10ba46b4da4abd5c504d4d69f240f2fd02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79545 Reviewed-by:
-
- Jun 29, 2023
-
-
Oliver Hader authored
The CSP backend module is not showing the optional source-file of the reported violation. This information references to the actual asset that caused the violation. In addition, visualizing the user-agent helps to identifiy and reproduce possible flaws. In case, `effective-directive` (preferred W3C property) is not given, but `violated-directive` (legacy W3C property) is, that value is taken - this still can happen in old browser versions. Resolves: #100912 Releases: main, 12.4 Change-Id: Idf9482d234292a15a4114c474ddb2b5316d21a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79562 Tested-by:
-
- Jun 27, 2023
-
-
Christian Kuhn authored
A single FormEngine element (created by "element" classes that typically extend AbstractFormElement) takes care of the "inner" HTML of an element. The surrounding "outer" HTML like embedding elements in palettes is created by "container" classes. Also, <label> tags for single elements are created by container classes, namely PaletteAndSingleContainer and FlexFormElementContainer. The situation having <label> done by a container and the inner HTML done by elements has drawbacks: First, "label" tags should have a "for" attribute, to connect it with input fields having "id" attribute. This is one of the accessibility "must haves". Separating label and fields in different classes does not allow doing this. Secondly, not all elements have such input or select tags at all. In those cases, the label is not a label, but should be a legend embedded in a fieldset. The patch moves the existing label tag generation from container classes to element classes: Only elem...
-
- Jun 26, 2023
-
-
Jasmina Ließmann authored
In order to ensure the readability of the progress bar, the previous content has been split up. Only the percentages are now displayed in the progress bar. Information about which installation step the user is currently at is now displayed above the progress bar. In addition, an undefined variable and icon were removed and the form buttons of the first step are now aligned in a row. Resolves: #100987 Releases: main, 12.4 Change-Id: Idc43d11a5f4b9988c51cf97482dee1f48d8e21b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79425 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
-
- Jun 22, 2023
-
-
Nikita Hovratov authored
While separating type folder from type group, it was forgotten to enable client-side validation for min/max checks in the FormEngine validation. Furthermore, it is recommended to use minitems over required=true for fields with multiple items. Reasons are: 1. it is not documented, 2. to better conform with the counterpart option maxitems. Resolves: #101089 Related: #96983 Releases: main, 12.4 Change-Id: I4a8d01e15bb72ceff8130c1dcc18b829097375ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79421 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Jun 08, 2023
-
-
Andreas Nedbal authored
The positioning line is always shown above elements, regardless of dragging position. This is most likely done to prevent jitter of the line between elements. This looks wrong at the end of the tree when trying to add a page below the last child, so we add a condition to show the line at the bottom for the last child of the tree in that case. Resolves: #100392 Releases: main, 12.4 Change-Id: Ib5ae4fc93aff565f9f54ac5af3e5736138198b98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79232 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Jun 07, 2023
-
-
Jasmina Ließmann authored
Resolves: #100779 Releases: main, 12.4 Change-Id: I7f7cf0a480a637df7fc4a4dc9ad74ceca0d77572 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79215 Tested-by:
-
- Jun 06, 2023
-
-
Benni Mack authored
See https://blog.getbootstrap.com/2023/05/30/bootstrap-5-3-0/ Used commands: - npm add "bootstrap@^5.3.0" - npm add "@types/bootstrap@^5.2.6" --include=dev Resolves: #100962 Releases: main, 12.4 Change-Id: I0514068524fb3e857fdac5e6512a21562bc51716 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79212 Tested-by:
-
Oliver Hader authored
This change removes jquery and jquery-ui from the image manipulation widget. The draggable & resizable features have been reimplemented in a new dedicated lit-element `<typo3-backend-draggable-resizable>`, which emits the following events (having `action` and `originOffset`): + @draggable-resizable-start + @draggable-resizable-update + @draggable-resizable-finish Resolves: #100948 Releases: main, 12.4 Change-Id: I65c00eb4f7bfbe7963b9ea20ff71194245f8e381 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79192 Tested-by:
-
- May 24, 2023
-
-
Jochen Roth authored
Currently, the year selector shows arrows which overlay the css styles and the current day style is equal to the selected day. This has been changed by hiding the arrows for the year selector and using disabled background color for the current day (today). Resolves: #100884 Releases: main, 12.4 Change-Id: I1f0e89e9fd5a59f90d97eb340b575d9c27a42718 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79139 Tested-by:
-
- May 09, 2023
-
-
Andreas Fernandez authored
The fields used in the table wizard are only used for internal handling to be able to compose the final table markup sent to DataHandler. The "management fields" are not interesting on server side and therefore their respective `name` attributes are removed to avoid sending potentially huge, superfluous data. Resolves: #100354 Releases: main, 12.4 Change-Id: If833f2bd1208a050dc88bc1844a19d9fbb209614 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78973 Tested-by:
-
- May 08, 2023
-
-
Nikita Hovratov authored
Resolves: #82481 Releases: main, 12.4, 11.5 Change-Id: Ieffc20f64cac7b546e20964e5f0deeab6e523771 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78902 Tested-by:
-
Oliver Bartsch authored
Since we are in the scope of a web component, access to "document" is now consistently avoided. Resolves: #100814 Releases: main, 12.4 Change-Id: I38b0b9f1796a3ff512bbf62bd518105cbaf273b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78946 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Oliver Klee authored
Resolves: #100821 Releases: main, 12.4 Change-Id: Ifc5652cf25bcf1d71580cfe207b2a22652735a2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78900 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- May 07, 2023
-
-
Oliver Bartsch authored
The record title in the delete confirmation modal of FilesControlContainer is now properly replaced. Resolves: #100815 Releases: main, 12.4 Change-Id: I6a66242a9d2e5fdea28191d3d98da036c3af77aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78947 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
- May 05, 2023
-
-
Andreas Fernandez authored
The identifier used to get a container in `type=files` based on `querySelector()` which flawed if the identifier contained a dot. The example identifier "#foo-data-foo.bar" resulted in "find an element with id 'foo-data-foo', having the class 'bar'", which is wrong. To solve this issue, while still limiting the scope to the web component, the selector is changed to use the `[id='']` syntax, which doesn't show the erroneous behavior. Resolves: #100777 Releases: main, 12.4 Change-Id: I9edff128c612cc6a614b65866533c3fb1c731f4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78898 Tested-by:
-
Oliver Bartsch authored
In case a site is missing a proper site configuration - having no default language a fallback SiteLanguage object is used in the page module. This fallback however does provide an empty string as flag identifier, which does no longer result in a broken icon. Resolves: #100799 Releases: main, 12.4, 11.5 Change-Id: I23f3d9347d2ea8a63520086054b9fa842a9f5cfd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78897 Tested-by:
-
- May 02, 2023
-
-
Andreas Fernandez authored
Clicking the "Remove all" button in the CSP backend module now closes any open report. Resolves: #100757 Releases: main Change-Id: Ie6b4b5d581c2b44385f40c9db8d3b5bcbd1b8a2a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78879 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
- Apr 26, 2023
-
-
Andreas Fernandez authored
`text-overflow: ellipsis` only works in Firefox if the parent element has an explicit width. Therefore, `button` and `a` elements are now set to a width of 100%. This also fixes an issue where images appear to be squeezed in Firefox. Resolves: #100743 Resolves: #100761 Releases: main Change-Id: I750f553b0fbdc0a05652074b785ec5028d3937bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78876 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
Frank Naegler authored
Resolves: #100726 Releases: main Change-Id: I49384e7bbf3f199504ee7a978a816df1285474ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78805 Tested-by:
-
- Apr 24, 2023
-
-
Jasmina Ließmann authored
With #100663 the overall spacings were adjusted. With this patch we align the spacing between scheduler group panels with the spacing between record list items. Also, a margin above the 'Unused task groups' section has been reduced. Resolves: #100735 Related: #100663 Change-Id: I618350f1bfa79cf67f781766a2a647c05b619cfb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78813 Tested-by:
-
Jasmina Ließmann authored
Previously, the form fields in user settings form were displayed in their entirety, filling the screen. With this patch, the width of the input mask is now reduced to create a uniform appearance with forms of the form engine. Some individual spacing between the form fields has also been adjusted to match those of the form engine. The buttons for adding or removing an avatar image now each contain speaking labels that were previously only aria-labels. Additionally, the form fields markup in the user settings has been updated to fully match the FormEngine form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should be using FormEngine for rendering anyway, so this is kind of a pre-patch. Resolves: #100605 Releases: main Change-Id: Ia83c9d42bcdb2faa12e1c1918d19e66a43f7ad66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78661 Reviewed-by:
-
Jasmina Ließmann authored
With #100042 the markup of the form fields in the add/edit form of a task has been updated. With this patch the markup was updated again to fully match the FormEngine's form field markup. With this we create the prerequisite that rollouts of global style adjustments for form fields also work on this form. Mid-term, this module should use FormEngine for rendering anyway, so this is kind of another pre-patch. Resolves: #100601 Related: #100042 Related: #100726 Releases: main Change-Id: I4ec2f7a1607bfb5005610cf2ab3cd5c2a2aac851 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78643 Tested-by:
-
