- Feb 09, 2022
-
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96791 Releases: main Change-Id: I7bec6ced5e284232cba0e5cc813ad29766ec0e30 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73359 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
This change uses the fluent API for generating preview URLs. This way, we can replace BackendUtility::getPreviewUri() in a next step. Resolves: #96777 Releases: main Change-Id: If4e30d3958f3117e3800077799d97505903f382c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73333 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Benni Mack authored
Default values should be integer for the newly introduced MAIL options in https://review.typo3.org/c/Packages/TYPO3.CMS/+/69907 Resolves: #96803 Related: #94544 Releases: main Change-Id: I1cbced77304e3015e5d5c64fde7257d46f037eb5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73373 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Georg Ringer authored
Remove usage of TSFE and access the site entity via `cObj->getRequest()`. Resolves: #96801 Releases: main Change-Id: Ie16f72a6d7bc3b49ba00ab8eb404dc4db935a88e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73371 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
Instead of referencing a language file, which has to contain three labels with predefined names, such as "mlang_labels_tabdescr", it's now also possible to configure the module title, description and short description individually. Resolves: #96799 Related: #96733 Releases: main Change-Id: I6fbe015fd18c6440a4bb0b49a5020045e08cf90e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73369 Reviewed-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Apply the new templating strategy to EditDocumentController (FormEngine record editing) by adding a first template and refactoring the class a bit. EditDocumentController is still a complex beast, the patch is quite conservative and cleans up only relatively obvious parts. Resolves: #96787 Related: #96730 Releases: main Change-Id: I30e340276a5687d96f04b11a567444272ec1d96c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73357 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Bartsch authored
Since introduction of the new module registration API (#96733), the TYPO3 backend route object might contain a Module object as "module" option. This option was then previously used in the RouteDispatcher to check, whether the current user has necessary access permissions for this module. However, the RouteDispatcher should not handle such validation tasks, but only dispatch to the defined target. Therefore, validation of the module access permissions, as well as further checks (e.g. for a given page id) are now moved into a dedicated PSR-15 middleware. To further improve the new API, the middleware also adds the module as attribute to the request. Additionally, the now obsolete "moduleName" route option is removed. It is always the same as the module identifier and can therefore be fetched via the object. Resolves: #96797 Related: #96733 Releases: main Change-Id: I2c580948399136a6ea9199f0872ae874ea99b8fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73367 Tested-by:
-
Anja Leichsenring authored
Set all missing files to declare(strict_types=1); Resolves: #96792 Releases: main Change-Id: I65946055f720830d2a431732d78846e0eac77a85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73360 Reviewed-by:
-
Oliver Bartsch authored
The InfoModuleController previously added the form action url as "moduleName" to the view. Since #96730, this variable name is overwritten by the ModuleTemplate. Since then, instead of the form action url, the variable only contained the module identifier. This lead to misbehavior on submitting the form. The form action url is therefore is now added, using the dedicated "formAction" variable. Resolves: #96798 Related: #96730 Releases: main Change-Id: Ic3c737cf1168bf2d6e887cc77d4d2a301037c9df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73368 Tested-by:
-
- Feb 08, 2022
-
-
Christian Kuhn authored
The match expression in PHP needs default as keyword, not as string literal. Change-Id: I8f242b47c74920034e046ce957cb5830d0584aa0 Resolves: #96794 Related: #96688 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73362 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Oliver Hader authored
Resolves: #96723 Releases: main, 11.5 Change-Id: Idb880e7a45ed91f472adfbfc5b9093c14d074a7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73355 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Susanne Moog authored
Since PHP 8, native attributes are supported. In comparison to annotations, attributes have auto-completion, are better readable and were "invented" for storing meta-information about properties. Extbase annotations are already nearly 1:1 translatable to attributes. The following annotations have been enriched for usage as attributes: @Extbase\ORM\Transient @Extbase\ORM\Cascade @Extbase\ORM\Lazy @Extbase\IgnoreValidation @Extbase\Validate Resolves: #96688 Releases: main Change-Id: I8f83790869bcca12cf8c8e2967fd24c468eea104 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73217 Reviewed-by:
-
Christian Kuhn authored
Refactoring of ext:linkvalidator backend controller towards new backend templating strategy together with a series of details to simplify code. Resolves: #96779 Related: #96730 Releases: main Change-Id: I347e7f167ac98cbd13a1fdb64122c1a99b7c9756 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73349 Tested-by:
-
Benjamin Franzke authored
The ModuleStateStorage introduced in #94762 as replacement for fsMod is only used via an <typo3-immediate-action> custom element (provided by ModuleTemplate), but had a fallback that requires the ModuleStateStorage to always be loaded in the page layout. With the removal of the fsMod shim in #96289, the unneeded include can be removed as the module is loaded dynamically via ImmediateActionElement.js Resolves: #96785 Related: #96289 Related: #94762 Releases: main Change-Id: I6fb25550d7ef59eb9a99ce045f7ed79fe1c211bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73354 Tested-by:
-
Lina Wolf authored
Releases: main Resolves: #96783 Change-Id: Ic4a36692a7dfffacca062e3c54e0ade1d8cda5ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73352 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Oliver Bartsch authored
The WorkspaceService->fetchPagesWithVersionsInTable() method is used to fetch all pages, which contain versioned records. This is e.g. used for highlighting the page tree. Since new records (created in a workspace) do not hold a t3ver_oid, they were previously not considered in the corresponding database query. This is now fixed by also checking the t3ver_state for the new placeholder flag. Resolves: #94931 Related: #92791 Related: #92497 Releases: main, 11.5 Change-Id: Ib40662aa6016c33b3047e1172ad4c1012e72d81c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73343 Tested-by:
-
- Feb 07, 2022
-
-
Nikita Hovratov authored
- Use native typehints instead of doctype - Add return types - Use strict types - Use DI: abstract class uses inject* methods, inheriting classes use constructor DI - Improve array annotations for phpstan level 6 (not yet detected) - Remove method comments with no added value - Use str_starts_with - Move abstract and public methods to the top Some minor refactorings along the way: Get "richtextConfiguration" directly from parameters array in BrowseLinksController. Resolves: #96763 Releases: main Change-Id: I547b50617a080e988b2b69417f0d5bce5ed98c62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73323 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Larry Garfield authored
This is just a general cleanup and tidying to use constructor promotion, typed properties, and other modern language niceties in the Mail system. It's mainly to setup for future patches to reduce the jitter in further refactor work. Resolves: #96715 Releases: main Change-Id: I0c05db4d2ad3d43de53342511d9a7c6712f0cf73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73256 Tested-by:
-
Oliver Bartsch authored
To dynamically use the search word operator as part of a locallang key, it has to be formatted (lowercase and no whitespace). Resolves: #96775 Releases: main, 11.5 Change-Id: I9ded9337a0a14ed0035ca83d887659aa4f246eb0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73341 Tested-by:
-
Christian Kuhn authored
The patch gives SetupModuleController some love by adding a first template for the outer module HTML, cleanup up various internals along the way, and switching to new backend templating strategy. Resolves: #96776 Related: #96730 Releases: main Change-Id: Ia97808ed040e65cd1311b7dfd0c1c71d6e3aebed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73340 Tested-by:
-
Benni Mack authored
The following extensions now only use CSV files for test fixtures: * felogin * recordlist * seo Resolves: #96770 Releases: main, 11.5 Change-Id: I55e4786d3a08d7049b1310edf98551831758c292 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73311 Tested-by:
-
Christian Kuhn authored
We need to move the main templates around a bit to apply new backend templating strategy to the ext:form backend controllers. Resolves: #96774 Related: #96730 Releases: main Change-Id: I0c3f82f33c17f482a0487e3f29eb8b2ba76ff128 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73338 Tested-by:
-
Christian Kuhn authored
Rather straight refactoring of the indexed_search AdministrationController towards new backend templating strategy. Resolves: #96772 Related: #96730 Releases: main Change-Id: I889c471f2f7902f5dd407d03d28cb4ac30e21fe9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73335 Tested-by:
-
Christian Kuhn authored
Straight implementation of the new backend templating strategy in ext:impexp. Resolves: #96773 Related: #96730 Releases: main Change-Id: If69320a4e1850e5c0c22682e8d46837d891ea8e8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73336 Tested-by:
-
Christian Kuhn authored
Basic refactoring of ElementInformationController (the "info" modal on records). The entry method is more clean, the class uses a bit less state, new backend templating strategy is used. The controller is still a bit messy and could be further cleaned up with an additional patch that should further separate 'db', 'file' and 'folder' handling. Resolves: #96767 Related: #96730 Releases: main Change-Id: Ic8c27b6da5e4faf863d1ec70d060ec9fe86d357c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73330 Tested-by:
-
Christian Kuhn authored
A rather straight refactoring of the ext:tstemplate "entry" controller to use the new backend templating strategy. Resolves: #96771 Related: #96730 Releases: main Change-Id: Ia452ee9a88232ee5cce4e463f13c866b8c2e31ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73334 Tested-by:
-
Christian Kuhn authored
This is a straight inclusion of new backend templating strategy for main "info" dispatcher controller "InfoModuleController". We're doing only strictly needed changes since this code construct will receive a major overhaul soon. Resolves: #96768 Related: #96730 Releases: main Change-Id: I29bf10f1fcbda49ae0b2b99f7d4688f7fc4c036e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73331 Tested-by:
-
Georg Ringer authored
Having the parent page information available for references can be helpful for editors. Resolves: #94601 Releases: main, 11.5 Change-Id: Idb1c0fe7627b1022bef70aaf537996a9a45ff00d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72198 Tested-by:
-
Georg Ringer authored
Improve the accessibility of the record history module by binding the label to the related field. Resolves: #96769 Releases: main, 11.5 Change-Id: If34bce1974c8c98783fdb2529b1555213b1dbc40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73332 Tested-by:
-
Benjamin Franzke authored
As prepared in #91316, PageRenderer state is now serialized instead of serializing the entire object, this means that caches of the importmap are excluded from serialization. Resolves: #96709 Related: #91316 Releases: main Change-Id: I8edde372274c7ea2fbc18bc08bcb9a140939292a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73251 Tested-by:
-
Stefan Bürk authored
The script "Build/Scripts/checkIntegrityComposer.php" verifies composer.json dependencies of each system extension to have the same version as the root composer.json manifest file. The patch adds an additional check that all dependencies of a system extension also have a counterpart in the main root composer.json of the development collection. This way, we avoid scenarios where we remove a dependency from the root composer.json and forget to remove it from system extensions, too. Resolves: #96757 Related: #96756 Related: #96749 Releases: main, 11.5 Change-Id: Ia179e79f5370137d37f572661570bd0fc225212e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73315 Tested-by:
-
Oliver Bartsch authored
This change introduces a new way to register TYPO3 Backend Modules. Each module is now registered during build-time in a dedicated registry. Therefore, The registration is moved from ext_tables.php to the Configuration/Backend/Modules.php file. Accessing the registered modules can be done via a central API, the ModuleProvider class. This class takes care of access permissions and further processing (e.g. module menu generation). $GLOBALS[TBE_MODULES] is fully removed as no sane backwards-compatibility (for a use-case) is available. A new PSR-14 event BeforeModuleCreationEvent is added, which allows to manipulate a module configuration, before it is used to create and register the module. Existing registrations do no longer work. However, to support extenion authors in maintaining multiple versions, the previously used API methods (e.g. `addModule` and `registerModule`) will stay until TYPO3 v13.0. No trigger_error() is used, so extension authors use the Extension Scanner to detect usages. Executed commands: composer u typo3/cms-styleguide Resolves: #96733 Releases: main Change-Id: I07f4bc417e6effb1215cf0e373cc60f2b13ba8ad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73058 Tested-by:
-
Chris Müller authored
Resolves: #96762 Releases: main, 11.5 Change-Id: I3f8300389fae0b6f30a7dc826afb8b2260ea41df Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73322 Tested-by:
-
Stefan Bürk authored
During backend view refactoring with #96605 it was overseen that essential JavaScript on permission edit view is no longer loaded, thus current permission not displayed. This patch adds the needed ViewHelper statement to the edit permission template file, like it has been done for the other views. Permission edit now works again. Resolves: #96759 Related: #96605 Releases: main Change-Id: I695e92ede51f65850f6fb38689c9a57943a5279f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73317 Tested-by:
-
Robert Kärner authored
The default configuration for JSWindow in lib.contentElement doesn't contain the params property, so after stdWrapping it in ContentObjectRenderer, it becomes an empty string. Thus, exploding it needs a fallback to prevent PHP 8.0 undefined array key warnings. In addition, first tests have been added for cObj->imageLinkWrap, which cover this warning. These tests have also found another warning for JSwindow.altUrl_noDefaultParams, which is also fixed now. Resolves: #96647 Related: #96508 Releases: main, 11.5 Change-Id: I593e42e3be8ebac4e8001275f2da9d635936c79e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73175 Tested-by:
physikbuddha <r.kaerner@oranto.de> Reviewed-by:
-
Nikita Hovratov authored
This reduces the amount of mocking drastically. Resolves: #96758 Releases: main, 11.5 Change-Id: Ia6d5e6086c23de4fe8c4ff8f95b20cc5320ae837 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73316 Tested-by:
-
Chris Müller authored
Resolves: #96761 Releases: main, 11.5 Change-Id: Ie3591fa68e2ae5a7a0d8075b6c992452bb48750e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73321 Tested-by:
-
Chris Müller authored
Resolves: #96760 Releases: main, 11.5 Change-Id: I7007c579fd3677e09229b0941f905dce8014cdfa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73319 Tested-by:
-
Stefan Bürk authored
With #96749 superflous polyfills has been removed from root composer.json. This patch removes missed occurrences in the composer.json of ext:core. used command: > composer rem symfony/polyfill-php80 -d typo3/sysext/core \ --no-update > composer rem symfony/polyfill-php81 -d typo3/sysext/core \ --no-update Resolves: #96756 Related: #96749 Releases: main Change-Id: I8205b898b4a11af5d00f7aea425a5abba3803ba3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73314 Reviewed-by:
-
Christian Kuhn authored
The ext:install BackendModuleController which renders the install tool login modal now bows to the general backend templating strategy. Resolves: #96755 Related: #96730 Releases: main Change-Id: Icf10c507bf3c9cf7d91b77b59a0fe4674448db28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73313 Tested-by:
-
