- Sep 25, 2023
-
-
Benjamin Franzke authored
The karma unit testing framework has been deprecated and suggests to use modern alternatives instead. We use one of the recommended alternatives named @web/test-runner which is toolset by the modern-web.dev and open-wc.org initiatives. It is based on mocha and es-dev-server, which allows to run our JavaScript modules natively in the browser (without having to bundle them via rollup). Note that compiled test files have been removed from the source tree, since we configure es-dev-server to transpile them on demand, allowing error output from tests to be using original line numbers and unmangled identifiers. The tests are executed in chrome by default (locally and CI). They can be executed via: # Run once npm run test # Run tests whenever files change npm run watch:build npm run watch:test # Open browser with devtools and debug mode activated MODE=dev npm run watch:test -- --debug Configuration is prepared to run in other browsers via playwright. Example: # https://playwright.dev/docs/browsers#install-system-dependencies npx playwright install --with-deps BROWSERS=chrome,chromium,firefox,webkit npm run test Commands executed: npm remove \ karma \ karma-chrome-launcher \ karma-coverage \ karma-jasmine \ karma-junit-reporter \ karma-rollup-preprocessor \ jasmine-core \ @types/jasmine npm install --save-dev \ @web/test-runner \ @web/test-runner-playwright \ @web/dev-server-import-maps \ @web/dev-server-esbuild \ @open-wc/testing \ sinon git rm -rf \ typo3/sysext/core/Tests/JavaScript \ typo3/sysext/backend/Tests/JavaScript npm run build Resolves: #101960 Releases: main, 12.4 Change-Id: Ia2fa94a9f6d66664d9fce72e7443aaeb12e0ca08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/81040 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Sep 05, 2023
-
-
Benjamin Franzke authored
With #101782 eslint project configuration was overwritten to use a custom path. eslint read the relative project configuration based on the current execution folder instead of relative to the eslintrc file. This worked as long as eslint was executed from the Build/ folder (execution folder == eslintrc folder). As some tools execute eslint from the git root directory, the configuration is now adapted to always resolve the tsconfig file name as an absolute path based on the configurations directory name. Also overrideConfigFile is removed from Gruntfile.js as .eslintrc.[json|js] is read by default and no override is needed. Resolves: #101846 Related: #101782 Releases: main, 12.4 Change-Id: I58a6322a74d388efb0da28d1d8e7375f491c7aea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80863 Reviewed-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
-
- Mar 09, 2023
-
-
Benjamin Kott authored
We renamed the eslint configuration to follow the recommended standards so developers IDEs will pick up the configuration more easily. The ruleset was adapted to follow a wider range of recommendations. - eslint:recommended - @typescript-eslint/recommended - lit/recommended - wc/recommended In addition we now also force more kinds of spacing rules to avoid IDEs having different opinions on how to format for example includes. The only recommendation we don't want to follow is - @typescript-eslint/no-inferrable-types. We don't want to disallow being explicit. Instead of turning off rules we cannot fully fulfill as of now, we are now changing the configuration to warning. This will help developers spotting mistakes more easy when writing code. Rules that are currently in "warn" mode: - @typescript-eslint/ban-types - @typescript-eslint/no-explicit-any - @typescript-eslint/no-this-alias To only check for errors run in the Build directory: - npx eslint ./Sources/TypeScr...
-
- Sep 06, 2022
-
-
Benjamin Kott authored
Commands executed: npm install --save-dev grunt-stylelint@^0.18 stylelint@^14.11 stylelint-order stylelint-scss npm run build Resolves: #98267 Releases: main Change-Id: I06887ef24d7e1f0614b6881624851fbe26fa6617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75618 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 05, 2022
-
-
Simon Gilli authored
This patch applies the new documentation standards to the .editorconfig. Resolves: #97302 Releases: main, 11.5, 10.4 Change-Id: I798b355f71dfa7ba8ac20ad424105e99a5c870cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74179 Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
Alexander Nitsche <typo3@alexandernitsche.com> Reviewed-by:
-
- Jul 29, 2021
-
-
Simon Gilli authored
For the covenience when creating files with code snippets the indent of .rst is changed to 4 spaces. This works for all cases also for lists where normally 3 spaces are used. Resolves: #94669 Releases: master, 10.4, 9.5 Change-Id: If1ed5927a1e5e17e56edf0696eb4c528599b788c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70159 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Simon Gilli authored
The NEON files are currently missing in the .editorconfig and properly added by this patch. Resolves: #94637 Releases: master, 10.4 Change-Id: Ieaf0f09d9111b9a6c59efac3855a04bb5b8750fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70070 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
- Dec 15, 2020
-
-
Christian Kuhn authored
Travis CI for core has been flaky for a while - processes tend to die or are queued forever. The only thing travis still executed for us is updating sonar cloud data. This service has been introduced some years ago but did never find significant usage and has never been configured. The patch drops travis along with sonar-cloud. If anyone wants to pick up work with sonar again, it could be added as github action again. Change-Id: I2929bfb1f72d1a6af273692b4f632d90280bf074 Resolves: #93084 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67144 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Jan 07, 2020
-
-
Chris Müller authored
The maximum line length of documentation files (80 characters) should be reflected in the .editorconfig as described in https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/GeneralConventions/CodingGuidelines.html#line-length Resolves: #90054 Releases: master, 9.5 Change-Id: Ib1c3f2f2fbae999b7d157949f1a59876c2ff451d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62818 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
- May 10, 2019
-
-
Andreas Fernandez authored
This patch aims to reduce the size of the .editorconfig file used by IDEs to get rid of duplicated configuration (indent_style), obsolete configuration (bower.json) and merge related configuration (scss, css). Resolves: #88271 Releases: master Change-Id: I5a34536858b0cea5e4eb5a1f9fc7ca566aa144e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60653 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Apr 23, 2019
-
-
Benjamin Kott authored
The indentations in the HTML templates are out of control. Even if we provide an EditorConfig, which should ensure that the files are all uniformly indented. There seems to have been an increasing aversion to TABS over time. This has led to the fact that above all newly created templates have always been indented with SPACES instead of TABS. We now have a mix of TABS and SPACES in our project, partly also in a single file. To avoid this in the future, all existing templates were converted to indentations with SPACES and the provided EditorConfig was adapted. In order to really, really make sure that it doesn't get out of hand, we also introduce a new linter, which ensures that all HTML templates are properly indented. Resolves: #88180 Releases: master Change-Id: I86d23120bc68e3696f398b1ae76f1efc4804d501 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60522 Tested-by:
Oliver Wand <wand@itaw.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
- Jul 30, 2018
-
-
Josef Glatz authored
This patch adds a proper .editorconfig configuration for .htaccess and fixes wrong existing indentions. Resolves: #85681 Releases: master Change-Id: Id5baa6084f1a687c1f6f7ccdfb66f7e87af2ad47 Reviewed-on: https://review.typo3.org/57722 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- May 11, 2018
-
-
Frank Naegler authored
Resolves: #84969 Releases: master Change-Id: I871656c436a9ded5c82fbade4a28d5bd5e84de26 Reviewed-on: https://review.typo3.org/56921 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
-
- Nov 03, 2017
-
-
Tymoteusz Motylewski authored
Resolves: #82900 Releases: master Change-Id: I9e80f662981dc107d5bcd1e4fc28bcf9d2ff3b4a Reviewed-on: https://review.typo3.org/54534 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Oct 30, 2017
-
-
Peter Kraume authored
Add definition for new TSConfig filetype .tsconfig to .editorconfig file. Change-Id: I3fd87abc8a8fe554692f61e548e37d4d02f74fa4 Resolves: #82879 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/54493 Tested-by:
-
- May 17, 2017
-
-
Andreas Allacher authored
The new file extension .typoscript will be the default for TypoScript configuration files and is the only recommended one from now on. This effort is made to introduce a dedicated file extension for TypoScript configuration files, and to avoid conflicts with already existing and more spread file extensions like ".ts" for TypeScript or Video Transport Stream Files. Resolves: #78161 Resolves: #80689 Releases: master, 8.7 Change-Id: I44b41631f498e3ba39e0f1936329094a59859f4e Reviewed-on: https://review.typo3.org/50096 Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
Resolves: #80529 Releases: master Change-Id: Ic90bf297baad33576509f9ff13ab67674ba658ac Reviewed-on: https://review.typo3.org/52221 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
- Mar 26, 2017
-
-
Benjamin Kott authored
In preparation for upcomming switch from bootstrap to SASS the backend style sources have been migrated to SASS. The autoprefixer configuration was corrected to match CMS8 LTS requirements and minification of CSS files is now enabled. Automatic style checks are now available through grunt. The tasks `grunt format` and `grunt lint` will now check sources files for consistency. Resolves: #80453 Releases: master Change-Id: I9ba23aea78014a1f0cce229db533a81d5ffcd02f Reviewed-on: https://review.typo3.org/52151 Tested-by:
Marco Christian Krenn <krenn@webconsulting.at> Tested-by:
-
- Feb 01, 2017
-
-
Benni Mack authored
The main problem with the current RTE configuration relies in the fact that it is *only* configurable via pageTS. CKEditor can now be configured via YAML, but the configuration preset can be overriden via pageTS. Additionally, the CKEditor Form Element is cleaned up. A different preset can be used via PageTS config: - RTE.default.preset = minimal - RTE.config.tt_content.bodytext.preset = full Once included, the next features will be - a configuration backend module for ckeditor - Make sure to re-add the feature for RTE.anchorClasses - Check the languages of CKeditor that they are in line with the TYPO3 languages (possibility to add others) - image handling - table handling Resolves: #78917 Releases: master Change-Id: Ia222b73072b9e3fdb3a120d0be0a24a913552126 Reviewed-on: https://review.typo3.org/50919 Tested-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
- Nov 26, 2015
-
-
Markus Klein authored
Resolves: #71863 Releases: master Change-Id: I4f3494ce2734f1ee0a2f6fc916d3d977c31feae7 Reviewed-on: https://review.typo3.org/44957 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
- Oct 08, 2015
-
-
Benjamin Mack authored
Resolves: #70511 Releases: master Change-Id: If4c8a52361e0f6e0c1c180653f653fec89d22999 Reviewed-on: http://review.typo3.org/43914 Reviewed-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
-
- Apr 06, 2015
-
-
Frank Nägler authored
Add new definition for JSON files and ReST files. Resolves: #66284 Releases: master Change-Id: I1b7052f37180c6d5be7c350b43df3936c33ed501 Reviewed-on: http://review.typo3.org/38493 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
Ingo Renner <ingo@typo3.org> Tested-by:
-
- Nov 24, 2014
-
-
Frank Nägler authored
Add html and tmpl files to .editorconfig Resolves: #63277 Releases: master Change-Id: I2da5a46af412c390b67e5ead04543bffe130c63b Reviewed-on: http://review.typo3.org/34521 Reviewed-by:
-
- Nov 16, 2014
-
-
Frank Nägler authored
Resolves: #63003 Releases: master, 6.2 Change-Id: I80a81e15afc71398d9607848160b8805407172fe Reviewed-on: http://review.typo3.org/34236 Reviewed-by:
-
- Sep 16, 2014
-
-
Frank Nägler authored
A lot of IDEs support a .editorconfig file, this file contains informations for the IDE how to handle and format files. This little file can be used for any kind of file. If the IDE support this file, the IDE configure it selfs to use the settings e.g. to use TAB instead of SPACES. Resolves: #61621 Releases: 6.2, 6.3 Change-Id: I76fb7901c0cf07a5b848523a0c0e46a6f705db4d Reviewed-on: http://review.typo3.org/32794 Reviewed-by:
-
