- Oct 25, 2022
-
-
Oliver Klee authored
Also update the PHPUnit PHPStan configuration. This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.11 > composer req --dev phpstan/phpstan-phpunit:^1.1.3 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98913 Releases: main, 11.5 Change-Id: Ifc374d02a2ad343bd6be9a61b2075deb019b98f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76257 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Oct 24, 2022
-
-
Chris Müller authored
Resolves: #98547 Releases: main, 11.5 Change-Id: I82b2fc75947d451b24ccfd90ebe82b0107aff1e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76243 Tested-by:
-
- Oct 22, 2022
-
-
Markus Klein authored
Releases: main, 11.5 Resolves: #87048 Change-Id: Ia44998ec3601226f45b96468b7a37ad4d20dccdf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76178 Tested-by:
-
Andreas Fernandez authored
The Fluid template in the filelist now checks if the clipboard is available at all to render the "multi item" actions, like "Transfer from clipboard" and alike. Resolves: #98641 Releases: main, 11.5 Change-Id: Icfd77f6b14c763128f81b4d8de3e1ebeec295cd9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76176 Tested-by:
-
Sascha Egerer authored
Log messages may have placeholders that must be interpolated based on the context provided to the message. Resolves: #98653 Releases: main, 11.5 Change-Id: I953bb41ba52599b7f65328027fe9e905ef5d35d0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76177 Tested-by:
-
- Oct 21, 2022
-
-
Andreas Fernandez authored
A backend module's docheader is "folded" when scrolling down in the backend module. Sometimes, the folding process appears to be laggy due to the pixel-snapping approach of animating a position change, which also leads to more work for browser engines. For a better rendering performance, the element isn't physically moved in the DOM, but transformed instead, offloading work to the GPU. See [1] for further information. [1] https://web.dev/animations-overview/ Resolves: #98693 Releases: main, 11.5 Change-Id: I93be697d8105eef83ce2376c8879419058dfdb85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76226 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
To avoid setting potentially invalid links, the "email address" and "telephone number" fields both are marked as "required". The input type of the former one is also changed to `email`. As a drive-by fix, `id` and `for` properties are set to link the input fields to their respective label. Resolves: #98388 Releases: main, 11.5 Change-Id: I24d62f70743e2bce73dd1de3cd9ecdac5dd0343a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76216 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Anja Leichsenring authored
In AddRecord Wizard, the property editConf is marked as string, but the fallback assignment is null, leading to a type error and exception. By assigning empty string as fallback, the error is prevented. Resolves: #98682 Releases: main, 11.5 Change-Id: Ic027f86632011a23cacf6e879e2561c807a792ae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76175 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Michael Vöhringer authored
PHP8.1 throws an TypeError if we sending null to createStream Resolves: #98417 Releases: main, 11.5 Change-Id: I327751c2cb13991122c84f4333a4976b9d0a0dae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75878 Reviewed-by:
-
- Oct 20, 2022
-
-
Andreas Kießling authored
RecordsContentObject and ContentContentObject create new instances of the ContentObjectRenderer. They need to pass down their local instance of the TypoScriptFrontendController so it will not try to fall back the global instance, e.g. while indexing with EXT:solr. Resolves: #98622 Related: #97638 Releases: main, 11.5 Change-Id: Ic19338246347400a96a7138f62001690aaacbd96 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76174 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Markus Zipfel authored
Resolves: #98637 Releases: main, 11.5 Change-Id: I516eb70b998bd81fdb522085aee42ec94b22908b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76173 Tested-by:
-
Chris Müller authored
Resolves: #98651 Releases: main, 11.5 Change-Id: I6f2dbd859341e7a57bf9bca7bf815eb2e1d161bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76172 Tested-by:
-
- Oct 19, 2022
-
-
Oliver Klee authored
PHPStan will (correctly) unify the previous type `\PDO::PARAM_*|Connection::PARAM_*|int` to `int` (because `\PDO::PARAM_*` as well as `Connection::PARAM_*` are all ints). So we're using the stricter `Connection::PARAM_*` now, which is a superset of `\PDO::PARAM_*`. This allows PHPStan to catch calls to this method with incorrect values. Resolves: #98512 Related: #98500 Releases: main, 11.5 Change-Id: I78efb486fe60aea2640435c8c48bd08ae8b3c3cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76167 Tested-by:
-
Benni Mack authored
This change modifies most of the userland code to use a) Connection::PARAM_* constants instead of \PDO::PARAM_* constants This is due to also another change from Doctrine DBAL 3 https://github.com/doctrine/dbal/blob/3.4.x/UPGRADE.md#bc-break-the-pdo-symbols-are-no-longer-part-of-the-dbal-api which can easily be changed in TYPO3's Source Code to ensure easy upgrade paths and showing best practices for extension authors looking into TYPO3 Source Code b) Avoid using constants from \Doctrine\DBAL\Connection but use our own constants. Even though Doctrine DBAL 3.x introduces "ParameterType" objects, we use our own connection implementation for the time being as we also seek to backport such changes in TYPO3 v11. The initial change was made with Rector - thanks to @schreiberten $rectorConfig->ruleWithConfiguration( \Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector::class, [ new \Rector\Renaming\ValueObject\RenameClassAndConstFetch( \PDO::class, 'PARAM_INT', \TYPO3\CMS\Core\Database\Connection::class, 'PARAM_INT' ), .... PDO constants are now solely used within our own Database adapter code. Resolves: #98649 Releases: main, 11.5 Change-Id: I6821093e39fd553ff9589c3740d36f59c1eef51a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76157 Tested-by:
-
Oliver Hader authored
With #85044, HMAC validation for form definitions in the backend form editor was introduced. However, nested multi-valued options have not been signed with corresponding HMAC values - which lead to error messages when persisting the form again in the backend. The exception for `_value` and `_label` (properties used for those multi-valued items) have been removed when generating HMAC values. Resolves: #94106 Resolves: #97235 Related: #85044 Releases: main, 11.5, 10.4 Change-Id: Iaf6798e0f5aa43bdaf90b2c1866745abaab25de1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76165 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Oct 18, 2022
-
-
Elias Häußler authored
This patch adds iterable types to parameters and return types in methods of `TypoLinkCodecService` leading to a better DX. Resolves: #98643 Releases: main, 11.5 Change-Id: Id4d42ec28ae49fdd3cf40322c8563d7c5827426d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76160 Tested-by:
-
Andreas Fernandez authored
The "table" for translated page records is internally identified as "pages_translated". However, the real table name "pages" was used to check the collapse state of the table in the record list module. The correct table identifier is now used to check if a table is collapsed or expanded. Resolves: #98634 Releases: main, 11.5 Change-Id: Iefb3e56228e34759cbddc92d769074579de36f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76152 Tested-by:
-
- Oct 17, 2022
-
-
Andreas Fernandez authored
The contents of a field of type `flex` may be NULL if the field is empty. `BackendUtility::getProcessedValue()` handles the content of such `flex` fields now only if the value is an actual string to solve deprecations related to PHP 8.1. In the same run, the content is trimmed to get rid of lots of empty lines caused by multiline XML data. Resolves: #97297 Resolves: #98595 Releases: main, 11.5 Change-Id: I4261d16bfa819fd1151bbe6905b97f2571701fee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76125 Tested-by:
-
- Oct 15, 2022
-
-
Johannes Przymusinski authored
Resolves: #98607 Releases: main, 11.5 Change-Id: Ib57659fb5e343449de877cf5e78f55c8656bf9e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76070 Tested-by:
-
- Oct 14, 2022
-
-
Elias Häußler authored
Since strict types were enabled for the GeneralUtility class, the `GU::createDirectoryPath()` may throw an exception if `$GLOBALS['TYPO3_CONF_VARS']['SYS']['folderCreateMask']` is not set. This is due to the fact that the fallback value is an integer, whereas the `octdec` function requires a string to be passed. Resolves: #98602 Releases: main, 11.5 Change-Id: I710d28166e3d3d8e76e6125db53ea59e1b4ab26d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76069 Reviewed-by:
-
Felix Nagel authored
Used command(s): > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98603 Releases: main, 11.5 Change-Id: I83aa10d188495fae7a7cac9179ec0c7d362eedcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76068 Tested-by:
-
Stefan Bürk authored
JetBrains created a new product named `Fleet` as lightweight editor. This tool tends to write it's config files to `.fleet/` folders, like all of the IntellJ based IDE's like PHPStorm uses the `.idea` folder. This change adds this config folder to .gitignore to avoid adding this folder to a patch if `Fleet` is used to create a patch. Resolves: #98615 Releases: main, 11.5, 10.4 Change-Id: I4f629a37904c2e9fda57df830377c98a88bec69c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76066 Tested-by:
-
Oliver Klee authored
This update gets rid of some false positives. Run commands: > composer req --dev phpstan/phpstan:^1.8.9 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #98610 Releases: main, 11.5 Change-Id: I65425faaf3c9b0f08bacb6fa56e60b97ca905ed1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76116 Reviewed-by:
-
Karsten Nowak authored
Fix warning if bodyTagCObject is referenced in TypoScript template. Set as empty array. Resolves: #98611 Releases: main, 11.5 Change-Id: Iaf0f3c1ae78386b2e6d5290251246740ee3d7d13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76065 Reviewed-by:
-
- Oct 13, 2022
-
-
Benni Mack authored
This change renames some variables within GeneralUtility::implodeAttributes and adds some first tests to this method. Resolves: #98597 Releases: main, 11.5 Change-Id: I5a667904e7788c76514c4832c197f37b74921bc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76064 Tested-by:
-
- Oct 12, 2022
-
-
Christian Weiske authored
Releases: main, 11.5 Resolves: #98591 Change-Id: I5474e11cd0653b61a1ac2c8725959bc4f1437da4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76063 Tested-by:
-
Benni Mack authored
This change adapts our coding guidelines and rules with PHP-CS-Fixer, allowing for * PER (a.k.a. PSR-12) * no_useless_nullsafe_operator (only use nullsafe if allowed) * only single-spaces in arrays This effectively adapts our code base * use "public const" instead of "const" where visibility is not defined * one whitespace between "declare()" and "namespace" declarations * Use (float) instead of (double) casting * Additional space in annonymous classes (PER) * grouped "use" statements (classes, function, constants) * only one space between items in array lists * Use (bool) instead of (boolean) Resolves: #98585 Releases: main, 11.5 Change-Id: Idb83729d0e4f9dc3c41e4dc5346dab77e6fbce84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76100 Tested-by:
-
- Oct 11, 2022
-
-
Christian Kuhn authored
Resolves: #98404 Releases: main, 11.5 Change-Id: I01f52c45d95f6ff2a56e0a3128f1367dc2a595aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76061 Tested-by:
-
Christian Kuhn authored
Resolves: #98414 Releases: main, 11.5 Change-Id: If29dc5fd03156889ac0d281d5c7b2e5683f708d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76062 Tested-by:
-
Christian Kuhn authored
Resolves: #98582 Releases: main, 11.5 Change-Id: I20116640c9adc44df524b58172913a4d8f8a01ed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76060 Tested-by:
-
Chris Müller authored
Resolves: #98580 Releases: main, 11.5 Change-Id: Ib3ee06cb2849efd8e4cf18fc2497f3c0fed0f752 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76059 Reviewed-by:
-
Benni Mack authored
Change-Id: I87e5976885d5d1862cb742d0ba8855a7912f5ac1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76088 Tested-by:
-
Benni Mack authored
Change-Id: I908c2eb905d4601da7a4737cc6211467384a64e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76087 Tested-by:
-
Stefan Bürk authored
Search- and filter functionaly usually uses `LIKE` or `NOT LIKE` SQL statements to search a provided search term in the database. Different dbms behave differently regarding search term casing. MySQL/MariaDB relies on chosen collation of the database-, table- and/or column level. Typical and recommended defaults on db side and by TYPO3 default settings are case-insensitive collations, which is the most common spread configuration. Based on this, most people assume search terms are searched case-insensitive, when using `LIKE` or `NOT LIKE` SQL statements. PostgresSQL on the other hand knows the keywords `LIKE` and `ILIKE`. The `ILIKE` keyword has to be used, when a case-insensitive search is wanted. The current implementation simply uses `LIKE` for all dbms, so searching with postgres is case sensitive, while it is usually case insensitive with MySQL/MariaDB. SQLite states `LIKE` is case-insensitive, which is basically correct. The limitation is, this only works for the 26 chars in the ASCII charset range, and not only for `LIKE` but also for the `UPPER()` and `LOWER()`. There should be a way to compile php extension sqlite with ICU support, enabling case awareness for more chars, but that's nothing we can expect people do and have by default. We cannot do much, so we leave some notes in the code regarding this detail. The patch changes ExpressionBuilder to use ILIKE on PostgresSQL to be in-line with the default MySQL/MariaDB behavior. Resolves: #98570 Releases: main, 11.5 Change-Id: I5a586a4bf46ee1b4699f4223fd4b19a0b9ae453b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76085 Tested-by:
-
Christian Kuhn authored
Obvious hardening of an array access. Resolves: #98469 Releases: main, 11.5 Change-Id: Ie4e083b0ff50de4e2fbabf4bdfd47753d29bd06d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76058 Tested-by:
-
Christian Kuhn authored
Harden GeneralUtility::explodeUrl2Array() and increase test coverage. Change-Id: I3136a27572414810989c038b78bd0f362cc64c65 Resolves: #98537 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76057 Tested-by:
-
Anja Leichsenring authored
Resolves: #98559 Releases: main, 11.5 Change-Id: Ifa5c3ac6997545a79c7306ff9a3afc0d97675dec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76083 Tested-by:
-
Simon Schaufelberger authored
Resolves: #98539 Releases: main, 11.5 Change-Id: I1a9943316a7d8d657b2e64cc704ae52943a89b40 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76056 Tested-by:
-
- Oct 10, 2022
-
-
Georg Ringer authored
Invalid HTML must not produce notices in backend or frontend. Resolves: #98513 Releases: main, 11.5 Change-Id: I6aca14d97318b292616a5a4670150263a2c7ec69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76076 Tested-by:
-
Stefan Bürk authored
PostgresSQL is really picky about types and used operators. Thus using for example a `like` comparision on non string/text based fields fails hard. Database errors like following indicates this issue: > Undefined function: 7 ERROR: operator does not exist: > smallint ~~ unknown This changes implicit converts field data to a text representation for PostgresSQL, if field is not compatible. In case of small/tinyint fields a double cast is used, means casting to integer and then to string before applying the like comparison on it. The choosen solution is used to have a comparible behaviour against the other supported dbms systems like MariaDB, MySQL and SQLite, also doing a full search on all fields may be a bad decision. The whole search and full-search across all types should be reconsidered generally. Resolves: #98563 Releases: main, 11.5 Change-Id: I4dde0e49bf8fd68a01b50aeabc12c24398fb6ac9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76055 Tested-by:
-
