[TASK] Avoid direct usages to Doctrine/DBAL and ext-pdo
This change modifies most of the userland code to use a) Connection::PARAM_* constants instead of \PDO::PARAM_* constants This is due to also another change from Doctrine DBAL 3 https://github.com/doctrine/dbal/blob/3.4.x/UPGRADE.md#bc-break-the-pdo-symbols-are-no-longer-part-of-the-dbal-api which can easily be changed in TYPO3's Source Code to ensure easy upgrade paths and showing best practices for extension authors looking into TYPO3 Source Code b) Avoid using constants from \Doctrine\DBAL\Connection but use our own constants. Even though Doctrine DBAL 3.x introduces "ParameterType" objects, we use our own connection implementation for the time being as we also seek to backport such changes in TYPO3 v11. The initial change was made with Rector - thanks to @schreiberten $rectorConfig->ruleWithConfiguration( \Rector\Renaming\Rector\ClassConstFetch\RenameClassConstFetchRector::class, [ new \Rector\Renaming\ValueObject\RenameClassAndConstFetch( \PDO::class, 'PARAM_INT', \TYPO3\CMS\Core\Database\Connection::class, 'PARAM_INT' ), .... PDO constants are now solely used within our own Database adapter code. Resolves: #98649 Releases: main, 11.5 Change-Id: I6821093e39fd553ff9589c3740d36f59c1eef51a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76157 Tested-by:core-ci <typo3@b13.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Benni Mack <benni@typo3.org>
Showing
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php 20 additions, 19 deletions...3/sysext/backend/Classes/Authentication/PasswordReset.php
- typo3/sysext/backend/Classes/Backend/Avatar/DefaultAvatarProvider.php 5 additions, 4 deletions.../backend/Classes/Backend/Avatar/DefaultAvatarProvider.php
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php 6 additions, 6 deletions...t/backend/Classes/Backend/Shortcut/ShortcutRepository.php
- typo3/sysext/backend/Classes/Clipboard/Clipboard.php 4 additions, 3 deletionstypo3/sysext/backend/Classes/Clipboard/Clipboard.php
- typo3/sysext/backend/Classes/Configuration/TranslationConfigurationProvider.php 5 additions, 4 deletions...lasses/Configuration/TranslationConfigurationProvider.php
- typo3/sysext/backend/Classes/Controller/ContentElement/ElementInformationController.php 6 additions, 6 deletions...ontroller/ContentElement/ElementInformationController.php
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php 12 additions, 11 deletions...ext/backend/Classes/Controller/EditDocumentController.php
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php 3 additions, 2 deletions...nd/Classes/Controller/Page/NewMultiplePagesController.php
- typo3/sysext/backend/Classes/Controller/Page/SortSubPagesController.php 2 additions, 1 deletion...ackend/Classes/Controller/Page/SortSubPagesController.php
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php 15 additions, 14 deletions...ysext/backend/Classes/Controller/PageLayoutController.php
- typo3/sysext/backend/Classes/Domain/Repository/Localization/LocalizationRepository.php 12 additions, 12 deletions...Domain/Repository/Localization/LocalizationRepository.php
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php 3 additions, 2 deletions.../backend/Classes/Form/Container/InlineRecordContainer.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractDatabaseRecordProvider.php 2 additions, 1 deletion.../Form/FormDataProvider/AbstractDatabaseRecordProvider.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php 3 additions, 3 deletions...nd/Classes/Form/FormDataProvider/AbstractItemProvider.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/DatabasePageLanguageOverlayRows.php 2 additions, 1 deletion...Form/FormDataProvider/DatabasePageLanguageOverlayRows.php
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaInputPlaceholders.php 1 addition, 1 deletion...nd/Classes/Form/FormDataProvider/TcaInputPlaceholders.php
- typo3/sysext/backend/Classes/History/RecordHistory.php 8 additions, 7 deletionstypo3/sysext/backend/Classes/History/RecordHistory.php
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php 4 additions, 4 deletions...3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php
- typo3/sysext/backend/Classes/Security/CategoryPermissionsAspect.php 2 additions, 1 deletion...xt/backend/Classes/Security/CategoryPermissionsAspect.php
- typo3/sysext/backend/Classes/Security/FailedLoginAttemptNotification.php 4 additions, 3 deletions...ckend/Classes/Security/FailedLoginAttemptNotification.php
Please register or sign in to comment