- May 12, 2017
-
-
Benni Mack authored
The main $GLOBALS['LANG'] class has been moved to the core extension into the "Localization" namespace, where all other related XLF/XML factory, store and parser classes reside. This is done in order to streamline the localization of core-relevant files, since this class will also be used in frontend context. EXT:lang now contains the backend module, as well as most XLF files. Resolves: #81196 Releases: master Change-Id: I0e5d8260f5c5a28254658c68766990b4f4662a2a Reviewed-on: https://review.typo3.org/52774 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 06, 2017
-
-
Christer Vindberg authored
Changed so doctrine constraints without the corresponding bind values aren't passed around. The $constraints variable defined in CleanerTask->cleanTable is reused in CleanerTask->deleteFilesForTable, but without the doctrine createNamedParameter bind variables, since the querybuilder is recreated. This caused the task to fail. Resolves: #80675 Releases: master Change-Id: I2da9b33f884f51bf9d90a9d08841fb4491eedea2 Reviewed-on: https://review.typo3.org/52362 Tested-by:
Thomas Hohn <thomas@hohn.dk> Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
- Mar 28, 2017
-
-
Wouter Wolters authored
The TYPO3 Core currently has no guidline how to handle phpdoc comments regarding @return annoations related to "void" and "null". In practice, these annotations have no additional value if no additional documentation is given. With this change, the php-cs-fixer will remove any unnecessary linebreaks within the comments above the @return annotation, as well as remove completely empty phpdoc comments because the @return annotation is removed. Please be aware, that once PSR-5 is accepted, this coding standard within the TYPO3 Core will change again, where there are currently some further proposal details like inheritance information. Resolves: #80454 Releases: master Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04 Reviewed-on: https://review.typo3.org/51686 Reviewed-by:
Nicole Cordes <typo3@cordes.co> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
- Feb 24, 2017
-
-
Morton Jonuschat authored
Deprecate BackendUtility::getRecordsByField() as it has a flawed design due to passing SQL fragments. This contradicts the goal of using named parameters for all queries in the core and requires passing the original QueryBuilder object in addition to the stringified constraint. Replace all calls to the method with direct usage of the QueryBuilder and deprecate the method. Resolves: #79122 Releases: master Change-Id: I8b040b98e20271aff84ef16fb89b59a406d54003 Reviewed-on: https://review.typo3.org/51078 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 17, 2017
-
-
Morton Jonuschat authored
Enforce consistent ordering of deleted records. Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6 Resolves: #79800 Releases: master Reviewed-on: https://review.typo3.org/51732 Tested-by:
Daniel Goerz <ervaude@gmail.com> Reviewed-by:
-
- Dec 03, 2016
-
-
Manuel Selbach authored
According to task #78437 queries should follow the prepared statement principle. Thus method BackendUtiltiy::getRecordsByField() has to be refactored to retrieve a queryBuilder which holds the parameter assigned to e.g. additional where clause, etc. otherwise the parameter and the dynamically generated placeholders in the queryQuilder will be reset. Change-Id: Id66d7b2fcfc5bcdca4d920b645c2285ded0c160a Resolves: #78704 Releases: master Reviewed-on: https://review.typo3.org/50664 Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Oct 26, 2016
-
-
Manuel Selbach authored
To remove the susceptiblity to errors of SQL injections within the core the principle of prepared statements should be followed for all queries. Even variables which will be casted to e.g. an integer should use setParameter(), setParameters() or createNamedParameter(). Change-Id: I7d6d256a199ba05f75791eb01f38b3b89b421989 Resolves: #78437 Releases: master Reviewed-on: https://review.typo3.org/50090 Tested-by:
-
- Sep 01, 2016
-
-
Georg Ringer authored
The optional arguments of RecyclerUtility::getRecordPath are not used anymore and are deprecated. Resolevs: #75637 Releases: master Change-Id: I30b3c3d05ebf9b4961060106b4a02d5c7a4a5089 Reviewed-on: https://review.typo3.org/49682 Tested-by:
Bamboo TYPO3com <info@typo3.com> Reviewed-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
-
- Aug 30, 2016
-
-
Wouter Wolters authored
As decided during T3ACME we will use the short array syntax in master. The 7.6 branch will also be done to make backporting easier. Resolves: #77692 Releases: master,7.6 Change-Id: I37e9484b1012fc9161148257a842054c24d162ba Reviewed-on: https://review.typo3.org/49651 Reviewed-by:
-
- Aug 22, 2016
-
-
Georg Ringer authored
To be in sync with all other modules, the recycler button in the toolbar is moved to the right. Resolves: #77570 Releases: master, 7.6 Change-Id: I6d681239d1d9dc10be356b576c0ac9cb1315a187 Reviewed-on: https://review.typo3.org/49541 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
- Jun 03, 2016
-
-
Helmut Hummel authored
To make the set of restrictions that are in effect when creating queries with the QueryBuilder becomes more understandable, we need to remove the QueryContext and the magic applied to that and replace it with the following behavior: delete, hidden, starttime, endtime restrictions are always enabled and need to be removed if needed. Other restrictions need to be provided manually depending on the desired result. Resolves: #76167 Resolves: #76264 Releases: master Change-Id: Iaf0cb08475ed44966838c3fbdd5756d3ba6ebcc1 Reviewed-on: https://review.typo3.org/48049 Tested-by:
Helmut Hummel <helmut.hummel@typo3.org> Reviewed-by:
-
- May 28, 2016
-
-
Valentin Despa authored
Remove the second parameter of sL and replace it with htmlspecialchars directly in the code. Resolves: #76325 Related: #71917 Releases: master Change-Id: I6668eea01d80446a6b6f2ec95435c6e3d93cb0c3 Reviewed-on: https://review.typo3.org/48346 Reviewed-by:
-
- May 05, 2016
-
-
Michael Oehlhof authored
Resolves: #75718 Releases: master Change-Id: I27a14e694cd17132bf71d2687b8ea2366409fa27 Reviewed-on: https://review.typo3.org/47763 Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
- Apr 27, 2016
-
-
Michael Oehlhof authored
Resolves: #75636 Releases: master Change-Id: I49611c3d0e6a0ec56e05871c5beb7f7de4bce949 Reviewed-on: https://review.typo3.org/47682 Reviewed-by:
-
- Apr 19, 2016
-
-
Morton Jonuschat authored
This name change transports the intent of the query context better and makes it more intuitive to use. Instead of explicitly disabling all enable fields and the deleted flag using the following code: $queryBuilder->getQueryContext() ->setIgnoreEnableFields(true) ->setIncludeDeleted(true); the more descriptive predefined context can be used: $queryBuilder->getQueryContext()->setContext('unrestricted') Releases: master Resolves: #75751 Change-Id: I4d38a328c2b6707a32f26022b4abfc48e945c0ed Reviewed-on: https://review.typo3.org/47759 Reviewed-by:Andreas Fernandez <typo3@scripting-base.de> Reviewed-by:
Susanne Moog <typo3@susannemoog.de> Tested-by:
-
- Apr 18, 2016
-
-
Michael Oehlhof authored
Resolves: #75717 Releases: master Change-Id: I210f838568c47469eb9926b7b4b6774578a28732 Reviewed-on: https://review.typo3.org/47733 Reviewed-by:
-
Michael Oehlhof authored
Resolves: #75713 Releases: master Change-Id: Ia82c7055e71ec154264f6b658addf49c5f9187a5 Reviewed-on: https://review.typo3.org/47730 Reviewed-by:
-
- Jan 16, 2016
-
-
Bernhard Kraft authored
When using the recycler as normal user (non admin) it isn't possible to restore any pages as the underlying BE API methods by default only allow to check for access to non-deleted pages. This situation is circumvented by disabling the "delete" flag in TCA while checking for access to deleted pages. Resolves: #70863 Releases: 7.6, master Change-Id: Ibf6ff305a6dbcf3eaf99fdca89b7bf7c78677319 Reviewed-on: https://review.typo3.org/45292 Reviewed-by:
-
- Jan 14, 2016
-
-
Andreas Fernandez authored
If enabled for an user or being an admin, deleted pages above the selected item are also recovered. If an user does not have this ability, the recover button is locked. Resolves: #1835 Releases: master Change-Id: I98d9876ee95f36cda64fc0730169197b153a2e7f Reviewed-on: https://review.typo3.org/36744 Reviewed-by:
-
- Dec 21, 2015
-
-
Benni Mack authored
The recycler module handles conversions to UTF8 and to other charsets, although the backend is solely UTF-8 since TYPO3 4.5. The logic and the according functions have been removed as they have no effect and only add complexity to code and slows down processing. Resolves: #72334 Releases: master Change-Id: Ifdae4a494e84dec1a7c42e96f36e48ecbf840ff3 Reviewed-on: https://review.typo3.org/45373 Reviewed-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
- Nov 29, 2015
-
-
Nicole Cordes authored
Multiple button settings are double encoded with htmlspecialchars. This patch removes the hsc within the setters as the button settings are already escaped during render method. Resolves: #71915 Releases: master Change-Id: I470b6e4ce42859d4147e21acf9e7b6334a776848 Reviewed-on: https://review.typo3.org/45014 Reviewed-by:
-
- Nov 22, 2015
-
-
Michael Oehlhof authored
Resolves: #71768 Releases: master Change-Id: I6527ccb5bbb11817989c7c9f6ba1ee3da9812e14 Reviewed-on: https://review.typo3.org/44888 Reviewed-by:
-
- Nov 20, 2015
-
-
Wouter Wolters authored
Resolves: #71726 Releases: master Change-Id: I4a356c8da668acee555149eee9cf56ccdb4dc0ee Reviewed-on: https://review.typo3.org/44822 Reviewed-by:
-
- Nov 08, 2015
-
-
Helmut Hummel authored
* Reverts the change that allowed HTML tags by default in flash messages * Simplifies flash message markup to be bootstrap alert style * Delegate flash message rendering completely to module template * Deprecate render method in flash message * Minor cleanups in flash message view helper and flash message class Resolves: #71249 Releases: master Change-Id: Idbb4bc31372fbc435519496168715e0bcc5cebf2 Reviewed-on: https://review.typo3.org/44592 Reviewed-by:
-
- Oct 13, 2015
-
-
Mathias Schreiber authored
With the introduction of the new Button types HelpButton and ShortcutButton we no longer need to use FullyRenderedButtons in the core thus changing all old code to use the new Button types Resolves: #70653 Releases: master Change-Id: Ie89cc2e2154af9a117f084ec8551192ffe4d6ef9 Reviewed-on: http://review.typo3.org/44032 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
- Oct 09, 2015
-
-
TYPO3 Release Team authored
In our efforts to achieve a better interoperability with other PHP projects, the PHP code base of the TYPO3 Core switches to the PHP coding guideline standard PSR-2. See http://www.php-fig.org/psr/psr-2/ for more information. Resolves: #70515 Releases: master Change-Id: I734c0d838af157003decfeb5fc0a11dddcb87bf5 Reviewed-on: http://review.typo3.org/43918 Reviewed-by:
TYPO3 Release Team <typo3cms@typo3.org> Tested-by:
-
- Oct 05, 2015
-
-
Michael Oehlhof authored
Resolves: #70367 Releases: master Change-Id: I5861cd2de035e2b730aca2f40adf74ff913a7d95 Reviewed-on: http://review.typo3.org/43803 Reviewed-by:
Benjamin Kott <info@bk2k.info> Tested-by:
-
Benjamin Mack authored
The AjaxRequestHandler now first checks in the Router if an AJAX route exists. A new flag "ajax" in the routing mechanism allows to call ajax-based URLs which are then handed to the AJAX Request Handler. All controllers now receive proper Request and Response objects. All previous logic still works, but can slowly be migrated to the Routing concept. Resolves: #69916 Releases: master Change-Id: I1e67d5a341a4dd2769247531246c9e1fad900c76 Reviewed-on: http://review.typo3.org/43365 Reviewed-by:
-
- Sep 22, 2015
-
-
Frank Nägler authored
Deprecate the IconUtility class from EXT:backend and handle its calls using the new IconFactory from EXT:core. Kudos to Benjamin Kott, Stephan Großberndt, Andreas Fernandez and Frans Saris for the great support on this big project. Resolves: #69057 Releases: master Change-Id: I27a045b7a3b9d31e6e3e915e1452d44af56b0cee Reviewed-on: http://review.typo3.org/42613 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
-
- Sep 20, 2015
-
-
Stephan Großberndt authored
Implement replacement and replace all core usages of IconUtility::getSpriteIconForRecord() with IconFactory->getIconForRecord(). Register and fix several icon definitions for core tables. Resolves: #69754 Releases: master Change-Id: I5adf4f58a0331c77458049e19c7c8ca441b9e4cf Reviewed-on: http://review.typo3.org/43272 Reviewed-by:
-
- Jul 15, 2015
-
-
Markus Klein authored
@author information can be found in version control. Cluttering our code with these tags does not make much sense and they are outdated by definition or would sum up to impressive lists. As decided on acme 2015, we drop them now. Releases: master Resolves: #68152 Change-Id: Iec1ea0f873b44ab6027c94ba8353a9fdb5477bdd Reviewed-on: http://review.typo3.org/41264 Reviewed-by:
-
- Jul 14, 2015
-
-
Nicole Cordes authored
The PageRenderer is a Singleton and only one instance exists during runtime. This patch cleans up the usage and prevents sharing the PageRenderer object over public getters. This helps to improve the api and get rid of unnecessary functions. Releases: master Resolves: #68074 Change-Id: I66abd565df96ff0b8fb31d24a04721ca8ecb3f3a Reviewed-on: http://review.typo3.org/41131 Reviewed-by:
-
- Jul 13, 2015
-
-
Stefan Neufeind authored
The usage of the ternary operator just for conversion to boolean like ... ? TRUE : FALSE is be replaced by a normal (bool) typecast. Change-Id: Ia32f63b423ffa7e066c9cf8bb002dde51b419bfa Resolves: #68063 Releases: master Reviewed-on: http://review.typo3.org/41110 Reviewed-by:
-
- Mar 26, 2015
-
-
Benjamin Mack authored
Resolves: #65292 Releases: master Change-Id: Ib94e59bf5d9896186aa6923eab50a2236308bd6a Reviewed-on: http://review.typo3.org/38113 Reviewed-by:
-
- Mar 15, 2015
-
-
Andreas Fernandez authored
The used bitmasks of JsConfirmation and Permission are put into "enums" and their representing constants are used instead of the raw bitmask values. Resolves: #65455 Releases: master Change-Id: I1910bb960b69836ea29c16c91d730ac74c22f929 Reviewed-on: http://review.typo3.org/37455 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Frank Nägler <typo3@naegler.net> Tested-by:
-
- Mar 10, 2015
-
-
Nicole Cordes authored
Due to a wrong language file path no setting information for the CleanerTask of the recycler are shown. Releases: master Resolves: #65647 Change-Id: I21b45a0efd1e9c03d4b6bae6475826ac55262b6f Reviewed-on: http://review.typo3.org/37713 Reviewed-by:
Steffen Müller <typo3@t3node.com> Tested-by:
Markus Klein <klein.t3@reelworx.at> Tested-by:
-
- Mar 06, 2015
-
-
Andreas Fernandez authored
Fix two broken tasks in the scheduler: "Remove deleted records" from EXT:recycler refers to the right xlf now. "System Status Update" belongs to EXT:reports again Resolves: #65558 Releases: master Change-Id: I50319632f1a26cd48f36b1ec872d8cf04da8992b Reviewed-on: http://review.typo3.org/37583 Reviewed-by:
-
- Mar 02, 2015
-
-
Philipp Bergsmann authored
Scheduler task to remove deleted records from content table(s) which are older than x days. If a deleted record also contains an upload field, then the file is also deleted. Releases: master Resolves: #32651 Change-Id: I58577c05a1a3b228579c05578cc8fdf2e3b393fa Reviewed-on: http://review.typo3.org/9013 Reviewed-by:
-
Frederic Gaus authored
Rename label "table" to "record type" in recycler Change-Id: I81226203e3bcb705320563bc508d74f69d8142c1 Resolves: #43368 Releases: master Reviewed-on: http://review.typo3.org/36710 Reviewed-by:
Andreas Fernandez <andreas.fernandez@aspedia.de> Tested-by:
-
- Feb 06, 2015
-
-
Andreas Fernandez authored
This patch improves the usability and fixes a small bug: - Add the clearable to the search form - Count deleted records correctly Resolves: #64911 Releases: master Change-Id: I0fc702697ce1c630d39f6b127f605c9d8aa5afb4 Reviewed-on: http://review.typo3.org/36716 Reviewed-by:
Mathias Schreiber <mathias.schreiber@wmdb.de> Tested-by:
-
