- Feb 25, 2023
-
-
calien666 authored
This change ensures that the original language record diff source (usually in the field l10n_diffsource as configured by transOrigDiffSourceField) is set correctly as soon as a localized record is created. To guard this, an additional test for pages is added, and several DataHandler tests are adjusted. TYPO3 displays the source language value of a field for a translated record. This information field can display a diff, if the source record value was changed. To accomplish this a shadow copy of localizable fields from the source language record is saved in the configurable language diff source field. Localization of a record creates a new record, adding the values of localizable fields value with a prefix and setting needed system fields like parent record id, language id and so on. This is updated if a localized field is changed in the localized language. `\TYPO3\CMS\Core\DataHandling\DataHandler` as the main actor in the backend is responsible for maintaining this source diff field along with other tasks. Due to an oversight, the source language record data was not set during record localization. Because of this, the field source display did not work until the localized record was saved again. This probably went undetected because in normal editorial work the record would be changed straight away. Extension authors using DataHandler hooks can influence which data is written, for example using translation tools and databases to localize records automatically during the translation process. Therefore, it is not really mandatory to change the value afterwards. In the past, that practice lead to a broken and invalid source diff field. The issue existed for pages and other records in the same way. Resolves: #99985 Releases: main, 11.5 Change-Id: I47d5262dfbcaaa1fa5108e950308f72319c41b5b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77895 Tested-by:
Sybille Peters <sypets@gmx.de> Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
-
- Feb 24, 2023
-
-
Thomas Hohn authored
Added a coalescing operator before accessing the value of $wrapper['showResultsNumbersWrap']. Resolves: #100024 Releases: main, 11.5 Change-Id: I166d8e300cc931f8d1788ef19954b55eab66f7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77942 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Thomas Hohn authored
Added string cast before trimming $typoLink. Changed annotation to be string|null. With TYPO3 v13 string should be added to the methods signature and cast removed. In addition fixed some potential calls that could have sent null to the method, prophylactically. Resolves: #99975 Releases: main, 11.5 Change-Id: I8cbafa51d96e3ab35d39855831803897b4ff0035 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77887 Tested-by:
Marc Willmann <mw@f7.de> Reviewed-by:
Kevin Appelt <kevin.appelt@icloud.com> Reviewed-by:
Kay Strobach <typo3@kay-strobach.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benjamin Kott authored
This patch drops the dedicated resource rename view and moves it to a modal view instead. Resolves: #100001 Releases: main Change-Id: I9d0ca07ddb6cdfda72cb9aaf15a6a0d52e543d35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77849 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Thomas Hohn authored
In the method getWordPairsForLineBreak, there is a missing coalescing operator around $wordsArray[$index + 1]. In the last iteration for uneven values of $wordsCount it will be undefined. Resolves: #100006 Releases: main, 11.5 Change-Id: I624bf444b10a595c99bfc0cd19cd4f72692155cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77924 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org>
-
- Feb 23, 2023
-
-
Andreas Fernandez authored
The eslint plugins `eslint-plugin-lit` and `eslint-plugin-wc` are installed and configured to help avoiding common issues when developing web components. These rules already revealed issues in our codebase that are now fixed. The most important ones are listed below: `lit/no-native-attributes`: Using native HTML attributes as web component attributes may cause side-effects, like `title` which renders a tooltip on hover. `lit/prefer-nothing`: It's preferred to return `nothing` instead of empty templates for performance reasons. `wc/require-listener-teardown`: To avoid memory leaks, any attached event listener in a web component must be detached again once the element is destroyed. Resolves: #100018 Releases: main Change-Id: I4a1197d5ca741a5683b4d21f84a87bdaf43241db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77937 Tested-by:
-
Markus Klein authored
Move the file_exists checks around to execute those only if really needed. The bootstrap methods are executed whenever the Core does any action, so its footprint should be as slim as possible. Resolves: #100013 Related: #99744 Releases: main Change-Id: I7d947c5d5b5aab52fec2610a7e6f9a030d1080c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77929 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Markus Klein authored
If, for whatever reason, the avatar image is not available, its publicUrl is null. This value can't be processed in the avatar environment. Resolves: #100020 Releases: main, 11.5 Change-Id: I111ec90af23208c69d76eac6ff17ad05db0d687f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77938 Tested-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Benjamin Kott authored
Resolves: #99983 Releases: main Change-Id: I160292295b0be648c1882bd58a5e504a1d10e5d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77892 Reviewed-by:
-
Thomas Hohn authored
Only set X-Mailer header if not already set. Resolves: #100016 Releases: main, 11.5 Change-Id: I78b1fcc6769420ccfd3f6a31cdf73374a0805c45 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77934 Reviewed-by:
-
Oliver Bartsch authored
Resolves: #99994 Releases: main, 11.5 Change-Id: I82955eae0675820355798df99e698db692f7d8ac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77932 Reviewed-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Andreas Fernandez authored
The configuration for interactjs used in the page module is adjusted to allow dragging only with a content element's header as previously done in TYPO3 <12. Resolves: #99313 Releases: main Change-Id: I77d421fd541f3a46548d50bd89173b7f43fb08a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77918 Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Andreas Fernandez authored
Resolves: #100014 Releases: main Change-Id: If42d5b06fb239f9c3c69316d381d2323dfe64d91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77930 Tested-by:
-
Oliver Hader authored
Using an HTTP header like `Cookie: 1=string` results in having a numeric key in the super-global $_COOKIE array. Resolves: #100012 Releases: main Change-Id: Ie50d8176e48796ef46dfd79d328c7ccd75a03ae8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77927 Tested-by:
-
- Feb 22, 2023
-
-
Josef Glatz authored
This patch takes care of migrating a legacy AdditionalConfiguration.php even if a settings.php is already present. It extends the change from the former patch of issue #98319 and follows its ChangeLog documentation. Such a scenario is noticeable, for example, during the installation process under DDEV and TYPO3 12.x / main. Another scenario could be upgrading from an older TYPO3 major version. A similar scenario is the usage of an existing (legacy) TYPO3 project boilerplate file structure. Similar to the handling of LocalConfiguration.php, AdditionalConfiguration.php is also automatically migrated from now on. Resolves: #99744 Related: #98319 Releases: main Change-Id: I7c08543421504b0145263ff92c05bd9e8408a232 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77634 Tested-by:
-
Oliver Bartsch authored
The PreviewUriBuilder is used in the backend to generate frontend URLs. Besides passing the exact page id, it's also possible to pass the default page id and the desired language id. In such cases, the PageRouter is responsible to resolve the id of the translated page. This is internally done, using the PageRepository. However, due to a missing visibility context does the PageRepository apply the whole FrontendRestrictionContainer, including start- and endtime restrictions. This is now fixed by passing a backend specific visibility aspect to the PreviewUriBuilder. Resolves: #100008 Releases: main, 11.5 Change-Id: Ieacca442588612491f0b3f0d80b30fa64f902e7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77917 Reviewed-by:
-
Oliver Bartsch authored
Defined HTTP methods in module configurations are now properly added to the corresponding routes. Previously they were just passed as route options, which however does not work as the HTTP method is an own property of Route. Additionally, the site configurations' sub module "delete" is now always called via POST, as defined in the module configuration. Resolves: #99984 Releases: main Change-Id: Ie562e99e6ef0de4920e6116fdc494e1560b46cbb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77893 Tested-by:
-
Oliver Klee authored
The new version finds new problems. > composer req --dev phpstan/phpstan:^1.10.1 > composer req --dev phpstan/phpstan-phpunit:^1.3.7 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #100007 Releases: main, 11.5 Change-Id: I6e76d4f01dc4f8d0b61f76d57b7c83fe3faadc8b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77919 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Feb 21, 2023
-
-
Benjamin Kott authored
Resolves: #100003 Releases: main Change-Id: If37327b1fa27ddf8f31d6b38d998a1016e99f706 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77916 Tested-by:
-
Oliver Bartsch authored
This reverts commit 7e10d6b5. Reason for revert: PageRepository->getPageOverlay() applies frontend access restrictions, which are wrong in this context, and which can not be skipped. Additionally, the WorkspaceRestriction is not applied. Resolves: #99992 Related: #99613 Releases: main, 11.5 Change-Id: I032f50b6465fbe2c3bf157cd13b9e99e558084db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77759 Tested-by:
-
Andreas Fernandez authored
This patch updates vulnerable JavaScript components identified by `npm audit`. Executed commands: npm audit fix npm run build Resolves: #99982 Releases: main, 11.5, 10.4 Change-Id: I383fc39e27faed18c659b7269cb0a0152184fee7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77891 Tested-by:Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Benjamin Kott authored
The link binding of the system information menu messages reuses module menu identifiers but does not embrace them to avoid additional attributes on links. We reworked the message link binding to make it independent from existing link binding and avoid further conflicts. Instead of refreshing the link bindings after each data fetch, we are moving the registration for the link click handler to the static parent element. The link binding now keeps intact after fetching new data. We currently dont have an encapsulated component for the system information menu. To avoid nested document queries we are hardening the selectors for now. In this step we are also removing jQuery from the system information menu, as there is no use for this here anymore. Resolves: #99961 Releases: main Change-Id: Id312ccc43559d6f630877254bdd09d2d1ed08038 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77868 Tested-by:
-
- Feb 20, 2023
-
-
Andreas Fernandez authored
JavaScript has a native Set() object that ensures uniqueness of values by design and is therefore faster than any custom uniqueness implementation. The Install Tool had an obvious implementation that is superseded by `Set()`, being several milliseconds faster, depending on the client's CPU. Resolves: #99987 Releases: main, 11.5 Change-Id: I6b566b97c70b241070b78b841350a6b21b64a5a6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77897 Tested-by:
-
- Feb 17, 2023
-
-
Oliver Klee authored
For strings, `trim($value) === ''` will always be true for empty strings. So an additional check for `$value` being empty is not needed. Resolves: #99897 Releases: main Change-Id: Id280cbaac38bd98447d087126025616b9379d722 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77801 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Benni Mack authored
This change uses the Locale object and its internal normalization process to automatically set the <html> tag within the PageRenderer. This change removes the usage of the Typo3Language "default" in PageRenderer. Resolves: #99927 Releases: main Change-Id: I45bb0985935231bdcaa4c91d712477bfc7823ae0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77827 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Reviewed-by:
-
Benjamin Kott authored
While reworking the filelist, a wrong identifier was used to trigger the meta data editing interface. We are now using the meta data identifier instead of the file resource identifier. Resolves: #99977 Releases: main Change-Id: I5e02cb989935f2d2e213d82d76dbf75fab5a994a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77886 Tested-by:
-
Andreas Fernandez authored
The current search providers accidentally passed a nested array into `PageRepository->getFlattenedPages()`, leading to issues when resolving web mounts. This issue is fixed and a new phpstan annotation helps to avoid this issue in the future. Resolves: #99971 Releases: main Change-Id: I7926e100d9067366be1699c348ba61bdd9904be9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77879 Reviewed-by:
-
Benjamin Kott authored
The dropdown component is completly based on css variables, this patch removes hardcoded colors. We are introducing a new link color css variable that can be used for general link styling within adaptive components. Resolves: #99959 Releases: main Change-Id: I7cd07c72d483ed5e7ba4b31ee69d7fd01b5be8b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77866 Tested-by:
-
- Feb 16, 2023
-
-
Jan Delius authored
This change corrects the behaviour of the path output in the Install Tool for the file "ENABLE_INSTALL_TOOL". The actual file name is removed in order to restore the behaviour from before and to make the information text meaningful. Resolves: #99951 Releases: main Change-Id: Ie62784c423cea7a9f8312c21b2c7a49f2a056ad2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77854 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
Especially the "uid" might contain special characters as it holds the combined identifier in case of e.g. folders. Encoding this value is therefore necessary to prevent JS errors on executing the corresponding AJAX request. Resolves: #99893 Releases: main, 11.5 Change-Id: I6f00a23a34497b65f2ed915f76f1e40b3699792a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77881 Reviewed-by:
-
Christoph Lehmann authored
Using the cli command `cleanup:deletedrecords` to clean up the database periodically is not really possible with an installed EXT:recycler, because all records marked for deletion are deleted immediately and thus the recycler seems less useful. The new option `--min-age` added to the `cleanup:deletedrecords` cli command allows to define a minimum age of X days a record needs to be marked as deleted before it gets deleted. Resolves: #99258 Releases: main Change-Id: If9daa0e7266868ee14ad9282e4997031b85c80b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76912 Reviewed-by:
-
Benjamin Kott authored
The install tool router and the backend router share identifiers and selectors. We are now introducing dedicated identifiers for the install-tool, to make it clear that the install router is handling the requests. Resolves: #99965 Releases: main Change-Id: Ic738911bf82ec0fb7af89421c3bd7db3ca565434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77872 Tested-by:
-
Benjamin Kott authored
This patch scopes the handling of module links within the module menu and toolbar. We are now differentiating between module menu events and module link events and avoiding the double usage of data attributes to have the scope of the data-attributes assigned. The internal selectors are now using on data-attributes, this provides various benefits in contrast to legacy `t3js-...` class based selectors. - Attributes can contain additional values we need for processing - We avoid conflicts with for example `*:not([class])` CSS selectors, this is helpful to identify links that need special treatment for example color adjustments within adaptive components like the dropdowns. While the module menu in its current state still handles the module links, this patch prepares future work to extract the link management. Managing the module links in the backend should not be the responsibility of the module menu. We are removing all "id" attributes attached to links to avoid conflicts with other existing identifiers in the backend. The processing has been adjusted to support this change. The keyboard navigation is now simplified and adjusted when leaving a subgroup the selection is now correctly at the parent element and not the previous parent element. Resolves: #99972 Releases: main Change-Id: Ieb87942fc73cab7679c7af939b2a1a247907b6d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77855 Tested-by:
-
Andreas Fernandez authored
With #98604, jQuery UI was replaced with SortableJS. It turns out that filtered element, where dragging should be disabled, also calls `preventDefault()` by default, leading to the issue that text fields cannot get focused anymore. As documented by SortableJS, `preventOnFilter` is now set to `false` to allow editing text fields again whilst disabling dragging their parent container. Resolves: #99736 Related: #98604 Releases: main Change-Id: I047cbe19a472e611cc5febaf29bb37f2ee1b7dc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77882 Reviewed-by:
-
Christian Kuhn authored
The request is always set to FormRuntime after creating the object. We can safely avoid the access to $GLOBALS['TYPO3_REQUEST'] by using $this->request. Resolves: #99969 Releases: main Change-Id: I593a959ec8d5996d804b67c2fd722e1c8d4535c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77877 Tested-by:
-
Christian Kuhn authored
A warmup patch preparing more work in this area: * Remove unused property * Private over protected * Comments * Property type hints Resolves: #99963 Releases: main Change-Id: I9159124942099ceb0238cc7d319f39d5aa622c7e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77870 Tested-by:
-
Benjamin Kott authored
When loading the typo3-backend-tree-toolbar it catches the focus after the first paint. There is no user input involved that would legitimate the focus switch. We are removing the autofocus for now. Resolves: #99962 Releases: main Change-Id: I39ad325d8440f65e4baf636e742de7d3240e1036 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77869 Reviewed-by:
-
Benjamin Kott authored
If no scheduler has never run, the user is prompted to check the scheduler setup check. This information is available in the system information panel, but there is no visible indicator for the user that action needs to be taken. We are now increasing the system information message counter to make the user aware of this possible missconfiguration. A as soon as the scheduler has been run atleast once, the message will dissappear. The link for the setup check is now correct. Resolves: #99960 Releases: main Change-Id: Ib7264dc3f76b84f7f5524f2405ad3158db9806d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77867 Tested-by:
-
- Feb 15, 2023
-
-
Josef Glatz authored
Resolves: #99968 Releases: main Change-Id: Ie54a76fadf1000e8506ad512e14caa165c41ca86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77876 Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Nikita Hovratov authored
personelData -> personalData Resolves: #99964 Releases: main Change-Id: If59a501b2faef95c4800995fc8ba985bba343134 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77873 Tested-by:
-
