- Jan 29, 2024
-
-
Simon Praetorius authored
Fluid 2.10.0 introduced a regression concerning the handling of local and global variables, which was fixed with 2.10.1. Executed command: composer req typo3fluid/fluid:^2.10.1 Resolves: #102984 Releases: main Change-Id: Ica56338d520b3a10d12bb94e2fb8e4d41ee5cef8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82698 Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Christian Kuhn authored
typo3/testing-framework no longer loads EXT:install in functional tests by default. The patch adapts a couple of tests to cope with this. Note core will continue to refactor in this area after 13.0: It for instance needs to be sorted out if the upgrade wizard infrastructure should be moved to EXT:core. For this reason, no full communication happened in this area, yet. > composer u typo3/testing-framework Resolves: #102982 Releses: main Change-Id: Id786a2f16d336b6e9d80519e7f944d560f61d8bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82695 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
Oliver Bartsch authored
In case no replacement has been done, e.g. due to an already modified version, don't update the server configuration file, since this might lead to an endless loop. Resolves: #102977 Releases: main Change-Id: If5cc0d33450c5b14b9f2e9ab1aec958ec02420ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82693 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Oliver Klee authored
Resolves: #102954 Releases: main Change-Id: I5d96243c83544195b21d3a45cd504d9755eb6951 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82669 Tested-by:
-
Oliver Klee authored
Resolves: #102966 Releases: main Change-Id: I6b7dce63373e805a7fdbc0792e834a424236c864 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82684 Tested-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
-
Stefan Bürk authored
For `ext:indexed_search` not only a cumbersome md5 to int conversion has been used. The original md5 length has been reduced by simply cutting off values from the end, combined with a `hexdec` conversion, leading to a highly increased conflict probability (duplicate keys) for several places. To mitigate this, the raw md5 hash should be used instead of the reduced integer representation. This change modifies the database and the user land code to use the full `md5()` hash without castrating them any longer. The following table fields are therefore changed from `int` to `varchar`: * index_phash: phash, phash_grouping, contentHash * index_fulltext: phash * index_rel: phash, wid * index_words: wid * index_section: phash, phash_t3 * index_grlist: phash, phash_x, hash_gr_list * index_debug: phash Note: The required table truncation is handled within the database analyzer schema changes and not as an upgrade wizard. Recently added native php types are now changed to string to cope with this change again. Also removed the now unused internal `IndexedSearchUtility::md5inthash()` method. Using `QueryBuilder::quoteArrayBasedValueListToStringList()` instead of named placeholders for `IN()` conditions to reduce the risk for exceeded placeholder limit. QuerySize limitation may still occur, but can be increased by the responsible server administrator. Resolves: #102975 Resolves: #84541 Resolves: #90977 Resolves: #79802 Resolves: #87138 Releases: main Change-Id: I8e1dcffccb351dc03b58f0d5bc5d4c8419bc307a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74688 Tested-by:
-
Garvin Hicking authored
Example for TCA and flex form XML usage scenarios added to the RST changelog. Resolves: #102981 Related: #102970 Releases: main Change-Id: Ic6d84e767f880924a6bf4dc239cb8154a578e674 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82696 Reviewed-by:
-
Christian Kuhn authored
The PaginationInterface contains the basic set of methods a pagination provides. The interface has been introduced with #89603, later, #93340 added getAllPageNumbers() to SimplePagination, and issue #94625 picked that up in SlidingWindowPagination. The patch adds the method to the interface to be generally available. Resolves: #102980 Related: #89603 Related: #93340 Related: #94625 Releases: main Change-Id: I895ba9f1c70be1c354f75b4a6dc564410fde375a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82694 Tested-by:
-
Stefan Bürk authored
It's a generic goal to provide database scheme defaults for TCA defined tables with the on-going #101553 quest. For `ext:redirects` the `target_statuscode` field has not been removed due to the database default value. Meanwhile it is ensured with #102938 that not only the DataHandler but also the auto-create using QueryBuilder respects TCA and database defaults - albeit overriden with a manual default and based on the SiteConfiguration. Therefore, this entry is now removed along with the todo comment from the `ext_tables.sql`. Core uses proper API's which ensures keeping the same default - whereas extension not using proper api could be trapped with the removed database default. Note: Removing the `source_*` fields and `hitcount` is not possible right now due to the simple fact that `type=input` not having default schema creation yet. Resolves: #102944 Related: #102938 Related: #101553 Releases: main Change-Id: I841baf50cf6eb8ed170af9496e283641e4be917f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82661 Tested-by:
-
Benni Mack authored
The TimeTracker exists for a very long time and did not receive much love over the years. It comes with fishy internal structures and needs a bigger overhaul. While various parts throughout the core and extensions actively use the "write" API - push(), pull() and setTSlogMessage() - the "init" API is only used by middlewares and the "read" and "print" API only by EXT:adminpanel. The patch moves the "print" related methods to the admin panel extension as is, and declares everything except the "write" methods `@internal`. This allows future refactoring of the now internal data structures and API. Resolves: #102976 Releases: main Change-Id: Ida37154a71dd4b04cb5bcea79208824f4e6f4293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82677 Reviewed-by:
-
Oliver Klee authored
Also fix the PHPDoc annotations and generics along the way to avoid introducing (valid) PHPStan warnings. Resolves: #102956 Releases: main Change-Id: I8444978d984993ff5a3fb6b29e487ed3b67f4e9a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82671 Reviewed-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Oliver Klee authored
Resolves: #102878 Releases: main Change-Id: I2f197b9417c0acc6a05f6e72543429382ff580c2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82524 Tested-by:
-
Stefan Bürk authored
This change gathers the default values for a redirect from the definied TCA and uses the database schema as fallback and use it for the auto-created redirects as default before applying the SiteConfiguration setting, manual defaults and dispatching the redirect event `ModifyAutoCreateRedirectRecordBeforePersistingEvent`. Reduces the need to implement a event listener when the `sys_redirect` table is extended with not nullable columns to ensure proper default value handling unknown to the redirects slugservice. Further superflous properties are removed in the SlugService and remaining properties get native types donated. Resolves: #102938 Releases: main Change-Id: I8cb406e3f571b9fdfe6f13bd356ea8d2e1668b2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82656 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Christian Kuhn authored
Flex form container sections have been restricted to not contain type=inline, type=group with MM and some furter combinatios with previous core versions before. The patch extends this to a general "Do not configure flex form container sections that have database relations". It modifies the according code in FormEngine TcaFlexProcess->scanForInvalidSectionContainerTca() accordingly. This check can be re-located to a more low level tailored flex form handling related class, later. The attached documentation ReST file comes with some reasons on why such a configuration is very problematic to be handled by the core in a good way. This patch unblocks further flex form development to actually fix existing issues with database relations within flex forms that are bound to casual fields not within container sections. Resolves: #102970 Releases: main Change-Id: I7c295487b28658b323549541b2089da371bfb188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82689 Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
- Jan 28, 2024
-
-
Christian Kuhn authored
To get some more details of EXT:workspaces right, the core needs some freedom when refactoring classes. Most of the workspaces "application" is obviously @internal, extensions must not tamper with this, or should be aware that details are not considered public API, except - of course - dispatched events. Future development in this area will sharpen the current mix-up of EXT:core related workspace code, and code located within EXT:workspaces, by moving things around. The patch adds a few `@internal` declarations. Resolves: #102971 Releases: main Change-Id: I5eefe768d965cd2f7fe50fe72a52650d934bcb0d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82690 Tested-by:
-
Torben Hansen authored
This change deprecates the class `TYPO3\CMS\Extbase\Security\Cryptography\HashService`. Due to the deprecation, all usages of the class in TYPO3 core have been replaced with the new class `TYPO3\CMS\Core\Crypto\HashService`. The new HashService incorporates an additional secret for hash generation to prevent hash reuse across different contexts, enhancing the security of generated hashes. The change results in the following breaking changes. Many of the code changes itself are not *strictly* breaking since most of the affected code is marked @internal. In this special case however, we decided to go with full blown deprecation documentation files, though. - Frontend user password recovery hashes generated with versions prior to TYPO3 v13 are invalidated due to the replacement of the HashService. Users with valid, non-expired recovery links will need to request new ones. - Custom extensions relying on `TYPO3\CMS\Extbase\Security\Cryptography\HashService` for property types or expecting its presence will encounter PHP Fatal errors. This affects various `@internal` properties across the TYPO3 core and extensions. Resolves: #102763 Releases: main Change-Id: I1fefd6e011f883ba799b2e9651770463397309b9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82666 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Oliver Bartsch authored
This adds the PSR-14 PackageInitializationEvent. The Event is being dispatched when packages are set up. TYPO3 Core registers listeners, which execute corresponding tasks, such as importing static extension data. Note this in not about loading / unloading of extensions in non-composer mode, but about setting up extensions after being loaded in non-composer by extensionmanager, or after being composer require'd (and thus auto-loaded) in composer mode. This allows to resolve dependencies to EXT:extensionmanager, which is therefore now optional and can be omitted for composer based installations. Activating packages can now be done by calling the new PackageActivationService. This service does also dispatch the new PSR-14 Event. The former functionality in `InstallUtility->install()` is moved to the new PackageActivationService. Therefore, the method now only acts as wrapper around the new service, allowing listeners to the AfterPackageActivationEvent to work as before. However, following PSR-14 Events are removed from extension manager: * AfterExtensionDatabaseContentHasBeenImportedEvent * AfterExtensionFilesHaveBeenImportedEvent * AfterExtensionSiteFilesHaveBeenImportedEvent * AfterExtensionStaticDatabaseContentHasBeenImportedEvent The information provided by those events can now be retrieved by listeners to the PackageInitializationEvent using the event's storage entries. Those entries are a PackageInitializationResult object, providing the listener's result. By convention, the identifier of the entries is the listener class name. Using `before` and `after` in the listener registration it's possible to place own listeners at a specific place, having the necessary information available. Additionally, the `InstallUtility->processExtensionSetup()` method is removed. This method just triggered the corresponding tasks, which can now be triggered by dispatching the new event. With the new `CheckForImportRequirements` listener, TYPO3 checks whether an extensions tries to import data, while required components (e.g. EXT:impexp) are not installed. Instead of a PHP Error, a warning is now logged in such case. If the package activation is triggered via the `extension:setup` command, which has been moved to EXT:core, the warning is also displayed on CLI. Resolves: #102935 Releases: main Change-Id: Icd340e85e64926d11c96c12461636f1606591cd1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82650 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Klee authored
Resolves: #102969 Related: #102879 Releases: main Change-Id: I1da732b04b2522907f969b850924d3d04b3fae4f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82688 Tested-by:
-
Christian Kuhn authored
$this->data['parameterArray']['itemFormElID'] is kinda ugly in FormEngine preparation, especially with flex form elements. Nowadays, the casual use case for 'per element' id's is to connect HTML input elements to a label element. This can be easily done in single element classes and needs no framework support. Some core classes do this aready. The patch drops 'itemFormElID' and adapts remaining consuming FormEngine element classes to create a unique id per element usage on their own. Resolves: #102968 Releases: main Change-Id: I0ea8e30348ffe7188b352256d380be35a0e1a537 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82686 Tested-by:
-
Oliver Klee authored
Make proper use of generics and align the API of our classes with that of the implemented interfaces `Iterator` and `ArrayAccess`. This helps extension developers use static analysis for their extensions. This is a pre-patch to introducing native types for the two classes. Resolves: #102958 Related: #102956 Releases: main, 12.4 Change-Id: I19f850264040246ef140c6958d20473ef4c9be28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82673 Tested-by:
-
Chris Müller authored
Some methods contain information of possible use cases which may be valuable to the user. The docblocks are also rendered in the documentation. Resolves: #102963 Related: #99802 Related: #99485 Releases: main Change-Id: Ib3b5fefbe7c4e09ca0794cd474727a4fa27207c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82681 Tested-by:
-
Chris Müller authored
This makes it easier for users to find the hooks. Resolves: #102965 Releases: main, 12.4 Change-Id: Ib5a515b46165b2d941444f90c615b59e244c9d6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82683 Tested-by:
-
Oliver Klee authored
Attributes provided to this method can also have integer values (which makes the `string` cast in the method necessary). The PHPDoc type annotations should reflect that to avoid false positives when calling code is statically analyzed. Resolves: #102967 Releases: main, 12.4 Change-Id: I00a3c11220c50fc5274c4aabb351b64b2e43a63f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82685 Tested-by:
-
Christian Kuhn authored
This should be an event later, but for now, EXT:core uses the package manager to see if it should destroy an EXT:install session during BE logout(). This will allow running TYPO3 instances without EXT:install. Resolves: #102962 Releases: main Change-Id: I2f2ce6ee4986dae0219c1f1ec01a07fe4d1370f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82676 Reviewed-by:
-
Christian Kuhn authored
Configuring multiple database connections and then moving 'arbitrary' tables to a connection other than the "default" connection never worked well for the main core table set. We are using more and more queries that join data accross tables, for instance with refindex and categories. We have to continue with this to further improve perfomance. The patch adds an 'important.rst' to clarify the situtation: Additional connections can still be configured and used, but the core expects the "main" table data set including all TCA tables to be on the "default" connection. Resolves: #102960 Releases: main Change-Id: I6fbf4f85716c1bccb8741195056413701caa7ca4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82675 Tested-by:
-
- Jan 27, 2024
-
-
Oliver Klee authored
This internal superclass provided methods with types that were overwritten with a different signature in subclasses, which means that the abstraction wass not helpful (and prevented using proper native type declarations). The superclass is hence now dropped. As the dropped class had been marked as `@internal`, this change is not breaking. The `AbstractFileFolderConverter` needs some more cleanup, but that is out of scope for this change. Resolves: #102884 Related: #102879 Releases: main Change-Id: I11fe0388f28685c16bb86b3beb8606fe90e1834e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82532 Reviewed-by:
-
Stefan Bürk authored
Doctrine DBAL has been upgraded to the next major version using the development version as a intermediate solution. Recently, the second release candidate has been released. This change upgraded to that candidate now. Adding the release candidate to a project root composer.json is still needed as a workaround - or lowering the minimum stability. Used command(s): > \ composer req --no-update --no-install \ -d typo3/sysext/redirects \ "doctrine/dbal":"4.0.0-RC2@rc" ; \ composer req --no-update --no-install \ -d typo3/sysext/core \ "doctrine/dbal":"4.0.0-RC2@rc" ; \ composer req --no-update --no-install \ -d typo3/sysext/install \ "doctrine/dbal":"4.0.0-RC2@rc" ; \ composer req -W \ "doctrine/dbal":"4.0.0-RC2@rc" ; \ COMPOSER=composer.dist.json composer req --no-update \ -d Build/composer \ "doctrine/dbal":"4.0.0-RC2@rc" Resolves: #102959 Releated: #102875 Releases: main Change-Id: Ia4c4c39234c68d6382fd6bebcc359eac6a8ab51e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82674 Tested-by: -
Oliver Klee authored
The abstract class `AbstractFileFolder` is broken by design as it tries to abstract the `originalResource` property while this property is relied on the have specific different types in subclasses. This is a pre-patch to get rid of this class and use clean native type declarations in the subclasses. As all affected classes are internal, this change is non-breaking. Resolves: #102949 Related: #102879 Releases: main Change-Id: I84e9d042fc186748e665bb9f37eddb30a339ad8a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82667 Reviewed-by:
-
Oliver Klee authored
This change does not try to resolve the broken concept of `AbstractFileFolder`, where subclasses provide more specific return types for the `originalResource` property and other code relies on that. Resolves: #102879 Releases: main Change-Id: I497acd64d7dc773d1eae8a1f610cf425b08b456c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82525 Reviewed-by:
-
- Jan 26, 2024
-
-
Christian Kuhn authored
The install tool "Installer" (the interface when first installing TYPO3) and the Maintenance "Clear Persistent Database Tables" card have a dependency to EXT:extensionmanager. This is loosened by asking the PackageManager if that extension is loaded now. Resolves: #102948 Releases: main Change-Id: Ied011db3a4da21db5d38ee78b2ecb28f00ce6d27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82664 Reviewed-by:
-
Oliver Klee authored
Resolves: #102885 Related: #102632 Releases: main Change-Id: Ica94133b69fcfa8950e378e473108ec1ef17ca94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82535 Tested-by:
-
Mathias Bolt Lesniak authored
Specifically mention FIRST_INSTALL file and recommend new users to read the Getting Started documentation at docs.typo3.org when warning that the Install Tool is locked. Also adds an info box with a similar documentation recommendation to new users. This ensures that new users always get directed to the documentation and that new users are told about the FIRST_INSTALL file, also if TYPO3 doesn't detect a new installation. Also fixes some minor grammar. Resolves: #102933 Releases: main, 12.4 Change-Id: I0efe032c9bfe4a619b80c6f620d53fe062c8abc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82654 Reviewed-by:
-
Andreas Kienast authored
This commit removes the pagination ViewHelpers from EXT:indexed_search in favor of the native pagination API shipped with TYPO3. Resolves: #102945 Releases: main Change-Id: I3bc6736de042be257f1ec5c531437fa30a50ea97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82657 Tested-by:
-
Christian Kuhn authored
The install tool has just a few dependencies to ext:extensionmanager. Most notably, it ships the AbstractDownloadExtensionUpdate upgrade wizard, which is used when core extracts stuff to dedicated extensions that are removed from monorepo. The v12 upgrade wizard for 'fe_login_mode' uses this. These upgrade wizards are tailored for non-composer-mode only, just like the extensionmanager, which essentially does nothing in composer mode. To loosen the dependency from ext:install to ext:extensionmanager, the patch moves the abstract, a model class for this case, plus the fe_login_mode implementation to ext:extensionmanager. Class aliases are established, so a casual deprecation is enough in this case. A few extensions rely on the class, typically those that try to extend the upgrade range of core by forward porting wizards older than two major core versions. Those shoud continue to work with v13, and will have to adapt the class namespace of the abstract with v14 latest. Moving the fe_login_mode wizard around does not make the wizard show up again in case the wizard has been marked 'done' during v12 upgrade already, since usually the according DB field does not exist anymore. We don't need special handling for this case. Resolves: #102943 Releases: main Change-Id: Idb5e6c90900ffad7f9c3c383fff58a05c6728aa9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82659 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
ReferenceIndex has a hard coded "skip" for table "tx_extensionmanager_domain_model_extension". This is needed since the extbase based EM repository depends on TCA being defined. To get rid of this dependency, the patch turns it by adding an event listener within ext:extensionmanager. Resolves: #102947 Releases: main Change-Id: Iacf8f0cbca42f57fe8ea7010580dd9278b550d1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82663 Reviewed-by:
-
Christian Kuhn authored
EXT:styleguide uses two images from EXT:extensionmanager in the "Cards" examples. To loosen the dependency, the example images are copied over to EXT:styleguide. Resolves: #102946 Releases: main Change-Id: I9eff6b9ef009b0d1059b788fa2ad730f148b37e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82662 Tested-by:
-
Oliver Hader authored
Resolves: #102942 Releases: main Change-Id: Ic12f84dd2a10897f5fded82c4264892f9029a6a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82660 Reviewed-by:
-
Andreas Kienast authored
The `sword` property and its getter/setter are used within the `SearchController` only. The getter and setter have been removed, the property is used directly. Resolves: #102940 Releases: main Change-Id: I4c0032b3fd19dfe18e5ebb82e2d78f04398678af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82655 Reviewed-by:
-
Oliver Klee authored
Add native type declarations and first-class callables for improved type safety and readability. Also make some callbacks static for improved performance. Resolves: #102722 Releases: main Change-Id: Icd7d4e5881cd859ec8342266cd7d49b65654dc06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82281 Tested-by:
-
Andreas Kienast authored
The ViewHelper namespace of Indexed Search was previously known as `is`, but it has been re-introduced as `search` previously. This commit streamlines this oopsie-whoopsie. Resolves: #102941 Releases: main Change-Id: I17fb68666a8bc1192e025612bae2c6340fd9633d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82658 Reviewed-by:
-
