- Dec 13, 2019
-
-
Benni Mack authored
Due to the INTL/ICU bug, which we have seen on various places, Guzzle, which does not cover our edge cases yet, ran in the same issue as our Core versions earlier in 2019. See https://github.com/guzzle/guzzle/issues/2448 https://github.com/guzzle/guzzle/pull/2454 For the time being, lets mark guzzle as incompatible until Guzzle has solved the issue and released a new version, so we can loosen the conflict constraint. Related: #87953 Resolves: #89904 Releases: master, 9.5, 8.7 Change-Id: If64fb9472d046f020c850cd0551beeaf78796b60 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62606 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
sqlserver is a special race that welcomes high memory servers as its habitat. However, we are short on resources and need to offer a very small amout of RAM for a living which already acts as server cruelty. While we're on it, it gets a nice bed to put some data on the RAM disk in the hope its job gets done at least quickier. Resolves: #89935 Releases: master, 9.5, 8.7 Change-Id: Ic06f4b7071ed1d16ec9d0cd5a0a57f05dde171f6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62611 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Dec 12, 2019
-
-
Andreas Fernandez authored
The top toolbar items now use our AJAX API instead of $.ajax(). Resolves: #89897 Releases: master Change-Id: I134ea97f2038097d486947f30545304e47a31dff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62578 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Andreas Fernandez authored
Executed commands: yarn add chosen-js@^1.8.7 --dev grunt build Resolves: #89884 Releases: master Change-Id: I242b8925f108d3bfa26191f1c58ea24a1149f0ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62609 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
Resolves: #89925 Releases: master, 9.5, 8.7 Change-Id: I3449606aa143c23dd656dd566c87aec08ae19425 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62603 Tested-by:
-
- Dec 11, 2019
-
-
Chris Müller authored
The code-block directive needs two colons to be rendered correctly. Resolves: #89922 Related: #89463 Releases: master Change-Id: Ida99628710cc3558a0dbdc39272e788c390ca154 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62600 Tested-by:
-
Richard Haeser authored
A PSR-14 event is introduced to make it possible to control the hreflang tags that will be rendered. Additionally the class HrefLangGenerator is migrated to be a listener to the new event. Resolves: #86614 Releases: master Change-Id: I51a5a79da6996148e62301c793b0ad257aada102 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59059 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Andreas Fernandez authored
The AJAX API fails to send a request if the API receives a non-absolute URL like /typo3/index.php?foo=bar, since the domain is missing. To fix this issue, the origin of the triggering request is added as well as `base` argument of URL(). Resolves: #89893 Releases: master Change-Id: Ice61a71fc8d4627e6d0b3b9d0f5ab524000361ab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62576 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
-
Alexander Schnitzler authored
As a prepatory work for a better static code analysis all ampersands have been removed from doc block params. The doc block must not reflect whether a variable is passed by value or reference. Releases: master Resolves: #89912 Change-Id: Ibead2ec2db6487e32bcd5fc271a6566bab46d255 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62594 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Björn Jacob <bjoern.jacob@tritum.de> Reviewed-by:
-
Jan Stockfisch authored
Shows error flash message while `exposeNonexistentUserInForgotPasswordDialog` is set to `1` Resolves: #88111 Releases: master Change-Id: I193e2ca22c45a83450aa4f0e44e3dce46696b16c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62482 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
- Dec 10, 2019
-
-
Alexander Schnitzler authored
As the StringClassNameToClassConstantRector would convert string class names that are deliberately defined as string, this rector has been disabled. Releases: master Resolves: #89899 Change-Id: Iecbcf2c009885501b0caafe66cb8f5703688c188 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62581 Tested-by:
-
Oliver Bartsch authored
As the extension configuration field `backendLogo` isn't resolved by `TYPO3\CMS\Backend\Controller\LoginController::getUriForFileName()`, it is in contrast to other fields (e.g. loginLogo or loginBackgroundImage) not possible to add a path with a leading slash. As this is neither explicit allowed nor disallowed, this unifies the behavior by removing a possible leading slash from the defined path before it gets resolved as it's already the case for the other fields. Resolves: #89636 Releases: master, 9.5 Change-Id: I3f7a72f1005bc403c72b837cf66e5303962a8a42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62293 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
-
Rasmus Larsen authored
IPLock breaks modern IPv6 setups because of the Fast fallback aka. Happy Eyeballs algorithm that can cause users to jump between IPv4 and IPv6 arbitrarily. Enabling lockIP should be a very conscious decision, not a default. Resolves: #89869 Releases: master Change-Id: I4b0fde1f767bfca613276d4763b91d9feb86ea27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62559 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Michael Binder authored
This Patch allows the usage of an HMENU with special = directory and the Fallback Type 'Free mode' Resolves: #88344 Related: #89368 Releases: master, 9.5 Change-Id: Ib7f53b4e061b6387e6b29b2545696a3eb2d015a0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62527 Tested-by:
Tobias Gaertner <tobias.gaertner@benaja-websolutions.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benni Mack authored
In order to use the final LTS distributions from Symfony for our latest stable, we need to set proper platform requirements for the root composer.json. Our packages rely on the settings so the base package can properly raise dependencies. Symfony has the requirements due to other PHP bugs (fixed very early already), however using the tarballs in 7.2.0 / 7.0.0 would still work, as the symfony changes only fix issues we dont rely on. v10: 7.2.5 v9: 7.2.5 v8: 7.0.8 Used composer commands: composer config platform.php 7.2.5 composer update --lock Resolves: #89882 Releases: master, 9.5, 8.7 Change-Id: Ib51ec076e643581603fced3ed0daa0de0aadb12c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62565 Tested-by:
-
Alexander Schnitzler authored
In two places, TYPO3\CMS\Frontend\Page\PageRepository had been used instead of TYPO3\CMS\Core\Domain\Repository\PageRepository. As this will eventually fail in the future, the wrong usage has been fixed. Releases: master Resolves: #89901 Change-Id: I5799bcb93486e3c8aa4a71fe4ad03cfce34948d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62586 Tested-by:
-
Alexander Schnitzler authored
In order to let rector process tests, the autoloading of all processed classes needs to be intact. In TYPO3 there were a bunch of classes whose namespace were a bit wrong according to PSR-4 and there were some class that didn't fit the PSR-4 standard at all. Classes that could easily be fixed have been fixed. All others have either been registered via a class map in composer.json or they have been excluded from the processing of rector. This change does not apply rector rules to tests, it only enables rector to operate on tests due to fixed autoloading. Releases: master Resolves: #89900 Change-Id: Iaa4a5bb2677a5a9af374d780423d962dcc09ade2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62583 Tested-by:
-
- Dec 06, 2019
-
-
Benjamin Franzke authored
The GeneralUtility $container instance should only be set/used in functional tests as we a) can not reset the instance (which means other unit tests are affected) and b) should mock/inject dependencies in unit tests. TreeDataProviderFactoryTest is therefore changed to to use GeneralUtility::addInstance() (which is intended for unit tests) instead of GeneralUtility::setContainer(). Change-Id: I9fc0e76077cc1cc2a6935d025b97309efc315f4f Releases: master Resolves: #89890 Related: #89733 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62573 Tested-by:
-
Benni Mack authored
Since TYPO3 v10.0, all links generated by TYPO3 contain a cHash if - there are arguments that are not mapped within the routing - there are arguments that are not explicitly "excluded" from cHash (e.g. fbclid) - there are arguments that are not internal (L,id,MP). The PageArgumentValidator middleware now always evaluates the arguments properly at every request and decides to disable caching or throw a 404, if an incoming request does not have a cHash or an invalid cHash. Through the middleware, any plugin is automatically checked for the cHash, and it does not matter anymore for plugins, so it does not matter for integrators or template authors as well as cHash is managed internally by TYPO3 Core now (with no way to disable it, for security reasons). All functionality regarding cHash that can be dropped: - CacheHashEnforcer and Extbase option - TSFE->reqCHash() can be marked as deprecated - the option within PiBased Plugins is now irrelevant as well. This change jointly decouples cHash evaluation from any other part than Url Generation (= PageRouter) and Resolver (PageArgumentValidator), finally streamlining all logic of cHash functionality. Resolves: #89868 Releases: master Change-Id: I7a694fbc95fa1ea4dc85b12a94b0a06b3722fd11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62267 Tested-by:
-
Alexander Schnitzler authored
In order to simplify the request/response handling in Extbase and to prepare the introduction of PSR-7 compatible request and response objects, the web versions of Extbase's request and response have been deprecated. All relevant logic has been moved into the base classes to stay api compatible and not introduce a breaking change. Along with the simplification of the request and response objects, quite a lot of instance checks have been removed to ease the transition to having a public api that is defined by interfaces and not concrete implementations. Releases: master Resolves: #89673 Change-Id: Ie920ae7d38e6de3167ff57f93fa6e98af2936d9f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62317 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade datatables grunt build Resolves: #89888 Releases: master Change-Id: I73ea78f4d217c2846b0c79cf0e5ad06aea1a8e9e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62572 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add sortablejs@^1.10.1 --dev grunt build Resolves: #89886 Releases: master Change-Id: I871faaca63f19bf7fe2e782d6741cf3e476156b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62571 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade requirejs grunt build Resolves: #89887 Releases: master Change-Id: I5b2347ebec049e1663a3684ce4246c323228befb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62569 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add moment@^2.24.0 moment-timezone@^0.5.27 --dev grunt build Resolves: #89885 Releases: master Change-Id: I6a6a7122fb1a0a343206c04c5cc3ce6a9a891d02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62570 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade typescript grunt build Resolves: #89889 Releases: master Change-Id: I1152fbbc89b30cae9ba34f1fa11494c071a7fe4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62568 Tested-by:
-
Andreas Fernandez authored
In order to become independent of jQuery, a new API to perform AJAX requests is introduced. This API implements the fetch API available in all modern browsers. Resolves: #89738 Releases: master Change-Id: Ibdc1a7047b29402dea21b6dd7a48217b9afb849e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62372 Tested-by:
-
Oliver Bartsch authored
Move title and description of the clear cache error notification to a xlf file to make it translatable. Resolves: #89447 Releases: master Change-Id: I925773de216ee8283336981b2cff2bd9a087a927 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62269 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add autosize@^4.0.2 grunt build Resolves: #89883 Releases: master Change-Id: I0bf8f30bb22ffceea9eda9e4c71bb0fc5d661a4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62566 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn upgrade jquery grunt build Resolves: #89881 Releases: master Change-Id: I48c48de69f977e949563957d59789156bd5989fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62564 Tested-by:
-
Andreas Fernandez authored
Executed commands: yarn add @claviska/jquery-minicolors@^2.3.4 --dev grunt build Also, since the mentioned issues have been solved meanwhile, the library is copied by grunt again. Resolves: #89880 Related: #77317 Releases: master Change-Id: I0d08fec8777b2e6090a98a85115deeb761c20e92 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62562 Tested-by:
-
Oliver Bartsch authored
This (re)adds various tooltips through the backend to further increase the accessibility. Especially for buttons that have a different meaning than normal in a particular context. In most cases, they were simply missed but some of them referenced to not longer existing locallang keys or to locallang keys of another sysext which is no dependency of the one where it is referenced. The tooltips are (re)added at following places: - Creating new content element in ext:core new record view - Multiple buttons in ext:core element information modal - Multiple buttons in ext:beuser listing and compare view - Multiple buttons in ext:form form management and form editor view - Multiple buttons in ext:info pagetree overview - New content element record button in ext:recordlist listing view - View redirect button in ext:redirect listing view Resolves: #89566 Releases: master Change-Id: I66cd16413b0e4f188627df06f233a0bba73c3056 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62175 Tested-by:
-
Oliver Bartsch authored
The update all button in the table head of the extensionMatrix is now disabled by default and only gets enabled if at least one active language pack is installed. This prevents interoperability of the entire card when entering the language pack update process. Resolves: #89561 Releases: master, 9.5 Change-Id: I8f04e0266d45b1257314ec937cc55a2fea603f83 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62171 Tested-by:
-
Alexander Schnitzler authored
The usage of switchable controller actions, both via flexforms and typoscript, is deprecated and will be removed in one the next major versions of TYPO3, probably version 11.0 or 12.0. Switchable controller actions allowed to override the php plugin configuration and to create god plugins, i.e. plugins that can be set into multiple different modes and therefore take care of all possible use cases. Every plugin should serve a single purpose, therefore the usage of switchable controller actions is an anti pattern which will be removed. The switchable controller action mechanic will be removed without replacement which means, that there is no migration path to a similar feature. Instead, extension authors need to create multiple, dedicated plugins for different use cases. Releases: master Resolves: #89463 Change-Id: I41afac9303205f97f390f208803908177e00cda5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61511 Tested-by:
-
Andreas Fernandez authored
All frontend stack related packages get updated to their latest version and a full build is generated. Executed commands: yarn add \ @typescript-eslint/eslint-plugin@^2.10.0 \ @typescript-eslint/parser@^2.10.0 \ @typescript-eslint/typescript-estree@^2.10.0 \ autoprefixer@^9.7.3 \ eslint@^6.7.2 \ grunt-stylelint@^0.12.0 \ grunt-terser@^1.0.0 \ karma@^4.4.1 \ node-sass@^4.13.0 \ typescript@^3.7.2 --dev yarn build Resolves: #89804 Releases: master Change-Id: I48f00a01fb4191b39e76e0859d1f1476644ad07b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62486 Tested-by: -
Benjamin Franzke authored
This reverts commit 26c9a8e3. The schedulers *primary* task is to *schedule* tasks, not to execute them from the backend. The backend-execution is only an additional functionality, which is available because it's sometime handy for manual tasks/testing. We shouldn't mark commands as non-schedulable when scheduling them is a perectly valid usecase. Usecases for scheduling backend locks are: * Planned maintenance locks: schedule a backend lock for a planned update or migration where you agreed to stop editing as of a certain date. * Regular edit-locks, e.g.: schedule a backend lock for let's say every friday as of 8pm schedule backend unlock on mondays at 8am. The reverted patch tried to fix the situation where the lock task was executed from the backend scheduler overview. If we'd want to fix that, the proper fix would be to add another property which states that this command must not be executed from the backend. Releases: master, 9.5 Resolves: #89873 Reverts: #89387 Change-Id: I782809ff065c05adba0653aa208d37e1241eb41a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62551 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Andreas Fernandez authored
The LanguagePackService now uses the RequestFactory to download the mirrors.xml.gz file, since it throws proper exceptions on failures. In case of e.g. a timeout, the thrown exception is properly caught and the designed fallback kicks in. Resolves: #89810 Releases: master, 9.5 Change-Id: Ie4e8bcf02c33eb18e58f505f1a791c1233d6f593 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62496 Tested-by:
-
Michael Telgkamp authored
- Do not toggle node with canToggle!==true - Check if node has parent before trying to go to parent node Resolves: #89847 Resolves: #89864 Releases: master Change-Id: I49f112c15e64103e707481cecb7f61bd58fa8182 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62544 Tested-by:
-
Frank Naegler authored
Resolves: #89834 Releases: master, 9.5 Change-Id: I914c6e8a0739c4380be4fa1c1d165f3eb4f1aecd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62520 Tested-by:
-
Susanne Moog authored
Avoid a TypeError exception in NewContentElementController in newer PHP versions because of an undefined array access. Resolves: #89860 Releases: master, 9.5 Change-Id: I5728638a3f5800588f17bef202fe5814e79d7f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62540 Tested-by:
Tobias D. <tobias.doll@snk.de> Reviewed-by:
-
- Dec 05, 2019
-
-
Anja Leichsenring authored
The rearranged stages structure will prevent the host machines and also gerrit from being overwhelmed with a high amount of running jobs all at once. Instead, the equal size of each stage keeps the load on an average height, but it will increase the total runtime of a plan. We prefer stability over quick runs in nightlies. Resolves: #89865 Releases: master, 9.5, 8.7 Change-Id: Ib915053e83d087007242c05886619faf8d7cee0f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62546 Tested-by:
-
