- Feb 02, 2020
-
-
Oliver Hader authored
https://github.com/TYPO3/testing-framework/commit/2111db60e8e1391fabdac4f2253af553f291d460 Resolves: #90294 Releases: master, 9.5 Change-Id: I21d8ad233b753c4a56c2227b4d2fec6944340c81 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63144 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Oliver Hader authored
Resolves: #90269 Releases: master, 9.5 Change-Id: I7366c213d5d417575b9c85c18728a4fdf4273520 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63142 Tested-by:
-
Oliver Hader authored
Resolves: #90278 Releases: master, 9.5 Change-Id: I158a7ea2c27b0081b3cdf5ee9452f2394cc31593 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63104 Tested-by:
-
Andreas Fernandez authored
The AJAX API doesn't expose the AbortController anymore as it has no benefit for a developer, besides aborting a request. For this reason, the AJAX API removes the `getAbort()` method and replaces it with an `abort()` method, which utilizes the controller directly. Resolves: #90292 Releases: master Change-Id: Id6355663bc00bbb763692ca3b7fab145cb8cc55e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63141 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Feb 01, 2020
-
-
Oliver Hader authored
Resolves: #90229 Releases: master, 9.5 Change-Id: Iec8baa5dbe23d78dd4bfae460b501c2da5cb6bd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63056 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
- Jan 31, 2020
-
-
Benni Mack authored
The RteHtmlParser has two public methods: ->init() ->RTE_transform() init() was introduced in early PHP4 times when there was no constructor in PHP. RTE_transform() contained a lot of parsing of properties, which is not needed anymore since TYPO3 v8. init() itself is not needed anymore. Since TYPO3 v8, RteHtmlParser is much cleaner towards the developer, and the last step for this PHP class is to clearly separate the logic for the transformations in each direction, making two new entrypoints: ->transformTextForRichTextEditor($content, $configuration) ->transformTextForPersistence($content, $configuration) This way, all logic is separated in these two methods, and the existing RTE_transform() method is just a shell, which is not needed anymore. Resolves: #90258 Releases: master Change-Id: Iba140d71c5cd954dab4cf1fe4bfaca2233527e50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63070 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Benni Mack authored
The first PSR-14 event received a custom Compatibility slot. All further "old" slots have been moved to "SlotReplacement" classes, which is now done with this first PSR-14 event (AfterMailerInitializationEvent) as well, and moved to a more generic MailerInterface API, now that symfony/mailer is stable. Resolves: #90273 Releases: master Change-Id: I989a941031987733d694335d7e235cf1e2392235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63098 Tested-by:
-
Oliver Hader authored
Resolves: #90270 Releases: master, 9.5 Change-Id: Idbc51d012b49f3214d163878611d2107010242aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63095 Tested-by:
-
Claus Due authored
Followup for https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069 The original patch changed both public and non-internal method signatures and constitutes a breaking change, but was not committed and documented as a breaking change. This patch restores the method signatures in accordance with the non-breaking nature of the original patch. Resolves: #90246 Releases: master Change-Id: Icc832f80aad0466e3bd1555ff32369ef3949b04b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63094 Tested-by:
-
Oliver Hader authored
Use createFieldConstraints instead of createRouteFieldConstraints (as it has been in PersistedPatternMapper). Resolves: #90269 Releases: master, 9.5 Change-Id: Ia4b70079291fc72527a2846d73b16b9e61c81dd3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63093 Tested-by:
-
Frank Naegler authored
Show error messages in TypoScript Object Browser and Template Analyzer for any invalid condition line. Resolves: #77714 Releases: master, 9.5 Change-Id: I8ad24455a61467c47a1b8b28e465022c467d21d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63092 Tested-by:
-
Benni Mack authored
This change migrates all left-over signals in TYPO3 Core to PSR-14-compatible events. Package manager - related events have been moved to EXT:core to decouple ExtensionManager functionality from PackageManager. The following signals have been moved to events: PackageManagement::packagesMayHaveChanged => PackagesMayHaveChangedEvent InstallUtility::afterExtensionInstall => AfterPackageActivationEvent InstallUtility::afterExtensionUninstall => AfterPackageDeactivationEvent InstallUtility::afterExtensionT3DImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent InstallUtility::afterExtensionStaticSqlImport => AfterExtensionStaticDatabaseContentHasBeenImportedEvent InstallUtility::afterExtensionFileImport => AfterExtensionFilesHaveBeenImportedEvent ExtensionManagementService::willInstallExtensions => BeforePackageActivationEvent ProcessAvailableActionsViewHelper::processActions => AvailableActionsForExtensionEvent Next up: Deprecate signal slot dispatcher. Resolves: #90249 Releases: master Change-Id: If688265c50c4200983c34f408b1cfd063f72546b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63045 Tested-by:
-
Georg Ringer authored
If the state property inside `ext_emconf.php` is set to `excludeFromUpdates`, the extension will be skipped while updating the language files in the Install Tool. Resolves: master Releases: #90236 Change-Id: I741216e7fac18aeb3e1144033495c2f2943d496f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63065 Tested-by:
-
Benni Mack authored
The page module search bar now redirects to the list module, where all functionality is given, and all records on this page (not just tt_content) are found, streamlining it with the list module logic. Editors without permission for the list module do not see the search in the page module (similar behaviour to LiveSearch). All code of the page layout classes related to search is removed. As this is non-public API, the removal is done without any deprecations necessary. Resolves: #90235 Releases: master Change-Id: Ia23c931c5a009e8ffe9a1a56219fb922d63e44bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63063 Tested-by:
-
Oliver Hader authored
Use [:xdigit:] (a-f0-9/i) instead of [:alnum:] (a-z0-9/i) for parsing hexadecimal values in sequences. Resolves: #90263 Releases: master Change-Id: I26d575c381a17c409abcd5ed04876696587a3886 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63078 Tested-by:
-
Oliver Hader authored
Settings for $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] are modelled in CacheHashConfiguration which takes care of validating configuration. It also determines whether corresponding aspects apply to a given URL parameter. Besides exact matches (equals) it is possible to apply partial matches at the beginning of a parameter (startsWith) or inline occurrences (contains). URL parameter names are prefixed with the following indicators: + = (equals): exact match, default behavior if not given + ^ (startsWith): matching the beginning of a parameter name + ~ (contains): matching any inline occurrence in a parameter name These indicators can be used for all previously existing sub-properties 'cachedParametersWhiteList', 'excludedParameters', 'excludedParametersIfEmpty' and 'requireCacheHashPresenceParameters'. Example: $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash'] = [ 'excludedParameters' => [ 'utm_source', 'utm_medium', '^utm_', // making previous two obsolete ], 'excludedParametersIfEmpty' => [ '^tx_my_plugin[aspects]', 'tx_my_plugin[filter]', ], ]; Resolves: #90234 Releases: master Change-Id: I16d316e463b7c94c5eb75069f8c24ffde135d080 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63062 Tested-by: -
Benjamin Franzke authored
All Routes.php information for Backend routes are now collected via Dependency Injection. That means Bootstrap::initializeBackendRouter() doesn't need to be called explicitly from a middleware anymore. The Router class will always have the routes populated whenever it is initialized / needed. We use DI factories to collect and add the backend routes. The routes from the extension configuration files are still cached, but the cache is managed by a service provider. We adapt the ServiceProviderCompilationPass to keep track of the return type of extended services where the extension may not have a return type declaration (because of the dynamic closures in PseudoServiceProvider). We do that to properly notify symfony DI that the routes are stored as ArrayObject. Change-Id: Ie589825408bf9e51782800a1b8370f57d81d5178 Releases: master Resolves: #90247 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62531 Tested-by:
-
Oliver Hader authored
The intention of PersistenceDelegate was to provide a generic API to resolve or generate route components. However the implementation did not provide any additional behavior. It just was used as structural pattern which did not provide any further advantages. That's the reason why PersistenceDelegate gets dissolved and its database connection invocation is moved to its corresponding callers PersistedAliasMapper and PersistedPatternMapper. For backward-compatibility reasons previous (protected) implementation is still kept in legacy layer for those two route aspects. Resolves: #90218 Releases: master, 9.5 Change-Id: I49eb58372c139c9b8274593efa2892a43eb81508 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63049 Tested-by:
-
Sebastian Michaelsen authored
In template tree view the property path is now shown in the title attribute of each node to help the user orient and navigate through a deeply nested tree. Resolves: #90237 Releases: master, 9.5 Change-Id: I175c38eda3168c04e9d5f5b6d96a7bdc74121799 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63064 Tested-by:
-
- Jan 30, 2020
-
-
Benni Mack authored
Within all refactorings, fetching the correct backend layout and relevant colPos information was still called via callUserFunction which is not needed at all, as it is a static information (class + method name) so a regular method call via PHP works just fine. Resolves: #90254 Releases: master Change-Id: I712e86b3a5d343bad3b4752a21dac9cbdc510f46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63073 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Benni Mack authored
The so-called "singleton factory instance" is a wrapper around makeInstance which can be used directly anyways. With Dependency Injection this is not even necessary anymore, and should be avoided under all circumstances. The constructor does not cache anything, so this can be replaced completely. SingletonInterface + DI should be sufficient already. Resolves: #90260 Releases: master Change-Id: I964ddb90425b273c6e7588781c4b7e3fe39ddd18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63076 Tested-by:
-
Daniel Siepmann authored
As `rowCount()` is not supported across all DBMS (e.g. sqlite). The logic is kept, but instead of relying on row count, the list of items is built first, and checked afterwards. Resolves: #90231 Releases: master Change-Id: Iad0dc46c507d300708c9bc9d53aad6d6840a3446 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63061 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
mehrlich authored
Resolves: #90252 Releases: master, 9.5 Change-Id: Ibacf2dab8a246bcb09f02be65765aa0760ba041b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63072 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Reviewed-by:
-
Benni Mack authored
Until TYPO3 v9, PageLayoutView was a subclass of AbstractDatabaseRecordList, so it inherited a lot of logic, which was never used in this class. The code can safely be removed, as PageLayoutView is only used in Page Module (web_layout) and Info Module ("Page Information"). Resolves: #90246 Releases: master Change-Id: Ie1fbd1fb2131d1b7d6dee9342a82f54c4dd5e563 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63069 Tested-by:
-
- Jan 29, 2020
-
-
Benni Mack authored
When commenting out the line SystemEnvironmentBuilder::initializeBasicErrorReporting() then Unit Tests run with notices, showing notices as errors. This happened due to recent updates of the TYPO3 testing framework v6. The fix to overcome this is https://review.typo3.org/c/Packages/TYPO3.CMS/+/62926 but the preferred clean ups are done beforehand. Resolves: #90245 Releases: master Change-Id: Ieb43f2f9524fb18c221b9c690de7116c994f5260 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63068 Tested-by:
-
Alexander Schnitzler authored
- Add phpdoc for variables to let phpstan know their type - Do not use ::class syntax for PHP 7.4 classes (yet) - Add missing class properties - Do not unset non-existing variables Releases: master Resolves: #90207 Change-Id: I01ae756c03f7dfc286bedd2577979e0d79ca3d9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63039 Tested-by:
Benjamin Franzke <bfr@qbus.de> Reviewed-by:
-
Daniel Siepmann authored
Children of $array in ArrayUtility::getValueByPath() may contain other datatypes than array, therefore check the datatype by is_array() before calling array_key_exists() in order to avoid a PHP warning. Resolves: #90241 Releases: master, 9.5, 8.7 Change-Id: Ibde8f854a28a0aef68ed33ed172299cb4e1ff2ca Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63066 Reviewed-by:
Stephan Großberndt <stephan.grossberndt@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
- Jan 28, 2020
-
-
Elias Häußler authored
Resolves: #90227 Releases: master, 9.5, 8.7 Change-Id: If905b071639844b9080e1ffd903a15cb211ed7f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63055 Tested-by:
-
Daniel Siepmann authored
Resolves: #90232 Releases: master Change-Id: If9b030c8f984914d41482d0ab5fd7f94e1385b58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63060 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Oliver Hader authored
Injects configuration to constructor directly, avoids using MockBuilder to define internal values (part of configuration). Resolves: #90230 Releases: master, 9.5 Change-Id: I7759b071192ed09572f3a7ed7e7779e51a4eb9f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63058 Tested-by:
-
Manuel Selbach authored
With this change the wrong introduced type hint will be changed and enriched with some detail information. Resolves: #90223 Releases: master Change-Id: I3437889fb355571c88f1902b217faf11d56dd158 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63052 Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Tested-by:
-
Oliver Hader authored
Changes concerning route `defaults`: + defaults are mapped now (e.g. `1` <=> `one`) + defaults are applied now when having multiple parameters in a route path (e.g. `{default}/{required}` + defaults are applied now for types `Plugin` and `Extbase` (type `Simple` worked in most cases) + enforced defaults are considered now (e.g. `{!default}` + `Route` instances get `_appliedDefault` option set now - which contains deflated values and still needs to be inflated manually Changes concerning route `requirements`: + requirements are deflated now for being processed as Symfony routes (resulting in requirements being correctly applied now in enhancers) + requirements are skipped now for parameters having corresponding aspects defined ("aspects take precedence over requirements") References: + https://symfony.com/blog/new-in-symfony-4-3-always-include-route-default-values + https://symfony.com/doc/4.3/routing.html#parameters-validation + https://symfony.com/doc/4.3/routing.html#optional-parameters Resolves: #86895 Releases: master, 9.5 Change-Id: Ia260e407dcc657a2e7c85628da9e001d94952c37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62885 Tested-by: -
Elias Häußler authored
The new TypoScript condition `tree.rootLineIds` which was introduced with #88962 is currently not documented in the original feature RST where the new symfony expression language was introduced. In order to keep the list of available TypoScript conditions up to date in this document, the new condition was added accordingly. Additionally, some minor code highlights were fixed in the document. Related: #90221 Releases: master Change-Id: Ib7aef851d10361b9de124cb55ba8a005d1b2d6c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63050 Tested-by:
-
- Jan 27, 2020
-
-
Christian Eßl authored
If a TCA field config of type="none" with the l10n_mode="exclude" is present, the DataHandler will try to persist the field when saving a translated version of the record, even though fields of type="none" must not be persisted. Resolves: #87781 Releases: master, 9.5 Change-Id: Ie99495ff95fcf1ceaac0c5d050653e21d3af2afd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61960 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Felix P. <f.pachowsky@neusta.de> Reviewed-by:
Steffen Frese <steffenf14@gmail.com> Reviewed-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Benni Mack authored
The public property in ReferenceIndex->WSOL was removed in 2006 and documented like that, but it has no effect, as it was never evaluated since 14 years. This property is removed, as the recommended way is to use the ->setWorkspaceId() anyway since a few years. Resolves: #90217 Releases: master Change-Id: Ib3b58c6823ec78cb0b51f19b104aa80186f0dfe6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63047 Reviewed-by:
-
Michael Stucki authored
If the language synchronization process is called on an inline relation within another inline relation when there is more than one language which should be synchronized, the process fails with the following exception: #1486233164: Child record was not processed The problem happens because of a non-unique cache identifier which leads to incomplete operation. Resolves: #81314 Resolves: #85168 Resolves: #85914 Releases: master, 9.5, 8.7 Change-Id: Icbfc96e5dae387b620e917db168e9e14de5f3820 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60722 Tested-by: -
Claus Due authored
The newly added class \TYPO3\CMS\Backend\View\PageLayoutViewDrawEmptyColposContent incorrectly assumes that colPos values are always strings when they may very well be integers. This patch casts the possibly-integer value to string before use of trim(). Releases: master Resolves: #90211 Change-Id: I8fb145c76f2bd6b0bca187be3b4c5b05fd3c3d80 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63044 Tested-by:
-
- Jan 26, 2020
-
-
Elias Häußler authored
A new TypoScript condition `workspace` has been added which allows checking of several workspace parameters against a given expression. Currently, only workspace id and state can be used within conditions. Example: [workspace.workspaceId === 0] # This matches if the current workspace id equals 0 [end] [workspace.isLive] # This can be used to check if the current workspace is live [end] [workspace.isOffline] # This can be used to check if the current workspace is offline [end] Resolves: #90203 Releases: master Change-Id: I4113fc31e28c2d187f2398cc346088144d621639 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63035 Tested-by: -
Alexander Schnitzler authored
Method FormViewHelper::renderRequestHashField isn't in use any more since removing the old Extbase property mapper in TYPO3 version 6.2. Back then it was forgotten to remove said superfluous method. Releases: master Resolves: #90206 Change-Id: I2f1ae48d182718aef9fb2ae972f9b1d34909e21f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63038 Tested-by:
-
- Jan 25, 2020
-
-
Andreas Fernandez authored
The grunt module `grunt-newer` is introduced to act with changed files only instead of copying or minifying all files all the time. Used command: yarn add --dev grunt-newer Resolves: #90200 Releases: master Change-Id: Idcf34b402f089757a5b5209398abec1bba3288a2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63031 Tested-by:
-
