- Sep 07, 2017
-
-
Christian Kuhn authored
Adds a card to the "Settings" menu to allow configuration of "System Maintainers" in the install tool writing SYS/systemMaintainers array to LocalConfiguration. Change-Id: I0219b60e9a261373befab7b846e55b61ea215e5e Resolves: #82319 Releases: master Reviewed-on: https://review.typo3.org/53931 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
Łukasz Uznański <l.uznanski@macopedia.pl> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Ralf Zimmermann authored
Fix JavaScript errors if "properties.options" array keys contain dots. Resolves: #80197 Resolves: #82210 Resolves: #81961 Resolves: #82186 Releases: master, 8.7 Change-Id: Idfa976bca2ba5bbe08a72852f306c83d84b8eef0 Reviewed-on: https://review.typo3.org/53956 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
protos authored
Insert missing id attribute for image and file upload element. Resolves: #82223 Releases: master, 8.7 Change-Id: Ia88cda2db1eda1ce6dab0678052e089184d8b0cd Reviewed-on: https://review.typo3.org/53959 Reviewed-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
protos authored
Change some wording for better understanding in frontend and backend. Resolves: #82326 Releases: master, 8.7 Change-Id: Idc43a1543a315f5d54fdaf6c575a2f7ef0084aae Reviewed-on: https://review.typo3.org/53951 Reviewed-by:
Stefan Neufeind <typo3.neufeind@speedpartner.de> Tested-by:
-
Ralf Zimmermann authored
It is now possible to add HTML5 elements with its needs. Resolves: #80130 Resolves: #80128 Resolves: #80127 Resolves: #80125 Resolves: #80126 Releases: master Change-Id: I1088d77c8ee52cca93878847a5d59c6b92faf1de Reviewed-on: https://review.typo3.org/52016 Reviewed-by:
-
Ralf Zimmermann authored
Fix JavaScript errors on page drag & drop within the form editor Resolves: #82337 Releases: master, 8.7 Change-Id: I6e67b05a68273f1ad2d6f851ed5dfa4781d7d5bb Reviewed-on: https://review.typo3.org/53949 Reviewed-by:
Carlos Meyer <cm@davitec.de> Tested-by:
-
Susanne Moog authored
Extension configuration is now stored as plain array instead of serialized values. To ensure backwards- compatibility and stream-line core usage, the old values will still be stored and written in $GLOBALS['TYPO3_CONF_VARS']['EXT']['extConf'] whereas the new array will be stored in $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']. As a second step we are going to introduce an API for retrieving extension configuration to remove the necessity for GLOBALS access in this case. Resolves: #82254 Releases: master Change-Id: I52ef7768491633e114e7e1b153a4ba63e07243ff Reviewed-on: https://review.typo3.org/53657 Reviewed-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
Romain Canon <romain.hydrocanon@gmail.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benni Mack authored
Currently calling the install tool modules from within the Backend does a simple redirect with adding GET variables. That's the reason why you need to re-authenticate again, and the context is handed over as a query parameter, which is simply not needed at all. Now, the redirect is removed, as the Backend entrypoint / request handler handles the authentication of the backend user, and the standalone entry point deals with the install tool password etc. The context parameter is now detected by the entry point (!) as well, allowing to get rid of quite some code. There are some more consequences: - Calling the install tool from the backend does not validate if you configuration is set up (= recovery necessary) -> since you're already in the backend we guess you're fine anyway. - Redirect functionality is almost not needed anymore in the regular request handler - routeParameters concept was removed again (which was introduced a couple of weeks ago) Additionally, the contextService could be replaced at a later stage with just a string. Resolves: #82306 Releases: master Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c Reviewed-on: https://review.typo3.org/53860 Reviewed-by:
-
Daniel Lorenz authored
Properly render multiline form values in summary page and HTML emails. Resolves: #82026 Releases: master, 8.7 Change-Id: Ic0d9cca3712437cd4625a4644355f77db8f01587 Reviewed-on: https://review.typo3.org/53950 Reviewed-by:
Ralf Zimmermann <ralf.zimmermann@tritum.de> Tested-by:
-
Mathias Brodala authored
Use shorter file paths to reduce the risk of hitting the Windows file path limit. Resolves: #82336 Releases: master Change-Id: Ibbba15a71b6b69df52ccf009ebe298f09840d864 Reviewed-on: https://review.typo3.org/53946 Reviewed-by:
-
Tymoteusz Motylewski authored
Functional tests checking Extbase rendering of tt_content records with FAL images. Also fixes two typos in fixture data. Resolves: #82298 Releases: master, 8.7, 7.6 Change-Id: I2cddf81a99b08df46a7fd03dc0e54b41b10452e5 Reviewed-on: https://review.typo3.org/53921 Reviewed-by:
Nathan Boiron <nathan.boiron@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Susanne Moog authored
Usage of limit > 0 or offset in a count query do not make sense and result in broken pagination in the list module as the returned total count of items is always 0. Reset given offsets/limit for that exact query. Change-Id: I18b1964b860e51256a6d0a5f39fd4c40544bac85 Resolves: #82325 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53940 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Ralf Zimmermann authored
* Show messages within page module and form engine if the backend user does not have access to the selected form definition. * Show flash messages within page module and form engine if the ext:form configuration is invalid. Resolves: #80678 Resolves: #81113 Releases: master, 8.7 Change-Id: I9646b31ac44752b8871635c8f1a04547872e715d Reviewed-on: https://review.typo3.org/52701 Reviewed-by:
Frans Saris <franssaris@gmail.com> Tested-by:
-
Benni Mack authored
Defining all configuration options in TYPO3 Install Tool is now handled via a Yaml file which additionally specifies the "type" of the configuration option, allowing to use further render settings, one of them already introduced for "allowedValues". This moves the "All Configuration" to a more flexible output rendering of dropdowns for a specific type. Resolves: #82312 Releases: master Change-Id: Id23c6a8e57177a68659fe98cbe7278f8744c0c34 Reviewed-on: https://review.typo3.org/53923 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Claus Due authored
This patch removes the previously introduced runtime cache and early returns from TemplatePaths, both of which were implemented in an attempt to prevent excessive TypoScript parsing - an issue which has since been solved by optimising the TypoScript parsing enough that a cache and early return is no longer necessary (no longer constitutes a significant performance increase). The early return and caching introduced regressions described in the related forge issues. Removing both solves those problems. In addition, the method resolving TypoScript paths is now covered by extensive unit tests confirming everything from merging to sorting of template paths. An average of 8 tests cover the method's lines. Each of the expected behaviors is now declared as specific test. Change-Id: Ia6d505dcec7d77ad7aaeea9094d7d85a58553c63 Resolves: #82196 Resolves: #82181 Related: #79662 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53917 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Sep 06, 2017
-
-
Benni Mack authored
This brings PHP 7.2 support for guzzle functionality. Verified that guzzle still runs with PHP7.0 (min requirement for us) Resolves: #82313 Releases: master, 8.7 Change-Id: I65b27c41d49dcb8b740b6f276da305df864ff50e Reviewed-on: https://review.typo3.org/53924 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Xavier Perseguers authored
Change-Id: I807a888ac7d977606d94f5ad9ccdfeee07ee61ec Resolves: #82307 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53915 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
- Sep 05, 2017
-
-
Sebastian Fischer authored
The parameter $subpartContent of substituteSubpart() can be either string or array. IDEs need to have both present in the comment to not show warnings for given parameters that are correct. Resolves: #82308 Releases: master, 8.7 Change-Id: Ifcceb8dcd5ad8be56695cef161949046ff74c994 Reviewed-on: https://review.typo3.org/53916 Tested-by:
-
Oliver Hader authored
Releases: master, 8.7, 7.6 Change-Id: I167c68d7d04dd4b8c876b1f6f8f939cf3d933478 Reviewed-on: https://review.typo3.org/53905 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de>
-
Benni Mack authored
The constant TYPO3_user_agent is removed as it is not in use anymore since TYPO3 v8. Resolves: #82296 Releases: master Change-Id: I4860e291c1888251be5c64c2c454022f5d51643b Reviewed-on: https://review.typo3.org/53908 Reviewed-by:
-
Tymoteusz Motylewski authored
Functional tests checking TypoScript rendering of tt_content records with FAL images. Releases: master, 8.7, 7.6 Resolves: #82187 Change-Id: I5889ab13183b28dc2ff1ccc2c00c18f01ceacc76 Reviewed-on: https://review.typo3.org/53798 Tested-by:
-
Susanne Moog authored
Some web servers allow and accept pht files as PHP files and execute them. Thus, pht should be part of the default file deny pattern and PHP file extensions. Resolves: #82078 Releases: master, 8.7, 7.6 Security-Commit: d7e19499bfa4bd552d4428a2b9a943005c20c61d Security-Bulletin: TYPO3-CORE-SA-2017-007 Change-Id: Ibadcaa8c32b70b9aec569027862918d0360ec075 Reviewed-on: https://review.typo3.org/53904 Reviewed-by:
-
Susanne Moog authored
TYPO3 does no longer send the concrete TYPO3 version as part of the default User-Agent header when doing requests. Resolves: #82072 Releases: master, 8.7, 7.6 Security-Commit: f5558a5d745f2bafe3c27d5621ef1ce26f3989a9 Security-Bulletin: TYPO3-CORE-SA-2017-006 Change-Id: If9d7745d909e93899e2b405e016518a9284a1006 Reviewed-on: https://review.typo3.org/53903 Reviewed-by:
-
Georg Ringer authored
If a user creates a sys_file_collection record, only those storage records must be shown which are allowed for the user. Resolves: #82029 Releases: master, 8.7, 7.6 Security-Commit: 45cdfccd52a224d8128e537214606848c717d8e7 Security-Bulletin: TYPO3-CORE-SA-2017-005 Change-Id: Iee94cd84f07ee0dc0730fe1ce84d228dad2f75a2 Reviewed-on: https://review.typo3.org/53902 Reviewed-by:
-
Georg Ringer authored
The record title must be properly escaped. Resolves: #81967 Releases: master, 8.7 Security-Commit: bb686f45996424aadd68185871c14bb4544107c2 Security-Bulletin: TYPO3-CORE-SA-2017-004 Change-Id: I71c8bdef21e76fafdae170c6ebd9f0f0834d5b0e Reviewed-on: https://review.typo3.org/53901 Reviewed-by:
-
Benni Mack authored
StandaloneView currently replicates a lot of code which is already present within TemplateView (= Extbase), however, both classes inherit from AbstractTemplateView. In order to see which parts are different (and continue on streamlining fluid) the parts can be placed within AbstractTemplateView. Resolves: #82269 Releases: master Change-Id: I4184a5899b98227cf50f93db6c3ae38812cc86ec Reviewed-on: https://review.typo3.org/53831 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
- Sep 04, 2017
-
-
Jörg Bösche authored
The locallang_ttc.xlf has a typo in the key "space_before_class" which is shown in the access list of a page content field. Resolves: #82284 Releases: master, 8.7 Change-Id: Id61c8c7d5c5da11b8f7bb3e55e49d7613e593730 Reviewed-on: https://review.typo3.org/53875 Reviewed-by:
-
Georg Ringer authored
Remove a not needed </td> tag which has not been removed with the refactoring. Resolves: #82279 Releases: master, 8.7, 7.6 Change-Id: I2077e9e0b0119e6b064b0a6d4ebb9c3dc1d848a4 Reviewed-on: https://review.typo3.org/53873 Tested-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
-
- Sep 01, 2017
-
-
Benni Mack authored
Resolves: #82270 Releases: master Change-Id: I37fbb8c1d5199239eaa4cd432fb49d958bc86123 Reviewed-on: https://review.typo3.org/53859 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
Daniel Gorges <daniel.gorges@b13.de> Tested-by:
-
Claus Due authored
This patch improves the performance of TemplatePaths in two ways: * GeneralUtility::removeDotsFromTS() is called on a far smaller array instead of all TypoScript. * Fallback paths are allowed to be cached in the runtime cache which avoids re-reading TypoScript when no paths are configured in TS. Saves several thousand calls to removeDotsFromTs which in turn saves several tens of thousands of calls to in_array. Change-Id: Ib8aef69dc9136d355441ac05f21fe391e524eacc Resolves: #82232 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53824 Tested-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
-
Justus Leon Moroni authored
The TranslationService uses the additional key 'error' in its translations of the validation errors. See https://github.com/TYPO3/TYPO3.CMS/blob/master/typo3/sysext/form/Classes/Service/TranslationService.php#L428. Releases: master,8.7 Resolves: #82264 Change-Id: Id00b60de0bf1b2b882f583f538be9bc8e40c010f Reviewed-on: https://review.typo3.org/53851 Reviewed-by:
-
- Aug 31, 2017
-
-
Benni Mack authored
Uses PSR-7 instead of plain echo() and die - and shutdown the install tool properly (except for redirects currently). In the future, we should introduce proper PSR-7 response objects for certain responses (JSON, Redirect) but this will happen in a separate step. Resolves: #82268 Releases: master Change-Id: If8124f975936f6205f45009d30d979204765d8d1 Reviewed-on: https://review.typo3.org/53856 Tested-by:
-
Benni Mack authored
A new option $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemMaintainers'] is introduced, which contains a list of Backend User uids. It is then possible to restrict access to backend modules to system maintainers - most importantly the four Install Tool modules. When this option is not set in LocalConfiguration.php, then all admins are system maintainers, same goes for accessing TYPO3 in Development context. This is the first step to remove the necessary "enter your intall tool password" when accessing the install tool from within TYPO3 Backend. Resolves: #82266 Releases: master Change-Id: If0026748ede694394b4e7f39788a650816160146 Reviewed-on: https://review.typo3.org/53830 Reviewed-by:
-
Christian Kuhn authored
The master version of this 8.7 patch just removes last mentions of suhosin from the codebase. Change-Id: If003a8db37660662c65290a1e1bf25ef61375b80 Resolves: #82267 Related: #82257 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53858 Reviewed-by:
-
Benni Mack authored
The PHP request flow logic for authentication against the install tool password is moved into a new class called AuthenticationService. Additionally, all logic which is only needed inside the StepController is moved from the AbstractController into the StepController or the recovery request handler. ToolController and AjaxController are now free of session handling completely. Resolves: #82265 Releases: master Change-Id: Ib75c920877da81d7d859feaa5e6cbbcf4f0fd2cf Reviewed-on: https://review.typo3.org/53837 Tested-by:
-
Christian Kuhn authored
The install tool brought its own "status message" class structure since the 6.2 refactoring. This is used at many places in the install tool for message handling. The core has a very similar class construct "Messaging" with only little dependencies, too. To simplify a later separation of 'install tool' and 'installer' the internal status message class structure is removed and transitioned to the core Messaging structure. to get rid of just another special thing the install tool does. The ext:core FlashMessage and FlashMessageQueue now both implement the \JsonSerialize interface. This allows direct json_encode() calls on these objects, helpful for instance for ajax responses. In ext:install "Environment checks" suhosin specific checks have been removed since the project is dead and only has a pre-alpha php 7.0 fork, so probably nobody is using that with the given core PHP constraints anymore. Change-Id: Ifecd3cd4889d8db5aaf3e87f317c98be706ae82b Resolves: #82257 Releases: master Reviewed-on: https://review.typo3.org/53835 Tested-by:
-
Benni Mack authored
The left-over signals in EXT:install/ext_localconf.php belong to EXT:core (uses classes from EXT:core anyways) and since both extensions are required at any time (part of minimal system) this is just a separation cleanup. Resolves: #82241 Releases: master Change-Id: I9ec93ada9b4985ced285276fa5c33b851ec0be8f Reviewed-on: https://review.typo3.org/53836 Tested-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Mathias Brodala authored
Resolves: #82175 Releases: master, 8.7 Change-Id: I4b70b2a662b1818171bb180f88f8d40a48ee91ed Reviewed-on: https://review.typo3.org/53788 Reviewed-by:
-
Fabian Thommen authored
Releases: master Resolves: #82194 Change-Id: I6bb00c14dc331ec362614d00e48bf169da7cd572 Reviewed-on: https://review.typo3.org/53799 Tested-by:
Sidoine Ghomsi Nokam <s.ghomsinokam@neusta.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
-
Susanne Moog authored
PHP already converts strings representing 8-bit integers to int - so there are no numeric array keys that are of type string that ArrayUtility should reorder. Change-Id: Ieff77f4b1b8d6cbadba73dad06e9ec02d8748e85 Resolves: #82201 Releases: master Reviewed-on: https://review.typo3.org/53805 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Reviewed-by:
-
