[TASK] Install Tool: Remove authentication from backend context
Currently calling the install tool modules from within the Backend does a simple redirect with adding GET variables. That's the reason why you need to re-authenticate again, and the context is handed over as a query parameter, which is simply not needed at all. Now, the redirect is removed, as the Backend entrypoint / request handler handles the authentication of the backend user, and the standalone entry point deals with the install tool password etc. The context parameter is now detected by the entry point (!) as well, allowing to get rid of quite some code. There are some more consequences: - Calling the install tool from the backend does not validate if you configuration is set up (= recovery necessary) -> since you're already in the backend we guess you're fine anyway. - Redirect functionality is almost not needed anymore in the regular request handler - routeParameters concept was removed again (which was introduced a couple of weeks ago) Additionally, the contextService could be replaced at a later stage with just a string. Resolves: #82306 Releases: master Change-Id: If7e4ddfaccf46cf93448d06c0ba9af81d5b9494c Reviewed-on: https://review.typo3.org/53860 Reviewed-by:Romain Canon <romain.hydrocanon@gmail.com> Tested-by:
Romain Canon <romain.hydrocanon@gmail.com> Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de>
Showing
- typo3/sysext/backend/Classes/Http/BackendModuleRequestHandler.php 0 additions, 8 deletions...sext/backend/Classes/Http/BackendModuleRequestHandler.php
- typo3/sysext/core/Tests/Acceptance/Backend/Install/InstallModuleCest.php 0 additions, 112 deletions...re/Tests/Acceptance/Backend/Install/InstallModuleCest.php
- typo3/sysext/install/Classes/Controller/AbstractController.php 1 addition, 7 deletions.../sysext/install/Classes/Controller/AbstractController.php
- typo3/sysext/install/Classes/Controller/Action/AbstractAction.php 12 additions, 13 deletions...sext/install/Classes/Controller/Action/AbstractAction.php
- typo3/sysext/install/Classes/Controller/Action/ActionInterface.php 7 additions, 0 deletions...ext/install/Classes/Controller/Action/ActionInterface.php
- typo3/sysext/install/Classes/Controller/AjaxController.php 1 addition, 0 deletionstypo3/sysext/install/Classes/Controller/AjaxController.php
- typo3/sysext/install/Classes/Controller/BackendModuleController.php 66 additions, 54 deletions...xt/install/Classes/Controller/BackendModuleController.php
- typo3/sysext/install/Classes/Controller/StepController.php 5 additions, 0 deletionstypo3/sysext/install/Classes/Controller/StepController.php
- typo3/sysext/install/Classes/Controller/ToolController.php 1 addition, 0 deletionstypo3/sysext/install/Classes/Controller/ToolController.php
- typo3/sysext/install/Classes/Service/ContextService.php 4 additions, 5 deletionstypo3/sysext/install/Classes/Service/ContextService.php
- typo3/sysext/install/ext_tables.php 4 additions, 24 deletionstypo3/sysext/install/ext_tables.php
Please register or sign in to comment