- Aug 23, 2017
-
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Mathias Brodala authored
Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7 Resolves: #82131 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53731 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Christian Kuhn authored
Change a series of cgl details after update of php-cs-fixer from 1.0 to 1.4. Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f Resolves: #82171 Related: #82164 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53776 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
- Aug 22, 2017
-
-
Frans Saris authored
To completely disable the Install Tool you can just leave the `installToolPassword` value empty in your LocalConfiguration. Problem here is that not all password hashing methods can handle an empty value without giving PHP warnings. This patch changes the password check in reporting to skip the install password hashing/check when there is no password. Releases: master, 8.7 Resolves: #82147 Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5 Reviewed-on: https://review.typo3.org/53757 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
Anders Kostending authored
Updates D3.js to the latest release version, 4.10.0. Release notes: https://github.com/d3/d3/releases/tag/v4.10.0 Fixes: * Add d3.areaRadial; deprecate d3.radialArea. * Add d3.lineRadial; deprecate d3.radialLine. * Add d3.pointRadial. * Add zoom.translateTo. * Re-implement d3.packEnclose using Matoušek-Sharir-Welzl. * Fix d3.packSiblings to center the circles more consistently around a fixed origin. * Fix axis rendering when a scale has a non-numeric range. * Fix interval.offset on filtered time intervals when step is negative. * Fix invocation of requestAnimationFrame in Edge. * Invoke nest.sortValues comparator prior to nest.rollup aggregator. * Drag & zoom behaviors now only register touch event listeners when touch is supported. * Drag & zoom behaviors now set the touch-action style to “none” when touch is supported. Resolves: #81945 Releases: master, 8.7 Change-Id: Idcd0826d2bd50467558d1bd6229d84651b93f4b0 Reviewed-on: https://review.typo3.org/53574 Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Reviewed-by:
Morten Pless <mpl@systime.dk> Tested-by:
Faton Haliti <fha@systime.dk> Reviewed-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
Helmut Hummel authored
The encryption key is a vital part to ensure security of TYPO3. Not having it set (by accident) can lead to severe security issues. Therefore enforce it to be set and throw an exception in case it isn't, instead of just reporting a warning. Releases: master, 8.7, 7.6 Resolves: #82169 Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3 Reviewed-on: https://review.typo3.org/53724 Tested-by:
-
Jigal van Hemert authored
The extension scanner now also works on windows, as the paths have been fixed to contain only one type of slashes. Change-Id: I9859f28029931f19f06873145e1de572fbb8bdfa Resolves: #82153 Releases: master Reviewed-on: https://review.typo3.org/53763 Tested-by:
-
Christian Kuhn authored
Executing 'npm run build-js' in Build/ directory reveals an update to tsconfig.json which has not been applied to core yet. Change-Id: Ida813943c3c8dc13059a707a9ea89954a14b3fd4 Resolves: #82173 Related: #81847 Releases: master Reviewed-on: https://review.typo3.org/53782 Tested-by:
-
Christian Kuhn authored
The em in "Installed Extensions" has a button "Download SQL Dump" for all extensions that provide ext_tables.sql. On click, an sql dump file is sent. This feature is severely flawed: * Dumps of extensions that add fields to existing tables contain a 'drop table' of these tables, the 'import into' statements are broken and only (try to) add these fields again. This easily leads to hazard in DB if importing such a dump. * There are no charset specs and other meta data whatsoever in the dump. * The dump is not dbal compatible, field definitions and imports are incomplete. We assume nobody really used this feature in a sane way, even at this prominent position in em. The lack of bug reports to this broken feature and the fact there have been zero changes in this area since main em refactoring years ago support this view. There are way better options to retrieve proper data specifications: * The list module has a csv export * Ext:impexp supports export and import in a much better way including proper relation handling and other options. * Low level db exports and backups should be done on cli or with more powerful guis like phpmyadmin or other db engine specific tools. The feature is dropped without substitution. The v8 backport of this patch will just remove the button from the em list view, but keep all code. Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070 Resolves: #82148 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53764 Tested-by:
-
Benni Mack authored
Drop three error related constants from bootstrap: TYPO3_DLOG, TYPO3_ERROR_DLOG, TYPO3_EXCEPTION_DLOG Removal of these constants has been prepared in v8 and can be done now. This unblocks further logging related works. Along the way, the two TYPO3_CONF_VARS "enable_errorDLOG" and "enable_exceptionDLOG" can be dropped. The extension scanner can find usages of these constants, making the patch not less breaking, but usage detection within extensions is safe and thus helps a lot to spot them. A new matcher is added to the extension scanner to scan for usages of global constants. Resolves: #82162 Releases: master Change-Id: I6310866738e5cda79a807239846f64996ec76974 Reviewed-on: https://review.typo3.org/53212 Reviewed-by:
-
Christian Kuhn authored
travis-ci still chockes on executing the functional tests which take ages, even with various tricks in place. The patch reduces the travis execution to unit tests only since all main tests are executed via our bamboo environment anyway beforehand. Change-Id: I809f38d79f0ac7848e6b7e155d35aab575f4d81a Resolves: #82172 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53780 Reviewed-by:
-
Jan Helke authored
This file is only used by typo3/testing-framework and has been moved to that repository since version 1.1.1. Releases: master, 8.7 Resolves: #81900 Change-Id: I5f88bd89c4cadd2fe65f4d0bc9f4494e172f4d2a Reviewed-on: https://review.typo3.org/53643 Tested-by:
-
Christian Kuhn authored
travis-ci still chockes on functional tests, even if splitting them among lots of single tasks. Run less tests in parallel and split to ever more jobs to have a higher chance for 10 minute output with given cpu constraints. Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7 Resolves: #82170 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53775 Tested-by:
-
Christian Kuhn authored
Fix three issues blocking core patches. Change-Id: I07deff6294061d04e15bd1a7707e504413bb30c9 Resolves: #82168 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53773 Tested-by:
-
Wouter Wolters authored
* codeception/codeception (2.3.3 => 2.3.5) * enm1989/chromedriver (2.30 => 2.31) * friendsofphp/php-cs-fixer (v2.0.0 => v2.4.1) Resolves: #82164 Releases: master, 8.7 Change-Id: I2543b99a7e4751c09ebd733335cc3eddc025d189 Reviewed-on: https://review.typo3.org/53769 Tested-by:
-
Christian Kuhn authored
The bamboo nightly job [1] fails due to a minor CGL issue which somehow slipped through. [1] https://bamboo.typo3.com/browse/CORE-GTN Change-Id: I9e0af185e757192846185c0b7e601ff33e05e491 Resolves: #82165 Releases: master Reviewed-on: https://review.typo3.org/53771 Tested-by:
-
Christian Kuhn authored
Remove <hr> of last wizard. Change-Id: I25a52d882e99333d4598e1dcc632300e2a8860ac Resolves: #82158 Releases: master Reviewed-on: https://review.typo3.org/53768 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Frank Naegler authored
This patch makes the Notification module in standalone install tool usable by adding the required CSS and fixing the dependency to the global TYPO3 object, which only exist in backend context. Resolves: #82138 Releases: master Change-Id: I954324e9d19569eedb1eb5e0ecfaf821fcecb070 Reviewed-on: https://review.typo3.org/53760 Reviewed-by:
-
Susanne Moog authored
In various places throughout the core we are using timestamps followed by a dot as unique identifiers for array keys (for example the avatar service is registered that way). The ArrayUtility renumbering function renumbers these keys on writing configuration, meaning that you cannot overwrite services registered like that via the configuration manager. ArrayUtility should not re-order strings containing a number ending with a single dot. Change-Id: I7dc1625cfdbab6704df87a8cc06f331d92992d24 Releases: master Resolves: #82155 Reviewed-on: https://review.typo3.org/53767 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Frank Naegler authored
This patch refactors the CardLayput.js to prevent some trouble with the navigation icons in the doc header. Resolves: #82151 Releases: master Change-Id: I6739de816b458a7b8c85c519d46664831dfa070c Reviewed-on: https://review.typo3.org/53762 Tested-by:
-
Christian Kuhn authored
Change an invalid class name. Change-Id: I146cbb27dae6e9b1044ef8e296989d7a6dba7056 Resolves: #82150 Releases: master Reviewed-on: https://review.typo3.org/53766 Reviewed-by:
Joerg Kummer <typo3@enobe.de> Tested-by:
-
Frank Naegler authored
Resolves: #82150 Releases: master Change-Id: I962a41df0f0375bbf1b325f29d270d8fe2da0e5f Reviewed-on: https://review.typo3.org/53761 Tested-by:
-
Christian Kuhn authored
The ext:func module menu image building is still referenced in the Gruntfile. Change-Id: Iaafed19faa9d99eca2ebce41ea622ef85728eabc Resolves: #82154 Releases: master Reviewed-on: https://review.typo3.org/53765 Tested-by:
-
Christian Kuhn authored
Refactor the 'clear tables' view of the install tool: * Main content is loaded on opening the card via ajax * Tables with 0 rows are no longer shown * Refresh view after 'clear this table' ajax action has been clicked Change-Id: I8608e6561eaf9d0ae06da8e27b25c5ce879a5b62 Resolves: #82136 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53743 Tested-by:
Jan Stockfisch <jan.stockfisch@googlemail.com> Tested-by:
-
- Aug 21, 2017
-
-
Frans Saris authored
Releases: master, 8,7 Resolves: #82144 Change-Id: I24b2d57e37f6ff95b7ec7bdab7cda0f21e85c90b Reviewed-on: https://review.typo3.org/53750 Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Tested-by:
-
Tymoteusz Motylewski authored
Introduce and Extbase version of the LocalizedContentRenderingTest. It tests how language related TS settings influences content rendering. Also changes exception code in ContentController, to make bamboo happy. This test suite is documenting current behaviour, which is in fact inconsistent with TypoScript tt_content rendering. The next step is to provide a fix for extbase with a feature switch, so this test suite will become a version with feature swich being disabled. Resolves: #81823 Releases: master, 8.7, 7.6 Change-Id: Ia616e5089b0209cfb895216726f7192f39c88a45 Reviewed-on: https://review.typo3.org/53426 Tested-by:
-
Christian Kuhn authored
With the ever growing number of functional tests, we split the suite into more parts to prevent "No output has been received in the last 10 mins". Change-Id: I55665c723f91f77347b376992f7a7a28da67b0fd Resolves: #82145 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53752 Tested-by:
-
Christian Kuhn authored
In the extension scanner, if opening a single extension view for the first time, the scanner is correctly triggered again. Change-Id: I72d18a17d735d67109135205684f25c75dc77711 Resolves: #82140 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53744 Tested-by:
-
Christian Kuhn authored
The JsonView should return the detail message text as 'message' array and not as 'status'. Change-Id: I492d31ee8fe3895c97e0229369c5f3ca09f7b713 Resolves: #82137 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53742 Tested-by:
-
Christian Kuhn authored
Fix a JS selector to correctly toggle on "Toggle All" again. Change-Id: Ie21c8c41fb9ba1aba4eedb197603a8c2a7111477 Resolves: #82141 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53745 Tested-by:
-
- Aug 20, 2017
-
-
Wouter Wolters authored
The type field contains a non existing field. Do not select this field in the query. Resolves: #82105 Releases: master, 8.7, 7.6 Change-Id: I9840712f4f87135740512ddf91a2b921b2515612 Reviewed-on: https://review.typo3.org/53710 Tested-by:
-
- Aug 19, 2017
-
-
Andreas Fernandez authored
Resolves: #82103 Releases: master, 8.7, 7.6 Change-Id: I3e04559c05381c49ab390dc3ad0d3eebddc5a57f Reviewed-on: https://review.typo3.org/53707 Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
- Aug 18, 2017
-
-
Mona Muzaffar authored
The patch applies a major refactoring of the "tool" part of the install tool. As the most visible change, the install tool application is now split from the "install" backend module menu entry into four different entries - "Maintenance", "Settings", "Upgrade" and "Environment". This is in-line with the strategy outline at https://decisions.typo3.org/t/typo3-system-management-the-big-picture The patch can be seen as the main separation and split patch to introduce the integration of the install tool application into the overall backend look and feel. On the visible side, single install tool actions that were spread over the old menu entries like "all configuration" and friends are now given single "cards" within one of the four main module entries. The "standalone" version of the install tool is now similar to the backend view - just without all the other module menu entries. Aside from this major visible change, the patch comes with a main refactoring of the underlying PHP code and click behavior: * All "action" buttons that initiate something are now ajax based. Codewise, this is the major part. * No main controller loads ext_tables / ext_localconf anymore. * Main "Install.js" is now mostly a dispatcher to load specific requireJs components determined by given clicked main module. * Major refactorinng of JavaScript output and click-flow. * Introduce various new "services". Ajax actions always return objects and arrays, but no HTML. This is a major step towards proper cli and psr-7 integration. Even with the install tool paradigm "never cache anything", the application feels very snappy due to slim main controllers and straight single Ajax action triggers. Some parts of the internal PHP API of the install tool have been changed. While the install tool is "internal" anyway, this patch has been marked as [!!!] to hint extension developers in the unlikely case it breaks some low level extension. The state of this major change is not "perfect": There are various details to improve. However, this patch has more than 9k lines, all major parts work fine and the huge file juggling prevents other patches from being integrated. Glitches and further improvements can be done with small patches afterwards. Resolves: #76084 Releases: master Change-Id: I2cc93f35c0760fce33c2136d41159c802932dfc4 Reviewed-on: https://review.typo3.org/53109 Reviewed-by:
Marco Christian Krenn <krenn@webconsulting.at> Tested-by:
Philipp Hamid <ph@supertrumpf.at> Tested-by:
-
Pascal Langhals authored
At the moment there is no possibility to disable the client side validation for the fluid form tag. Releases: master,8.7 Resolves: #81654 Change-Id: I8adbd51f0d50528e8a7d92fc4aeb2315aefafee7 Reviewed-on: https://review.typo3.org/53299 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
Matthias Vogel <typo3@kanti.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
-
Michael Oehlhof authored
When creating an "update storage index" task, now the selected storage is saved correct. Resolves: #67241 Releases: master Change-Id: I371c5aa882ff78095536f1e413d58850ccb46c2b Reviewed-on: https://review.typo3.org/51036 Reviewed-by:
-
Wouter Wolters authored
Releases: master,8.7,7.6 Resolves: #82079 Change-Id: I21a6ebcff4ebd0c6f2d2c83e0aa6d9e2c03d32d9 Reviewed-on: https://review.typo3.org/53720 Tested-by:
-
Georg Ringer authored
Instead of using 2020 use the technical limit of 32bit which is 2038. Resolves: #81940 Releases: master, 8.7 Change-Id: If0b1bee101b4917d7a974dd0e91f79bc24139227 Reviewed-on: https://review.typo3.org/53582 Tested-by:
Sonja Großewinkelmann <s.grossewinkelmann@neusta.de> Reviewed-by:
-
Wouter Wolters authored
Correctly use htmlspecialchars for the link. Resolves: #82077 Releases: master,8.7,7.6 Change-Id: I87ea4010aa187f5f601c31423fb1a0fc05a23107 Reviewed-on: https://review.typo3.org/53719 Tested-by:
-
Wouter Wolters authored
The AjaxDataHandler JavaScript must be loaded to add the on click handlers. Resolves: #81685 Releases: master,8.7 Change-Id: If3616ee99a73171be3a878abce40de7e5c0e8225 Reviewed-on: https://review.typo3.org/53730 Tested-by:
-
Tymoteusz Motylewski authored
Third argument passed to BackendUtility::viewOnClick should be an array or null. Resolves: #82124 Releases: master, 8.7 Change-Id: I330d2fcbbc30d9f22f4758ad84599755a1d707ad Reviewed-on: https://review.typo3.org/53721 Reviewed-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
