Skip to content
Snippets Groups Projects
Commit 2798e522 authored by Frans Saris's avatar Frans Saris Committed by Benni Mack
Browse files

[BUGFIX] Mark not set Install Tool password as secure

To completely disable the Install Tool you can just leave the 
`installToolPassword` value empty in your LocalConfiguration. 
Problem here is that not all password hashing methods can handle an 
empty value without giving PHP warnings.

This patch changes the password check in reporting to skip the install 
password hashing/check when there is no password.

Releases: master, 8.7
Resolves: #82147
Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5
Reviewed-on: https://review.typo3.org/53757


Reviewed-by: default avatarWouter Wolters <typo3@wouterwolters.nl>
Tested-by: default avatarTYPO3com <no-reply@typo3.com>
Reviewed-by: default avatarWolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: default avatarJoerg Boesche <typo3@joergboesche.de>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarSebastian Fischer <typo3@evoweb.de>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarBenni Mack <benni@typo3.org>
parent 5ae3fc87
Branches
Tags
No related merge requests found
......@@ -52,7 +52,7 @@ class SecurityStatusReport implements \TYPO3\CMS\Reports\StatusProviderInterface
$validPassword = true;
$installToolPassword = $GLOBALS['TYPO3_CONF_VARS']['BE']['installToolPassword'];
$saltFactory = \TYPO3\CMS\Saltedpasswords\Salt\SaltFactory::getSaltingInstance($installToolPassword);
if (is_object($saltFactory)) {
if ($installToolPassword !== '' && is_object($saltFactory)) {
$validPassword = !$saltFactory->checkPassword('joh316', $installToolPassword);
} elseif ($installToolPassword === md5('joh316')) {
$validPassword = false;
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment