- Jun 17, 2024
-
-
Garvin Hicking authored
Once the ExtensionScanner hits a '@extensionScannerIgnoreLine' annotated code line, it internally sets a flag that is never reset. That causes all following lines to be ignored, not just one. This patch will reset the property `$isCurrentLineIgnored` to `false` again, once the annotated line has passed. Tests are adapted to verify this behaviour. Due to the behavioral change it is possible that the scanner now finds more hits in third-party scanned extensions that previously may have been ignored. Resolves: #100702 Releases: main, 12.4 Change-Id: Ib1cbb5e7758e7e302e4395d759e8585eeff15d8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84716 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Torben Hansen authored
This change removes redundant typecasts in ext:fluid, where the variable type already matches the type being cast. Resolves: #104122 Releases: main Change-Id: I9ff2f0eaeae1f931179dcfe85c99d877e67dd132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84728 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Christian Kuhn authored
The release comes with a nifty memory usage improvement and probably allows us to avoid a couple of hacks we've used, which we'll clean up later. Raise for now. Core v12 will raise phpunit 10 instead. > composer req --dev phpunit/phpunit:^11.2.2 Resolves: #104127 Releases: main, 12.4 Change-Id: I4faf1af0378e2996324b3db101709764a31419b0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84730 Tested-by:
Garvin Hicking <gh@faktor-e.de> Tested-by:
-
Christian Kuhn authored
Have a switch/case for the main per-type construct and avoid loops per type. Resolves: #104110 Related: #101553 Releases: main Change-Id: I8c4751a266c979fa96f78a6328e1a70e02e1b91f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84714 Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christoph Lehmann authored
BackendAccessDeniedException is thrown due to inproper client ip. BackendLockedException is thrown when the backend is locked. Both cases are desired behaviour, so they should not get logged. Resolves: #104120 Releases: main, 12.4 Change-Id: If29f4bb58d78a3a3dfcd6d1815ae1b0404311662 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84726 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Andreas Kienast authored
When EXT:workspaces is installed, backend users with granted permissions may now search for workspaces in the LiveSearch and invoke certain, related actions. Resolves: #102869 Releases: main Change-Id: I6fd9a67708cdf70ef13f6395641c30fb51a7d4a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82516 Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
Andreas Nedbal <andy@pixelde.su> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
- Jun 15, 2024
-
-
Philipp Kuhlmay authored
This fixes some labels in EXT:styleguide Resolves: #104107 Releases: main, 12.4 Change-Id: I04fb8067220879aca1341e93d7ab4e00990387fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84723 Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Andreas Nedbal authored
Backend users can now search for the backend modules they have access to in the LiveSearch. Resolves: #92009 Releases: main Change-Id: I28d9593655989f064b7a7fac0ab80415eee4c6fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84654 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Jun 14, 2024
-
-
Simon Praetorius authored
This patch adds a new condition-based Fluid ViewHelper which allows integrators to check for feature flags from within Fluid templates. Resolves: #104020 Releases: main Change-Id: I76d19f4ec4888268b51fb9358812a870d79db41c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84719 Tested-by:
-
Oliver Bartsch authored
A new multi record selection option is added to the filelist, which allows to edit the metadata of multiple records while respecting the currently defined columns list. Resolves: #104095 Releases: main Change-Id: Ib679628f280116de47e6f59ec5e3cec0e4f9535a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84695 Tested-by:
Jochen Roth <rothjochen@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
A new multi record selection option is added to the recordlist, which allows to edit multiple records while respecting the currently defined columns list. Resolves: #104085 Releases: main Change-Id: I740a8b31381bbc03c178e4b2048c760f5d31afd6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84682 Tested-by:
-
Oliver Bartsch authored
Defining columnsOnly, which is used by the EditDocumentController to instruct the FormEngine to only render a subset of available fields for records is now table aware. This allows to render records from different tables in the same request, while respecting the fields to be rendered on a per-table basis. The "columnsOnly" parameter therefore now requires the fields as array under the corresponding table name: &columnsOnly[pages][0]=title A backwards-compatibility layer is in place, migrating the previous syntax to the new one by adding the configured fields for the tables from the edit configuration. Resolves: #104108 Releases: main, 12.4 Change-Id: I46500100eb369ad117a2cf5c61a9811c6fd5c7a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84711 Tested-by:
-
Christian Kuhn authored
We've had quite a few patches to streamline and clean up indexed_search. This patch continues these efforts. ext_conf_template.txt debugMode from 2014: "Only for debugging since it slows down the system and fills the database with crap." This is still true: Enabled debugMode fills the database with crap. Looking closer at the functionality, we decided to remove it without substitution: * Persisting debug info triggered by FE scaling with the number of pages or worse isn't a great idea in the first place. * This debug is more log-like, we do have rotation handling of large logs, but of course not for something like this debug table. * It's risky enabling debugMode in dev and then accidentally deploying this to live, potentially ending up with a *huge* table. * The debug data is actually not really helpful: It basically logs the ext config (boring and redundant) over and over again, plus some close to never changing info which file parsers are registered, plus FE content. Important parts derived from this FE content is already stored in index_phash, and the content *itself* is cut at 1000 chars, which isn't helpful either. There is actually nothing fancy in this table that couldn't be discovered with true debugging tools by developers. The patch removes the ext_conf_template.txt debugMode setting, plus the table. This is not considered breaking since it's internal and not extendable ext:indexed_search functionality. Resolves: #104104 Releases: main Change-Id: I492cd63171d97c77b8f8d56d748d8e09123f4e68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84708 Tested-by:
-
Christoph Lehmann authored
Local resources are currently not "cache-busted", for example, have no version in URL. TypoScript has no possibility to add the cache buster. When replacing them a new filename must be used (which feels little hacky), because web clients may have cached the old file version. This introduces 1) getText "asset" to cache-bust assets in TypoScript .. code-block:: typoscript page.20 = TEXT page.20 { value = { asset : EXT:core/Resources/Public/Icons/Extension.svg } insertData = 1 } # Result: typo3/sysext/core/Resources/Public/Icons/Extension.svg?1709051481 2) cache-busted assets with the :html:`<f:uri.resource>` ViewHelper .. code-block:: html <f:uri.resource path="EXT:core/Resources/Public/Icons/Extension.svg" /> Before: typo3/sysext/core/Resources/Public/Icons/Extension.svg Now: typo3/sysext/core/Resources/Public/Icons/Extension.svg?1709051481 The ViewHelper argument :html:`useCacheBusting` is enabled by default. Depending on FE/versionNumberInFilename the cache buster is applied as query string or embedded in the filename. Resolves: #99203 Releases: main Change-Id: Ie421a1a9b08b542686437bb65c8663e433045a58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/77018 Reviewed-by:Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by:
Josef Glatz <typo3@josefglatz.at> Tested-by:
-
Christian Kuhn authored
Add 'title' column to TCA to it auto created in DB. Resolves: #104109 Releases: main Change-Id: I246bb64825bae93d252937a04f32ebb9548212d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84713 Tested-by:
-
Christian Rath-Ulrich authored
Resolves: #104065 Releases: main, 12.4 Change-Id: I48c121620bf84a9444ff3c9d79d1adfd1fa631f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84655 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Reviewed-by:
-
Benni Mack authored
In order to enable more possibilities in the events, the PSR-14 events in EXT:felogin are extended with the PSR-7 request object, otherwise the events are useless as $GLOBALS['TYPO3_REQUEST'] must be used. Currently, it is f.e. not possible to modify the view ModifyLoginFormViewEvent based e.g. on a site configuration. Resolves: #104100 Releases: main, 12.4 Change-Id: I9daa6481d71fd1cae98d0a7ab01fe1adc7602748 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84696 Reviewed-by:
-
Bingquan Bao authored
The documentation contained a wrong registration code example, which now uses the proper array depth level notation. Releases: main, 12.4, 11.5 Resolves: #104105 Change-Id: Idb3c9b0e723af2f1bb579bc304637497e1272e36 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84709 Tested-by:
Lina Wolf <112@linawolf.de> Tested-by:
-
Torben Hansen authored
Extbase validators do currently not provide the possibility to include PSR-7 request related data for validation. With this change, validators extending extbase `AbstractValidator` will include the PSR-7 request object when instantiated by `ValidationResolver`. Extension developers can use data available in the PSR-7 request object in custom validators. Resolves: #102951 Releases: main Change-Id: I3012c778078de1b69cecfb36f05ce8f9794adf88 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82895 Reviewed-by:
-
Benni Mack authored
The StandardContentPreviewRenderer has some quirks, which allows to render the content via a Fluid Template via Page TSconfig. mod.web_layout.tt_content.preview.textmedia = EXT:site_mysite/Resources/Private/Templates/Preview/Textmedia.html This is now done via a PSR-14 EventListener. This was previously (back in v10) not possible while the legacy "Page module" and the "Fluid-based" page module existed and the PSR-14 event was not possible. This way, the StandardContentPreviewRenderer is trimmed down. Also, some additional logic is now restructured within the StandardContentPreviewRenderer in order to separate the class into smaller pieces. Also, the TextmediaPreviewRenderer as well as the ImagePreviewRenderer are not needed anymore. Resolves: #103603 Releases: main Change-Id: I879b913529c5928b67d2f98a438015719fc55f86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83744 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Jun 13, 2024
-
-
Christian Kuhn authored
Field / column 'repository' is obsolete since #92457, but couldn't be removed at this point in time. It's possible now. Resolves: #104102 Related: #92457 Releases: main Change-Id: I5ebcc65f5f9520b065ad3bddba728566b1264325 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84704 Tested-by:
-
Andreas Kienast authored
With the upgrade to Bootstrap 5, the panels have no explicit position anymore, breaking the progress bars in the Extension Scanner found in the Install Tool. This commit adds a relative positioning to the panels. Resolves: #104073 Releases: main, 12.4 Change-Id: Ie67989dbcfa859ebc3020dabaa27913de7ae4b64 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84663 Tested-by:
-
Nikita Hovratov authored
The goal here is to have a generic PreviewRenderer, which is not tt_content specific. The StandardContentPreviewRenderer could then extend this generic renderer. This is a pre-patch to make the refactoring easier in the next patch. For this to work, GridColumnItem now exposes methods to retrieve the table from the context, the type column and the record type. Additionally, some drive-by refactorings have been done like early return statements and stricter checks. The unused variable $infoArr has been removed as well. Resolves: #102825 Releases: main, 12.4 Change-Id: I38eab3c095e06b789915600e79b7831556a25ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82442 Tested-by:
-
Benni Mack authored
While cleaning up BackendLayout code, a "declare(strict_types=1);" line was introduced, which made existing v13-compatible PHP code break. This is now reverted in order to smoothen the upgrade path to v13 LTS. Resolves: #104099 Related: #103365 Releases: main Change-Id: Ic0de7e903da365178d5e417ff5eeb60c00f1b516 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84701 Reviewed-by:
-
Georg Ringer authored
The bookmark title within the following modules is enriched by the page id: - Info module Resolves: #103909 Releases: main, 12.4 Change-Id: I715a55dea86ac08f1a3dbeeff01e8d1b03712464 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84523 Tested-by:
-
Christian Kuhn authored
Tables with TCA columns set to type="input" do not need an ext_tables.sql entry anymore. The core now creates this field automatically. This is one of many patches in this area: The v13 goal is to obsolete ext_tables.sql in most cases by creating default "business" fields of TCA tables automatically. The patch adds the main magic in class DefaultTcaSchema and removes own ext_tables.sql definitions having type=input. Resolves: #102279 Related: #101553 Releases: main Change-Id: Ia371638bb10d0521cec01542e3a5fc7a364609f1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83183 Reviewed-by:
-
Torben Hansen authored
This change cleans up extbase persistence backend class, by: * using constructor property promotion * using strict types and return types where possible * removing self explaining method doc comments Resolves: #104006 Releases: main Change-Id: Idb9d6fe252095d3ded49e752becc09957d8ee63e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84532 Tested-by:
-
Christoph Lehmann authored
When the record does not exist anymore, then the FlexForm definition might also not exist anymore (imagine a removed plugin) and it results in an Exception. Resolves: #102656 Releases: main, 12.4 Change-Id: I3eac287a50366ae8ca66416080738634eb65ae97 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83648 Reviewed-by:
Christian Weiske <typo3-2022@cweiske.de> Tested-by:
-
Andreas Nedbal authored
With the rework of moving the "Show clipboard" toggle into the view mode dropdown for the list and filelist module, the functionality of the user TSconfig "options.file_list.enableClipBoard" and the page TSconfig "mod.web_list.enableClipBoard" has been broken. This commit fixes the functionality, aligning it with the documented behaviours. Resolves: #102145 Releases: main, 12.4 Change-Id: I17e3677638ea9d2f950a9f8d6c33ad089fc813c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84666 Reviewed-by:
-
Christian Rath-Ulrich authored
Resolves: #104071 Releases: main, 12.4 Change-Id: I9e0958168cf9812e20fbd3d3be2ce8dab80a8bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84661 Tested-by:
-
Georg Ringer authored
SuggestWizard should also find records in workspace. Resolves: #81732 Releases: main, 12.4 Change-Id: Ic552cd3329174632eb5be92ff9f7876959a454f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84518 Tested-by:
-
Christian Kuhn authored
Resolves: #104094 Releases: main Change-Id: I0d732915975135e2eb04c6c854b6b01257c3aec9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84694 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Andreas Kienast authored
The settings for the `typo3-t3editor-codemirror` element were passed in an `options` attribute, which is unknown. This leads to the issue that e.g. the `readOnly` flag set in TCA is ignored. The composed settings are now properly merged. Resolves: #104084 Releases: main, 12.4 Change-Id: I7e34a8230764c33b7924128176088ab32cb35a58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84685 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Stefan Bürk authored
Doctrine DBAL uses lowercased array index names for table or index names, which has been used to make RENAME DDL statements. Due to the lack of having the old information correctly in place, this leads to invalid RENAME DDL statements for tables or indexes having upper case characters in the name. That is a edgecase for PostgreSQL and SQLite due to custom index name handling based on that array key. This change modifies the ConnectionMigrator to use correct casing for column and index naming in case table or column needs to be renamed. That allows, that following correct DDL statements are now created: ALTER INDEX "freeIndexUid_65098221" RENAME TO "customFreeIndexUid_6dedc8fa" ALTER TABLE "index_phash" RENAME COLUMN "freeIndexSetId" TO "zzz_deleted_freeIndexSetId" in case the `EXT:indexed_search/ext_tables.sql` is changed for table `index_phash` to drop the `freeIndexSetId` column by commenting it out or remove it and renaming `freeIndexUid` index to `customFreeIndexUid`. [1] [1] https://review.typo3.org/c/Packages/TYPO3.CMS/+/84576/3/typo3/sysext/indexed_search/ext_tables.sql Resolves: #93223 Releases: main, 12.4 Change-Id: I195ad021b8826be59a3ae78a926a396528ca0c66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84576 Tested-by: -
Georg Ringer authored
The key `record` might not always contain the full record. When using the `FormSlugAjaxController`, the record might just contain a sub-set of fields. Resolves: #94388 Releases: main, 12.4, 11.5 Change-Id: Ie72d6701ebef4da8af8b039e0da056e28b8d0ecb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84574 Reviewed-by:
-
Georg Ringer authored
Instead of rendering the tag meta tag `twitter:card` always it is now only rendered if either one of the twitter fields is filled or the twitter card attribute is selected in the page record. Additionally the default value is now set to an empty string This leads to one markup line less for most of the pages. Resolves: #101621 Releases: main Change-Id: I55061debc4425d8c2207efec7ee5c5d376a83ca3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84622 Tested-by:
-
Oliver Bartsch authored
Resolves: #104088 Releases: main Change-Id: I22ed897cf9f320ddaa6a51fdb133c61df264af7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84684 Reviewed-by:
-
Oliver Bartsch authored
The toggle button to open the selection options of the multi record selection component does now provide an aria-label to make it accessible for screen readers. Resolves: #104089 Releases: main, 12.4 Change-Id: I89af5e4f5a0f8dd87be5d532bdd894bd2636502e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84686 Tested-by:
-
Rozbeh Chiryai Sharahi authored
The current `SlugHelper` implementation make several tasks hard to implement, for example language aware transliteration, customization for extension tables or 3rd party data adaptations. It makes sense to extract the `slug (url segment)` sanitization into a dedicated normalization class as a preparation for further improvements and also making the new implementation DI aware right from the start. Other parts will be streamlined in further changes to modernize the slightly unhandy `SlugHelper`. This change moves the slug normalization code now from the `SlugHelper::sanitize()` method into a dedicated class, adjusts the `SlugHelper` tests and duplicate the tests for the new implementation. Resolves: #104090 Releases: main Change-Id: I5126dedc3c9e1e0395087f72d3aafd41c30b4980 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/84608 Reviewed-by:
-
Garvin Hicking authored
The modal to download selected data from a record listing (Web > List) is enhanced to display a list of configured presets. These presets can be defined via page TSconfig or user TSconfig. The listed columns take personal "exclude fields" into consideration. A preset definition looks like: ``` mod.web_list.downloadPresets { pages { 10 { label = Test-Preset-1 columns = uid, title, crdate, slug } 20 { label = LLL:EXT:myext/Resources/Private/Language/locallang.xlf:preset2.label columns = uid, title, slug identifier = some-identifier } } } ``` Multiple presets for one table can exist, and as many presets for as many tables as needed are possible. Extensions can provide such preset definitions in their `Configuration/page.tsconfig` file, or in Site Sets. A new PSR-14 event `BeforeRecordDownloadPresetsAreDisplayedEvent` allows to modify the list of presets as well. A new PSR-14 event `BeforeRecordDownloadIsExecutedEvent` allows to modify the actual download data, replacing the old hook usage of $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS'] ['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList'] ['customizeCsvHeader'] and $GLOBALS['TYPO3_CONF_VARS'] ['SC_OPTIONS']['TYPO3\CMS\Recordlist\RecordList\DatabaseRecordList'] ['customizeCsvRow']. These hooks have been deprecated and are scheduled for removal with TYPO3 v14; the only public TYPO3 extension currently utilizing this hook is gridelements. Resolves: #102337 Releases: main Change-Id: I001e43874c082c99ded5c6dd8d0f6c3b9e020393 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/83713 Tested-by:
-
