- Feb 05, 2024
-
-
Andreas Kienast authored
The version was outdated and is removed as it is not needed, since there is no intent to publish the build-folder as-is on npmjs. Resolves: #103039 Releases: main, 12.4 Change-Id: I799e03b00caefea946fb9700a6863ae325551f90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82783 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
Andreas Kienast <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
-
Benni Mack authored
With #100759, f:translate has been changed to use the extbase LocalizationUtility in all scopes. This triggers the ConfigurationManager, which fetches TypoScript setup from the Request attribute. But TS setup is never set in fully cached page content scenarios and there is usually no Fluid view triggered in this scope. The admin panel however renders in "fully cached" as well, which then fails when trying to fetch TS setup. We *do* want extbase to fail in this scenario, since TS is important for extbase configuration and it needs to rely on TS setup being set in Frontend. The patch thus works around the issue in admin panel directly. The situation should resolve later again, when work on LocalizationUtility finished. Resolves: #102638 Related: #100759 Releases: main, 12.4 Change-Id: I5cf8af6593f37299e71b8555b79bf05c0e5e9c09 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82396 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by: C...
-
Oliver Bartsch authored
The element browsers, such as file browser, folder browser or the create folder browser are rendering the FileList in the `browse` mode. In this case the context menu component is not loaded. This is correct, since using the context menu inside the modal would lead to various side effects. Because the JS component is not loaded for mentioned reasons, wrapping the icons with the click menu needs to be omitted. This otherwise leads to further side effect, e.g. loading a second folder tree in the create folder browser. Therefore, this change now omits wrapping the icon with then click menu when the Filelist is used in the `browse` mode. Resolves: #103001 Releases: main, 12.4 Change-Id: Ifd4daf5487b5dd9c74553d48cd0c2270b2c4f58b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82742 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Stefan Bürk authored
This change adds further MySQL Server versions to the `Build/Scripts/runTests.sh` to allow executing local functional and acceptance tests with these version. Added versions: - MySQL 8.1 - MySQL 8.2 - MySQL 8.3 Resolves: #103030 Releases: main, 12.4, 11.5 Change-Id: I578ed524560ae1907ab8a79df7694470f9aa234a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82741 Tested-by:
-
- Feb 04, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @lit/reactive-element@^2.0.4 \ lit@^3.1.2 \ lit-element@^4.0.4 \ lit-html@^3.1.2 npm run build Resolves: #103024 Releases: main, 12.4 Change-Id: Iec49465ce10b9da4cd2a05bcc13c09dd49508ef0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82770 Reviewed-by:
-
- Feb 03, 2024
-
-
Stefan Bürk authored
TYPO3 uses a composer package [1] to import locales along with translations and a custom script has been added to create and update included translation files. This change updates the language files with the last updates and requires the package with the current highest version as minimum. Used command(s): > composer req --dev \ "sokil/php-isocodes-db-i18n":"^4.0.19" > php Build/Scripts/updateIsoDatabase.php [1] sokil/php-isocodes-db-i18n Resolves: #103027 Related: #100659 Releases: main, 12.4 Change-Id: I2839113ed3894cec58b41c85abd59039cab00725 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82774 Tested-by: -
Stefan Bürk authored
The `Symfony\Component\Translation\Dumper\XliffFileDumper` is extended to add processing workflowes needed to update the xliff files based on the ISO Database with `Build/Scripts/updateIsoDatabase.php`. Symfony 7 added method types and return types, and therefore the extended method `dump()` needs a compatible return type. The corresponding `:void` return type is added now. Resolves: #103026 Releases: main, 12.4 Change-Id: Id39dbbab9cccffc0b0900267bdc411187623f6fb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82740 Tested-by:
-
- Feb 02, 2024
-
-
Andreas Kienast authored
Executed commands: npm install --save \ @codemirror/autocomplete@^6.12.0 \ @codemirror/lang-html@^6.4.8 \ @codemirror/language@^6.10.1 \ @codemirror/lint@^6.5.0 \ @codemirror/view@^6.23.1 \ @lezer/common@^1.2.1 \ @lezer/lr@^1.4.0 npm run build Resolves: #103023 Releases: main, 12.4 Change-Id: I4b21ebc335f3bc3483a957e0c6c48d62e0e4f622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82769 Tested-by: -
Albrecht Köhnlein authored
The methods `logicalAnd()` and `logicalOr()` allow any number of constraints as parameters. The outdated PHPdoc comment still said "two". Resolves: #103007 Releases: main, 12.4 Change-Id: I582eb3f1c17fb3149a49a15649469794ce386149 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82739 Reviewed-by:
-
Stefan Bürk authored
The `Build/Scripts/runTests.sh` supports `podman` and `docker` as container cli binary since quite a while now, albeit docker has been kept as default if not specified using `-b`. This change removes the hard default and will now use `podman` as default. In case `podman` is not available `docker` is used. As a side-effect, the binary for CI is no longer enforced the hard way. PostgreSQL 16 is added as database version. Resolves: #103018 Releases: main, 12.4, 11.5 Change-Id: Iedcd7cbcd2380adb6781bd8b4f075da86e25c03b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82766 Tested-by:
-
- Feb 01, 2024
-
-
Oliver Bartsch authored
There is no valid reason to force a minimum amount of 5 records to be displayed in the list view. Therefore, the range is reset to 0 - 10000, as it was before #92103. Resolves: #103011 Related: #92103 Releases: main, 12.4 Change-Id: Icd22e6a77dc554774dcde6a6a3dc3c2a799d2d7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82738 Tested-by:
-
Stefan Bürk authored
Used command(s): > composer req --dev \ "typo3/testing-framework":"^8.0.9" [1] https://github.com/TYPO3/testing-framework/releases/tag/8.0.9 Resolves: #103010 Releases: 12.4 Change-Id: Ic0b592ba160c958833a75b17481141a65bf566b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82756 Tested-by: -
Albrecht Köhnlein authored
In case modules do not provide a "shortDescription" the module card is now rendered without title in the "About" module Resolves: #103005 Releases: main, 12.4 Change-Id: Ic383df283eb7c3e3e175862f808ea731531ccfff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82737 Tested-by:
-
- Jan 31, 2024
-
-
Stefan Bürk authored
The first argument after processing defined options has been stored into the variable `TEST_FILE`. This value was passed to PHPUnit based commands as last argument, defining the test case to execute (or a subset). Removing this workaround and directly passing remaining options to the command makes special arguments like `-e` obsolete and unblocks more generic command passing. This change removes this variable and passes all remaining arguments after option processing directly to the PHPUnit command and paves the way for future command improvements. Note: This makes the `-e` option basically obsolete, but is kept for now to minimize muscle memory issues. Using it will display a `deprecation` notice at the end of the script - so it gets recognized. Resolves: #102769 Releases: main, 12.4, 11.5 Change-Id: I9a85206330a7e1b58d81dc5a2c97a13831af29a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82728 Tested-by: -
Oliver Bartsch authored
To prevent PHP from encoding the numeric keys of the available languages as string, which would lead to JavaScript errors, `array_values` is now applied to the filtered list of languages. This resets the keys and therefore ensures a continuous numeric sequence starting from 0. Reference: https://www.php.net/manual/en/function.json-encode.php#refsect1-function.json-encode-notes Resolves: #102911 Releases: main, 12.4 Change-Id: Ieca55dd815d1389f44823b252df8da75196d0fdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82734 Tested-by:
-
Oliver Bartsch authored
The element browser string (bparams), forwarding different information between states is using the pipe ("|") character as separator. With #101231, this string got extended by also respecting a "disallowed" file extension list, next to the "allowed" list. Since this information is stored as one part, an additional separator ";" was introduced. However, this character now leads to problems, depending on the used environment (see linked references). To circumvent this, the separator is changed to the "~" character for now, as this is not a reserved character, according to RFC3986. In the long run, this string should anyways be replaced by a more robust solution. * https://github.com/traefik/traefik/issues/9164 * https://github.com/symfony/symfony/pull/51709 * https://datatracker.ietf.org/doc/html/rfc3986#section-2.2 Resolves: #102992 Related: #101231 Releases: main, 12.4 Change-Id: I05e3548305d7ff50bd6db94fd2236aba95e80edb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82726 Tested-by: -
Sascha Nowak authored
When fetching a lot of records from database the memory is nearly doubled in the fetchAll function. It seems php keeps references or creates an array copy that could not be garbage collected. Enforcing a manuell gc_collect_cycles does not help either. Resolves: #102986 Releases: main, 12.4, 11.5 Change-Id: I2da5f1e0126aa1dc867c8fb3074be4a11491f8f3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82725 Tested-by:
-
Chris Müller authored
The index file in its current state does not has any value to the user. Mostly numbers are displayed as reference. Resolves: #102996 Releases: main, 12.4 Change-Id: I6a4c52e5c295bb27f5fd85045f2c3f9451bea1e5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82733 Reviewed-by:
-
- Jan 30, 2024
-
-
Oliver Bartsch authored
There might be no comma in front of an extension scanner tag. This should not lead to an error as it's unrelated for this check and will already be catched by the "validateLastLine" check. Resolves: #102987 Releases: main, 12.4, 11.5 Change-Id: Icda7cbb1b01ced39ee80311e15bccdfd9318b953 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82732 Tested-by:
-
Oliver Bartsch authored
This patch prevents empty categories in the wizard and prevents an undefined array key warning. Resolves: #102990 Releases: main, 12.4 Change-Id: Iec69d1d3e3df66d9a054dfe382afe3d282fec332 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82704 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
- Jan 29, 2024
-
-
Andreas Kienast authored
The `is:pageBrowsing` ViewHelper now receives the `freeIndexUid` argument. Also, a typing issue in the data attribute is solved to let JavaScript get its value. Resolves: #102950 Releases: 12.4, 11.5 Change-Id: Ia8c6dd2bf5a61676cf9db85ef2623cf76d7dffb9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82668 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Simon Schaufelberger <simonschaufi+typo3@gmail.com> Tested-by:
-
- Jan 28, 2024
-
-
Oliver Klee authored
Make proper use of generics and align the API of our classes with that of the implemented interfaces `Iterator` and `ArrayAccess`. This helps extension developers use static analysis for their extensions. This is a pre-patch to introducing native types for the two classes. Resolves: #102958 Related: #102956 Releases: main, 12.4 Change-Id: I19f850264040246ef140c6958d20473ef4c9be28 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82620 Tested-by:
-
Chris Müller authored
This makes it easier for users to find the hooks. Resolves: #102965 Releases: main, 12.4 Change-Id: Ib5a515b46165b2d941444f90c615b59e244c9d6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82619 Tested-by:
-
Oliver Klee authored
Attributes provided to this method can also have integer values (which makes the `string` cast in the method necessary). The PHPDoc type annotations should reflect that to avoid false positives when calling code is statically analyzed. Resolves: #102967 Releases: main, 12.4 Change-Id: I00a3c11220c50fc5274c4aabb351b64b2e43a63f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82687 Tested-by:
-
- Jan 26, 2024
-
-
Mathias Bolt Lesniak authored
Specifically mention FIRST_INSTALL file and recommend new users to read the Getting Started documentation at docs.typo3.org when warning that the Install Tool is locked. Also adds an info box with a similar documentation recommendation to new users. This ensures that new users always get directed to the documentation and that new users are told about the FIRST_INSTALL file, also if TYPO3 doesn't detect a new installation. Also fixes some minor grammar. Resolves: #102933 Releases: main, 12.4 Change-Id: I0efe032c9bfe4a619b80c6f620d53fe062c8abc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82618 Tested-by:
-
- Jan 25, 2024
-
-
Peter Kraume authored
The method resolveResourcePaths() is superfluous because the PageRenderer resolves path with EXT: later with getStreamlinedFileName() anyway. Furthermore this patch resolves open_basedir errors. As a plus, the form.css gets a version numbered filename now which mitigates caching issues. Resolves: #98545 Releases: main, 12.4, 11.5 Change-Id: Ie93b6aa817889281c8f96fd272884f03cab3857e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82616 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Stefan Bürk authored
This change updates phpstan and related libraries to available maximum versions. The new version finds one `array_filter` usages with wrong typeing, which is fixed along the way. Used command(s): > composer require --dev \ "phpstan/phpstan":"^1.10.57" \ "phpstan/phpdoc-parser":"^1.25.0" \ "phpstan/phpstan-phpunit":"^1.3.15" > Build/Scripts/runTests.sh -s phpstan Resolves: #102920 Releases: main, 12.4 Change-Id: Iab6a0a079ff745b5bdbedf9b15a3bf9c7f83c171 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82641 Tested-by:Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Jan 24, 2024
-
-
Oliver Bartsch authored
Due to the loading order, the EXT:form configuration module provider might not be available. This is now fixed by adding EXT:lowlevel as constraint (suggests) to EXT:form. Resolves: #102838 Releases: main, 12.4 Change-Id: I172ff2d27803f61b9247147ae8a7fd1cb6585561 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82611 Tested-by:
-
Andreas Kienast authored
The `Indexer` class from Indexed Search has an `internal_log` property that's only accessed when `debugMode` is enabled. However, the wrapper method `log_setTSlogMessage()` always writes into the log, which doesn't make much sense. Said method now checks for enabled debugging before writing into the log property. Resolves: #102909 Releases: main, 12.4 Change-Id: I3d2df9ce49677e995bc86e87d74d80a9016900c4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82615 Tested-by:
-
- Jan 23, 2024
-
-
Simon Praetorius authored
Maybe there is also a better way to display this? Currently the line breaks aren't visible, which makes it quite hard to understand. https://docs.typo3.org/c/typo3/cms-form/main/en-us/D/FrontendRendering/Index.html Releases: main, 12.4 Resolves: #102903 Change-Id: Ib363f2aa6145511b0ed244d140068bb32e68de15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82614 Tested-by:
-
Oliver Klee authored
This change makes the parameter type annotations consistent with the property type annotations in the affected classes. This allows PHPStan to catch calls with invalid argument types. Resolves: #102887 Related: #102885 Releases: main, 12.4 Change-Id: I0cb1ab2ce5da1a40ae670d65e4997a456ef7a8c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82601 Reviewed-by:
-
Torben Hansen authored
The code example for the `BeforeRequestTokenProcessedEvent` event listener implementation contains an error, since the request token scope is checked for lower cased `loginType` in `AbstractUserAuthentication`. This change fixes the code example. Resolves: #102899 Releases: main, 12.4 Change-Id: I5582b916b9399eb90672edf3f06a59d84e3bdef0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82613 Tested-by:
-
Benjamin Franzke authored
Also switch back to `List` instead of `DocumentList`, since the new DocumentList implementation (that we use since #100348) has been integrated into `List` and the temporary name `DocumentList` is now deprecated (and just a no-op wrapper for `List`). Executed commands: npm install -P $( grep ckeditor5 package.json | \ grep '\^40' | \ grep -v dev-utils | \ sed 's/^[^"]*"\([^"]*\)".*/\1@^41/' \ ) npm remove @ckeditor/ckeditor5-dev-utils npm install -D @ckeditor/ckeditor5-dev-utils@^39.5.1 npm run build Releases: main, 12.4 Resolves: #102854 Change-Id: I7c5085a6526941e3d3b4125f019b66d2c71b5f79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82504 Tested-by: -
Andreas Kienast authored
In preparation for further improvements in the LiveSearch, the latest used page id stored in the browser's session storage is now passed to the LiveSearch search demands. This patch is marked as a task, as the whole API is still internal, allowing to backport this to v12 as well. Resolves: #102894 Releases: main, 12.4 Change-Id: If957d3b5eadbfe9fe5eb967fe5e17a697995ee6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82612 Reviewed-by:
-
- Jan 22, 2024
-
-
Christian Kuhn authored
page = PAGE page { 10 = COA 10 { 10 = TEXT 10.value = A 20 = TEXT 20.value = B 30 = TEXT 30.value = C } } page.10.30 > This correctly unsets 'page.10.30', but also 'page.10.10' which should be kept of course. The patch fixes this by avoiding a bogus removeChildByName(). Resolves: #102831 Related: #97816 Releases: main, 12.4 Change-Id: Iab66e9c3187588cb403f7c4e65145863314817d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82559 Tested-by: -
Christian Kuhn authored
Extbase BE modules suffer from the conceptual mistake of using FE TypoScript for configuration. Modules not in page context pick the first root template in the page tree as TS entry point. The patch changes this awful handling to also use the attached site object for this page to substitute site settings used as constants in TS correctly. Resolves: #102452 Related: #97816 Releases: main, 12.4 Change-Id: I24e1e814cd20fc4999311d4f0068fb51818ad611 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82558 Tested-by:
-
Julian Hofmann authored
No semicolon after method argument is needed/allowed. Releases: main, 12.4 Resolves: #102888 Change-Id: Ib04783dc487456df88d5b42ae68882ab8c34eb67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82573 Tested-by:
-
Stefan Bürk authored
New core-testing-* images has been build and published in the TYPO3 testing-infrastructure repository and pulled to the core ci gitlab runner instances. [1][2] This change modifies `Build/Scripts/runTests.sh` to set new image version to ensure the usage for all changes based on this change. For information what changed in the image see the patches in the testing-infrastrucure repository linked below - at least for the phpXY images. * core-testing-php81 => 2.10 * core-testing-php82 => 1.9 * core-testing-php83 => 1.10 * core-testing-apache24 => 1.3 * core-testing-nodejs18 => 1.2 * core-testing-nodejs18-chrome => 1.2 [1] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/2fb328622d88d47afd3e8abc9bf6ff32f7ef3db6 [2] https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/e1ec0954b823acbab3f37100f8b6d0a03c31f0d8 Resolves: #102886 Releases: main, 12.4, 11.5 Change-Id: I3830a5f53b18e2170c9f973a66007dc3868d99dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82553 Tested-by:
-
- Jan 21, 2024
-
-
Torben Hansen authored
The documentation for redirect mode "Defined by Domain entries" for ext:felogin does not describe, that configured domains must be known to TYPO3. This change updates the documentation, so it is clear, that all domains for the "Defined by Domain entries" redirect mode must be configured in TYPO3 site settings. Resolves: #98372 Releases: main, 12.4 Change-Id: I2a18ce40016d60c3878656cc5194cec6af5ed6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82572 Tested-by:
-
Oliver Bartsch authored
This fixes several bugs of the recordlist pagination page input field. 1. The selector for the corresponding form element is no longer hardcoded to "pages", enabling the field for all tables again. 2. A JavaScript warning regarding "NaN" for parseInt() is resolved by using `Number()`. 3. Setting the value is only done in case corresponding `min` / `max` settings exist. Resolves: #102872 Resolves: #102861 Releases: main, 12.4 Change-Id: I2110fef23e17ccbde3e37754be5ef3c5187dfa43 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/82555 Tested-by:
-
