- Aug 02, 2021
-
-
Christian Kuhn authored
Extbase provides a couple of generic domain repositories and models, especially frontend / backend users and groups. Those are flawed by design: The main issue is that domain models have to be specific for the domain they are used in. By definition, a generic, opinionated model can't be "correct" since the domain it is used in, is unique: It might be that a backend user email has to be set and the domain does not model anything but email and firstname? Many usages don't need backend groups attached to a backend user model at all, or if they need them, then maybe in a recursive presentation, or a specific order or something similar. Having a default group resolution is thus at least misleading, if not wrong, and can be a performance issue on top. A generic model can never foresee its usages. The existing models thus try to 1:1 adapt the database fields, which is also misleading since a domain model is not and should not be a direct representation of a database table. It would only be by chance if the generic models fit a specific domain. Similar issues exist with the repositories: The CategoryRepository for instance assumes it is a good idea to set respectStoragePid(false), which is most likely not the right thing for an extension use. In the end, whatever extbase delivers here, is most likely wrong and does not fit the problem domain. The patch keeps the 'experimental' FAL related models since those can be actually useful for extensions and their final fate has not been decided, yet. The other generic models, especially those with lots of properties are marked as deprecated with the patch. Change-Id: I06629fddd0258c517f3fa8bdf2e9c4b342be9678 Resolves: #94654 Related: #83296 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70061 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Oliver Bartsch authored
A new TCA type "category" is introduced, which allows to simplify the configuration of category TCA columns. Besides the benefit for integrators, this allows to deprecate the CategoryRegistry in the next step. The new type can also be used for other use cases. Therefore, the TCA option "relationship" is available for this TCA type. Besides "manyToMany" (default), this can also be set to "oneToOne" or "oneToMany". Using the new type, FormEngine will always render a category tree. This means, no additional `renderType` is defined. In such case, TCA type "select" can still be used as before, without any limitation. However, all relevant places in core are adjusted in this patch. The category element is rendered through a custom element (web component), reducing inline javascript. Resolves: #94622 Releases: master Change-Id: I1b95c42288b070fa6bac114266f5ad246a045b21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69899 Tested-by:
-
Nikita Hovratov authored
This fixes wrong input configuration, wrong method calls and adds some missing test cases. - The first parameter of assertSame expects the expected value. All occurrences in DataHandlerTest, which had them mixed up, are corrected. - TCA configuration "type => input" corrected. - Missing test cases with empty string as input added. Resolves: #94682 Releases: master Change-Id: If31ad11bb1e958fd24b1cbdb7d525d056fe3111b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70175 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
- Jul 30, 2021
-
-
Georg Ringer authored
If the creation date of a system news is cleared by an editor, the rendered news must skip the date. Resolves: #94576 Releases: master, 10.4 Change-Id: I93958ba0e858960dba4b99c0123cedce7dba5539 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69908 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
Resolves: #94678 Related: #92953 Releases: master Change-Id: I33073717590a8561c9c5cfe4a1d76bfc627ff949 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70164 Tested-by:
-
Christian Kuhn authored
The upstream wincache PHP module is unmaintained, a PHP 7.4 version came late and there is no work for a PHP 8 compatible version on the horizon. The ApcuBackend is a suitable alternative that works on windows platform as ram driven key/value store. The patch deprecates the wincache based cache backend implementation. Resolves: #94665 Releases: master Change-Id: I6e1eb551c048f73d48c85ed498d1cd4caab266d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70130 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
The 'pdo' cache backend is of rather little use since the Typo3DatabaseBackend supports the casual DBMS via doctrine/dbal. The backend is also pretty much unmaintained and didn't receive any optimizations over the years in contrast to the Typo3DatabaseBackend. The patch deprecates PdoBackend. Resolves: #94664 Releases: master Change-Id: I584c150b754f0e3bb226dae998051eb389284e10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70129 Tested-by:
-
Sybille Peters authored
When matching IPv6 addresses (for example in IPmaskList) appending the address with * as wildcards will not work. The function GeneralUtility::cmpIPv6() uses validIPv6() which will fail on an address with *. Using addresses with CIDR-notation, will work for both IPv4 and IPv6 addresses (e.g. 2001:0DB8:1234::/48, 192.16.0.0/16). The description of TYPO3_CONF_VARS and comments for the function in GeneralUtility is updated accordingly. Resolves: #94620 Releases: master, 10.4 Change-Id: Ie068ca579a41cd3c6552e6a302bbe11b0ca2883a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70055 Tested-by:
-
Christian Kuhn authored
Scenario: A tt_content default language record with images, assets or media is localized ("translate" / "connected" mode, not "copy") to another language. Attached images, assets and media will be localized, too. If later the default language record is changed to add another image, asset or media, the localized record now shows the additional default language record relation as shadowed box and allows localizing this additional record with a single click. This is done by setting for those TCA inline relations: ['appearance']['showPossibleLocalizationRecords']. Notes: * showPossibleLocalizationRecords works on l10n_parent and does NOT honor l10n_source (yet?): In a 'localization chain' (default is localized to dutch, dutch is localized to german), an additional image, asset or media on the dutch record *is not* shown in the german record, but an additional record in default language *is* shown in the german record. * showAllLocalizationLink: This is an optional additional button to localize all missing relations with one click, not only single ones. This is *not* enabled with the patch: The additional button bloats the already pretty complex interface even more, and editors often only need to deal with one or at least only a small list of additional relations. Instances where editors often deal with lots of such inline relations can easily enable that button on their own. * showSynchronizationLink: The behavior of that button is in practice very similar to showAllLocalizationLink and *not* enabled for similar reasons. Change-Id: I34e469171ac34b06ff0350e8e3725188f6de625b Resolves: #94623 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70058 Tested-by: -
Jonas Eberle authored
Due to different handling of scrollbar positioning and layouting in user agents (most use the operating system's graphics stack to show scrollbars, Chrome its own) it could happen that the modulebar icons were shown partially only. It should not be relied on the width of scrollbars and if they affect the user agent's box model or not. In our case an inner element was pixel-perfectly relying on parent elements' box sizes since #93353. This dependency has been removed for the collapsed state. Resolves: #94633 Releases: master Change-Id: Ic573ade55af461935f0cada80a98bf3aaaf9a9c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70066 Tested-by:
-
- Jul 29, 2021
-
-
Simon Gilli authored
For the covenience when creating files with code snippets the indent of .rst is changed to 4 spaces. This works for all cases also for lists where normally 3 spaces are used. Resolves: #94669 Releases: master, 10.4, 9.5 Change-Id: If1ed5927a1e5e17e56edf0696eb4c528599b788c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70159 Tested-by:
-
Oliver Hader authored
Allows to make use of custom properties in backend layouts, e.g. like shown below in Fluid templates: ``` <f:if condition="{column.definition.myFeature}"> <div data-colpos="{column.columnNumber}">...</div> </f:if> ``` Resolves: #94634 Releases: master Change-Id: I2dc2b7324bbcabc55a8896f74c3dd79768a0b87d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70067 Tested-by:Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Lina Wolf authored
Fixes Layout problems: Malformed lists, malformed headlines, non-working links to documentation or other changelogs. Directive `:ts:` and `.. code-block:: ts` is only used for typescript, exchanged it into `:typoscript:` for typoscript examples. Resolves: #94534 Releases: master, 10.4, 9.5 Change-Id: I61e3c5910d6a5bc97f1ec887ce5b2c1e6d59a2db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69922 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
-
Stefan Neufeind authored
Extend the HtmlParser to support srcset attributes, which can be found in img tags or source tags inside of HTML 5 picture elements, making it fully compatible with responsive images. Change-Id: If47af154b059c0744c3d660c760fb2cc2d703aeb Resolves: #71775 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/44901 Tested-by:
-
Christian Kuhn authored
The nifty ruleset for handling core changelog files described at https://docs.typo3.org/c/typo3/cms-core/10.4/en-us/Changelog/Howto.html sometimes gets violated by the one or the other patch. This happens, so we occassionally synchronize Changelog files between versions. Resolves: #94668 Releases: master, 10.4, 9.5 Change-Id: Ia02af5909687a6f200257b791fee098ced7f32b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70154 Tested-by:
-
Christian Kuhn authored
The patch for issue #91123 was originally planned for having a v10 backport, but made it to master only and has been released as 11.0. The Important.rst file has been added to 10.4.x directory, but it should reside in 11.0 directory. Adapt that and fix a reference to it. Change-Id: Ia28b3b7d75b27b5f2d1ccd2fe9ec77a767eaeeae Resolves: #94667 Related: #91123 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70153 Tested-by:
-
Benni Mack authored
TYPO3 used RelationHandler for HMENU special=list to fetch all pages for this menu once, but fetched the full records again for MountPoint relation, and manual language + workspace overlay was taken care later-on. Once menus were generated with mountpoints and workspace and language overlays, the ordering was not in line, and existing queries were not used. Instead, the code is now simplified and fully relies on PageRepository functionality, just as most other Frontend-related code. Resolves: #94643 Releases: master Change-Id: Ib86116a74c7db6739c474e5efb13b77284e41b08 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70112 Reviewed-by:
-
Benni Mack authored
This change uses RelationHandler for foreign_table / allowed and MM in BackendUtility::getProcessedValue in a consistent way. In addition, the RelationHandler now fetches the full record by default and adds this to the processed array, making fewer queries to the database by fetching each record fully directly. Some bugs are fixed with that: * FAL images (as in all inline fields) in list module now have the correct order * Fewer DB queries when fetching relations in Group field in FormEngine Setting the option in RelationHandler to fetch all fields by default avoids unneeded calls in general when fetching the records. Resolves: #94651 Releases: master Change-Id: I8261a0c2657b9b71ae7cdc686ee43eaa7461c8b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70117 Tested-by:
-
Nikita Hovratov authored
This patch fixes a regression originally introduced in #94103. The problem there was simply an erroneous strict comparison, which further got completely removed in #94527 due to a misconception. The mentioned condition is important for date type fields with a lower range set in TCA. If the user doesn't provide a value for that date field, the range validation should be skipped. Otherwise this empty value would always be interpreted as 0, resulting the validation to change it to the lower range value. As this is a special case, the condition was extracted and rewritten, to only apply for this exact scenario. Other than that the validation should not be skipped. An acceptance test and a unit test are added to ensure this behavior can't break anymore. Resolves: #94621 Related: #94103 Related: #94527 Releases: master, 10.4 Change-Id: I54c1a815077e48064f9f6eeba9584184c5f760d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70060 Tested-by:
-
Georg Ringer authored
To simplify setting up permissions the following fields are now always shown to editors: - 'slug' in table 'pages' - 'colPos' in table 'tt_content' Resolves: #92202 Releases: master Change-Id: I854d03f8a4b7b56cb69bed0a914697201462939e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65687 Tested-by:
-
Oliver Bartsch authored
The PasswordViewHelper is extended for a new tag attribute "autocomplete", which can be used to instruct the users' password manager how to fill the password field. Resolves: #94653 Releases: master Change-Id: I00941f3bb61624d405dcdd8a6af48777c3364d1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70121 Tested-by:
-
Benni Mack authored
This change migrates $result->fetch() methods to $result->fetchAssociative() and $result->closeCursor() to $result->free() methods. Since TYPO3 uses fetchMode "associative" by default when setting up the connections, this change is another step towards Doctrine DBAL 3.0 compatibility. Resolves: #94659 Releases: master Change-Id: Idce7c8466925a6e58059e7e16ebc3ffe35ca6fa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70125 Tested-by:
-
Oliver Bartsch authored
Resolves: #94652 Releases: master Change-Id: I805352b13eae98fd207ca45bbade34c489cc4c6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70120 Tested-by:
-
Simon Gilli authored
The NEON files are currently missing in the .editorconfig and properly added by this patch. Resolves: #94637 Releases: master, 10.4 Change-Id: Ieaf0f09d9111b9a6c59efac3855a04bb5b8750fc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70070 Tested-by:
crell <larry@garfieldtech.com> Reviewed-by:
-
Jochen Roth authored
Settings acceptence tests has been extended to revert all changes done to the installer when the test finished. On top of that the tests now verify the changed setting by re-open the modal and compare the values. Resolves: #94445 Releases: master Change-Id: I94219db58cd624da2789e2cd5903a14f0091fd47 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69672 Tested-by:
-
- Jul 28, 2021
-
-
Christian Kuhn authored
Similar to styleguide's backend TCA data generator, the extension can now generate a demo frontend to render a page tree with menu having examples of the default core content elements and demos for ext:felogin and ext:form. The generator is accessible through the existing backend styleguide module below the '?' help button in the toolbar. The FE data will be used for core acceptance tests soon. The raise also brings a minor TCA change for a pending core regression patch. composer req --dev typo3/cms-styleguide:~11.4.0 composer req --dev typo3/cms-styleguide:~11.4.0 -d typo3/sysext/core --no-update Change-Id: Ie1ef73400cda2b82c6379401341e69ff9e78645e Resolves: #94658 Related: #94621 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70124 Tested-by:
-
Nikita Hovratov authored
Show in runTests -h command how to execute one specific acceptance test. The syntax in codeception is a bit different than in phpunit. Resolves: #94644 Releases: master Change-Id: I681be04ff92f6682c2226df8fb4797bf16bcc647 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70113 Tested-by:
-
Benni Mack authored
Since TYPO3 uses the \PDO::FETCH_ASSOC fetch mode by default, fetchAll() is the equivalent for fetchAllAssociative() which is the new API for Doctrine 3. In order to move towards the new Doctrine DBAL 3.x API, this change migrates all fetchAll() calls to fetchAllAssociative() or fetchFirstColumn(). Resolves: #94618 Releases: master Change-Id: I2ab4db871d0b65ad07e629b54bb79b1c3b411005 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70016 Tested-by:
-
Nikita Hovratov authored
Due to several modules initializing tooltips, it might happen that they are initializing the same element twice or even more times. This can be easily avoided by using the new bootstrap Tooltip method "getOrCreateInstance". This should fix weird behaviour, where the tooltip did not disappear. Also, since updating to a newer bootstrap version the fix 0005bc5b did not work anymore. This is fixed by using the container context as selector basis. Resolves: #94477 Releases: master Change-Id: Iea67db7fe63825f2eba028302d435cf7e2c8e7b8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70119 Tested-by:
-
- Jul 27, 2021
-
-
Benni Mack authored
This change * Streamlines Controller Code * Avoids unneeded Fluid assigns * Uses strict typing Resolves: #94604 Releases: master Change-Id: I91035f9c70e4df80c443e3a45f044f10c28fdb27 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69722 Tested-by:
-
Nikita Hovratov authored
To further streamline the usage of the IconRegistry, the reports registration array now allows to define an icon identifier. Absolute paths and paths with "EXT:" prefix are still possible. Further improvements: The IconViewHelper of the reports extension has been dropped. It had the same functionality as a normal ImageViewHelper with the addition of a fallback icon. This logic has been moved to the controller action. Some minor code refactoring and template cleanup while at it. Resolves: #94588 Resolves: #94590 Releases: master Change-Id: I901b8a0c56f26459c609a36a59c67b341c6b4168 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69965 Tested-by:
-
Oliver Bartsch authored
#94612 introduced the realpath command for retrieving the "CORE_ROOT" path. This however leads to execution failures on MacOS systems, which did not manually install this command (as it's not installed by default). To prevent the script from failing on default MacOS systems, a check for the existence of the realpath command is added. If not installed, the previous behaviour is used while displaying a short information. Resolves: #94635 Related: #94612 Releases: master, 10.4, 9.5 Change-Id: I30792f1e5492b57adf7ff28a7fa2c415ac2e094c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70068 Tested-by:
-
Benni Mack authored
The indexed_search queries to "index_config" do not need to have the FrontendRestrictionContainer as the default restriction container is enough to check for. This change was introduced back then when building Doctrine DBAL into Core. Resolves: #94593 Releases: master Change-Id: I2d8c111028591b31af57b2a366e3cfb05311c447 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69977 Tested-by:
-
- Jul 26, 2021
-
-
Jochen Roth authored
In case substr returns false $siteUrl is now casted to string and covered by an additional unit test. Resolves: #94624 Releases: master Change-Id: Id778319104d107c329a2ee8f947571a87e3c401d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70059 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Helmut Hummel authored
Several benefits come (basically for free) with this change. 1. We only maintain platform dependencies in composer.json 2. Advanced users can omit the runtime check from being generated 3. Relying on canonical functionality instead of our own For this to work, Composer 2.0 must be required not only for development, but also for any production install of the packages. With doing so, eventually other runtime functionality like installed package versions can be used as well. composer req composer-runtime-api:^2.0 This also remove the upper version check for PHP <9 because Composer runtime API does not provide upper bound checks, to allow future compatiblity of software installs, in case it isn't updated any more, but would run with later PHP versions. Upper PHP version check and failing with an appropriate error message is useful for cases when users accidentally use a PHP version higher than TYPO3 is capable of running on. However not only isn't there a PHP version 9 on the horizon, it isn't even remotely clear, whether this PHP version would have a compatiblity impact on TYPO3. Therefore an upper version check at this point in time provides zero value and can be safely omitted. Besides that, also from a maintainer perspective it will be much easier to check the impact on PHP 9 release candidates, because tests could be run automatically against this version, without modifying the code, so that compatiblity with this future PHP version can be provided ahead of time, making the upper bound check obsolete as well. Resolves: #93257 Releases: master Change-Id: I55c0c17088f222736afa99d929fe8646a483a5ee Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67371 Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
Xavier Perseguers <xavier@typo3.org> Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
The GitHub main repository has been renamed from "TYPO3/TYPO3.CMS" to "typo3/typo3". The new URL is https://github.com/typo3/typo3 This change reflects all places in TYPO3 Core to adapt to this renaming. Resolves: #94639 Releases: master, 10.4, 9.5 Change-Id: Ia5c3136a48b8b4580283277da4b7b11768c32132 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70092 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
Torben Hansen authored
Fix PHP8 undefined array key in indexed_search when typoscript configuration is not included. Resolves: #94631 Releases: master Change-Id: If068c5a1b5bc0d1962b922312adf2bf2efc05e50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70064 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Oliver Bartsch authored
This fixes inconsistency in the display of the grid columns between the fluid based page module and PageLayoutView. * Proper distinction between unassigned and unused columns * State describing classes, such as "restricted" and "hidden" are now added correctly * Access restricted columns do not longer display elements previously added to this column * Column titles are now correct * TSconfig option "hideRestrictedCols" is respected * TSconfig option "colPosList" does now work correctly * All used labels are now translatable * No more cross dependencies for labels Resolves: #94602 Related: #93829 Related: #93313 Releases: master Change-Id: I1d1e641722d57657169e16e92ddd501aab04bc72 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70013 Tested-by:
-
- Jul 25, 2021
-
-
Georg Ringer authored
Smaller images must not be blown up in visual size if smaller than 400x590px. Resolves: #94475 Releases: master, 10.4 Change-Id: I8ef7e084a55d41778d6a71ff50cdc3125bcb176f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69909 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
-
- Jul 23, 2021
-
-
Christian Kuhn authored
With all non-legacy usages of ObjectManager being gone, this final patch adds a series of @deprecation annotations throughout the core, adapts some comments, and finally adds a trigger_error() to ObjectManager->get(). Resolves: #94619 Related: #90803 Releases: master Change-Id: Iaa65f7dee4e5aa9eb4e2c217e76105b0263dc6dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/70054 Tested-by:
-
