Skip to content
Snippets Groups Projects
Commit 4ab93f35 authored by Helmut Hummel's avatar Helmut Hummel
Browse files

[TASK] Use Composer runtime platform check instead of our own

Several benefits come (basically for free) with this change.

1. We only maintain platform dependencies in composer.json
2. Advanced users can omit the runtime check from being generated
3. Relying on canonical functionality instead of our own

For this to work, Composer 2.0 must be required not only for
development, but also for any production install of the packages.

With doing so, eventually other runtime functionality like installed
package versions can be used as well.

composer req composer-runtime-api:^2.0

This also remove the upper version check for PHP <9
because Composer runtime API does not provide upper bound checks,
to allow future compatiblity of software installs, in case it isn't
updated any more, but would run with later PHP versions.

Upper PHP version check and failing with an appropriate error message
is useful for cases when users accidentally use a PHP version
higher than TYPO3 is capable of running on. However not only isn't
there a PHP version 9 on the horizon, it isn't even remotely clear,
whether this PHP version would have a compatiblity impact on TYPO3.

Therefore an upper version check at this point in time provides zero
value and can be safely omitted.

Besides that, also from a maintainer perspective it will be much easier
to check the impact on PHP 9 release candidates, because tests could be run
automatically against this version, without modifying the code, so that
compatiblity with this future PHP version can be provided ahead of time,
making the upper bound check obsolete as well.

Resolves: #93257
Releases: master
Change-Id: I55c0c17088f222736afa99d929fe8646a483a5ee
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/67371


Tested-by: default avatarcore-ci <typo3@b13.com>
Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Tested-by: default avatarSimon Gilli <typo3@gilbertsoft.org>
Tested-by: default avatarHelmut Hummel <typo3@helhum.io>
Reviewed-by: default avatarXavier Perseguers <xavier@typo3.org>
Reviewed-by: default avatarMarkus Klein <markus.klein@typo3.org>
Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarMathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: default avatarSimon Gilli <typo3@gilbertsoft.org>
Reviewed-by: default avatarHelmut Hummel <typo3@helhum.io>
parent 6aa3ebe0
Branches
Tags
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment