- Mar 20, 2020
-
-
Alexander Schnitzler authored
This patch simply pulls out the level 2 rules into a separate configuration file which is a copy of the original level 2 configuration file of phpstan with some rules, services and parameters disabled. Also, additional configuration files are put into the Build folder and phpstan.neon has been added to the .gitattributes file. Releases: master Resolves: #90789 Change-Id: Ia3b3c30cfa57227c0607904df38add31f36be0e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63802 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Alexander Schnitzler <git@alexanderschnitzler.de> Reviewed-by:
-
Christian Bülter authored
Releases: master Resolves: #90793 Change-Id: I087f38e04d8e96c66610c1bc293d6bceb7fc1e51 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63809 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
-
Susanne Moog authored
Files that are not readable by the web server should not be returned by FAL LocalDriver as we cannot do anything with them and even the basic subsequent steps (fileinfo, indexing) will fail. Resolves: #57457 Releases: master, 9.5 Change-Id: I5314cc9ba9e49bf142b4c388feea4495b8f8e5a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63807 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Jacob Dreesen authored
Releases: master, 9.5 Resolves: #90779 Change-Id: If6931385b288456dc6e1d5d0e289b1132886bc77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63766 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
Define the `hideDropzone` event listener via assignment to keep the binding of `this` to the DragUploader class. Resolves: #90792 Releases: master, 9.5 Change-Id: I21c52da477349e77a52f2c6701fd75abc3b5b074 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63805 Tested-by:
-
Guido Schmechel authored
Deferred files should not be concatenated. They are now output as a single script. Resolves: #90208 Releases: master, 9.5 Change-Id: I17c84b41acd445db6ee261bade69fddd32ca7380 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63040 Tested-by:
Ghanshyam Bhava <ghanshyambhava@yahoo.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Georg Ringer authored
Partly revert #89956 to reallow category titles in extension settings which contain a space. Resolves: #90776 Releases: master Change-Id: I93358e1c10e502ba9c48402a78927e34c240215a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63764 Tested-by:
-
Andreas Fernandez authored
The "Check TCA in ext_tables.php" module in the Install Tool now loads the ext_localconf.php per checked extension as well. Resolves: #89713 Releases: master, 9.5 Change-Id: I55bc23611554cfb0270e1f10a7787dae058609ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63801 Tested-by:
-
Benni Mack authored
The fields * be_groups.workspace_perms * be_users.workspace_perms * be_users.disableIPlock Are now only shown if the requirements are met (e.g. EXT:workspaces is installed, or the IPlock options are enabled Resolves: #40867 Releases: master Change-Id: Id6310bdbfbd187c2d0190118476a1b3fe729aa77 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63761 Tested-by:
-
Frank Naegler authored
Since Firefox 72 a user interaction is required to prompt the user for native browser notification permissions. This should prevent the user for notification SPAM. This patch introduces a modal confirmation, to get this user interaction. The user is asked only once (as before), this is possible because the modal is triggered only if a UC setting is not present. Resolves: #90666 Releases: master, 9.5 Change-Id: I031a2addee9894db7e345f46d1e5e5d0d62316d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63567 Tested-by:
-
- Mar 19, 2020
-
-
Susanne Moog authored
If TYPO3 is configured to use multiple database connections, the system information toolbar should display information about each. However, errors occuring when connecting to the non-essential databases should not directly result in an exception. Instead, these exceptions are now caught and the database status displayed as offline. Resolves: #89831 Releases: master Change-Id: I52fa2df01b23ac005b63b21bc8d7b11a294ec46f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63796 Tested-by:
-
Benni Mack authored
Resolves: #76218 Releases: master, 9.5 Change-Id: I1597d4482c2536266b6fc2fed31dd9ca67ebb60a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63800 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Susanne Moog authored
While number_format does an internal cast to float, it does not cast things like empty strings to 0 - instead a PHP warning is emitted. To catch that edge case, we are now casting to float before calling number_format. Resolves: #90786 Releases: master, 9.5 Change-Id: Ibfbacd2606dabd926adc140960e1116076bbdb5f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63798 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Georg Ringer authored
If a field is used in `foreign_table_where` configuration which points to a field using `group` as type, the uid needs to be fetched differently from the processed row. Resolves: #17073 Releases: master, 9.5 Change-Id: I8ec9c7cd0dd166a0c4e87a61adb2f87b7c1c8cf5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63595 Tested-by:
-
Benni Mack authored
* TSFE->contentStrReplace only calls a hook, which is now moved to the callers code (which only contains another hook as well) * TSFE->clearPageCacheContent_pidList() is not used anymore (protected) * cObj->decryptEmail() is not used anymore (protected). * BE_USER->getRealUserId() is not used anymore (protected) * DataHandler->recUpdateAccessCache is not used anymore (protected) * LiveSearch (internal) -> getRecordTitlePrep() is not used anymore Resolves: #90785 Releases: master Change-Id: Idf14c9185a9356091ec0400faecfc8bbe5861c3b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63795 Tested-by:
-
Benni Mack authored
This change modifies "->expectExceptionMessageRegExp" which is not available anymore in PHPunit v9. In addition, expectException(Warning::class) is deprecated in PHPUnit v9, which is modified as well, to make Core a small step towards PHPUnit v10 compat. Resolves: #90787 Releases: master, 9.5 Change-Id: Ie8aedc3cf95b5fac84791cb2d7cedba642d481c7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63797 Tested-by:
-
Alexander Schnitzler authored
Releases: master Resolves: #90766 Change-Id: I59823ed9b573344a96823d3308b253edcc765a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63682 Tested-by:
-
Benni Mack authored
Resolves: #42111 Releases: master Change-Id: Ie9b35fb8a32f18f3be6ccd62b87e93e71d6cdea9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63770 Tested-by:
-
Benni Mack authored
* t3o has fileadmin/l10n since 2 years (currently it's a redirect). * new translation server just took the path as previously on t3o This is now consolidated: * t3o is replacing fileadmin/ter with fileadmin/l10n (saving t3o some redirects) * localize is using xliff/ Both changes are in place already on the remote servers so this change can be used directly. Resolves: #84025 Releases: master, 9.5 Change-Id: I6362f6f0f8dbc6739f007deb82edb54de608d21c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63533 Tested-by:
-
Markus Klein authored
Resolves: #89124 Resolves: #90689 Resolves: #88184 Releases: master, 9.5 Change-Id: I41b6c9d73346974cffb029551be5f987f9a09a79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63714 Tested-by:
-
Oliver Hader authored
Avoid calling GeneralUtility::makeInstance() in UriBuilder multiple time, but add class member instead. Resolves: #90781 Releases: master, 9.5 Change-Id: I0d1341e9fcbd54ca30d3be791f927219b030f841 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63767 Tested-by:
-
Benni Mack authored
When fetching a page from cache, the information which cache tags were used are not available anymore for any hooks in extensions (e.g. static_filecache). Resolves: #90775 Releases: master, 9.5 Change-Id: Ib1ca0f256411a2d979113ddbb0ef128bc79a0197 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63768 Tested-by:
-
Christian Eßl authored
Hide the module menu, if it doesn't contain any modules (If the editor has no access to any module, that is placed in the module container). Also disable the toggle icons for module menu / list module in this case. Resolves: #67725 Releases: master Change-Id: I680ef0bd1d4de8c7b71d393ea14429d55f740de8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63697 Reviewed-by:
-
Benni Mack authored
When adding a new main module, the "position" is now taken into account, allowing TYPO3 Core also to use the addModule API everywhere. Resolves: #47663 Releases: master Change-Id: I733ee92eada88f09fd247fa818c018dc6bee62d6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63724 Tested-by:
-
- Mar 18, 2020
-
-
Christian Eßl authored
If an editor has "view" permissions set for a table, but no "modify" permissions, the record list would still show many buttons related to modifying records, to the user: "Add", "Edit", "Copy", "Cut" actions. Trying to click one of these buttons would lead the editor to a broken page that just shows an infinite loading spinner. This patch now adds "tables_modify" permission checks to many places in the code. The following adjustments were made: - Check modify permissions on "copy" in RecordProvider (context menu) - Check table modify permissions in DatabaseRecordList Resolves: #83008 Resolves: #89307 Resolves: #23598 Releases: master, 9.5 Change-Id: Ia3140ba887573a314191ebba5672c85d93fe885c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63696 Tested-by:
-
Georg Ringer authored
Use the FluidEmail service for sending the test task of EXT:scheduler. Resolves: #90725 Releases: master Change-Id: I7edb46c1e449acdb6979982c016658de95043807 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63678 Tested-by:
-
Georg Ringer authored
With #86629 the link type "telephone" has been added but it was forgotten to add support for it in the InputLinkElement. Add the support and show a nice icon next to the number. Resolves: #90771 Releases: master Change-Id: Ib2ea37ab07b0ae2fa9a429dc683c6021a8691aae Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63760 Reviewed-by:
-
Susanne Moog authored
As system news are sorted by crdate, the user had no way to influence the order in which news appeared. While it makes sense to sort by creation, users should have an option to influence that. Changing to tstamp would not be a solution, as tstamp changes on every edit (for example correcting a spelling mistake should not change the order). Adding an explicit sorting field seems like overkill (and would need upgrade wizards and DB changes). Therefor TCA has been changed to allow editing of the creation date for these kinds of records. Resolves: #90774 Releases: master, 9.5 Change-Id: I1268cbe7be6ed6a241e608b4a8800e19eeb58515 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63762 Tested-by:
Stefan P <spo@snk.de> Tested-by:
-
Susanne Moog authored
Resolves: #86943 Releases: master, 9.5 Change-Id: I1092442a963d7ba6e2282ed8d4c4bce360be8afc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63614 Tested-by:
-
- Mar 17, 2020
-
-
Christian Eßl authored
In some cases, the "dirty" field checks were still not working for both ckeditor and flexform fields. The following changes were made: - Flexform elements can use dots for html id attributes, which are not officially supported by the W3C CSS specification. So escape the corresponding element selectors to work with the validation. - When maximizing an RTE, ckeditor4 automatically removes all the classes from the connected html elements (and reapplies them once leaving the fullscreen mode), so the markFieldAsChanged() validation won't work here. In this case, apply an event for remembering the changes, once the user leaves fullscreen again. Resolves: #88978 Resolves: #88776 Releases: master, 9.5 Change-Id: Ib21d415766b67be8d6c6e9aae8b8e937d03850bd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63730 Tested-by:
-
Guido Schmechel authored
Improve the privacy of users by using the no-cookie setting by default and set the do not track parameter to 1. Resolves: #89381 Releases: master, 9.5 Change-Id: I81d1a6aae802126f66765702417b7ffd350d8fb7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61948 Reviewed-by:
-
Markus Klein authored
This patch fixes three things: 1) SQLite can handle a primary key, the special handling can be removed. The field names must be quoted though. A lot of duplicate tests can be removed here. 2) The handcrafted arrays passed on to the TableDiff class need to be indexed by the column or index name, otherwise the SQLite driver fails to identify them correctly. 3) Allow only one column operation per table. Having multiple column adjustments (rename, removal) within one run generates wrong migration SQL. This is due to the possibility of the Install Tool to be able to select on a "per column" level. (Keep in mind that in SQLite one operation needs at least 5 SQL statements, contrary to other DMBS) Resolves: #90758 Resolves: #90754 Resolves: #90751 Releases: master, 9.5 Change-Id: I972346fae3cc97b877e20033b466345fa1c0a83d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63702 Tested-by:
Daniel Siepmann <coding@daniel-siepmann.de> Tested-by:
-
- Mar 16, 2020
-
-
Benni Mack authored
When accessing the editPanel, the option "onlyCurrentPid" allows to also check the permissions of the editable record to verify if the user is allowed to edit it. When checking for CONTENT_EDIT permissions, the "onlyCurrentPid" is also evaluated now, having "mayEdit" set to false by default, before evaluating the condition further. Resolves: #43429 Releases: master, 9.5 Change-Id: I47ed7a7b8c0d1c750cd5b13b485ed14b3aced2dd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63616 Tested-by:
-
Susanne Moog authored
Flushing the redirect cache before rebuilding is not necessary and may result in dead-locks if multiple processes try to do the same. As there is only a single entry for redirects which gets overwritten when the rebuilding is finished, there is also no need to tag the entry as the identifier is enough. Resolves: #90069 Releases: master, 9.5 Change-Id: I2bc7c5ce9d0f4a37a3b1c9f51df34de556b2f35f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63729 Tested-by:
-
- Mar 15, 2020
-
-
Christian Eßl authored
phpstan requires, that a @var PHPDoc comment is immediately followed by the variable in the next line. Resolves: #90765 Releases: master Change-Id: I4c11582dd4831b2a9433ffd0bb262ab34a7d4e33 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63731 Reviewed-by:
-
Tizian Schmidlin authored
There is a flaw in the way TYPO3 handle the rendering of the backend edit forms that leads to fields used as labels always being rendered. This may lead to an huge amount of html being generated and thrown away without ever being pushed to the browser. For most fields, this effort is negligible, since TYPO3 has to render i.e. the title field once per backend call anyway. For table using a relation as title, as does `sys_file_metadata`, this means generating a select with all files in the system that could be related to that record. What happens is, that since the label of the sys_file_metadata record is the field file, the FormDataProvider `TcaColumnsProcessRecordTitle` will add file to the columnsToProcess for the current record and the `TcaSelectItems` will happily work it's way through and generate the html for the select box. Bare in mind, that this is absolute and utter dead weight since nowhere in the TCA showItem definition of any type the file field is referenced. This would not be to big of a problem since in most systems there are no more than 10k files but in systems with 100'000+ the memory get's used up and it can lead to memory exhausted errors in PHP (even with as much as 512M memory_limit). Resolves: #82990 Releases: master, 9.5 Change-Id: I5da8e08b71dfacac0535e4c8e858099d7e307a3e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61970 Tested-by:
-
Alexander Schnitzler authored
This commit adds missing doc blocks and missing type hints to existing doc blocks to help static code analyzers like phpstan do a better job. Also, wrong type hints have been changed. Releases: master Resolves: #90661 Change-Id: I966884b15e33f5668498290d3fd80b67a7ddcba0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63561 Tested-by:
-
Benni Mack authored
Instead of using $GLOBALS['SOBE'] for this single usage, the constructor is modified when building the Position Tree now. Resolves: #84376 Releases: master Change-Id: I49f340e431656f76f6be3d8027cf6640c38f6ad3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63625 Tested-by:
-
Benjamin Gries authored
These changes in the Datahandler and the FormSlugAjaxController allow users to override slug fields with columnsOverrides. Typical usecases for this are custom doktypes which should have an individual url behaviour defined by their type. Resolves: #87364 Releases: master, 9.5 Change-Id: I4c08c38f541197166cac0d054e323bc94f82c192 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61416 Tested-by:
-
Markus Klein authored
We now make sure that JSON en- and decoding works flawlessly, otherwise we throw the usual exceptions instead of failing with PHP errors. Resolves: #90744 Releases: master, 9.5 Change-Id: I7f791a73906447f0879590bee6f51143b7089ba5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63713 Tested-by:
-
