Skip to content
Snippets Groups Projects
Commit decea21a authored by Markus Klein's avatar Markus Klein Committed by Benni Mack
Browse files

[BUGFIX] Make SQL schema migrations working on SQLite

This patch fixes three things:

1) SQLite can handle a primary key, the special handling
   can be removed. The field names must be quoted though.
   A lot of duplicate tests can be removed here.

2) The handcrafted arrays passed on to the TableDiff class
   need to be indexed by the column or index name, otherwise
   the SQLite driver fails to identify them correctly.

3) Allow only one column operation per table.
   Having multiple column adjustments (rename, removal)
   within one run generates wrong migration SQL.
   This is due to the possibility of the Install Tool
   to be able to select on a "per column" level.
   (Keep in mind that in SQLite one operation needs at
   least 5 SQL statements, contrary to other DMBS)

Resolves: #90758
Resolves: #90754
Resolves: #90751
Releases: master, 9.5
Change-Id: I972346fae3cc97b877e20033b466345fa1c0a83d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63702


Tested-by: default avatarTYPO3com <noreply@typo3.com>
Tested-by: Daniel Siepmann's avatarDaniel Siepmann <coding@daniel-siepmann.de>
Tested-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Tested-by: default avatarBenni Mack <benni@typo3.org>
Reviewed-by: default avatarGeorg Ringer <georg.ringer@gmail.com>
Reviewed-by: default avatarBenni Mack <benni@typo3.org>
parent 585287e9
Branches
Tags
No related merge requests found
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment