- Jul 04, 2023
-
-
Daniel Siepmann authored
Some checks might return a message why images can't be generated. Those checks didn't return success which prevents processing by JavaScript, leading to endless "Loading" state within UI. All responses now properly return success = true in order to be processed by JavaScript. Resolves: #100893 Releases: main, 12.4 Change-Id: I720893a0b01a26a7b77bdcb16c02295eed3ae595 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79680 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Alexander Schnitzler authored
ObjectAccess::getGettablePropertyNames() has quite the history by now. It used to be quite simple, an is_callable() check for getters/hassers and issers of objects. That didn't account for methods with mandatory method arguments which was fixed by using reflection. Because runtime reflection is slow, the usage of cached reflection (ClassSchema) had been introduced. But, during that change, symfony/property-access had also been introduces, which contradicts the idea of performance gain because: - symfony/property-access also uses uncached reflection - symfony/property-access actually calls the accessors under test As both is undesirable, the usage of symfony/property-access has been removed again. Releases: main, 12.4, 11.5 Resolves: #101176 Change-Id: I2bc796ebeaf2f1357fd3154b711910c6f553f4e4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79675 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
Georg Ringer authored
The deleted records should be sorted by the timestamp descending instead of by the uid ascending because in most cases one of the recently deleted records should be restored. In addition, a comparison is fixed as a drive-by change to have compatible types. Resolves: #100252 Releases: main, 12.4 Change-Id: I67ce8134ea498782b476381716559e92f9867059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79677 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Bartsch authored
Since #97330, a form engine elements label might not be represented by a <label> tag, but by using a <legend> tag. This patch now ensures that those elements are also correctly considered within form engine validation. Resolves: #101221 Related: #97330 Releases: main, 12.4 Change-Id: Iac4ef9b198bd7a7b8c75e53b83e45117be348c98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79636 Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de>
-
Oliver Bartsch authored
The markup is adjusted to make the "parallel execution" checkbox in the scheduler module edit view working again. Additionally, the checkbox is only displayed for recuring tasks, because it's always set to FALSE for tasks with single execution. Resolves: #101146 Releases: main, 12.4 Change-Id: I0bc595683565ab099ca2a78f7a0aaf1480255a8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79674 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
Guillaume Germain authored
Use array chunked query combined with direct value list to retrieve full data set in `DataMapProcessor` methods `fetchTranslationValues` and `fetchDependentElements`. Resolves: #99326 Releases: main, 12.4, 11.5 Change-Id: Iaf220014cd991002450779197169c5c32a3c7dbc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79673 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Benni Mack authored
This change also adds some basic tests for MediaViewHelper Resolves: #100929 Resolves: #99122 Releases: main, 12.4 Change-Id: Ie5d086efe605845f70f55e647c4edb87d03eba6d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79638 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Nikita Hovratov authored
Since the swap to LinkResult, the ATagParams and some more attributes are cached independent of different configuration. This is now fixed by adding the following configuration options to the md5 hash: - TMENUITEM: ATagParams - TMENUITEM: additionalParams - TMENU: addParams - TMENU: target Note: Doing this weakens the usefulness of the runtime cache again (especially for old-school TypoScript based menus). Another option would be to add the attributes after the LinkResult generation (how it was done before), but this would bypass possible Event manipulation. Resolves: #100319 Related: #96486 Releases: main, 12.4 Change-Id: I8a0346b5b932f071f9498ddccd7ecceca39deed4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79672 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
Nikita Hovratov <nikita.h@live.de>
-
Benni Mack authored
This way, it works in CLI mode as well. Resolves: #100745 Releases: main, 12.4 Change-Id: Idc00323c012bd3c7f6816b6431ed91c44da50605 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79637 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
- Jul 03, 2023
-
-
Oliver Bartsch authored
Resolves: #101194 Releases: main, 12.4, 11.5 Change-Id: I431e0af6b35d85aed0a3834c16b9f75c2923bfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79634 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
core-ci <typo3@b13.com>
-
Benni Mack authored
Resolves: #100538 Releases: main, 12.4, 11.5 Change-Id: Ia0e37a39ed566938a9b9f947ad21949a9ab3b0bc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79550 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
This change updates ckeditor5 to version 38.1. See [1] for detailed information. Executed commands: npm i --save \ @ckeditor/ckeditor5-alignment@^38.1.0 \ @ckeditor/ckeditor5-autoformat@^38.1.0 \ @ckeditor/ckeditor5-basic-styles@^38.1.0 \ @ckeditor/ckeditor5-block-quote@^38.1.0 \ @ckeditor/ckeditor5-clipboard@^38.1.0 \ @ckeditor/ckeditor5-code-block@^38.1.0 \ @ckeditor/ckeditor5-core@^38.1.0 \ @ckeditor/ckeditor5-dev-utils@^38.0.4 \ @ckeditor/ckeditor5-editor-classic@^38.1.0 \ @ckeditor/ckeditor5-engine@^38.1.0 \ @ckeditor/ckeditor5-essentials@^38.1.0 \ @ckeditor/ckeditor5-find-and-replace@^38.1.0 \ @ckeditor/ckeditor5-heading@^38.1.0 \ @ckeditor/ckeditor5-horizontal-line@^38.1.0 \ @ckeditor/ckeditor5-html-support@^38.1.0 \ @ckeditor/ckeditor5-indent@^38.1.0 \ @ckeditor/ckeditor5-link@^38.1.0 \ @ckeditor/ckeditor5-list@^38.1.0 \ @ckeditor/ckeditor5-paragraph@^38.1.0 \ @ckeditor/ckeditor5-paste-from-office@^38.1.0 \ @ckeditor/ckeditor5-remove-format@^38.1.0 \ @ckeditor/ckeditor5-source-editing@^38.1.0 \ @ckeditor/ckeditor5-special-characters@^38.1.0 \ @ckeditor/ckeditor5-style@^38.1.0 \ @ckeditor/ckeditor5-table@^38.1.0 \ @ckeditor/ckeditor5-theme-lark@^38.1.0 \ @ckeditor/ckeditor5-ui@^38.1.0 \ @ckeditor/ckeditor5-undo@^38.1.0 \ @ckeditor/ckeditor5-utils@^38.1.0 \ @ckeditor/ckeditor5-word-count@^38.1.0 npm run build [1] https://github.com/ckeditor/ckeditor5/releases/tag/v38.1.0 Resolves: #101223 Releases: main, 12.4 Change-Id: I5653cc0fb217dfa9bb2301c5a985aca953fc4d87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79633 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Andreas Fernandez authored
With the dismissal of jQuery and jQuery UI from the image manipulation component, the event handling for the trigger button ("Open Editor") got borked as the event state toggling previously done via `.off(...).on(...)` was replaced with using a `signal` as documented at [1]. The `AbortController` instance is only built when the modal has been fully shown, way after the event handling took place, breaking the module's global state. To solve this issue we removed the `AbortController` and its usages again. Also, `initializeTrigger()` now uses event delegation to register the event handler on the trigger buttons. As a drive-by fixes, the `active` state of the ratio buttons is now properly toggled, and the ratio title field is correctly updated by comparing with the scoped `ratioTitleWindow.HTMLElement` prototype. [1] https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#add_an_abortable_listener Resolves: #101150 Resolves: #101199 Related: #100948 Releases: main, 12.4 Change-Id: I021c74bb67976468ebdc5226263c6441796bd65b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79632 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Benni Mack authored
This change prevents a PHP warning in ContentObjectRenderer when working with "max" and "begin". Resolves: #100857 Releases: main, 12.4, 11.5 Change-Id: I1af115deecc537efdc41125daa119630d6449044 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79548 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Benni Mack authored
When editing in FormEngine the popup now has a larger size, corresponding to up-to-date displays and devices. Resolves: #99383 Releases: main, 12.4 Change-Id: I0638d42b0b4018aba1093cca5f816e91bf86e471 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79546 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Stefan Bürk <stefan@buerk.tech>
-
Andreas Nedbal authored
This change in the Rollup configuration caused the window namespace to disappear, breaking the JS call in the process. Resolves: #101202 Releases: main, 12.4 Change-Id: Ie216d7d91502436b68c6404b0c81268ce0f5672e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79547 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Nedbal <andy@pixelde.su> Reviewed-by:
Andreas Nedbal <andy@pixelde.su>
-
Torben Hansen authored
This change moves the section about "Access restrictions on the felogin plugin" to the user manual, since the section is not an example, but an important notice for users of the plugin. The part about having two plugins on one page has been removed, since this will lead to other problems as noted in the "Known problems" chapter. Additionally, a short notice about the "Hide at login" problem has been added to the "Known problems" chapter. Resolves: #100632 Releases: main, 12.4, 11.5 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I28fe311ce46ef3e1cae9cd60cebb7215fb02701e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79543 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Benni Mack authored
The site language's configuration setting "hreflang" was deprecated with #99908, however, it still serves a valid purpose. If working with EXT:seo and the <link rel="alternate"> tags, it is still valid and possible to set a specific "hreflang" attribute. Example setups: * You have "German (Germany)" (which is using de-DE as locale) and "German (Austria)" (which is using de-AT as locale). here you want to set "de" as generic fallback in the "de-DE" locale when using hreflang attributes. * You want to explicitly set "x-default" for a specific language, which is clearly not a valid language key. This change does the following: * It re-adds the hreflang property to be managed by the UI, however it is empty by default and will fallback to the $locale->getName(). * It is not used within the <html lang="..."> attribute anymore as this was a mis-use in the first place (and now properly using just the language key, see https://www.w3.org/International/questions/qa-html-language-declarations.en.html#attributes * The method "SiteLanguage->getHrefLang()" is not deprecated anymore. * The RST is adapted accordingly Still, the relevant information is: The site language configuration option "hreflang" is not relevant anymore for regular websites without rendering hreflang tags, but is now customizable, and has a proper fallback. Resolves: #101160 Resolves: #95798 Related: #99908 Releases: main, 12.4 Change-Id: Ifc5b5b10ba46b4da4abd5c504d4d69f240f2fd02 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79545 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Susanne Moog authored
As LC_NUMERIC is not set via Locales::setLocale because conflicts on float calculation may occur, we have to manually set LC_NUMERIC in places where we need the locale aware numeric functionality. In the core this is only formatSize - which missed the LC_NUMERIC handling since the switch to SiteConfiguration. With this patch, the handling is reintroduced by using the locale set by setLocale for LC_MONETARY to temporarily set LC_NUMERIC in formatSize. Resolves: #101211 Releases: main, 12.4 Change-Id: Id694f04fb07fb421644fa87c415d786ca11bcfaa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79542 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-
Markus Klein authored
All PHP code is adjusted to use proper spelling "referrer". Existing Fluid variables or config options are not touched. Resolves: #101216 Releases: main, 12.4, 11.5 Change-Id: I8d18b1f269c921d01bcd1b5c3b7017527d92e72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79581 Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org>
-
Andreas Fernandez authored
If a console command throws an exception that isn't caught, the exit code evaluates to "0" (aka successful) because the exit codes usually are the exception timestamp and UNIX doesn't support exit codes > 255. The issue is now solved by checking the exit code in `CommandApplication` and setting an upper bound of 255. Resolves: #101220 Releases: main, 12.4 Change-Id: I722125aa678fe24accb7ebf9732e571ff54abb73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79541 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Tymoteusz Motylewski authored
Include Matomo, Google, Hubspot. Resolves: #101180 Releases: main, 12.4, 11.5 Change-Id: I15ba4d4ec84e5abfb22e5f83d02535e06e2de40f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79539 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Benni Mack <benni@typo3.org> Tested-by:
Benni Mack <benni@typo3.org>
-
- Jul 02, 2023
-
-
Torben Hansen authored
This change removes a useless test, which only tests PHP native `htmlspecialchars()` and `htmlspecialchars_decode()` functionality. The test did previously test `GU:htmlspecialchars_decode()`, which has replaced by PHP native `htmlspecialchars_decode()` in #54777. Resolves: #101215 Related: #54777 Releases: main, 12.4 Signed-off-by:
Torben Hansen <derhansen@gmail.com> Change-Id: I11b68e74eb55ed160931353fb0f25c0340732c67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79538 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Jul 01, 2023
-
-
Christian Kuhn authored
A new patch level requires to regenerate baseline. > composer req --dev phpstan/phpstan:^1.10.22 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #101214 Releases: main, 12.4, 11.5 Change-Id: I762846574afa26b6b4bc0ae122b07be3dde99c73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79577 Reviewed-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Stefan Bürk <stefan@buerk.tech>
-
Nikita Hovratov authored
The previous logic for checking whether a value for a specific doktype already exists falsely assumed the value should be an array. This is now fixed by using the null coalescing assignment, which is available since PHP 7.4. Resolves: #101196 Related: #94498 Releases: main, 12.4, 11.5 Change-Id: Iab1dba7987d336b08bfb4f398b16666d591daada Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79536 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
Oliver Bartsch <bo@cedev.de>
-
- Jun 30, 2023
-
-
Stephan Großberndt authored
Instead of breaking the execution with a TypeError if an array to be flattened by ArrayUtility::flatten() has integer keys, this change allows the method to handle this case correctly. Resolves: #101208 Related: #97202 Releases: main, 12.4 Change-Id: I05d47da80e088f024536fe15f5f2c2802c22a921 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79535 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
Class SchemaMigrator has an unused property $schema. Removing this property makes it more obvious this service is stateless. Resolves: #101207 Releases: main, 12.4 Change-Id: Icb6fced983129a508152ed79f7511b1b219c23db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79566 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Stephan Großberndt authored
Replace the Fluid if condition for the onSubmit value in the login template of EXT:fe_login with the else part. The onSubmit value in the login template of EXT:fe_login was ported from the pibase'd version but never set in Extbase'd version and thus in Fluid. Resolves: #101178 Releases: main, 12.4 Change-Id: Ic80a65c80841292c4b6ee2251d8e148d51b56e9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79567 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
- Jun 29, 2023
-
-
Andreas Fernandez authored
The fix for #100750 aimed to apply `array_unique()` to the array containing page ids used as webmounts for the backend search. Unfortunately, the call was done only for the storage in the runtime cache with the side effect that still the full array with possible duplications is returned on first invocation. The affected `array_unique()` call is now extracted into a separate line right before storing the resulting array to cache, which results in returning the same, unified array. Resolves: #101200 Related: #100750 Releases: main, 12.4, 11.5 Change-Id: Idbe6f1639ec84737ab151d5ab2d18739736e2327 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79534 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de>
-
Oliver Hader authored
The CSP backend module is not showing the optional source-file of the reported violation. This information references to the actual asset that caused the violation. In addition, visualizing the user-agent helps to identifiy and reproduce possible flaws. In case, `effective-directive` (preferred W3C property) is not given, but `violated-directive` (legacy W3C property) is, that value is taken - this still can happen in old browser versions. Resolves: #100912 Releases: main, 12.4 Change-Id: Idf9482d234292a15a4114c474ddb2b5316d21a87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79562 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Oliver Hader authored
Reconstituting HashValue objects from their string representation fails and cannot be used in the site csp.yaml settings as a consequence. This change addresses several flaws: * `HashValue` is used instead of `HashType` as value object * returning potential null values by `BackedEnum::tryFrom()` has to be avoided, since it exits too early * `rsort` reindexed and destroyed the array keys, which would have contained the relevant class names Test cases for ModelService::buildSourceFromString() are added. Resolves: #101183 Releases: main, 12.4 Change-Id: I43126941cb7cc9316c483e5a96992dc6d32ead35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79561 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
Oliver Hader authored
Adds tests for site resolving by e.g. https://example.org/?id=1&L=0 Resolves: #101198 Releases: main, 12.4, 11.5 Change-Id: Ie6a3db97181662e2d3570eb8e93bebaa9c3509c8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79558 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 28, 2023
-
-
Dennis Prinse authored
The update to only allow guzzlehttp/promises has been breaking to external extensions and their dependencies. Only allowing guzzlehttp/promises v2 caused projects to refuse updating TYPO3 from v12.4.1 to v12.4.2 > composer require guzzlehttp/promises:"^1.5.2 || ^2.0" > composer require --no-update guzzlehttp/promises:"^1.5.2 || ^2.0" \ -d typo3/sysext/install/ Resolves: #101184 Related: #100919 Releases: main, 12.4 Change-Id: I173ca51ed03e3d1522d3dfa2e0db46a9141b6e13 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79527 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Nikita Hovratov <nikita.h@live.de>
-
- Jun 27, 2023
-
-
Oliver Hader authored
Resolves: #101169 Releases: main, 12.4 Change-Id: I3fc60ed9fcfa55a6368618976d5f8a1c2315039f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79520 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Christian Kuhn authored
A single FormEngine element (created by "element" classes that typically extend AbstractFormElement) takes care of the "inner" HTML of an element. The surrounding "outer" HTML like embedding elements in palettes is created by "container" classes. Also, <label> tags for single elements are created by container classes, namely PaletteAndSingleContainer and FlexFormElementContainer. The situation having <label> done by a container and the inner HTML done by elements has drawbacks: First, "label" tags should have a "for" attribute, to connect it with input fields having "id" attribute. This is one of the accessibility "must haves". Separating label and fields in different classes does not allow doing this. Secondly, not all elements have such input or select tags at all. In those cases, the label is not a label, but should be a legend embedded in a fieldset. The patch moves the existing label tag generation from container classes to element classes: Only elements know if, how and where label and legend tags should be placed. The patch adds two helper methods to AbstractFormElement to simplify this, and connects the label tag with the input field in all elements or adds a fieldset with a legend. The v12 version of the patch needs to jump through some additional loops: When elements take care of label or legend, they signal this by setting the flag labelHasBeenHandled in the result array. The container then skips label creation to not have them twice. This is a b/w compat layer for not yet adapted custom elements in v12. The v13 version of the patch does not come with this fallback layer and documents needed custom element changes in a ReST file. Resolves: #97330 Releases: main, 12.4 Change-Id: Ia110eef5ec17aa4b7c731c3f82262b932d86958f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79517 Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de>
-
Christian Kuhn authored
A broken cache handling related to site settings in PageTsConfigFactory effectively leads to broken access to site settings related "constants". The patch fixes the cache handling. Resolves: #100810 Related: #97816 Releases: main, 12.4 Change-Id: I6af1a2aae037f90f97ed61aff8aabebcc8e91f89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79533 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch>
-
Christian Kuhn authored
The v12 TypoScript parser has a nifty feature to create the smallest possible amount of cache entries: When two sys_template records have the same content, when they're basically just different by their uid, pid and maybe title, then they share the same cache entry of their tokenized representation. A sys_template row that has the "clear constants" flag set, triggers inclusion of possible site settings, which are available as constants. When there are two different sys_template "entry" records in a multi site instance, those sys_template records are bound to different sites and should thus load potentially different site settings. The data fields of those two sys_template records may be the same, but still need to trigger different cache entries. Otherwise, the site settings from the request that triggered creation of the cache entry swaps into the other one. To deal with this scenario, the site identifier of the current site is now added to the cache identifier, which leads to different cache entries in this scenario. Resolves: #101177 Related: #97816 Related: #99331 Releases: main, 12.4 Change-Id: I4bf9b79fe9e91c8ec7ef01ccffd7661549dc8f86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79532 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
core-ci <typo3@b13.com>
-
- Jun 26, 2023
-
-
Jasmina Ließmann authored
In order to ensure the readability of the progress bar, the previous content has been split up. Only the percentages are now displayed in the progress bar. Information about which installation step the user is currently at is now displayed above the progress bar. In addition, an undefined variable and icon were removed and the form buttons of the first step are now aligned in a row. Resolves: #100987 Releases: main, 12.4 Change-Id: Idc43d11a5f4b9988c51cf97482dee1f48d8e21b5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79425 Tested-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com> Tested-by:
core-ci <typo3@b13.com> Reviewed-by:
Jasmina Ließmann <minapokhalo+typo3@gmail.com>
-
Oliver Hader authored
The admin panel uses Symfony's `HtmlDumper` to output data - which is adding inline JavaScript and StyleSheet elements. To be compatible with CSP those elements need to be allowed with a nonce attribute. This change relies on a merged pull request for Symfony v6.3: https://github.com/symfony/symfony/pull/49977 Executed commands: composer req symfony/var-dumper:^6.3 composer req symfony/var-dumper:^6.3 \ -d typo3/sysext/adminpanel --no-update Resolves: #100456 Releases: main, 12.4 Change-Id: I7fcea196107959db85257c7d735f85a9e78839d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79204 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
Oliver Hader <oliver.hader@typo3.org>
-
Stefan Froemken authored
The extbase implementation "Query" of the QueryInterface contains a method "unsetLimit". Calling this method really PHP:unset()'s the $limit property from Query object. That will produce various PHP warnings where getLimit() is called. As $limit is initialized with null while instanciation, calling unsetLimit() will now reset $limit to null again instead of removing the complete property. Resolves: #100999 Releases: main, 12.4 Change-Id: I8042823b7b3e8d010787d976c1a469988b618c41 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79423 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Benni Mack <benni@typo3.org>
-