Skip to content
Snippets Groups Projects
  1. Jul 04, 2023
  2. Jul 03, 2023
  3. Jul 02, 2023
  4. Jul 01, 2023
  5. Jun 30, 2023
  6. Jun 29, 2023
  7. Jun 28, 2023
  8. Jun 27, 2023
    • Oliver Hader's avatar
      [BUGFIX] Provide CSP nonce value for adminpanel assets · 3ef7ec48
      Oliver Hader authored
      Resolves: #101169
      Releases: main, 12.4
      Change-Id: I3fc60ed9fcfa55a6368618976d5f8a1c2315039f
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79520
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarOliver Hader <oliver.hader@typo3.org>
      Reviewed-by: default avatarOliver Hader <oliver.hader@typo3.org>
      3ef7ec48
    • Christian Kuhn's avatar
      [TASK] Connect label with element in FormEngine · 4531510e
      Christian Kuhn authored
      A single FormEngine element (created by "element"
      classes that typically extend AbstractFormElement)
      takes care of the "inner" HTML of an element.
      
      The surrounding "outer" HTML like embedding elements
      in palettes is created by "container" classes. Also,
      <label> tags for single elements are created by
      container classes, namely PaletteAndSingleContainer
      and FlexFormElementContainer.
      
      The situation having <label> done by a container and
      the inner HTML done by elements has drawbacks:
      First, "label" tags should have a "for" attribute,
      to connect it with input fields having "id" attribute.
      This is one of the accessibility "must haves".
      Separating label and fields in different classes
      does not allow doing this. Secondly, not all elements
      have such input or select tags at all. In those cases,
      the label is not a label, but should be a legend
      embedded in a fieldset.
      
      The patch moves the existing label tag generation from
      container classes to element classes: Only elements
      know if, how and where label and legend tags should
      be placed. The patch adds two helper methods to
      AbstractFormElement to simplify this, and connects
      the label tag with the input field in all elements
      or adds a fieldset with a legend.
      
      The v12 version of the patch needs to jump through
      some additional loops: When elements take care of
      label or legend, they signal this by setting the
      flag labelHasBeenHandled in the result array. The
      container then skips label creation to not have
      them twice. This is a b/w compat layer for not yet
      adapted custom elements in v12. The v13 version of
      the patch does not come with this fallback layer
      and documents needed custom element changes in a
      ReST file.
      
      Resolves: #97330
      Releases: main, 12.4
      Change-Id: Ia110eef5ec17aa4b7c731c3f82262b932d86958f
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79517
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Reviewed-by: default avatarMichael Telgkamp <michael.telgkamp@mindscreen.de>
      Tested-by: default avatarBenni Mack <benni@typo3.org>
      Reviewed-by: default avatarBenni Mack <benni@typo3.org>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarMichael Telgkamp <michael.telgkamp@mindscreen.de>
      4531510e
    • Christian Kuhn's avatar
      [BUGFIX] Have site settings in pageTsConfig · d6f109c6
      Christian Kuhn authored
      A broken cache handling related to site settings
      in PageTsConfigFactory effectively leads to
      broken access to site settings related
      "constants". The patch fixes the cache handling.
      
      Resolves: #100810
      Related: #97816
      Releases: main, 12.4
      Change-Id: I6af1a2aae037f90f97ed61aff8aabebcc8e91f89
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79533
      
      
      Tested-by: default avatarcore-ci <typo3@b13.com>
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      d6f109c6
    • Christian Kuhn's avatar
      [BUGFIX] Correct multi site FE TypoScript caches · 541766ba
      Christian Kuhn authored
      The v12 TypoScript parser has a nifty feature to
      create the smallest possible amount of cache entries:
      
      When two sys_template records have the same content,
      when they're basically just different by their uid,
      pid and maybe title, then they share the same
      cache entry of their tokenized representation.
      
      A sys_template row that has the "clear constants"
      flag set, triggers inclusion of possible site
      settings, which are available as constants.
      
      When there are two different sys_template "entry"
      records in a multi site instance, those sys_template
      records are bound to different sites and should thus
      load potentially different site settings. The
      data fields of those two sys_template records may be
      the same, but still need to trigger different cache
      entries. Otherwise, the site settings from the request
      that triggered creation of the cache entry swaps into
      the other one.
      
      To deal with this scenario, the site identifier of
      the current site is now added to the cache identifier,
      which leads to different cache entries in this
      scenario.
      
      Resolves: #101177
      Related: #97816
      Related: #99331
      Releases: main, 12.4
      Change-Id: I4bf9b79fe9e91c8ec7ef01ccffd7661549dc8f86
      Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/79532
      
      
      Tested-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Reviewed-by: default avatarChristian Kuhn <lolli@schwarzbu.ch>
      Tested-by: default avatarcore-ci <typo3@b13.com>
      541766ba
  9. Jun 26, 2023