- Jan 30, 2017
-
-
Andreas Fernandez authored
Currently, a warning sign is rendered next to field labels whose validation failed. Failed validations are errors and thus another icon should be rendered. With this patch, a red circle containing an exclamation mark is rendered. It’s the same icon as in the tabs holding affected fields. Resolves: #79537 Releases: master Change-Id: I01b783c36dfac551bf6e9f0cb8fc703290c3eb72 Reviewed-on: https://review.typo3.org/51460 Tested-by:
TYPO3com <no-reply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Reviewed-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Thomas Hohn <thomas@hohn.dk> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Dominique Kreemers authored
This makes "eval" processing working again for text fields. Resolves: #79545 Related: #79341 Releases: master Change-Id: Icda2f32a41a95afa33c87be9ed60c5b5ed47f275 Reviewed-on: https://review.typo3.org/51465 Reviewed-by:
Marcus Schwemer <ms@schwemer.de> Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Frans Saris authored
Resolves: #79280 Releases: master Change-Id: I1d3815cef36d624c910d40eb6d63a3eba4f3f53d Reviewed-on: https://review.typo3.org/51455 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Claus Due authored
This patch avoids `f:switch` in the partial template, since this ViewHelper is not compilable in the version provided as override from TYPO3 CMS. The patch also adds the CompileWithRenderStatic trait to a ViewHelper used frequently in that partial. Change-Id: I768e43e7c70a17fef04c28774169d4b3badb310b Resolves: #79542 Releases: master Reviewed-on: https://review.typo3.org/51464 Tested-by:
Philipp Gampe <philipp.gampe@typo3.org> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Andreas Fernandez authored
With the merge of #79513 the fields `ses_hashlock` were removed from be_users and fe_users. The usages within the acceptance test fixtures were not removed, causing the acceptance test to fail. This patch removes the field usages in the fixtures. Resolves: #79526 Related: #79513 Releases: master Change-Id: Ibf139599ac0b71f510e322e011d461c4df400664 Reviewed-on: https://review.typo3.org/51453 Tested-by:
-
- Jan 29, 2017
-
-
Claus Due authored
This patch solves a special case in the integration with Fluid. Fluid itself allows an emulated controller action to be used, which contains a sub-path (controller name supports this as well). However, the RenderingContext forced use of pathinfo() on the passed path, which caused sub-paths to be removed. The patch switches from pathinfo() to substr() to preserve any slashes in such controller action names. Only direct usage of Fluid's API is affected and no current compatibility is broken by the patch. Change-Id: I7e1c27d55a44b957aadbace571e50afd7614d8a0 Resolves: #79519 Releases: master Reviewed-on: https://review.typo3.org/51451 Tested-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
-
Thomas Hohn authored
There is no need to check the record we are updating - since we update it anyway, update timestamp too and save both a call to getRecord and a loop through fields, casting and checking each field value comparing to DB. Change-Id: Ic807030c5cea83d36e543ed0f75cf980c3872d1e Releases: master, 7.6 Resolves: #79004 Reviewed-on: https://review.typo3.org/50976 Tested-by:
-
- Jan 28, 2017
-
-
Michael Oehlhof authored
When saving a new linkvalidator task in the scheduler and the validation failed, now the previous input is kept in the external fields. Resolves: #79056 Releases: master Change-Id: Ib629f47890f2972de8c8bfa28644ef933357c374 Reviewed-on: https://review.typo3.org/51011 Tested-by:
-
Georg Ringer authored
Use tooltips instead of ancient JavaScript alerts for locked records. Resolves: #79422 Releases: master Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df Reviewed-on: https://review.typo3.org/51387 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Reviewed-by:
-
Benjamin Franzke authored
As https://review.typo3.org/#/c/44025/ enabled extensionmanager offline mode for composer installations, the composer mode message should no longer be a warning but an info. Releases: master, 7.6 Fixes: #79107 Change-Id: Ic9fcb134c113172de504833ed81f7a46a0ba4e2c Reviewed-on: https://review.typo3.org/51059 Tested-by:
-
- Jan 27, 2017
-
-
Claus Due authored
PlainDataResolver will do semi-expensive operations for workspaces-enabled tables even if EXT:version (and therefore EXT:workspaces) is not loaded. Doing a cheap check can prevent calling two such operations and saves SQL queries and memory. Change-Id: I6062538c3c158352b7be5748d407bbe2aad3a641 Resolves: #78982 Releases: master Reviewed-on: https://review.typo3.org/50952 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Artus Kolanowski authored
Introduce a new class `OrderedProviderList` which calls providers with dependencies given by setter. Resolves: #79512 Releases: master Change-Id: Icf97e2e6fa5ed88d7b76b7628bb4e9790b615a38 Reviewed-on: https://review.typo3.org/51443 Tested-by:
-
Morton Jonuschat authored
While it's normally fine to replace DISTINCT with GROUP BY when counting objects this results in a different resultset. The GROUP BY statement will have n rows with the count per grouped combination while the DISTINCT based query will have one row with the count of unique combinations. Use a COUNT(DISTINCT uid) to get the expected result. DISTINCT is supported on MySQL, PostgreSQL, Oracle and MSSQL Server. Change-Id: If3193113529f1bb01693dba39abccfe349f169b1 Resolves: #79330 Releases: master Reviewed-on: https://review.typo3.org/51320 Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
Artus Kolanowski authored
To follow the concept of backend apps and provide a lean core by removing a rarely used feature, which benefit is pretty low for the editor. Resolves: #79364 Releases: master Change-Id: Ic1796aa4f23507ac45b52155c66da02cffc88b3b Reviewed-on: https://review.typo3.org/51340 Tested-by:
-
Michael Oehlhof authored
Added a feature to the scheduler to mark tasks to be run by next cron job. Resolves: #45537 Releases: master Change-Id: I72d0e693821630a0be655159b53c168b1973d886 Reviewed-on: https://review.typo3.org/45807 Tested-by:
-
Georg Ringer authored
The field `select_key` is not used by the core and is moved to the EXT:compatibility7. Resolves: #77934 Releases: master Change-Id: Ied7fa722c1bccb314fd02229da407613fbce7dfe Reviewed-on: https://review.typo3.org/49934 Reviewed-by:
-
Benni Mack authored
The TYPO3 Core used the "useragent" to create a hashbase by default to harden the session hijacking functionality. This very very old feature adds a tiny bit of security on top, however it has the drawback that users get logged out (of BE or FE) if their browser updates (due to evergreen browsers or security updates as the user agent string changes). This is very inconvenient for websites that use a very long session time for logged in users in the frontend (or backend) when using TYPO3 as a platform or application. It was originally concepted so it could be extended but there is no hook to do so, and extending all classes does not really make a lot of sense in the hierarchical PHP class structure. Resolves: #79513 Releases: master Change-Id: I78e58210da80c7c1544a644e8e10bc1f667b5bf1 Reviewed-on: https://review.typo3.org/51437 Tested-by:
-
Thomas Hohn authored
A new signal is introduced to allow the exclusion of tables from the ReferenceIndex. The checks whether tables or columns should be excluded are extracted to methods. Fixes: #79387 Releases: master Change-Id: I5ef558bc1a1c63553e8a1dc193167d068f235487 Reviewed-on: https://review.typo3.org/51362 Reviewed-by:
Stephan Großberndt <stephan@grossberndt.de> Tested-by:
-
Thomas Hohn authored
Change-Id: I889264f34599be556e16b3d37825a3761b681e70 Resolves: #79068 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51018 Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Mathias Brodala authored
Objects implementing the DomainObjectInterface must always be persisted using their identifier, even if they implement the Traversable interface. Change-Id: Iccb53d6e7ded9b6b5300e111e8503641b10615f4 Resolves: #79294 Related: #57255 Releases: master, 7.6 Reviewed-on: https://review.typo3.org/51287 Tested-by:
-
Georg Ringer authored
The php-cs fixer creates a cache file which should not be commited. Add it to the .gitgnore to avoid any mistakes. Resolves: #79510 Releases: master, 7.6 Change-Id: Ia85f825416ad767a07d280de35a18c318e1a5133 Reviewed-on: https://review.typo3.org/51441 Reviewed-by:
-
- Jan 26, 2017
-
-
Christian Kuhn authored
The patch introduces a new API on FormEngine element level that substitutes the old "wizards" / renderWizard() API with a more powerful system. Single wizards are now split into one of three categories: * An informational wizard * A control button / icon * A true wizard with additonal functionality Method renderWizards() is still called in elements for compatibility reasons if people added own scrip/popup/userFunc wizards, but all core wizards are migrated. The patch significantly cleans the HTML of single elements, especially HTML stuff that was added by the SingleFieldContainer is now put down to single elements, while main HTML wraps formerly done by renderWizards() is fetched "up" to single elements. This gives single elements full control about the main HTML it is producing, which is a must have preparation in order to further advance in this area and to switch single elements to fluid rendering in one of the next steps. The patch brings a pretty huge list of TCA changes and simplifications, all TCA changes are supported by TCA migration, so existing extensions should benefit out of the box and just get deprecations logged. Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab Resolves: #79440 Resolves: #70032 Releases: master Reviewed-on: https://review.typo3.org/51151 Tested-by:
-
Manuel Selbach authored
Add a functional test to verify that serialized PHP objects can be successfully stored in the database without having encoding/escaping problems. Resolves: #79452 Releases: master Change-Id: I97d586cb8a50e571d99ff8b7fc463c0a83e15f36 Reviewed-on: https://review.typo3.org/51394 Reviewed-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Ralf Zimmermann authored
Render the form label or a placeholder text (if no form is selected) within the page module. Resolves: #78834 Releases: master Change-Id: I5519ce8bec7ae077d22328ff0ad70b29aa1b5af7 Reviewed-on: https://review.typo3.org/51422 Tested-by:
Bjoern Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Andreas Steiger authored
* add attribute role="alert" to error hints * streamline bootstrap 3 error classes * add attribute formnovalidate to previous button of multistep form * remove fieldset wrap from element type 'PAGE' Resolves: #69974 Releases: master Change-Id: I66336879bed0f94752482404c3ed7cfa7028046d Reviewed-on: https://review.typo3.org/51426 Tested-by:
-
Ralf Zimmermann authored
Adds a new button into the form editor module header. Clicking on this buttons shows the form settings within the inspector. Resolves: #79467 Releases: master Change-Id: I767c71fcf65ca5bd58b2b530a60fce1caf75e3c9 Reviewed-on: https://review.typo3.org/51425 Tested-by:
Andreas Steiger <typo3@andreassteiger.de> Tested-by:
-
Ralf Zimmermann authored
Parse finisher option values only if the referenced formelement value is a string. Resolves: #79412 Releases: master Change-Id: Ie379a396473c31907d52c8aa096168fed803510b Reviewed-on: https://review.typo3.org/51381 Tested-by:
Daniel Lorenz <daniel.lorenz@extco.de> Tested-by:
Jan Helke <typo3@helke.de> Reviewed-by:
-
Georg Ringer authored
- Skip length check of header - Use type "number" for integer types - Apply min & max attributes if available Resolves: #79421 Releases: master Change-Id: I508000547214d3d3ca18a8e311ce68dd03dea09b Reviewed-on: https://review.typo3.org/51386 Reviewed-by:
Mattias Nilsson <tollepjaer@gmail.com> Tested-by:
-
Thomas Hohn authored
The database field definition for ref_string is limited to varchar(200) and can cause an SQL error when bigger strings are inserted. In addition it makes sense to add a mb_substr() to avoid an error if longer strings are inserted. Fixes: #79425 Releases: master Change-Id: I1f1e672f610f830ad5e02509cb1f0529c9cbeb41 Reviewed-on: https://review.typo3.org/51397 Tested-by:
-
Mona Muzaffar authored
An error occurs in the createNamedParameter function which expects an array but gets a string instead. Change-Id: I393a6a87c912129ded28f677ca65c081fc4205e7 Resolves: #79309 Releases: master Reviewed-on: https://review.typo3.org/51342 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Manuel Selbach authored
Change-Id: I6db726bfff61c092309a971eb71e074c30cad046 Releases: master, 7.6 Resolves: #79378 Reviewed-on: https://review.typo3.org/51349 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Reviewed-by:
-
Thomas Hohn authored
This patch marks some internal cache variables in the Datahandler as deprecated since their visibility should be changed from public to protected or even be replaced by a runtime cache. Since this can't be done before TYPO3 v9 they are marked as deprecated in TYPO3 v8 as a preparation. Fixes: #79441 Releases: master Change-Id: I7d35792fb81e6f16b3b729a3841c1cfda109952f Reviewed-on: https://review.typo3.org/51411 Reviewed-by:
-
Thomas Hohn authored
Switch updateIndex method to use a subselect based approach to avoid errors due to huge parameter lists for manually built NOT IN queries which could exceed the maximum query length. Add a warning if the table doesn't share a connection with the reference index as it can not be updated automatically. Resolves: #79397 Releases: master Change-Id: I563dfe607b24ffe949ef5a0e9d2e62b2312ff8f0 Reviewed-on: https://review.typo3.org/51370 Tested-by:
-
Markus Klein authored
This fixes the issue that lines are wrapped within a HTML entity. Resolves: #79398 Releases: master, 7.6 Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002 Reviewed-on: https://review.typo3.org/51369 Tested-by:
Dominique Kreemers <dominique.kreemers@icloud.com> Tested-by:
-
Manuel Selbach authored
Within the refactoring process the optional parameter $useDeleteClause was missed to remove from the parameter list of the method, as it is not implemented in the body and not used anywhere in the core. Releases: master Resolves: #79382 Change-Id: I4db104941b78f44573b0b1f51ad216ded93887bf Reviewed-on: https://review.typo3.org/51351 Tested-by:
-
Manuel Selbach authored
When writing to database tables with BLOB type columns declare the field type for the query parameters in functional tests. This is required for databases that use a different encoding/transport protocol for BLOB fields. Resolves: #79453 Releases: master Change-Id: I1371bb192abaec841be982a1b228cc6b7e6d1cbf Reviewed-on: https://review.typo3.org/51395 Reviewed-by:
-
- Jan 25, 2017
-
-
Mona Muzaffar authored
Change-Id: I6a17811dd5dbc5ed285b6040fcbe97e94b416b8b Releases: master Resolves: #79321 Reviewed-on: https://review.typo3.org/51359 Tested-by:
-
Claus Due authored
A new Fluid ViewHelper, `f:variable`, has become available in TYPO3 after raising the minimum required version of the Fluid engine to 2.2.0. Change-Id: I4f42030ef586e8d9a3d40c54c64137eb1969384d Resolves: #79402 Releases: master Reviewed-on: https://review.typo3.org/51398 Tested-by:
-
Anja Leichsenring authored
With the update of cs-fixer to version 2.0, some checks got minor changes in behaviour. The core follows now in applying those suggested changes. Resolves: #79469 Relates: #79361 Releases: master Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989 Reviewed-on: https://review.typo3.org/51428 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Frank Naegler authored
This patch adds a missing compilerOption to generate subfolder in the build directory, which fix the copy to final destination problem. Resolves: #79431 Releases: master Change-Id: Ie756d47e12d2ff72aa6db397d87db311eed43b59 Reviewed-on: https://review.typo3.org/51404 Reviewed-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
