- Jul 20, 2020
-
-
Nikita Hovratov authored
The search field has now an own class to apply css before the wrapper gets rendered. The extension list table columns have now explicit widths. This ensures the view is not slightly changing after initial JavaScript operations. Resolves: #91732 Releases: master, 10.4 Change-Id: Ic9ce327cfa6b5e415974792ee33896540e5a3de6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64992 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Andreas Fernandez authored
Resolves: #91740 Releases: master Change-Id: Ie728f74bd45f7e427f4f2242778257320eac5ef7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64995 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Alexander Stehlik authored
The field size is increased to decimal(2,1) to be able to store the value 1.0 zero in MariaDB databases. Resolves: #91736 Releases: master, 10.4 Change-Id: I72aa5e5a1f23673f6912b2f042c9d9364fd9855f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64993 Tested-by:
Simon Vincent Ackermann <simon@hemmer.ch> Tested-by:
Eric Chavaillaz <eric@hemmer.ch> Tested-by:
-
- Jul 17, 2020
-
-
Oliver Hader authored
Resolves: #91819 Releases: master, 10.4 Change-Id: I8f43397f3366e66f08ca2dad7bcfd290e0769c58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65054 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The tab handling now utilizes the BrowserSession module to store the tab menu states in the browser's sessionStorage. These values get removed after the browser's session is closed with renders the manual expiry handling obsolete. Additionally, all previously in localStorage stored states get removed as they are not required anymore. Resolves: #91591 Releases: master Change-Id: Id9fa0560cfa2b186cecaf5671f27b698a45d141c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64784 Tested-by:
Benjamin Kott <benjamin.kott@outlook.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Oliver Hader authored
Inline JavaScript used in the backend paginate widget is replaced by data-attribute instructions handled by `GlobalEventHandler` module. Resolves: #91804 Releases: master, 10.4 Change-Id: I230b2e3c550be6ca1089da9bcbe9ace752a29db7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65039 Tested-by:
-
Alexander Nostadt authored
The newest versions are to be on top, to comply to the order given to older versions. Releases: master Resolves: #91816 Change-Id: Id4fb2444cad7078accd65aa76549a5dc65e92d4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65051 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
- Jul 16, 2020
-
-
Benjamin Franzke authored
Left-hand module menu and top toolbar are refreshed using inline JavaScript when e.g. an extension is de-/activated in extension manager or users switch their backend language in setup module. A new module `ImmediateActionElement` is introduced that implements the Custom HTML Element `<typo3-immediate-action action="…">`. The element immediately dispatches the action passed via the action attribute once attached to the DOM. We therefore drop the (currently unused) data-dispatch-immediately attribute which was introduced in #91015, as we opt for a more streamlined custom HTML element implementation now. Resolves: #91191 Releases: master, 10.4 Change-Id: I2724c51da3ea9aea0556ac63e834368e48866dd4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64675 Tested-by:
-
- Jul 15, 2020
-
-
Oliver Hader authored
* streamline variable names * streamline method names * preparation for additions in the future Resolves: #91805 Releases: master, 10.4 Change-Id: Iaa16cfcbcda7adbd48838a498f2f459d97f4ef18 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65042 Tested-by:
-
Oliver Hader authored
Prior to this patch routes were processed in reverse definition order. Routes defined last came first. Depending on the existence of variable defaults this behavior produced a couple of unexpected results. first: routePath: '/route/{a}/{b}' second: routePath: '/route/{c}' defaults: c: '0' The example above, processed in reverse order and having parameters `a` and `b` given, still resulted in `second` route being used since the missing parameter `c` was defined by corresponding variable default. This change adjusts the order of routes depending on given parameters, completeness of a route (when all parameters are given, even defaults). Sorting is adjusted based on the following criteria: * default routes (e.g. `/my-page`) - processed later * static routes (e.g. `/my-page/list`) - processed later * all variables are given (complete) - processed earlier (e.g. parameters `a` and `b` are given for route `/route/{a}/{b}`) * all mandatory variables are given (complete) - processed earlier * less missing variable defaults - processed earlier * less variable defaults amount - processed earlier Tests in class `RouteSorterTest` provide more examples & details. Resolves: #90924 Releases: master, 10.4, 9.5 Change-Id: I26f56e6905472a501ff487295da23b3bc3b5c77e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64877 Tested-by:Aimeos <aimeos@aimeos.org> Tested-by:
-
Richard Haeser authored
Removed the dependency on EXT:about by adding translations for the General Information widget to EXT:dashboard itself. Releases: master, 10.4 Resolves: #91399 Change-Id: I8b84e334e3aa814947722846ca73b799f9a1a19e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65038 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
Stephan Großberndt authored
This patch fixes the SQL query inserting index_rel records on PostgreSQL by making sure an integer instead of a float is inserted in the freq column (which is defined as smallint). Resolves: #91660 Releases: master, 10.4, 9.5 Change-Id: Id994bce0ca89105f03446c5fe13516774b0a16a0
-
- Jul 13, 2020
-
-
Martin Bless authored
Releases: master, 10.4 Resolves: #91791 Change-Id: Id26b4288a7e7eff902a3c31431635dcf0950b5da
-
- Jul 10, 2020
-
-
Andreas Fernandez authored
TYPO3 now ships a new module acting as wrapper for `sessionStorage`. It behaves similar to `localStorage`, except that the stored data is dropped after the browser session has ended. Resolves: #91738 Releases: master Change-Id: I221ac1ea7b8a8a24b8490d7ddf55b92775e37d81
-
- Jul 09, 2020
-
-
Helmut Hummel authored
When rendering child elements of a tabs, not only the rendered HTML is collected from these child elements, but also hidden fields HTML, assets and a lot more. Therefore it is crucial to merge the child results regardless of whether the "html" property is empty. Releases: master, 10.4, 9.5 Resolves: #91636 Relates: #89094 Change-Id: If169bd6486d3001466464462b29788b94fbb0943
-
Benni Mack authored
This change removes deprecated functionality: - ReferenceIndex->updateIndex() is now either ProgressListenerInterface or null - ExtensionManagementUtility->findService() expects an array as third argument - BasicFileUtility->setFileExtensionPermissions() removed - GeneralUtility->callUserFunction now expects object or null as third argument - DataMapper->__construct does not expect $query to be set anymore - ObjectAccess->setProperty - fourth argument removed Resolves: #91613 Related: #91473 Releases: master Change-Id: I39fa30f84201b0ed837f6ac0e6d27e1ddb15376d
-
- Jul 07, 2020
-
-
stiffes authored
The new RteHtmlParser->transformTextForPersistence() method expects a string value. Before this patch the given value was simply passed without checking its type or casting it. However, if "null" is handed in (by e.g. a translated record which expects null), null is now kept. Resolves: #91749 Releases: master, 10.4 Change-Id: I9db872ca73dcf2bbfc2ac2d0b67d45ca3ffd4c5e
-
Andreas Fernandez authored
Instead of generating the URL to the backend login, the URI of the current request is now used for the referrer check in backend login. This fixes a redirect issue with password recovery links opened via email. The anchor-based reload detection has been replaced with a localStorage-based solution as browsers don't trigger a new request if the target location is already loaded, but only an achor is appended to the URL. Resolves: #91442 Releases: master, 10.4, 9.5 Change-Id: I577bdd8ce75c94f864852f812c0b8ad66f0d5634
-
- Jun 30, 2020
-
-
Benjamin Franzke authored
FileReferences objects contain references to File objects which itself contain service dependencies (e.g. event dispatcher) which are not seralizable. This leads to problems for instance when having a multi-step form containing file uploads where file reference objects are being serialized. Resolves: #91196 Releases: master, 10.4 Change-Id: I7650186adc5c61528e1a1adcf06b8d6cf67a55cd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64841 Tested-by:
-
Christian Eßl authored
The doc comments for DataHandler::clear_cacheCmd() contained outdated information on how to clear the system caches. Resolves: #91720 Releases: master, 10.4 Change-Id: I42cb2aebecc7ef2eb45b0070e3fff19a199b9651 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64944 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Helmut Hummel authored
To allow uncached plugins to provide a different page title, page title providers must be also be called after uncached plugins are rendered. To not loose the state of page title providers that are called for cached entires, the state of page title providers is stored in cache as well and provided for the second title generation process after uncached objects are rendered. Resolves: #91233 Releases: master, 10.4, 9.5 Change-Id: I277551d9a58781c0d130c27b346bcbbc209266fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64934 Tested-by:
-
- Jun 29, 2020
-
-
Benni Mack authored
If a "fileExtension" is given in the Image Processing of FAL (e.g. via Fluid ViewHelper setting "fileExtension='png'"), then a SVG image is now converted to the target file extension as well. This might be important for various use cases when dealing with SVGs Resolves: #75191 Releases: master, 10.4 Change-Id: I82fd2e7cccf15f845a7624a8dc9135bb06eaf145 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63611 Tested-by:
-
Benjamin Franzke authored
Do not swap the global singleton instance, as that would only update new classes that are retrived though GeneralUtlity::makeInstance). Existing ones (cached in already initialized classes, or initialized via the symfony DI container would not be updated). Releases: master, 10.4 Resolves: #91316 Related: #87402 Related: #88179 Change-Id: Ibcd4ecd3418dd047861b83685a6664e391a8f66b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64419 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Andreas Fernandez authored
nprogress is used to indicate activity when a collapsed IRRE node is about to get loaded. In case of FlexForms the id attribute may contain a dot which is not an issue if handled correctly. However, nprogress doesn't treat this value as an id, but rather as a full CSS selector which causes issues and breaks loading the IRRE node. To work around this issue, the id of the container used to render the progress bar is now MD5 hashed. Resolves: #91585 Releases: master, 10.4 Change-Id: I893d0cf24ea0f384d9ffff4d84f83b0fa35341b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64783 Tested-by:
-
Oliver Klee authored
Some system extensions use functions like libxml_disable_entity_loader which are provided by ext-libxml. To make sure these methods are available, this PHP extension needs to be required. Used composer command: composer require ext-libxml:"*" Also add the extension as required in the install tool. Releases: master,10.4 Resolves: #91069 Change-Id: Ib98d4aba4a9071f48e2fb370382f61130115daad Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64204 Tested-by:
-
Benni Mack authored
When the userTSconfig options.defaultUserFolder = 1:/my-folder/ does not exist, Backend users now fall back to the first selected user folder. A test is added to show that the fallback to the default storage works. Resolves: #86815 Releases: master, 10.4 Change-Id: Ia88a9020adb4ba522e10e3a6059189500d9a407f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64552 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Andreas Fernandez authored
The JavaScript modules now utilize the native String.prototype.trim function to trim whitespaces off string where jQuery's trim was used before. Resolves: #91683 Releases: master, 10.4 Change-Id: I5c7a25e508e7e052339f2969a5725593e110a3a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64932 Tested-by:
-
- Jun 26, 2020
-
-
Daniel Goerz authored
Always loading the alias loader is required in order to allow extensions to provide class aliases in non Composer mode. Also update the class alias loader to latest version with: composer up typo3/class-alias-loader By doing so, we can remove the additional composer dumpautoload in test suite, which only was required because the alias loader update requires a two step operation. Resolves: #91692 Releases: master Change-Id: Ie70ae295d14a5a813e294ae22a4e1bf10c8f0a5d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64933 Tested-by:
-
- Jun 22, 2020
-
-
Benni Mack authored
The og:image and twitter:image meta tags are not resized. If an editor puts a 5000 pixel wide image in a field, it does not get resized, and if it is large enough (in size + MB) it doesn't get picked up everywhere. For this reason, we'll limit the image width to 2000 Resolves: #91687 Releases: master, 10.4 Change-Id: Iec7b185c37b3685f523a0debebf90dbc7025bbc6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64909 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
David Steeb <david.steeb@b13.com> Tested-by:
-
- Jun 21, 2020
-
-
Helmut Hummel authored
Currently \TYPO3\CMS\Core\Imaging\ImageManipulation\Area objects are serialized in processing configuration, therefore we must allow this class during unserializing the configuration. Resolves: #91675 Related: #91571 Releases: master, 10.4, 9.5 Change-Id: I8976754abed62e3c9a6205988176b5a1f0220e50 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64907 Tested-by:
-
- Jun 20, 2020
-
-
Andreas Fernandez authored
The JavaScript functions TBE_EDITOR.fieldChanged_fName` and its legacy alias `TBE_EDITOR_fieldChanged_fName` used to extract the table name, field name and uid from the incoming field name have been removed. As a drive-by bugfix, the undefined variables `TBE_EDITOR_setHiddenContent` and `TBE_EDITOR.setHiddenContent` have been removed as well. Resolves: #91578 Releases: master Change-Id: I528fde709367d5d474b846f347a3770d15b1a227 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64678 Tested-by:
-
Andreas Fernandez authored
Some modules have been rewritten to not use jQuery in the past. However, there was still a dependency due to missing `ready` handling. Since recent changes TYPO3 is capable of such handling and enables to remove jQuery completely from some modules. Resolves: #91598 Releases: master Change-Id: I23fa63f9090eee8abc49cd1993df27bec12d92e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64832 Tested-by:
-
- Jun 19, 2020
-
-
Benni Mack authored
The current workspace preview middleware runs at a point after the Page ID (and PageArguments) has been resolved by the URL already. This means a workspace preview with a preview user (and not a backend user) does not work, as the user is registered too late in the Middleware workflow. In order to restore the functionality, the preview user is now created BEFORE the PageResolver middleware, and does everything (incl. sending the preview cookie, which is now attached to the response, and not done during processing of the request). However, as the webmount of the current page ID needs to be registered, a second middleware is added which runs before TSFE->determineId() but after the PageResolver and PageArgumentValidator middlewares. Resolves: #91662 Releases: master, 10.4 Change-Id: Ic0108d2cd468f3ecf84e5a0e06c0fd5329046606 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64900 Tested-by:
-
- Jun 14, 2020
-
-
Daniel Siepmann authored
A wrong label was used when using "Fluid based page module". This resulted in "[]" instead of "[Hidden]" for records with hidden headline. This is fixed by using the proper label reference. Resolves: #91628 Releases: master, 10.4 Change-Id: I7749cbf4441335f8493eadbb9386d95835dff9a9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64850 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Jun 09, 2020
-
-
Oliver Hader authored
Overriding route requirements with `.+` allows to have slashes in route parameters. This is different to Symfony's default behavior not allowing slashes here at all. However, when having multiple route parameters it can lead to resolving false-positive routes like shown in the following example: routePath: '{first}/{second}' URI: https://example.com/first/second/third resolves to parameters + first: 'first/second' + second: 'third' This change passes existing TYPO3 route `requirements` and uses pattern `.+` only for those parameters not having a definition - both applies to parameters using `aspects` only. Besides that tests in `EnhancerLinkGeneratorTest` mixed internal argument values with URL parameters (`100` <=> `hundred`) are were "wrong" before. Resolves: #91246 Releases: master, 10.4, 9.5 Change-Id: Ic1fe15790cc16dd52c624cd3be9ed060ae9b9d69 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64654 Tested-by:Stephan Großberndt <stephan.grossberndt@typo3.org> Tested-by:
Manuel Selbach <manuel_selbach@yahoo.de> Reviewed-by:
-
- Jun 08, 2020
-
-
Simon Gilli authored
Setting up backend layouts with colPos not set will show the content of column 0 because of an excplicit cast of the colPos. This patch checks if colPos is set and if not skips the assignment of records. Resolves: #91176 Releases: master, 10.4 Change-Id: I75d9818c4330bb8a4d9a7a60130a547167a83e58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64305 Tested-by:
-
Oliver Hader authored
Direct hash comparison is replaced by cryptographic-safe `hash_equals`. Changes in this patch set basically don't have much impact regarding security aspects. This is a preparation for starting with RIPS scanner. Resolves: #91565 Releases: master, 10.4, 9.5 Change-Id: I5666e586b6b6b462f7864a597139763fd2cd2f98 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64668 Tested-by:
-
- Jun 07, 2020
-
-
Markus Klein authored
Use only the body and the content-type header of the internal sub-request. Everything else of the sub-request can be discarded. Resolves: #91582 Related: #81644 Releases: master, 10.4 Change-Id: I393acb340c04b3c7aa0cde1e1de1df9fcc92ca7a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64672 Tested-by:
Johannes Kasberger <johannes.kasberger@reelworx.at> Tested-by:
-
- Jun 05, 2020
-
-
Benni Mack authored
TypoScriptFrontendController has had functionality to dynamically load JavaScript and CSS code, also in non-cacheable (USER_INT) content. This has been largely superseded via the AssetCollector API and PageRenderer API which is built in a way to deal with non-cacheable and cacheable content with proper method calls. For this reason, the legacy functionality is removed: * TSFE->setJS (used via TSFE->setJS('openpic') in core) * TSFE->additionalJavaScript * TSFE->additionalCSS * TSFE->JSCode * TSFE->inlineJS Although all methods and properties have been marked as internal in TYPO3 v10, a Breaking RST is still added. Resolves: #91563 Releases: master Change-Id: I167dae29e3daa5e1d5ad4c6848dcc49fbfec3183 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64660 Tested-by: -
Benni Mack authored
In order to reduce the amount of accessing globals in the future, and especially TYPO3_REQUEST which was born because of missing structure of TYPO3 Core, the currrent request object is now handed in (optionally) to methods, to work directly with them in TSFE context. Resolves: #91568 Releases: master, 10.4 Change-Id: I760dbd70c9748d69c669bc6f65d65d20dd8ab530 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64662 Tested-by:
-
