- Oct 29, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92273 Change-Id: Ifb45f980a08efd79f5e3f288e0f20e1ac283e1f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65664 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
manuel_winkelhofer authored
To announce the buttons correctly when using assistive technologies there needs to be an aria-label, as there will not be a real label attached to the top bar buttons. Resolves: #92667 Releases: master Change-Id: I5cd6eae2da613ba87205835da4d1926b3076c6f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66320 Tested-by:
Michael Telgkamp <michael.telgkamp@mindscreen.de> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Georg Ringer authored
Remove the upper range from the TCA of the fields imagewidth and imageheight of tt_content. There is no reason to set it to a random number which might have been high 10 years ago. Resolves: #92659 Releases: master, 10.4 Change-Id: I3d7db5b67dbd3d523365eaca63d6c9e7a516c3b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66246 Tested-by:
-
Daniel Siepmann authored
The actual method name is format, not setFormat, that should be respected by changelog docs. Resolves: #92732 Releases: master, 10.4 Change-Id: Iaca271783da78440b973b7afcae41ba62bc1b561 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66352 Tested-by:
-
Alexander Schnitzler authored
JsonView did set content type headers in its render method which is a problem since the view should only be responsible for rendering the content of the to be returned response. The current approach, setting those headers in the action controller, is just a temporary solution until Extbase is capable of handling PSR-7 responses which then makes it superfluous to set headers magically. Instead people will need to set headers manually or use a JsonResponse object instead and let the core handle setting headers further down in the request/response handling stack. Releases: master Resolves: #92692 Change-Id: Idfa417cfd25d7f692dea2e6d6822f1d3a44cb38d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66078 Tested-by:
-
- Oct 28, 2020
-
-
Sybille Peters authored
Information for working with Linkvalidator as editor is added. Resolves: #92718 Releases: master Change-Id: I5c116c4561b91b2f8020f6803f6a1d50cd18a413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66275 Tested-by:
Chris Müller <typo3@krue.ml> Tested-by:
-
Chris Müller authored
With the release of v10.4 the changes of master were removed from the changelog. Now it is here again. Resolves: #92730 Releases: master Change-Id: I5a96dbfa3d62c426aba3b3033118bbe2f4379e52 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66331 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Georg Ringer authored
Always show the edit button so that users know this functionality. Additionally the element is transformed from an link to an actual button to be accessible for keyboard users. Resolves: #92658 Releases: master Change-Id: I50e4f0aa4d904843a9bd5e2e9fcc20c7f2a971e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66243 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Christian Kuhn authored
A couple of not needed assignments throughout the core and a 'too many arguments' fix. Resolves: #92605 Releases: master Change-Id: I883dc2fcc12c72c525bc7a44236cac8311d96f11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66182 Tested-by:
-
Christian Kuhn authored
This reverts commit e6bd4f02. Reason for revert: Firefox acts funny with missing autocomplete. Change-Id: If6ecdbacb4a1cd7f81464f820975dc1508e6564c Reverts: #92619 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66336 Tested-by:
-
Sybille Peters authored
Resolves: #92717 Releases: master Change-Id: Id6aee19c74ff3fe1765d0c2bb9caa91a4d425648 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66267 Tested-by:
-
Mark Leutl authored
This merge request removes the autocomplete attribute of the login button. Resolves: #92619 Releases: master, 10.4 Change-Id: I6a2ba3e82c87f261fa7415f7124c70b657e7d3a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66317 Tested-by:
-
manuel_winkelhofer authored
To clarify the purpose of the link, change the text from "click for details" to "details about licences" Resolves: #92630 Releases: master Change-Id: Ibd44a4737bcd589d2a7f80be91e83ee53da6add1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66313 Tested-by:
-
Tymoteusz Motylewski authored
The BE user aspect is correctly initialized since TestingFramework 6.4.6 So the initailization can be removed from the test. Resolves: #92574 Releases: master, 10.4 Change-Id: I78f101338c84931bef57e7cf63fdb15a8373def3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66150 Tested-by:
-
Sybille Peters authored
The chapter "Next Steps" contained very little information. Resolves: #92719 Releases: master Change-Id: I2cacf4081c47bbb35f4e89239dfc9ae0b78253db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66268 Tested-by:
-
Sybille Peters authored
Resolves: #92716 Releases: master, 10.4, 9.5 Change-Id: I0ad629f08cac11fbbffc2d61e9c4c8d7b2de7a23 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66264 Tested-by:
-
Oliver Bartsch authored
The CleanerTaskTest creates a DateInterval and formats it to return the day representation of the difference. Therefore, the `%d` format character was used. Because `%d` does only output the number of days not already covered by the month, the test now failed. The `%a` format character is now used as it will always output the total number of days. Resolves: #92727 Releases: master, 10.4 Change-Id: I2e7dd9af41b54f5e5dbaea39eaaac1724fd29982 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66328 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Oct 27, 2020
-
-
Alexander Schnitzler authored
This patch introduces a couple of changes to the extbase request creation and handling process. The request builder is used during bootstrap to create an extbase request object. This enables building the extbase request from the incoming server request in the future without passing the server request through a layer of services. Further, it enables a more sensible API for the request handlers whose methods canHandleRequest() and handleRequest() did not receive the extbase request as arguments for evaluation in the past. The idea is to have the extbase request and an attached context object as single source of truth regarding request data and avoid storing that data elsewhere or accessing it through services during runtime. Releases: master Resolves: #92703 Change-Id: I6c9c3fd32e1af32ef3f73aa12073d34c8a63a43d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66281 Tested-by:
-
Benjamin Franzke authored
The remotes are not lazy loaded, therefore there is no need to inject the container instance into RemoteRegistry. We can pass the remote instances directly into the registerRemote method, that has the slight benefit of avoiding roundtrips and the symfony service defintions can be inlined/optimized (the remote instances are created withing the generated RemoteRegistry factory). Resolves: #92722 Related: #92457 Releases: master Change-Id: Ie8e52a5d48d2d1614d8f554f0854408cc11ec17d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66324 Tested-by:
-
Benni Mack authored
When the Admin Panel is activated, TSFE should not override the frontendpreview aspect by default, as the preview settings will never work otherwise. Resolves: #92713 Releases: master, 10.4 Change-Id: I070fe49d5196f1ae2e8cc9feed3d16926f5d9728 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66314 Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
-
- Oct 26, 2020
-
-
Jonas Eberle authored
The event was split up into 2 events in https://review.typo3.org/c/Packages/TYPO3.CMS/+/64021/17 yet the example in the changelog was forgotten. Resolves: #92702 Releases: master, 10.4 Change-Id: I2ab04d38745bb20cfcf7dd07c44ec63ccb1cf9d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66280 Tested-by:
-
- Oct 25, 2020
-
-
Frank Naegler authored
This patch prevents double escaping of the src attribute by unescaping the value before handover to the AssetCollector->addJavaScript() function. Resolves: #92284 Releases: master, 10.4 Change-Id: Ia9bb22e176f8a58a8bba642599546d13aa4855d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65700 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Christian Kuhn authored
A couple of foreign_table_where TCA fields for l10n_parent do not allow setting a localized element to a different parent element located on the same page. Solution is to use the same foreign_table_where strategy as used with other tables like tt_content. Note this is only visible for sys_category since the two fal related tables do not show that field at all. Those two are still changed to streamline core code and to not deliver broken examples. Change-Id: I449ba949b555efa04138da054d6cca9a4d52372b Resolves: #69906 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66221 Tested-by:
-
Oliver Bartsch authored
Since some TCA columns like `hidden` use the `invertStateDisplay` option for display in FormEngine nowadays, the corresponding CSH labels are now adjusted to reflect this behaviour. Resolves: #92603 Releases: master, 10.4 Change-Id: I05bb667930906232947a2ebb4f1995e795e39110 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66212 Tested-by:
-
Oliver Bartsch authored
The paste content buttons now have the type "button" set to not falsely behave as submit buttons, which is the default if no type is defined. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#attr-type Note: In this case the regular submit event is prevented by JavaScript which leads to no actual functional change here. Resolves: #92668 Relates: #92653 Releases: master, 10.4 Change-Id: I22f80778eab02b9c9ada9177ae5f72cfca2f55ff Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66248 Tested-by:
-
- Oct 23, 2020
-
-
Oliver Bartsch authored
A <button> tag is now being used instead of an <a> tag as collapsing / expanding the tables is an interaction on the same page rather than opening a new one (<a> tag had empty `href` attribute). The button now also provides a proper aria-label with a descriptive text and gets the aria-expandend state initially set. Furthermore the button now uses common styling to be directly recognized as such. Resolves: #92657 Releases: master Change-Id: I7d98720f49b549bd74af1632c1fdd9fb9accbdba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66244 Tested-by:
Jens Ulrich <jens.ulrich@snk.de> Tested-by:
-
Sybille Peters authored
The Introduction page is updated to reflect current master. The text are changed in a way that they also apply for previous versions 10 and 9. Screenshots are replaced. Resolves: #92691 Releases: master, 10.4, 9.5 Change-Id: I9eb633f5446dc08636f97548920a6419b1fe8359 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66263 Tested-by:
-
Alexander Schnitzler authored
This patch introduces a proper request/response handling chain. That means, that Extbase no longer creates a response object early, passes it through the request handler and dispatcher into the controller and expects it to be altered there. Instead, request handlers, the dispatcher and controllers only get passed a request object and controllers are then responsible for creating and returning a response. This change is preparatory work for the introduction of PSR-7 responses in Extbase. Those responses are immutable and can no longer passed by reference through the stack. Instead, the controller must return the desired response along with its state down the stack while remaining unaltered. This patch is considered breaking because it changes several method signatures of public classes and interfaces. Still, it is quite unlikely to be struck by this change when using the public api of Extbase and not overriding classes such as the ActionController. Releases: master Resolves: #92513 Change-Id: I3ab7846268ea68727a2f57eea69328b85be4f5e6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66079 Tested-by:
-
Georg Ringer authored
- Provide a page title - Replace nowrap attribute with the nowrap class Resolves: #92676 Releases: master Change-Id: I31cb551a5807a1eea5ab3f1899d62419494c0c6b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66251 Tested-by:
Josef Glatz <josefglatz@gmail.com> Reviewed-by:
-
- Oct 22, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92580 Change-Id: Iab991450493b13d524f4429d51a71958ad62a0e0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66159 Tested-by:
-
Oliver Bartsch authored
The fluid based page module tried to return a "unique id" for each "create content element" button using the `getUniqueId` method. This id however was not unique as it was stored as class property after the first creation. This lead to all buttons got the same ID which is according to the spec https://html.spec.whatwg.org/multipage/dom.html#the-id-attribute not allowed. Therefore the `getUniqueId()` method now returns a new "unique id" on each call. Resolves: #92629 Releases: master, 10.4 Change-Id: Ie3724423e91eb11a6caf5933c651d34691da477b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66220 Reviewed-by:
-
Georg Ringer authored
Use the same viewport configuration as the core and as the Install Tool is not yet translated, the language can be hardcoded to english. Resolves: #92672 Releases: master Change-Id: I9aa557108dba98943710bcf2d24fede9326d09af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66249 Tested-by:
-
Benni Mack authored
The RedirectService should have a ServerRequestInterface object that can properly set up TSFE when linking to pages. Resolves: #92666 Releases: master Change-Id: I39fddb224396410bfc0bffb229ea16eaeef5adeb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66140 Tested-by:
-
Benni Mack authored
This is a pre-patch as a cleanup to extract the file system related functionality and the "zip file" related functionality in separate classes, to remove further cross-dependencies between PHP classes in Extension Manager code. Resolves: #92669 Releases: master Change-Id: I55710f4d4354b1ea239738d219ca778e74306396 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66189 Tested-by:
-
Christian Kuhn authored
* Merge import .csv files and rename file to "ImportDefault.csv" * Extend assert .csv files to contain all tables in the same order as the import files. This allows to easily diff the before/after files and to get a have overview if viewing them side-by-side. Additionally, this shows unwanted side effects from patches more easily. Change-Id: I9a5c37de4492d34903f9bda1b398884e6f6ac7e4 Resolves: #92677 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66245 Tested-by:
-
Georg Ringer authored
The marker ###POSTJSMARKER### is not replaced anymore and can be removed. Resolves: #92673 Releases: master Change-Id: Iddc2d7c0ee9d0c36383c179143f06e7440e2e67d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66250 Tested-by:
-
Danilo Caccialanza authored
Consider the case you have N workspaces and some BE "advanced users" and "limited users” having access to a workspace. "Advanced users" have access to all workspace’s page tree and also LIVE workspace, in this case everything works correctly. "Limited users" have access only to a limited page tree of the workspace and cannot access to LIVE workspace. When the user logs in, the page tree doesn’t show up and the system indicate the following error: "Page tree error Got unexpected response from the server. Please check logs for details" This patch fixes the "limited user" problem. Resolves: #91918 Resolves: #91594 Releases: master, 10.4 Change-Id: I0029add1940504ad1d274eac4ab02ff2af69f96d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65755 Tested-by:
Danilo Caccialanza <supercaccia@bluewin.ch> Tested-by:
cbugada <christian.bugada@ti.ch> Tested-by:
-
Oliver Hader authored
Using view helper `f:form.select.optgroup` with argument `disabled` throws PHP type error, since array is expected, but string given. Resolves: #92656 Releases: master, 10.4, 9.5 Change-Id: I7f1fd3a1f81c7befb15e4657c9e59ff862e663e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66242 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Markus Klein authored
With #86219 the migration from sys_domain records to Sites was faulty. Formerly all known domain records were inspected in order to decide whether a domain was local or not. This was changed to an invalid check covering the current site only. This change now again validates all known sites. Resolves: #92626 Related: #86219 Releases: master, 10.4, 9.5 Change-Id: I2ce4dc0e8891ee2b438c42d20fff10428fafa7e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66227 Tested-by:
Helmut Hummel <typo3@helhum.io> Tested-by:
-
Georg Ringer authored
The attribute alt is not allowed for the element "textarea". Resolves: #92633 Releases: master, 10.4 Change-Id: I70790e529a270300f73d3b22cb598e2d8197e07c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66225 Tested-by:
-
