[TASK] Create TER remote instances in symfony service factory

The remotes are not lazy loaded, therefore there is no need to
inject the container instance into RemoteRegistry.

We can pass the remote instances directly into the
registerRemote method, that has the slight benefit
of avoiding roundtrips and the symfony service defintions
can be inlined/optimized (the remote instances are
created withing the generated RemoteRegistry factory).

Resolves: #92722
Related: #92457
Releases: master
Change-Id: Ie8e52a5d48d2d1614d8f554f0854408cc11ec17d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66324


Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Oliver Bartsch <bo@cedev.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Bartsch <bo@cedev.de>
Reviewed-by: Benni Mack <benni@typo3.org>

typo3/sysext/extensionmanager/Classes/DependencyInjection/ExtensionRemotePass.php

@@ -39,7 +39,6 @@ final class ExtensionRemotePass implements CompilerPassInterface
 
         foreach ($container->findTaggedServiceIds($this->tagName) as $id => $tags) {
             $definition = $container->findDefinition($id);
-            $definition->setPublic(true);
             $configuration = [];
 
             foreach ($tags as $attributes) {
@@ -47,7 +46,7 @@ final class ExtensionRemotePass implements CompilerPassInterface
                 $configuration['enabled'] = (bool)($attributes['enabled'] ?? true);
             }
 
-            $remoteRegistryDefinition->addMethodCall('registerRemote', [$id, $configuration]);
+            $remoteRegistryDefinition->addMethodCall('registerRemote', [$definition, $configuration]);
         }
     }
 }

typo3/sysext/extensionmanager/Classes/Remote/RemoteRegistry.php

@@ -17,9 +17,6 @@ declare(strict_types=1);
 
 namespace TYPO3\CMS\Extensionmanager\Remote;
 
-use Psr\Container\ContainerInterface;
-use TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException;
-
 /**
  * Registry of remote connectors.
  *
@@ -27,11 +24,6 @@ use TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException;
  */
 class RemoteRegistry
 {
-    /**
-     * @var ContainerInterface
-     */
-    protected $container;
-
     /**
      * @var ExtensionDownloaderRemoteInterface[]
      */
@@ -42,22 +34,8 @@ class RemoteRegistry
      */
     protected $defaultRemote;
 
-    public function __construct(ContainerInterface $container)
-    {
-        $this->container = $container;
-    }
-
-    public function registerRemote(string $id, array $configuration): void
+    public function registerRemote(ExtensionDownloaderRemoteInterface $remote, array $configuration): void
     {
-        $remote = $this->container->get($id);
-
-        if (!$remote instanceof ExtensionDownloaderRemoteInterface) {
-            throw new ExtensionManagerException(
-                'Extension remote ' . $id . ' must implement ' . ExtensionDownloaderRemoteInterface::class,
-                1602173538
-            );
-        }
-
         $identifier = $remote->getIdentifier();
 
         $this->remotes[$identifier] = array_merge(