- Sep 12, 2023
-
-
Benni Mack authored
Change-Id: If8efb77fb623053c3e5419d4299caed01deb8a37 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80976 Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
core-ci <typo3@b13.com>
-
Benni Mack authored
Change-Id: I05e25a742ad281c630178b5861dda7071f6dad8f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80975 Tested-by:
-
- Sep 10, 2023
-
-
Oliver Wand authored
When performing `Build/Scripts/runTests.sh -s cglGit` with latest cs fixer version a rule dependency error is thrown. This patch exchanges the deprecation with the current recommended rule. Used command(s): > composer require --dev \ "friendsofphp/php-cs-fixer":"^3.26.1" > Build/Scripts/runTests.sh -s cgl Resolves: #101888 Releases: main, 11.5, 12.4 Change-Id: Ie139ef841c92461e116732923991c6474e888a5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80937 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
- Sep 08, 2023
-
-
André Buchmann authored
When the parent record has been set to sys_language_uid=-1, but the child record has translations, it should be displayed in the correct language. Setting the languageUid for the querySettings to -1 results in display of the default language record of the child. Resolves: #92768 Releases: main, 12.4, 11.5 Change-Id: I25bcdbb182c1b35cbc08e5f91339453b0986cdcc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80929 Tested-by:
Stefan Bürk <stefan@buerk.tech> Reviewed-by:
-
Friedemann Altrock authored
ContentObjectRenderer::getImgResource is used for the content objects IMAGE, IMG_RESOURCE, as well as GIFBUILDER to process images. When it is passed a FileReference object, it should respect the crop settings of this reference, same as when it is passed a reference UID plus the treatIdAsReference config. Resolves: #101810 Releases: main, 12.4, 11.5 Change-Id: I399106399ec283561c00fa5cf61d6c7fe2871e49 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80928 Tested-by:
-
Helmut Hummel authored
When a junction already exists on Windows, it is tried to create a symlink, because of a missing OS check. While this works as errors are ignored, it is an unnecessary filesystem call. Therefore the code is changed to only emit the appropriate filesystem operations per OS. Resolves: #101871 Related: #98434 Related: #98447 Releases: main, 12.4, 11.5 Change-Id: Ifafadceae3742da23fd1a40e5aab50074e60313c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80924 Reviewed-by:
Benjamin Franzke <ben@bnf.dev> Tested-by:
-
Benni Mack authored
When an oembed provider does not send an "author_name" property, then the request fails, and there is a sys_file without a sys_file_metadata. This then results that the show info popup does not work. Resolves: #101877 Releases: main, 12.4, 11.5 Change-Id: If6ead0084664372b9133fdd544ede90aa8a0e5d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80926 Tested-by:
-
Helmut Hummel authored
Only create one filesystem object, instead of always creating new ones where needed. Resolves: #101870 Releases: main, 12.4, 11.5 Change-Id: I56a47f412fded7585425098f18f1d7090baf09d1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80923 Tested-by:
-
- Sep 07, 2023
-
-
Nikita Hovratov authored
Accessing static properties as non-static has always triggered a notice in PHP. However, since PHP 8.0 accessing undefined properties (which always comes with the former notice) is now a warning. This will be caught by the error handler in debug mode. To fix this, the more robust _getProperty method is backported from #100120 and used in the _isDirty method. Resolves: #101488 Related: #100120 Releases: 11.5 Change-Id: I5f9ccb411f02f0dcc164d0d14917ecd631dc1178 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80280 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
-
Benjamin Franzke authored
The module components (like the iframe wrapper) are created asynchronously after their implementing module (e.g. <typo3-iframe-module>) is loaded. The router had a preparatory check that verified that existing module elements are reused, but missed to verifiy whether the element has been created in parallel while the module components javascript module was loaded. This happens when the module changes while the module component is loaded for the first time. That leads to a situation that the module componenent was created twice, which rendered two module frames into the backend. Also resolve a long overdue todo while at it. Resolves: #101851 Releases: main, 12.4, 11.5 Change-Id: I069f9e924d38b3abeb70c6d4e805d9c43a4f05e9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80912 Tested-by:
-
Georg Ringer authored
Check if a field exists before accessing it. Resolves: #101852 Releases: main, 12.4, 11.5 Change-Id: I95d227d920975b1e348c95a1069a9ddddcddc900 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80851 Tested-by:
-
Benjamin Franzke authored
With the deprecation removal of regular expressions based EXT:form validators in #101070, the set of available validators for the form element type URL became empty. (See EXT:form/Configuration/Yaml/FormElements/Url.yaml) Instead of only removing the select element from the DOM, the entire form-group is now removed, in order to also hide the corresponding <label> tag, as such a stray label tag isn't helpful for an enduser and is therefore actually even invalid HTML (as the reference to an input element is missing). Resolves: #101749 Related: #101070 Releases: main, 12.4, 11.5 Change-Id: Ib0d34e94e2c3ba109133dac64374f04f7c91329b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80734 Tested-by:
-
- Sep 06, 2023
-
-
Stefan Bürk authored
With #101739 a bug has been reported, which is not correct. This change adds functional tests to `ext:redirects` to show and cover that: * regexp redirects with a pattern not covering params but query arguments are given in the request uri and "Respect GET Parameters" has been set do not redirect. * RegExp Redirects with a pattern not covering params and no GET arguments are given in the request uri but "Respect GET Parameters" has been set redirects to the target url. Resolves: #101739 Releases: main, 12.4, 11.5 Change-Id: I023889ba6fefe5a4b06b392e02dece4b6ac517c0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80886 Tested-by:
-
Stefan Bürk authored
Avoid native PHP warnings in FrontendBackendUserAuthentication because of invalid array key access. The places are now guarded using null coalescing operator with a suitable fallback value. Resolves: #101848 Resolves: #101847 Releases: main, 12.4, 11.5 Change-Id: Iaf747172b6ac04b9d2bdbf60519346ef7e3b3f2f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80845 Tested-by:
-
- Sep 05, 2023
-
-
Benjamin Kott authored
We also ensure that TYPO3.lang checks are correct when the modal is used in a context where TYPO3.lang is not defined. Resolves: #101844 Releases: main, 12.4, 11.5 Change-Id: I1e6e90ed86e72f483929429b8e2c833179b60f87 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80868 Tested-by:
-
Chris Müller authored
Twitter made the CSS framework Open Source in 2011, since then it is called only "Bootstrap". Resolves: #101840 Releases: main, 12.4, 11.5 Change-Id: I05c7d9ce3a197cb61058a5582918935d6720e371 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80839 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Sep 03, 2023
-
-
Markus Klein authored
This supplements the other viewhelpers already equipped with this attribute. Resolves: #101775 Releases: main, 12.4, 11.5 Change-Id: Iadcdb1de591d9d9e56722623cacd1a5cf8fbe0af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80827 Tested-by:
-
- Sep 01, 2023
-
-
Friedemann Altrock authored
Only add implicit default paths (Resources/Private/X) when they are not explicitly configured via TypoScript, as they may have been configured as an overwrite for another base path. Resolves: #81099 Releases: main, 12.4, 11.5 Change-Id: I0fe4cb690aa253d5d9941fcfbe0a9c9063298547 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80835 Tested-by:
-
Friedemann Altrock authored
Before this fix, only the first RTE processing configuration would be taken into account when deciding which tags to keep in an HTML snippet. RteHtmlParser is a DI service and as such is treated as a singleton. Using multiple RTE processing configurations with potentially different sets of allowed tags should work as expected. Resolves: #101190 Releases: main, 12.4, 11.5 Change-Id: Ib0227872b542f53b30a16494aa2f979b8f601e07 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80833 Reviewed-by:
-
- Aug 31, 2023
-
-
Stefan Bürk authored
FormEngine sends some information as payload with the suggest wizard ajax request to the `SuggestWizardController` as context. The controller loads the record based on the tableName and the uid to determine the recordType to read the correct TCA field configuration, respecting special overrides like `columnsOverrides`. If a new record is created, there is no record uid available and passed to the controller. Therefore, the recordType is not properly determined. That leads to wrong record suggestions, if for example the `allowed` record table is overriden for specific recordTypes. This change adds the recordTypeValue as additional html data attribute to the suggest search field, reads and sends it along with the context payload in the ajax request to the suggest wizard controller, which now uses the passed value while keeping the record retrievement as fallback for now. Suggest records are now directly searched correctly respecting the full TCA configuration for the type, even for new records. Additionally, uid is send as null instead of the string "NaN". Used command(s): > Build/Scripts/runTests.sh -s buildJavascript Resolves: #101796 Releases: main, 12.4, 11.5 Change-Id: I3b814d37b7d4d3e9674ad6f2af882520c4f91413 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80798 Tested-by:
-
Achim Fritz authored
BackendUtility has a couple of strtotime() calls that may end up as strtotime(null). This emits a PHP E_DEPRECATED error since PHP 8.1. Add a cast. Resolves: #101811 Resolves: #101805 Releases: main, 12.4, 11.5 Change-Id: I5cca1b2fd3bc0d6792f6d61a59bdbc5b4850d15d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80796 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
- Aug 30, 2023
-
-
Oliver Hader authored
DataMapProcessor tries to access `$possibleChainedIds[0]` which might not be defined, since that array is the result of a previous `array_intersect` invokation, which keeps the array keys of the original input array. DataHandler tries to access `$this->copyMappingArray[$table][$uid]`, which might not be defined in case the previous copy command could not be executed (e.g. since the record was deleted already). Resolves: #101748 Releases: main, 12.4, 11.5 Change-Id: Ibcbc412c7df62ce17dfa2c0f6fc120ccebb953d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80669 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Robert Kärner authored
This patch fixes two issues when generating symlinks to the public extension resources (Public/Resources) into the _assets folder during Composer installation. First, directory symlinks can't be created the same way on Windows as on Unix platforms. The creation requires elevated rights, and the required command is named differently as well. Junctions should be used on Windows instead, because they do not need elevated privileges to be created. When installing a TYPO3 extension via Composer, its Resources/Public folder is getting symlinked to the publicly accessible _assets folder. Until now, this process only used the Unix specific functions provided by Composer. It did not create any symlinks on Windows based installations, without generating any error message. This patch adds the same checks and platform-specific functions used by Composer when symlinking packages from a local path repository. The second issue that has been addressed is the naming of the symlinks themselves. When a Resources/Public directory is symlinked into the _assets folder, the symlink will be named using an md5 hash based on parts of the extension's installation path on the filesystem. During Composer installation, this relative path is derived from the absolute path provided by Composer. As Windows uses a different default path separator (backslash) compared to Unix (forward slash), the relative path will be different between both platforms, resulting in a different md5 hash being generated. Absolute path on Unix: /path/to/typo3/vendor/mycompany/myext Absolute path on Windows: C:\path\to\typo3\vendor/mycompany/myext Relative path to be used for the hash on Unix: /vendor/mycompany/myext Relative path to be used for the hash on Windows: \vendor/mycompany/myext If an uri into the _assets folder is to be generated in either frontend or backend, the md5 hash will be always be generated by using forward slashes, resulting in incorrect links on Windows installations. This difference has been solved by replacing all backslashes in the absolute extension installation path into forward slashes on Windows installations, so the symlink will be named correctly from the beginning. Resolves: #98434 Resolves: #98447 Releases: main, 12.4, 11.5 Change-Id: I221eb538312302a7af4f7c3010c9982922f1c6ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80753 Reviewed-by:
-
- Aug 29, 2023
-
-
Benjamin Franzke authored
…of a new form element, that has not yet been persisted. Tabbing through an elemenet is considered an "input" by the browser, which is why the "input" even is triggered. The result is an empty input element (as before), but an intent is made to delete the underlying property from the form element object model. When the object model is empty (remeber, it is a new element), and an input field refers to a nested property (e.g. properties.fluidAdditionalAttributes.placeholder) removing an element (e.g. 'placeholder') will fail when the parent has not yet been set (e.g. properties.fluidAdditionalAttributes) Resolves: #101750 Releases: main, 12.4, 11.5 Change-Id: I49a9ead343e671c3d0289bd6d969316b888d05eb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80733 Tested-by:
-
- Aug 28, 2023
-
-
Oliver Klee authored
This fixes an issue in the acceptance tests where `null` is passed to `GeneralUtility::xml2array()` (which expects a `string`). Having an early check for an empty string also avoids pointless XML parsing (which should help performance a bit). Resolves: #101757 Releases: main, 12.4, 11.5 Change-Id: Ifc4406536c273baca9acdda7a0af7a91594f57bf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80680 Tested-by:
-
- Aug 23, 2023
-
-
Andreas Fernandez authored
When a backend user is created via the Install Tool, a notification is rendered to tell the system maintainer that the action was successful. However, the original patch mixed up the title and the message, which is now fixed. Resolves: #101741 Related: #91461 Releases: main, 12.4, 11.5 Change-Id: Ie25efa0476a118cfaa99a54d3cb4fe27ca5ef8e7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80676 Tested-by:
-
Andreas Fernandez authored
This patch makes use of `PathUtility::getAbsoluteWebPath()` in EXT:indexed_search's SearchController which is suitable for calculating asset paths in both, Composer and non-Composer scenarios. Resolves: #101727 Releases: main, 12.4, 11.5 Change-Id: I88f487b1fdf88b404fc51a3d5d6131dba5483cdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80674 Reviewed-by:
-
Dominic Petit authored
Allow to save a phone link with a comma or a semicolon. Resolves: #101721 Releases: main, 12.4, 11.5 Change-Id: I54e19fbfb2b1b184db4454a19728f08e70cddc4a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80655 Reviewed-by:
-
Sybille Peters authored
If there is not a newline before and after the list, the list may not be formatted correctly. A newline was added before and after lists in .rst files. Additionally, some lines beginning with "- " (which would result in false positives when checking) were modified so that list checking can be performed more easily in the future. Lists can be checked for example by using the following regular expressions: find typo3/sysext/*/Documentation -name "*.rst" | while read i;do grep -B1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" grep -A1 -H -E "^(\-|\*)\s" "$i" | grep "\.rst-" \ | grep -v -E "\.rst-($|\-|\*|\s)" done https://docs.typo3.org/m/typo3/docs-how-to-document/main/en-us/ \ WritingReST/CommonPitfalls/Lists.html Resolves: #101715 Releases: main, 12.4, 11.5 Change-Id: I8dca5634ae3dcd7e702197cb72b43d79a05f3f5c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80652 Reviewed-by:
-
- Aug 22, 2023
-
-
Timo Gurr authored
On recent MariaDB versions >= 10.6 utf8 is an alias for utf8mb3 while until MariaDB 10.5 utf8mb3 was an alias for utf8. https://mariadb.com/kb/en/unicode/ Resolves: #101719 Releases: main, 12.4, 11.5 Change-Id: Ida8a5b89fd99f9ff196d496ddb34d55c9657daf5 Reviewed-by:
Timo Gurr <timo.gurr@gmail.com> Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80616 Tested-by:
-
- Aug 18, 2023
-
-
Simon Gilli authored
see https://github.com/TYPO3/html-sanitizer/releases/tag/v2.1.3 composer req typo3/html-sanitizer:^2.1.3 composer req typo3/html-sanitizer:^2.1.3 \ -d typo3/sysext/core --no-update Resolves: #101705 Releases: main, 12.4, 11.5 Change-Id: I3e3152663b7b7804b01c8cd9b28393132efab628 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80592 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
- Aug 16, 2023
-
-
Andreas Fernandez authored
Google Chrome (and other browser vendors will probably follow) deprecates the unload event with Chrome 117 [1] and encourages using the Page Lifecycle API [2] instead. This patch replaces any usage of the `unload` event with the `pagehide` event that is available for all supported browsers [3]. [1] https://developer.chrome.com/en/blog/deprecating-unload/ [2] https://developer.chrome.com/blog/page-lifecycle-api/ [3] https://caniuse.com/mdn-api_window_pagehide_event Resolves: #101662 Releases: main, 12.4, 11.5 Change-Id: I675b180e855d8fb1070a84f5ba865e9250b2c0aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80560 Reviewed-by:
-
- Aug 15, 2023
-
-
Thomas Hohn authored
Fix undefined array key 0 in `InlineRecordContainer` by adding a null coalescing operator and handling `$uid` properly. Resolves: #101682 Releases: 11.5 Change-Id: I510c4af4dacfd9b1fb8110bf43b192c87918450f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80548 Reviewed-by:
J�rg B�sche <typo3@joergboesche.de> Tested-by:
-
- Aug 14, 2023
-
-
Thomas Hohn authored
Fix undefined array key "pages" in FileContentParser by adding a null coalescing operator. Resolves: #101450 Releases: main, 12.4, 11.5 Change-Id: Idc3bba5d5ab5516689925fadec86e6fac5978e73 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80544 Tested-by:
-
- Aug 09, 2023
-
-
Ernesto Baschny authored
In case you add a new TCA field of type "slug" in the pages table but without a config "eval", you get an exception in the backend. Resolves: #101640 Related: #93640 Releases: main, 12.4, 11.5 Change-Id: Ia9fc65707c581c288101eb9d54957aa9d025b98a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80496 Tested-by:
-
- Aug 08, 2023
-
-
Stephan Bauer authored
Releases: main, 12.4, 11.5 Resolves: #101620 Change-Id: I18563030fd382331a1389c500f313e28383901d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80474 Tested-by:
-
Benjamin Franzke authored
New runTests.sh option "-g" opens a tab in a local browser pointing to http://localhost:7900/?autoconnect=1. This allows watching acceptance tests clicking around. Releases: main, 12.4, 11.5 Resolves: #101611 Change-Id: I53cbb861d7df6daac96dfcc382183f46847d7894 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80368 Tested-by:
-
Daniel Hettler authored
The URL param '_stg_debug' is needed to call the debug mode on-site Resolves: #101613 Releases: main, 11.5, 12.4 Change-Id: Iff94ede5c3d388fe8b130e10e5b48658511a0bc3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80473 Tested-by:
-
- Aug 07, 2023
-
-
Thomas Hohn authored
Moved assignment of $destPid = $sortInfo['pid'] after check if $sortInfo is an array, since the method call to getSortNumber can return other values than an array. Resolves: #101606 Releases: main, 12.4, 11.5 Change-Id: I3cfef35b351a0cd1fa8197702cce9e3b05871fcf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80430 Tested-by:
-
Thomas Hohn authored
Added a null coalescing operator when assigning value to $editUid. Resolves: #101602 Releases: 11.5 Change-Id: Ie19fa72032c57c824322a319deafc441fdb9319e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80427 Tested-by:
-
