- Oct 26, 2021
-
-
Kim Christiansen authored
.stylelintrc is a json-like config and needs to quote keys. Releases: master Resolves: #95785 Change-Id: I626e956af5ffa70f664764fd746c102c73e740be Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71980 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Florian Sommer authored
The function fputcsv gets an enclosure as third parameter. Providing an empty string as enclosure leads to following warning: fputcsv(): enclosure must be a character To prevent this, the header line should also be surrounded by quotation marks. Resolves: #95734 Releases: master, 10.4 Change-Id: I39e550d1dd4b185845984a6d7fddd73fa143374b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71939 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Torben Hansen <derhansen@gmail.com> Reviewed-by:
-
Christian Kuhn authored
Table sys_file_processedfile field configuration is a blob. It usually contains a serialized array with processing information, but can be null due to the nature of blob. unserialize(null) emits an E_DEPRECATED error with PHP 8.1. ProcessedFileTest stumbles here, we however don't fix that in the test, but in the code to deal with the fact that this table field might be null in DB for whatever reasons. Resolves: #95790 Releases: master Change-Id: I961f042088347ade2689fb2c085543373d1104f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71986 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Christian Kuhn authored
That's a seldom gem. Method convNumEntityToByteValue() in DataHandler is *seriously* strange. It exists since very early TYPO3 claiming to fix a "very rare" MSIE bug. It *tries* to convert the "{" of a string like "foo{bar" to an ascii char ("{") and does this with a weird logic that includes a microtime(). Testing this thing locally reveals the method returns different results per execution! The patch drops that @internal method and it's caller. Change-Id: If9da47cc39d7c811b80879a4b532af90e9ea6f20 Resolves: #95789 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71985 Tested-by:Benni Mack <benni@typo3.org> Reviewed-by:
-
Stefan Bürk authored
PageRender sanitizes array values in two methods, using array walk with trim(). These values can be other types then string, which trigger deprecation warning in PHP 8.1. This patch change the array walk to an closure to have an explicit type cast to string for passing the value to trim(). Additional a return type ': string' is added to the protected method getTemplate(), as this method always returns a string. Resolves: #95788 Releases: master Change-Id: Id0cdef928f977fdc1a9d476475bd3a44c5783922 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71984 Tested-by:
-
Christian Kuhn authored
Various functions expect string arguments and emit E_DEPRECATED with PHP 8.1 in non strict_types=1 calls. The patch adjusts some null coalescence fallbacks from null to string to satisfy this. Resolves: #95787 Releases: master Change-Id: Ie1b28bc285c33af3509d18eaeb7d0b6013284434 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71983 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Florian Rival authored
The assumption for FilePathSanitizer::sanitize is to return file names relative to the public directory of TYPO3. Therefore, when making a given absolute file path relative with PathUtility::getPublicResourceWebPath, we must ensure to set the second argument to false to avoid adding the current site path to the relative path, but just directly return the relative path. This bug was not covered by the test, because on CLI this API NEVER appends the current site path. Therefore the test is now adapted to simulate a frontend web request. Also streamline usage of Environment API in tests to clarify intent. Releases: master Resolves: #95644 Change-Id: I20e7e6f434e4b4ca47aca35c79ec20e659fd7114 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71804 Tested-by:
Simon Gilli <typo3@gilbertsoft.org> Tested-by:
physikbuddha <r.kaerner@oranto.de> Tested-by:
Helmut Hummel <typo3@helhum.io> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #95778 Releases: master Change-Id: I764dc299cb192e4ebbcb00b21553f474355c55cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71976 Tested-by:
-
Christian Kuhn authored
Calling LanguageService->sL() should *always* return a string, even if it's empty. The patch enforces this. This reveals a couple of incomplete unit test mocks, which are fixed to keep the test suite happy. Resolves: #95776 Releases: master Change-Id: I2fbd272cebdbf76eeec354b3bc8750c172b3ece3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71974 Tested-by:
-
- Oct 25, 2021
-
-
Christian Kuhn authored
Calling trim() with something else than a string emits a E_DEPRECATED error with PHP 8.1. Some ContentObjectRenderer->stdWrap_*() are affected by this and sanitized with explicit string casts. This is a bit of an artificial thing that mostly only happens in tests since in TypoScript usually everything is a string anyways. However, depending on how stdWrap_* methods are fed and used code-wise, it could also be a db return, which might be int or null. We thus can't simply change the method signature to 'string $content' and need to go with casts instead. Resolves: #95774 Releases: master Change-Id: Ifbb90170c4561e1570444c0c3d818aa32e58c827 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71972 Tested-by:
-
Christian Kuhn authored
Calling str_replace() with second argument non-string is deprecated as of PHP 8.1. Sanitize stdWrap_brTag() in ContentObjectRenderer to avoid a case found by unit tests. Resolves: #95775 Releases: master Change-Id: I9353ec28d23ec3b0ef50b8ecf48053ce27f5645e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71973 Tested-by:
-
Christian Kuhn authored
PHP 8.1 emits E_DEPRECATED if second argument to str_replace() is null. Adapt a null coalescence and add a cast to string for TSFE->page['uid'] in AbstractMenuContentObject to avoid this. Change-Id: Iafcf027471b976b160db768b4ada4a9535190319 Resolves: #95773 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71971 Tested-by:
-
Christian Kuhn authored
The filter_var() filter FILTER_SANITIZE_STRING is deprecated as of PHP 8.1. Extbase TextValidator uses it. Goal of the text validator is to allow most 'casual' characters and strings as long as they don't contain HTML. The path switches to strip_tags() to validate. Tests are refactored and extended to show more cases. https://wiki.php.net/rfc/deprecations_php_8_1 Change-Id: Ifbf3de7a7200512d1281b694a7a6c2f8fb3ac781 Resolves: #95768 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71968 Tested-by:
-
Christian Kuhn authored
We unfortunately still didn't manage to drop remaining usages of GeneralUtility::getIndpEnv() and deprecate the method in v11. So we have to harden it a bit towards better PHP compatibility: The method states it always returns string, but it doesn't. Especially HTTP_HOST and REMOTE_ADDR tend to return null. This isn't critical since that's usually just triggered by tests, but still, these calls should fall back to empty string instead of null. The return values are often further processed with string related methods, both in getIndpEnv() itself, in other consumers, and in other helper methods like cmpIp(). It absolutely makes sense to return empty string over null in lowlevel getIndpEnv() directly. Resolves: #95764 Releases: master Change-Id: I008452bb8445f1c23f634312d205102e4bb7602d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71966 Tested-by:
-
Christian Kuhn authored
FluidTemplateContentObject calls: $headerAssets = $this->view->renderSection(...); if (!empty(trim($headerAssets))) { ... This expects that renderSection() actually returns a string, which it usually does. Not returning a string and then calling trim(null) emits a PHP 8.1 E_DEPRECATED error. The heavy mocking FluidTemplateContentObjectTest class however misses to mock the view properly in many places and then triggers the trim(null) deprecation since especially renderSection() method mock is not instructed to return string and falls back to null. The patch takes care of proper mocking and adds a todo these tests would benefit from being turned into functional tests to avoid the mock party. Change-Id: Ifc2cb6ca00f09af0c6bd850f31c8807347e8c645 Resolves: #95771 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71969 Tested-by: -
Christian Kuhn authored
StringUtility::multibyteStringPad() does a happy division feeding str_repeat() to evenly pad on left and right side. The division result can be a float. With PHP 8.1, str_repeat($string, float) emits E_DEPRECATED "Implicit conversion from float looses precision.". Avoid this with an explicit cast. Resolves: #95772 Releases: master Change-Id: I8b918f6a4a304a059729e573a45626d1d5d27d10 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71970 Tested-by:
-
Christian Kuhn authored
GeneralUtility::_POST($this->formfield_permanent) returns null if that field is not set in $_POST. Feeding null to strlen() emits a E_DEPRECATED PHP 8.1 error. Sanitize that call. Change-Id: Ib2712ee04807f2853f6dc4b66c76293ce6e161e8 Resolves: #95765 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71967 Reviewed-by:
-
Benni Mack authored
This change uses the PackageManager API to fetch the extension key title, and also solves a small issue when the TCA title is not prefixed with "LLL:". Resolves: #95716 Releases: master Change-Id: I199a44dae03968a549876b7862b01f2865269c8c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71934 Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
-
Georg Ringer authored
With #94996 the behavior for composer based installations changed: - All extensions are always active - PackageStates.php is not used anymore - ext_emconf.php is not used anymore More information makes updates easier for integrators. Resolves: #95647 Releated: #94996 Releases: master Change-Id: I24f727987484e9eb2cefec37d85293dc2657aa66 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71805 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Sybille Peters authored
- Error code 500 used to be displayed as the generic "Network error / invalid domain" which was misleading - Libcurl errors were always displayed with complete exception message which always added the URL to the libcurl errors. This bloated up the results page We now display short, localized error messages for the most common messages, falling back to the exception message. Resolves: #92231 Releases: master Change-Id: I7cc73a47912bf6bc25d74fa7fcfd8a33084a96cf Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/66074 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
-
- Oct 24, 2021
-
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in FinisherVariableProvider to avoid deprecation messages without breaking compatibility. Do that for 'mixed' returns, and use correct return types directly for this @internal final class. Resolves: #95755 Releases: master Change-Id: Ic3d69e474419f48c58d4311b74047f952a483c29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71961 Tested-by:
-
Stefan Bürk authored
Set int return type for @internal class FileCollector to satisfy PHP 8.1 strict return on SPL classes. Resolves: #95757 Releases: master Change-Id: I9f064122f44a44d1adaffac9c7ad2539367fc3dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71963 Tested-by:
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in ext:form FormRuntime to avoid deprecation messages without breaking compatibility. We can however set some of the return values for @internal marked methods. Resolves: #95754 Releases: master Change-Id: I76c52da760e9bc302884fddb9ad38852d3c13e6c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71959 Tested-by:
-
Nikita Hovratov authored
Since PHP 8.1 The Countable interface has tentative return types. This means mismatching return types trigger deprecation notices. The methods current and key of EmptyFileSearchResult have the mismatching return type void. To suppress the deprecation without a breaking change, the #[\ReturnTypeWillChange] attribute has been added to those methods. Resolves: #95758 Releases: master Change-Id: I3b8c75fa754762904277c88c9fbf9a8d72dc4ba4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71964 Tested-by:
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in ext:frontend LinkResult to avoid deprecation messages without breaking compatibility. Resolves: #95756 Releases: master Change-Id: I3906c54c49c894fd4bbf221a956a17856e0b2fdb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71962 Tested-by:
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in AbstractCompositeValidator to avoid deprecation messages without breaking compatibility. Resolves: #95753 Releases: master Change-Id: I0bbdabceefabc084d28ca8fc647339fb10d91a67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71958 Tested-by:
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in ext:extbase ArrayAccessClass to avoid deprecation messages without breaking compatibility. Resolves: #95752 Releases: master Change-Id: I6e3dafd39813e5aa2622dbf3c145aefd3cf4e961 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71955 Tested-by:
-
Stefan Bürk authored
Set #[\ReturnTypeWillChange] and corresponding @todo comments to methods of implemented interfaces in ext:extbase QueryResult to avoid deprecation messages without breaking compatibility. Resolves: #95751 Releases: master Change-Id: Idac157313409d0a39c3c4ce35a0cbb01fed8d04f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71954 Tested-by:
-
Robert Kärner authored
Three methods in Extbase's Result are now annotated with the correct return type to make PHPStan happy when they are accessed in custom extensions. Resolves: #95730 Releases: master, 10.4 Change-Id: I68e4b9a434c9d64037521d45e5c5d0dbcb678094 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71936 Tested-by:
-
Benni Mack authored
This change now uses allowed_classes=false on all calls of unserialize() for sys_log.log_data which we did not have before. Resolves: #95731 Releases: master Change-Id: I1619aeba8f9c40696f15e040bc56007ffe3baf48 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71937 Tested-by:
-
Christian Kuhn authored
Let getLL() return string in tests to avoid a "sprintf(): Passing null to parameter #1" from Typo3Status test. Sanitize that sprintf(). Resolves: #95749 Releases: master Change-Id: I851badd4e8f6bcdd64ba2e70d37dafcce03e905b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71952 Tested-by:
-
Stefan Bürk authored
PHP 8.1 added concrete return types to internal interfaces, classes and methods which triggers deprecation messages, or fatal if it is related to inheritance or interface implementations. There are two ways to mitigate this: * add concrete return type * add #[\ReturnTypeWillChange] Adding concrete return types would be breaking, thus this patch adds #[\ReturnTypeWillChange] to methods related to the \Iterator interface, which LazyLoadingProxy implements. Further @todo comments are added to remove the php attribute #[\ReturnTypeWillChange] and add concrete return types as breaking change in v12. Resolves: #95750 Releases: master Change-Id: Ibd18158928c6290c6a04e50e073c1ec6a58a980d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71953 Tested-by:
-
Stefan Bürk authored
ext:extbase Controller/Arguments extends ArrayObject which implements several interfaces. Since PHP 8.1 added concrete return types this triggers deprecation messages, and in cases of inheritance fatal. This patch adds #[\ReturnTypeWillChange] to methods as we cannot add concrete return types without beeing breaking. Also add corresponding @todos to add them as breaking patch in v12. Resolves: #95748 Releases: master Change-Id: I4f9e2d9bc57df06146e17b2d20773db327237851 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71951 Tested-by:
-
- Oct 23, 2021
-
-
Christian Kuhn authored
finediff is used in various core places to render a HTML "diff" view of two strings. The library didn't see changes since 2014. With PHP 8.1, it started mumbling about \ArrayAccess signature shenanigans. We forked the lib to lolli42/finediff as drop-in replacement, modernized the codebase a bit and added multibyte support along the way - that's the reason this patch is a bug fix. composer req lolli42/finediff:^1.0 composer rem cogpowered/finediff composer req lolli42/finediff:^1.0 -d typo3/sysext/core --no-update composer rem cogpowered/finediff -d typo3/sysext/core --no-update Change-Id: Ib00b8073253709459b56e3080d9361c46f913e4c Resolves: #95742 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71945 Tested-by:
-
Stefan Bürk authored
To make units test notice free in #85092 a wrong fallback for array access has been used. Fallback to null and passing to trim() through null coalescing operator has been the wrong choice, as it triggers a deprecation message in PHP 8.1. This patch change the fallback to an empty string instead to avoid this deprecation message. Resolves: #95747 Related: #85092 Releases: master, 10.4 Change-Id: Ica8522a18d5980affe87958c6b662ce4c1b64578 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71950 Tested-by:
-
Stefan Bürk authored
PageArguments and SiteRouteResult implementing the \ArrayAccess interface indirectly through implementing RouteResultInterface, but do not have set parameter and return type for some methods. This could not be done as mixed is only availabe since PHP 8.0. PHP 8.1 implemented concrete return types for internal classes, interfaces and methods which triggers deprecation messages, unless they are part on an inheritance. This patch adds the #[\ReturnTypeWillChange] attribute to suppress the message for PHP 8.1, but ensure the compatibility for PHP 7.4. Further @todo's are added to remove #[\ReturnTypeWillChange] and add concrete return types and parameter types as breaking change in v12. Resolves: #95746 Releases: master Change-Id: I584e56295d43d063b9cce05377f5ab3c1641b00a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71949 Tested-by:
-
Stefan Bürk authored
MetaDataAspect implements multiple interfaces and has return type hints that match the interfaces. Except for the offsetGet() and current() methods, which are defined by the ArrayAccess and Iterator interfaces. The 'mixed' return type cannot be used before PHP 8.0, so it cannot be added yet. This patch adds the attribute '#[\ReturnTypeWillChange]' to avoid the fatal error for PHP 8.1 and @todo comments to change the correct return types, as a breaking patch for TYPO3 v12. Resolves: #95744 Releases: master Change-Id: Ic2c38758bbeaeef96efdcdf5f3349e3e3e08a72c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71947 Tested-by:
-
Stefan Bürk authored
WebProcessorTests uses GeneralUtillity::getIndpEnv() directly or indirectly, thus triggering deprecation message on PHP 8.1 if $_SERVER['HOST'] is not existing. This patch sets $_SERVER['HOT'] to avoid this message. Resolves: #95745 Releases: master Change-Id: I71bd3c9b1a803c90d79dee42cd60032c9477c4b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71948 Tested-by:
-
Stefan Bürk authored
SchemaColumnDefinitionListener instantiates a new Column class and passes the column name retrieved from an array. If the array key 'field' does not exist in the tableColumn definition, the null coalescing operator with the fallback of 'null' is used, which is not ideal because the fieldname parameter has a docblock type hint of string. DBAL internally there is a check of the column name using the php-internal function strpos(), which since PHP 8.1 causes a deprecation message if a null value is passed as first parameter. This patch changes the value of the null coalescence operator to an empty string to avoid this deprecation message, and to be compatible when DBAL changes the parameter type hint to string. Resolves: #95743 Releases: master Change-Id: I95869666cf1c8f798259652cf63bdd8fbfc554fd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71946 Tested-by:
-
Stefan Bürk authored
Since PHP 8.1 passing null as first argument ($format) has been deprecated. LanguageService uses 'sprintf()' for formatting messages. In normal instances LanguageService would return translated keys, or at least an empty string. Test in FileHandlingUtilityTest has been mocked the LanguageServiceFactory to inject it into a class, thus not providing a proper setup LanguageService and return null instead of an empty string as translation. This patch change from mocked to prophezied LanguageServiceFactory and LanguageServices objects to avoid these deprecation messages in PHP 8.1. Resolves: #95740 Releases: master Change-Id: I2a45cd9657c2e1e9f6d9e45d56dc398311b73d55 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71943 Tested-by:
-
