[BUGFIX] Let GeneralUtility::getIndpEnv() return string more often
We unfortunately still didn't manage to drop remaining usages of GeneralUtility::getIndpEnv() and deprecate the method in v11. So we have to harden it a bit towards better PHP compatibility: The method states it always returns string, but it doesn't. Especially HTTP_HOST and REMOTE_ADDR tend to return null. This isn't critical since that's usually just triggered by tests, but still, these calls should fall back to empty string instead of null. The return values are often further processed with string related methods, both in getIndpEnv() itself, in other consumers, and in other helper methods like cmpIp(). It absolutely makes sense to return empty string over null in lowlevel getIndpEnv() directly. Resolves: #95764 Releases: master Change-Id: I008452bb8445f1c23f634312d205102e4bb7602d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71966 Tested-by:core-ci <typo3@b13.com> Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Jochen <rothjochen@gmail.com> Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Anja Leichsenring <aleichsenring@ab-softlab.de>
Please register or sign in to comment