- Jan 14, 2020
-
-
Mathias Brodala authored
Resolves: #89720 Releases: master Change-Id: I97e7f5b0465527d3a8ebe7190e3bdf710e9d7f54 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62353 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Steffen Frese <steffenf14@gmail.com> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
Rémy DANIEL <dogawaf@no-log.org> Reviewed-by:
Felix P. <f.pachowsky@neusta.de> Reviewed-by:
-
Markus Klein authored
Resolves: #90108 Releases: master, 9.5 Change-Id: I6aded269507fc79f0404cbdbfb79ac0f20b9d2a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62877 Tested-by:
-
Benni Mack authored
LanguageService a.k.a. $GLOBALS[LANG] is used in various places, not just for backend-labels anymore. The "init()" method (which stems from the fact that PHP did not have constructors !!! back then), should be covered - which is now done via factory methods. The goal of the factory methods are to explicitly define the dependencies where LanguageService is used, instead of calling "init()" in the emitters code. This change is a pre-cursor for TYPO3 to - avoid accessing Bootstrap API for initializing $GLOBALS[LANG] - streamline the various places where this API is instantiated - have a first step to switch to "real" locales at _some_ point - and eventually get rid of accessing LanguageService via globals. In addition the PHP class comments are streamlined to reflect the purpose of this class. The next step is to adapt the testing framework to easily use this API so our tests will not have to worry about $GLOBALS[LANG] anymore. My 2c: We should actually rename "LanguageService" to "LabelService" or "LabelProvider" at some point. Resolves: #90062 Releases: master Change-Id: Ib1b6a8aacb2c2aecc3ab2931db04002dd02f0a99 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62826 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
-
Andreas Fernandez authored
This patch updates the Install Tool to use the new AJAX API introduced with #89740. Resolves: #89740 Related: #89738 Releases: master Change-Id: I0e9e3b43a375b0ec0105ce8ce2db128c0aaaf857 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62373 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Markus Klein authored
This allows to create a folder link to the currently selected folder in the folder browser. Resolves: #72527 Releases: master, 9.5 Change-Id: Ifbbfbd744965f8ca8e78f116ea89e3b9d8396d59 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62852 Tested-by:
-
Sebastian Rosskopf authored
Prevent double scrolling bars in error messages. For example in install tool modals. Resolves: #88093 Releases: master, 9.5 Change-Id: I32b70197cede4f652c864774bcbf24cea5120d90 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60398 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Tizian Schmidlin authored
Since TYPO3 8 the way TypoLinks are represented has changed. The new form is t3://page?uid= as prefix for page links. The documentation of TypoLinkViewHelper is updated to reflect this. Resolves: #89408 Releases: master, 9.5 Change-Id: I093c3db171163cff9de3a02a715784241724a2c1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61968 Tested-by:
-
Oliver Hader authored
Resolves: #90086 Releases: master, 9.5 Change-Id: Ibe5eb0db866933984a07ac5f5b82010a0ae4698b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62844 Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Markus Klösges authored
The scheduler module now shows validation errors for execute console commands as messages in the backend. Previously changing the configuration of a console commands arguments could lead to an exception when the currently selected set of arguments was not parseable anymore with the new configuration. In some circumstances it was also possible to save a task without supplying all required arguments, which rendered the backend module non-functional because of the exception. Catching the exception and providing the error message helps spotting and fixing these errors without having to manipulate the database directly. Resolves: #89774 Releases: master, 9.5 Change-Id: I838e90bdd48f7146863630fa7dd09776459393d2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62756 Tested-by:
-
Oliver Hader authored
StateRangeMapper routing aspects defined like the following did not use leading zero (0) prefixes due to internal number conversion to integer: month: type: StaticRangeMapper start: '01' end: '12' Zero prefixes are applied in case they were explicitly given in either start or end property for StaticRangeMapper settings. Resolves: #87730 Releases: master, 9.5 Change-Id: I1846d9faa4843834d7175173f5ca9db5b1445ca5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62864 Tested-by:Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Hader authored
* replaces nested array logic with domain objects * introduces perputation logic (instead of foreach/foreach/foreach/...) * introduced common variables container compiled when executing tests (allows to declare arbitrary behaviour without hardcoding values) * applies more specific page type decorators in request tests Resolves: #90053 Releases: master, 9.5 Change-Id: Id145de4aafc419ab70cd60fb8a439144307a0cec Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62815 Tested-by:
-
Jan Stockfisch authored
Resolves: #89969 Releases: master Change-Id: Ic813e072904c8a078567bd9a067d9787f6ebf856 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62677 Tested-by:
Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Riny van Tiggelen authored
The database field which is created based on TCA setting translationSource, now automatically gets an index. This improves the performace in (for example) the migration from pages_language_overlay to pages. Resolves: #89853 Releases: master, 9.5 Change-Id: I23ba8254158250249422b9fb0d20975372a11dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62534 Tested-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
- Jan 13, 2020
-
-
Benni Mack authored
HMENU provides a way to directly create the external link if a page is of type "External URLs" but typolink does not resulting in a) more bandwidth / hits for TYPO3 when using typolink b) different results / expectations. The patch makes typolink handle external URLs like HMENU. Resolves: #90008 Releases: master Change-Id: I712e79f2a399b50d9781bca75f623a419a29f09e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62630 Tested-by:
-
Daniel Goerz authored
When generating the list of pages for a sitemap in an alternative language only pages are considered that are actually translated or covered by the fallback strategy. Additionally the method generateItems() in the internal class PagesXmlSitemapDataProvider is now protected. Resolves: #90046 Releases: master, 9.5 Change-Id: I54557e0485ae7791ac51fa975991d6d9c9211b61 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62865 Tested-by:
-
Markus Klein authored
The name clash with the PHP native exception is not beneficial. We replace it with \InvalidArgumentException. Resolves: #90101 Releases: master Change-Id: Icc53bcca2dcc24352f4edd4f2e9ef66df7bdfdd5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62862 Tested-by:
-
Benni Mack authored
When the PageTypeDecorator is used for routing, currently ALL available typeNums must be registered, otherwise links to pages with a typeNum just get their type removed (fallback to default). A new check is added when creating links (resolving these URLs with a GET type= parameter works just fine) for skipping unmapped arguments when decorating. Resolves: #87817 Resolves: #88836 Releases: master, 9.5 Change-Id: I252cf80de2befed8396cc93b1bc737d77aa18b31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62383 Tested-by:
-
Joerg Boesche authored
The sys_category TCA configuration behavior is now the same as in tt_content. Flags and labels for the languages in the select single dropdown. Resolves: #89607 Releases: master, 9.5 Change-Id: I5a4c2df7294b699136b62cbf4f68d2ceeae43b8e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62860 Tested-by:
-
Markus Klein authored
If a select field is comprised of static and dynamic (database relation) values the order of items stored in database is preserved when showing the select field. Resolves: #87672 Releases: master, 9.5, 8.7 Change-Id: I95ed9d523f68eb106c22bbbcd14e60a17a2c0293 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62856 Tested-by:
-
- Jan 12, 2020
-
-
Daniel Goerz authored
The list module now takes the available SiteLanguages into account when rendering the buttons for creating new translations of records. If a language gets deleted from the site configuration it is no longer possible to create record translations to this language. Resolves: #86662 Releases: master, 9.5 Change-Id: If03598fbb63496d36c93cd832cbdb3028b5e32e1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62854 Tested-by:
-
Daniel Goerz authored
Resolves: #90099 Releases: master, 9.5 Change-Id: Ia3917f8a33aa6c76c20cbcc5e107546520113ab3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62858 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Markus Klein authored
Example: [traverse(request.getQueryParams(), 'tx_news_pi/news') > 0] Resolves: #89176 Releases: master, 9.5 Change-Id: Ic589f68382951c203afa5ad6a7bc16fbddbc20b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61708 Tested-by:
-
Georg Ringer authored
A condition like [getTSFE().id == 1] is evaluated in BE as well and logged an error 'Unable to get a property on a non-object'. This patch ensures that conditions based on getTSFE() are treated gracefully and are evaluated to false. Resolves: #87021 Releases: master, 9.5 Change-Id: If56a8b7bd66b9f7e66bdc8ce5f56c8df890cf655 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59129 Tested-by:
-
Susanne Moog authored
As feedit has been removed from the core, EditToolbarService is no longer in use. As it was marked as internal it is removed without further notice. Resolves: #90098 Releases: master Change-Id: I5e8a622c5581e46539afe43a1aed3486c6d5ae11 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62853 Tested-by:
-
Susanne Moog authored
As config.extTarget might not be set, passing it by reference results in the string "< config.extTarget" being passed instead - which will not evaluate to empty therefor breaking the fallback chain. Resolves: #89994 Releases: master, 9.5 Change-Id: Ice368e3d139309b32fb886538ef69437f62b3cc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62752 Tested-by:
-
Markus Klein authored
The labels have been moved around before and these place have been forgotten to be updated. Resolves: #90096 Related: #87882 Releases: master Change-Id: I738e7b5230ed300449e25acedc4f06fccdd588d5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62850 Tested-by:
-
Volker Kemeter authored
Since sys_file_metadata records are stored on pid=0, there is no site configuration available. This situation is similar to be_users.limitToLanguage feature, where all languages of all sites need to be visible (depending on the backend user rights). This patch adds an option for the TranslationConfigurationProvider to render all languages of all sites as a combined list if the given pageId is 0 (based on the current user rights). Resolves: #88897 Releases: master Change-Id: I14b1bb6ae5c8577571cf5fa7bc2da1c1824c0f58 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/61419 Tested-by:
-
Markus Klein authored
The DefaultTcaSchema::enrich() function dynamically adds TCA-defined ctrl-fields to the SQL schema definition for a provided set of tables. The function used to add these definition for any table that is defined in TCA, independent whether the table actually exists in any ext_tables.sql file. While this behaviour is no problem under the assumption that the function is always called with the content of all ext_tables.sql files, this is a problem if the function is called with only a subset of those ext_tables.sql files. One example is the "extension manager tables" upgrade in the Install Tool. Despite the fact that the function was documented that it needs to be called with the full set of tables, it actually is not strictly necessary to do so. This patch changes the requirement for the enrich() function and changes the behaviour to not dynamically create tables if those are found in TCA. Technical detail to the reported bug: The table definitions created by this class are usually overruled by whatever might be defined in an ext_tables.sql file. In case of the upgrade wizard (where only extension manager tables are requested) the table definitions for all TCA tables were created based on the best practice suggestions from the core. If the present DB schema (created by the real ext_tables.sql files) mismatched those suggested definitions a DB schema change was proposed, hence the wizard kept popping up. Resolves: #89535 Releases: master, 9.5 Change-Id: I78594f1ee0878e8d3f5606901d0abb7fe0023059 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62154 Tested-by:
-
Georg Ringer authored
Remove the feature switch `betaTranslationServer` and use the new translation server by default. Resolves: #89992 Releases: master Change-Id: Iab61c913d1a6df3cc1b509e731d30616392c43a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62747 Tested-by:
-
Georg Ringer authored
As the description is using a textarea element in the backend, editors can add a multi-line text. The line breaks should be shown in the frontend as well by using f:format.nl2br. Resolves: #89611 Releases: master Change-Id: Ia2b1b2ef896004b1ec91a1719d48826efdc3fb91 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62629 Tested-by:
Jan Stockfisch <typo3@jan-stockfisch.de> Reviewed-by:
-
- Jan 10, 2020
-
-
Benni Mack authored
In the environment module, the removed <i:constant> viewhelper is still referenced, which can easily be used by assigning the proper variable to Fluid. This change was merged last week due to the TYPO3_version logic. Resolves: #90077 Related: #90007 Releases: master Change-Id: Ie3ccd03b757303e253a71bea26c60406552e3d5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62838 Reviewed-by:
-
Manuel Selbach authored
With this change $connection::query() is used instead of $connection::exec() which can not be used for statements that return results, see: https://www.php.net/manual/de/pdo.exec.php#61702 Resolves: #82686 Releases: master, 9.5, 8.7 Change-Id: Ic4b2cc8caec0bc74ffa730b09d03ca0009ca1751 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62841 Tested-by:
-
Benni Mack authored
Using Class constants instead of constants that are defined during runtime has the following benefits: - Naming can be made more consistent (and separated) - Speeding up requests where the constants are not needed - Benefit from Opcaching of class loading instead of dynamic runtime definition - Testing framework has less "bootstrap" to do This affects the following constants: - TYPO3_copyright_year - TYPO3_URL_GENERAL - TYPO3_URL_LICENSE - TYPO3_URL_EXCEPTION - TYPO3_URL_DONATE - TYPO3_URL_WIKI_OPCODECACHE The constants are now deprecated. In addition, the "Typo3Copyright" class is now called "TYPO3Information". Resolves: #89866 Releases: master Change-Id: I607c90cb281179bda9875504d258daefd3471868 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62624 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by: Anja Leichsenring <aleichsen...
-
Benni Mack authored
With Dependency Injection, the new PSR-14 based EventDispatcher, built into TYPO3 Core should never be exposed to our core code, since we should always reference the EventDispatcherInterface. We do this in almost all cases, except for a few places where we introduced PSR-14 before DI. Resolves: #90034 Releases: master Change-Id: I59e74333360c98b3c2e16c1b3df6fbd8bbf450f0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62778 Tested-by:
-
Benni Mack authored
This change cleans up some RelationHandler code: - Working with true boolean inside RelationHandler for getValueArray() - RelationHandler->MM_oppositeFieldConf is an array, but declared wrongly as string (since forever!) - detecting the MM_oppositeTable property should not need a $tmp variable, but using a direct assignment - and unset() is not needed due to PHP7s memory management - internal $isSet flags should be boolean, instead of a number Resolves: #90066 Releases: master Change-Id: Ifff2a016a7be945ba6a1dd265e06b1e52bee5de7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62830 Reviewed-by:
-
Georg Ringer authored
The method inet_pton returns false if the provided IP address is invalid. This needs to be checked to avoid errors. Resolves: #90059 Releases: master, 9.5, 8.7 Change-Id: Ic3c7955eb64aff723b31862ef9c7c95e31a098b7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62833 Tested-by:
-
Benni Mack authored
During the TYPO3 v9 install tool refactoring, a simple PHP array syntax mistake did not correctly set the fluid variable "systemInformationCgiDetected" which always resulted in not running in a CGI environment. The change adapts the array variable assigment. Resolves: #87320 Releases: master, 9.5 Change-Id: I2368ff033a6318d67c9153be20816d13ad8bd08d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62837 Reviewed-by:
Michael Schams <typo3@2018.schams.net> Reviewed-by:
-
- Jan 09, 2020
-
-
Helmut Hummel authored
The AbstractTask always had methods setScheduler and unsetScheduler to avoid serialization of the scheduler instance. These methods are called by the scheduler API before serializing (unset) and after unserializing (set). Use these methods in favor of the __sleep and __wakup calls to avoid issues with third party subclasses that implement these methods and to make sure tasks that are already serialized with an outdated logger instance are properly updated on next run without the need to clean them up manually. Releases: master, 9.5 Resolves: #86941 Resolves: #87780 Change-Id: I140973fa952c5c41b8eac966ba3b541420ec060b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60306 Tested-by:
-
Benni Mack authored
The symfony/mailer instance needs an email address in the form of new Address($emailAddress, $name); The MailUtility::getSystemReplyTo() returns a strange (Swiftmailer-like) syntax, which was implemented wrong when migrating to Symfony/Mailer. The change switches the constructor arguments to be used in the correct order ($email, $name). Resolves: #90040 Releases: master Change-Id: I2f2bfc67b47fdd1327895c96bd27b2d481805a1b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62836 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Benni Mack authored
The BasicFileUtility was very important before the FAL API was introduced in TYPO3 v6. Since TYPO3 v10, the last important parts have been removed, which is why the PHP class is now marked as internal. In addition, several internal methods have been removed, the "setFileExtensionPermission" method is still there in order to avoid PHP Fatal Errors so extensions can stay compatible with TYPO3 v9 and TYPO3 v10. Resolves: #90020 Releases: master Change-Id: I1c6903f914722c5ddca79dd16f5766984f8c10db Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62764 Tested-by:
-
