- Mar 26, 2020
-
-
Andreas Fernandez authored
This patch introduces a filter in the "New Content Element" wizard which enables a backend user to search for their wanted content element respecting the CE name and description. If a query leads to the situation that a tab has no results, that very tab becomes unavailable to the user. If the current active tab has no results, the next available tab is made active. Resolves: #83128 Releases: master Change-Id: I8cff939933fd895d986047c170cd9816776474bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63888 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Susanne Moog <look@susi.dev> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Frank Nägler <frank.naegler@typo3.org> Reviewed-by:
-
Susanne Moog authored
Using offsetSet or unset allows manipulating the QueryResult manually. As the result of `count` is cached, offset changes need to reset that cache to accurately return the correct offset. Resolves: #76310 Releases: master, 9.5 Change-Id: Ic43f3810766bdb1ee02800b07f6853c81ba404f5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63919 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Reviewed-by:
-
Benni Mack authored
The examples are outdated and should be removed in Core, to avoid shipping dead code. Resolves: #90833 Releases: master Change-Id: Iff93c3963ec7efb91fa1c06c046494e8070f6a65 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63924 Tested-by:
-
- Mar 25, 2020
-
-
Susanne Moog authored
The buttons on top of the page tree behave like a button group and should be styled as such. Resolves: #86916 Releases: master Change-Id: I04e4f65cda19d6e1ed808ebdaecb942e21b202fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63915 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Susanne Moog authored
The debug/live presets toggled the deprecation log in earlier versions. Since rewriting the deprecation log to the logging framework, the presets do not take deprecations into account anymore. Due to the configuration merge between Default and LocalConfiguration it is currently not possible to disable the deprecation log by overwriting it in LocalConfiguration - setting will only take effect when set in AdditionalConfiguration. Therefor we are removing the mention of deprecation logs in the presets to avoid confusion. Resolves: #89769 Releases: master, 9.5 Change-Id: I0bc1db480a31692350ea20454cfc5b143edcc70a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63829 Tested-by:
Daniel Haupt <mail@danielhaupt.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Josef Glatz authored
Restore sorting of documentation files based on their filename like it was available up to TYPO3 version 8.7. Resolves: #87390 Releases: master, 9.5 Change-Id: I2ab75d6b750b3a3003f00ed174c0d3dfb865bec9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63913 Tested-by:
-
Daniel Siepmann authored
Resolves: #85653 Releases: master, 9.5 Change-Id: Idda07be57a1774362b2aea0ea6e019a0c4f7a6e2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63753 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
-
Michael Schams authored
This change updates the email texts and subject lines for HTML and plain text mails, as well as some labels in the backend. Resolves: #90670 Releases: master Change-Id: I1ac121097d784bcdf365f1e31c2ce37f53c73617 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63771 Tested-by:
-
Nicole Cordes authored
If an extension provides wrong SQL in ext_tables.sql, the upgrade wizard is skipped completely. This patch catches the current exception and outputs the error that needs to be resolved manually. Resolves: #87187 Releases: master, 9.5 Change-Id: I903ce7fdc9373eee66da7bed86698c42a2731dc7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/59182 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Benjamin Kott authored
Configuration from external plugins is now only set if the plugin actually provided some. By default, the plugin name is used for any configuration provided by an external plugin. Since the name of the internal configuration setting can be chosen by the author of a plugin we now provide a new option to adjust the name that should be used. Resolves: #88302 Releases: master, 9.5, 8.7 Change-Id: I5c1f921f4897cf15e11199015454d0927915a30e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63004 Tested-by:
-
- Mar 24, 2020
-
-
Sybille Peters authored
If a page translation exists, it should be deleted before the original page. It the translation is deleted after the deletion of the original page, this will result in an error because the existance and delete permissions of the original page is checked before deletion of the translated page. Resolves: #85824 Releases: master, 9.5 Change-Id: I74b333fd450ea4bf361efbcd39a4daa07002c930 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63757 Tested-by:
-
Julian Hofmann authored
Fix a wrong code example: 'config' is a property of PAGE-object, not of the USER-object. Releases: master, 9.5 Resolves: #90821 Change-Id: I8639bfdbd71e9968687afd172418616ce930d93d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63887 Tested-by:
-
Andreas Fernandez authored
Deleting flexform sections now removes the fields from DOM as DataHandler only cares for the "action" being sent. This commit also fixes a strange condition that checks whether the action array has empty values. To have at least one similarity with IRRE, deleting a section now also fades the container. Resolves: #71607 Releases: master Change-Id: Ib696385ff4bdd3daed323a94c5dd7fdd3a74f640 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63830 Tested-by:
-
Susanne Moog authored
Simulating a user group had no user set, which resulted in some things not being simulated (for example the fluid `role` and `authenticated` view helpers). As the expectation just includes a `uid` > 0, we are now setting `uid=1` for the simulated user. However, the long term solution for future versions should be replacing the usergroup simulation by a simulation of a concrete user (like impersonating is done in the backend). Resolves: #90773 Releases: master, 9.5 Change-Id: Idf380607921184edf50ab784ffa309e864e754f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63794 Tested-by:
Henrik Ziegenhain <henrik@ziegenhain.me> Reviewed-by:
-
Susanne Moog authored
The FAL indexer stopped the whole indexing queue if any error occured. While single files might not be indexed, the whole process should not be stopped because of it. Exceptions while indexing are now caught and logged, but the indexing process continued. Resolves: #62253 Releases: master, 9.5 Change-Id: Id64cfb59d7e94edf52ca941254761a2014a3aa06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63815 Tested-by:
-
Benni Mack authored
Current implementation for defining a maximum lifetime of a workspace-related previewlink is based on userTSconfig - which actually relies on the user configuration that creates the preview link. This can lead to massive side effects. The option is therefore added to each workspace with a default value of "48 hours", to properly define the lifetime on a per-workspace and not on a "per-user-who-generated the links" basis. Actual features will be to add a GUI to the workspace module and see currently working preview links. The UserTSconfig option should be marked as deprecated in further iterations together with the new GUI feature. Resolves: #66948 Releases: master Change-Id: I76c2dabef81d5e1b3fc2d88e049c9df09381cb6f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63881 Tested-by:
-
Susanne Moog authored
The getDefaultUploadFolder hook must get the PID for the current page if the inline element is located on a page object. The logic is now as follows: - In case of records that are stored on a page, $pid is the uid of that page (pid of the record) - In case of an existing page $pid is the current page uid - In case of a new page, $pid is the relative page id as used in other places (for example -224 for a page below page id 224) - this allows hook implementations to react accordingly Resolves: #82881 Releases: master, 9.5 Change-Id: Ie8570f9656f54e25bfec3224411a5014c396ed2e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/54513 Tested-by:
-
Benni Mack authored
The existing drawItem_* hooks modified the record data to include custom values to be used in previews. The GridColumnItem now needs to allow to set the record data again. Resolves: #90819 Releases: master Change-Id: I008cdeb8b3411cda7fd7cfa184ca827a8d955581 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63880 Tested-by:
-
Daniel Goerz authored
The check was removed with https://review.typo3.org/c/Packages/TYPO3.CMS/+/53481 However, it is still needed and therefore reinstalled. Resolves: #90202 Releases: master, 9.5 Change-Id: Ib92b610ea744b41553245a80922080d3ab42a3ea Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63883 Tested-by:
-
Daniel Goerz authored
Resolves: #83138 Releases: master, 9.5 Change-Id: I369b750c951c408cd880cab8a64dd6a3734c47aa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63882 Reviewed-by:
-
Susanne Moog authored
Gzip encoding inline CSS does not work and we should not do that. Therefor setting `inline = 1` now also implies `disableCompression` (same way as it is done for concatenation). Resolves: #90820 Releases: master, 9.5 Change-Id: I85c70bba9dd850fe9b03086dc6c51f7064c60ba7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63884 Tested-by:
Timo Poppinga <timo.poppinga@zdrei.com> Tested-by:
-
- Mar 23, 2020
-
-
Sebastian Klein authored
This enables an editor to see where he added the 'soft hyphen' character by switching to the source mode of the Rich Text Editor. The otherwise invisible Unicode character is then replaced by the HTML entity '­'. Resolves: #85391 Releases: master, 9.5 Change-Id: Idb8a6b554a068398abd7d788d30092ab16e6c668 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/57687 Tested-by:
-
Claus Due authored
Pure metadata change - allows site admin to create a new site which uses Fluid 3.0. A separate change will come in TYPO3 v9. Releases: master Resolves: #90285 Change-Id: I5de150a4a8b7d99b12a50b2b5c9eb36462121f06 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63132 Tested-by:
-
Benni Mack authored
This change targets a couple of things: - The global constant "FILE_DENY_PATTERN_DEFAULT" is moved to a class constant - The global constant "PHP_EXTENSIONS_DEFAULT" which is not in use anymore, is removed. - The security aspect of checking against the fileDenyPattern is extracted into its own Class where - The fileDenyPattern can never be empty, but only be set via DefaultConfiguration. This makes it easier to test this functionality, a single object is taking over the responsibility, and the logic is now in one place. Also, the non-usage of the global constant makes life easier. Resolves: #90147 Releases: master Change-Id: I9db0d6fc3b10f75a3735017cb9ac0d9bfd4ff02b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62843 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
-
Georg Ringer authored
Due to incomplete editing in the site module or wrong yaml configuration it is possible that an empty static route is defined which will break the complete frontend. Skip empty routes as those don't make any sense. Resolves: #87500 Releases: master, 9.5 Change-Id: I9f5737bf077fd3b2f0c38522ee3ae641c7e5cd21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63610 Tested-by:
-
Benni Mack authored
The environment status should show proper information whether both PHP.ini settings have the same value or differ (but post_max_size is higher which is fine). Resolves: #89543 Releases: master, 9.5 Change-Id: Ib589715507d7e929904366cbda9b33b45e254564 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63879 Tested-by:
-
Benni Mack authored
When transforming the workspace notification emails, the option to set an alternative email sender was not added, but is now configurable properly. Resolves: #46634 Releases: master Change-Id: I3c254de90ce2c490f1e076eee60e99c885f91575 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63878 Tested-by:
-
Kay Strobach authored
The previous implementation used two typecasts in a row: from bool to string, and from string to bool again. This caused a boolean false to be cast first to null and then to an empty string instead of to "0". Resolves: #89491 Releases: master, 9.5 Change-Id: I4003dfe1e027437fe6366d21cc05453511f85919 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62087 Tested-by:
Stefan Froemken <froemken@gmail.com> Tested-by:
-
Benni Mack authored
The hook BackendUtility->preProcessValue() needs more context for the hooks to know what field/table/record is currently processed. This is added as a stdObject now. Resolves: #32169 Releases: master Change-Id: I477d0ad61f0279165f81c772005fd2b3b0c3f0b2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63877 Reviewed-by:
-
Christian Eßl authored
In the list view of a sysfolder, users could still see the page preview button. The list view is now using the same logic as the page module and the EditDocumentController, that allows for excluding some doktypes from showing the preview button. By default, the page types Recycler, Sysfolder and Spacer are excluded. This behaviour can be overridden by setting the already available pageTSconfig "TCEMAIN.preview.disableButtonForDokType". Resolves: #55300 Releases: master, 9.5 Change-Id: Iad7c651e33928b3ababe84c86222291e0bb6c3cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63515 Tested-by:
-
Andreas Fernandez authored
Due to CSS precedences the `sortable-ghost` class must have an important opacity to have any effect, e.g. in IRRE. Resolves: #90807 Releases: master Change-Id: I5d026bc86281b35c6f120d26c35dd468473d3f5a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63840 Tested-by:
-
Andreas Fernandez authored
This patch debounced or throttles some `scroll` or `resize` events to improve the client performance a bit, as the event listeners aren't executed anymore everytime the event is triggered. Resolves: #90810 Releases: master Change-Id: Id5262eebd004ee4d10d87a83cc17e3f517aca1a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63844 Tested-by:
-
Susanne Moog authored
When using `makeCategorizable` with options to overwrite the default field configuration, onChange was not overwritten. This has now been implemented. Resolves: #84799 Releases: master, 9.5 Change-Id: If62dd0472be2214d02b3b6c538d5d35d6d41661a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63873 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Reviewed-by:
-
Benni Mack authored
The internal_type=file was removed in TYPO3 v10, but the Backend Module "DB Check" (lowlevel) still contained lots of parts that are not relevant anymore. This patch cleans up the corresponding parts and simplifies various other places due to the lack of checks of internal_type=file. Resolves: #90816 Releases: master Change-Id: I742fc1ea197837c477415368a674ad8831e10f31 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63872 Tested-by:
-
Benni Mack authored
With PSR-14 events, it is now easier to detect newly created metadata records. For the time being, the pseudo-field "newlyCreated" is removed and the current check is made against "crdate". In addition, a unnecessary unit tests was removed. Resolves: #89020 Releases: master Change-Id: Ifc5e0e0faee6e3b6f7130c2387abbe6e6992109e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63874 Tested-by:
-
Andreas Fernandez authored
If assets get imported via mass selection in the Element Browser, the order of the items is now kept. Since this requires interframe communication, the Inline Control Container now sends a postMessage to the Element Browser. When the import process starts, the first asset of the selection gets imported. After the import, the postMessage is intercepted and the next asset get imported, until the queue is empty. As this could be a rather lenghty process, a progress bar is rendered at the top of the file table. To get a more fitting naming, all previously used action names used in postMessages have been renamed from `typo3:foreignRelation:inserted` to `typo3:foreignRelation:insert`. As a drive-by fix, the server is not spammed with n request anymore due to queueing. Resolves: #86362 Resolves: #59341 Releases: master Change-Id: Ib9e3ee8d943582874a0a73632968f8660b169b42 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63838 Tested-by:
-
Alexander Schnitzler authored
Used command: composer require friendsoftypo3/phpstan-typo3:"~0.2" --dev Releases: master Resolves: #90811 Change-Id: Ibd9ae856e8046edc67cb7610956ede92c474bf12 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63846 Tested-by:Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Susanne Moog authored
The parser for foreign_table_where consists of a basic regex that did not allow the use of field functions due to its character restrictions. The character match group has been adjusted to allow the following chars additionally: ")( Resolves: #82955 Resolves: #88166 Releases: master, 9.5 Change-Id: I0fa9283d920a0aaf2bacf9168d0e35f09c3d57af Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63755 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Sybille Peters authored
Lists must always be preceeded and followed by a newline. Otherwise they will not get rendered correctly. Resolves: #90805 Releases: master, 9.5, 8.7 Change-Id: I558e486ef556be41bb27873af8d0d67a448064f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63837 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Andreas Fernandez authored
Executing a debounced event listener immediately now sets a timeout to wait until the next execution is invoked. Resolves: #90809 Releases: master Change-Id: I76622c62cacfcf82d737fd93ae5a96fa4e7485a3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63843 Tested-by:
-
