- Sep 22, 2020
-
-
Oliver Hader authored
As a backend user, it is possible to preview a hidden page & record in a workspace, however, without a user it is not possible. Adding the tests also discovered that access to a "hidden" page should result in a 404 instead of 403 response (even though the page has access restrictions or not) in a live environment. This change adds tests to ensure this functionality is always working. Resolves: #92225 Resolves: #84098 Resolves: #86346 Releases: master, 10.4 Change-Id: I746717473bb93681c7b998d61c4f72eab4ec2ef3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/58829 Tested-by:
TYPO3com <noreply@typo3.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Simon Gilli authored
This patch adds the missing field `flag` from the site configuration to the LanguageMenuProcessor. The field could be used now to show the flag icon in a language menu out of the box and without workarounds. Resolves: #84926 Releases: master, 10.4 Change-Id: Ie27bed551a96cae8c6b20913105ff95db7f61942 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65800 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
Alexander Nitsche <typo3@alexandernitsche.com> Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
Oliver Bartsch authored
The ext:linkvalidator ValidatorTask has been improved. Therefore the task was switched from marker based templates to FluidEmail. The mail content was extended for a proper list of broken links along with all necessary information such as record id, page id, and so on. This allows editors now to easily access the records with broken links without having to visit the backend module first. Because of heavy refactoring and introduction of a new PSR-14 event, extension authors are now able to fully customize the mail content and the configuration (such as to, from, subject) dynamically (e.g. adding another recipient only on production context). Both the task and its field provider got added strict types. The task however currently still needs some type casts for backwards compatibilty as the tasks state is stored as serialized string in the database. The whole link analyzing process was moved into the dedicated class `LinkAnalyzerResult`. A new field `languages` is introduced which allows to restrict the report to the defined languages which is handy if different tasks should be used (e.g. editors responsible for only one localization). Resolves: #29342 Releases: master Change-Id: Ibe070038ef66f876de38e47d6f82f4f090af96ce Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65549 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Georg Ringer authored
The rendertype `InputLinkElement` renders a preview of the link since #28171. If a link to a page contains a fragment, this information has been added to the preview. Resolves: #92366 Releases: master Change-Id: I326fec85aa5bd535f675a435e8ea851fe96c892e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65801 Tested-by:
-
Oliver Bartsch authored
The EmailFinisher class evaluates the defined "translation language" which can be used to define the language of the mail content independent of the current frontend language. The corresponding option is however missing in the EmailToSender configuration. This leads to side effects if e.g. EmailToReceiver is configured with this option before EmailToSender. The EmailToSender finisher then automatically also uses this language without any possibility to prevent this behaviour. Therefore the missing configuration option for defining a translation language is now also available in the EmailToSender finisher configuration like already claimed in the documentation. Resolves: #92304 Releases: master, 10.4 Change-Id: Id81a5f616d439b4e4e844e270cadde3888ace46d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65733 Tested-by:
-
- Sep 21, 2020
-
-
Daniel Goerz authored
This patch removes the feature switch "rearrangedRedirectMiddlewares" and changes the default ordering of redirect middlewares. Resolves: #92352 Releases: master Change-Id: I3fe5d8eb8eaeb77c5502d5b87c8c457d7634f474 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65799 Tested-by:
-
Benjamin Serfhos authored
Releases: master Resolves: #91890 Change-Id: I64d7a355ca4e88b4f73c4cb46fce60ca7b0605c6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65317 Tested-by:
-
Ingo Fabbri authored
FileSpool uses GeneralUtility::mkdir_deep() if path does not exist. mkdir_deep() also tries to fix permissions. Even if this fails, there are further writable-checks down the line in \TYPO3\CMS\Core\Mail\FileSpool constructor. Resolves: #92303 Releases: master, 10.4, 9.5 Change-Id: I4d388ab458455eb1f940e0452fcde07967e1ca67 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65748 Reviewed-by:
Bernhard Berger <bernhard.berger@gmail.com> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92274 Change-Id: Ia8e8fd47389dab32080fa82976d1c72aad5457c9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65668 Reviewed-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
Sascha Egerer <sascha@sascha-egerer.de> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92257 Change-Id: I686d520009ac4fed95127c2c6098109cbc91bf46 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65681 Tested-by:
-
- Sep 20, 2020
-
-
Oliver Bartsch authored
Instead of displaying the JSON value of the `crop` field, which has no value for editors, the otherLanguageContent wizard is replaced with a new wizard which renders cropped thumbnails for other languages by respecting the corresponding cropping configuration. Resolves: #77815 Releases: master, 10.4 Change-Id: I23ed0df13593330b303af1ec71f5a1c49476cf1e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65533 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
-
Georg Ringer authored
To enable image manipulation from external images, the cross origin check is disabled. Resolves: #92224 Releases: master, 10.4 Change-Id: I7ed1366c488f019345f75be3ea300917a57db3d8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65686 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Christian Kuhn authored
When publishing workspace changes to live, many sys_refindex rows are not updated properly, especially if dealing with workspace-new or workspace-moved rows and relations. To update the reference index for relations, the data handler uses class ReferenceIndex, which uses class RelationHandler, which uses PlainDataResolver. All of these classes are workspace aware and pick the current user workspace if not explicitely told otherwise. When publishing records, a given user is currently in some workspace, but the reference index needs to be fixed for live. This explicit runtime workspace switch is lost in the ReferenceIndex. The patch hands over given workspace context from ReferenceIndex to RelationHandler during publish. This one-liner fixes tons of broken reference index cases. It also reveals a couple of still missing entries. Those will be tackled with another patch. Change-Id: Ib7647baad827fa8f148763efe91b331e5ad4484e Resolves: #92348 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65771 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Benni Mack authored
Editors should never see the "editlock" field, which locks the record for editing of admins only. In order to achieve this, the fields pages.editlock and tt_content.editlock are changed to never be shown for non-admins and on top, the field is not shown in setting permissions within be_groups.allowed_exclude_fields anymore. Resolves: #87100 Releases: master, 10.4 Change-Id: I39b9212f0e955fd1a284b15014fcf00078cab16e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65694 Tested-by:
-
Christian Futterlieb authored
Requests to /favicon.ico should not stop rewrite processing. They could trigger a static route or could be handeled by an error handler. Change-Id: Iceff3719604f3d6a2ce2fe2a810cb33e7b4cebb2 Resolves: #92237 Releases: master, 10.4, 9.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65645 Tested-by:
Frank Nägler <frank.naegler@typo3.org> Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Reviewed-by:
-
Stefan Froemken authored
Allow individual Fluid templates for each Plugin while Feature toggle "Fluid based page module" is activated. Resolves: #91920 Releases: master, 10.4 Change-Id: I52537dc2fcb61e16d78ed9bf71945a250a3f2f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65150 Tested-by:
-
Daniel Windloff authored
Show only the default table columns, if no columns are set (backend user configuration). Resolves: #92347 Related: #92154 Releases: master Change-Id: Ib1406a4b693515d1ea799d591657a301c10bb29a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65792 Tested-by:
-
Helmut Hummel authored
Once a page is selected in the page tree, a drag action is initiated and a drop zone created for a delete action on the current page. But since the drag is immediately stopped, without a dragging action, it is necessary to always delete this created dropzone, to avoid that it is created multiple times. To avoid additional flickering of the focus indicator, when selecting a page, the drop zone is hidden by CSS until the page is actually dragged on itself and the dropzone is shown. Releases: master, 10.4, 9.5 Resolves: #92067 Change-Id: I39210d1bcf2ba87370ecc913af382fe50450d742 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65406 Tested-by:
-
- Sep 19, 2020
-
-
Christian Kuhn authored
The reference index can be seen as a cache for relations. It is used in various places to show how many other records have a relation to a given record, for instance in list and filelist module and in the record info modal. In workspaces, new and moved records create records pairs: t3ver_state -1 & 1 and t3ver_state 3 & 4. The backend always shows only one of these pairs. The reference index creates an entry for each record, so two for each pair. This is useless and confusing for editors: If for instance a new file reference is added to a content element in workspaces, the file list shows two usages of the file instead of only one. The patch suppresses reference index entries for the placeholder records - t3ver_state 1 and 3 - so each pair ends up with only one sys_refindex entry. Resolves: #92345 Related: #61917 Releases: master, 10.4 Change-Id: I16ede3a9f1b66a7195526a224e9f1c43c03d7ba6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65767 Tested-by:
-
Daniel Haupt authored
Show the week numbers in DateTimePicker as additional information for editors. Resolves: #92022 Releases: master Change-Id: I6eaa21dcd559717649b3260f1ef1bcb60b7cdb93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65344 Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Reviewed-by:
-
Christian Kuhn authored
Resolves: #92344 Releases: master, 10.4 Change-Id: Ia34b93a6fefaee408da7b54965cf02e138cadf26 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65769 Reviewed-by:
-
Anja Leichsenring authored
The function in question is array_key_first, which was introduced with PHP 7.3.0. It is not available for PHP 7.2 testing, so a workaround was introduced. Resolves: #92343 Releases: master, 10.4 Change-Id: Id0eaceefb4fb5581b8f3a25de8d43819b9389d76 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65768 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
- Sep 18, 2020
-
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92261 Change-Id: I9fe2fc72a60e794a03663625ea7ec3e40984b04b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65660 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92272 Change-Id: I83c32dfcd22dfb9d3e5f4d968ab5290f550f3e79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65667 Tested-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92258 Change-Id: Ifb2a7a9879e4e6d826137567a5224adef33eadc1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65678 Tested-by:
-
Daniel Windloff authored
Merge the methods `init()` and `main()` to the `mainAction()` method. Remove unnecessary properties, which were only used to transfer values between these methods. Initialize `siteLanguages` with the current page uid. Releases: master Resolves: #92308 Resolves: #90966 Change-Id: Iafd45ebeb06e8c61dac9e9ed865e40bc999ab54a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65739 Tested-by:
-
Daniel Windloff authored
Use `editContentPermissionIsGranted()` to calculate the permission to cut records (except pages). Releases: master Related: #89465 Resolves: #92307 Change-Id: I387c486c3814c3e5b6f4959d6c725ff59562c32e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65736 Tested-by:
-
Uwe Trotzek authored
When a users sends a draft version to another stage a modal opens to let the user decide which users should be notified about this. This patch ensures that only the selected persons will get an email. Prior to this only the last user of the list got an e-mail. Resolves: #92316 Change-Id: Ia4014878f6b30a3773b5d38e01d5379094394c32 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65746 Tested-by:
-
Oliver Bartsch authored
Add possibility to use language labels as value for the user TSconfig `options.bookmarkGroups` option. Resolves: #15760 Resolves: #92337 Releases: master Change-Id: I0e0e2467b8ab87b05ec432f09d65abc676081228 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65764 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Reviewed-by:
-
Benni Mack authored
In order to ensure PHP 8 compatibility, PHP methods should not have optional arguments BEFORE required arguments. Resolves: #92140 Releases: master Change-Id: Ia9ee2ba12af0301d7bf2a0defbe6ad64674c1a71 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65742 Tested-by:
-
Oliver Bartsch authored
The fluid based page module used a non existing variable to access the language id of a column. This lead to passing `NaN` as language id to the DataHandler when moving a content element in the corresponding column. Therefore the content element was actually moved to the default column because of the changed language. The template is now accessing the correct variable fetched from the SiteLanguage object which makes moving content on translated pages possible again. Resolves: #92086 Releases: master, 10.4 Change-Id: I6fb95338e47e9ad5b0a3f637f6b637174271ba35 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65691 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
-
Oliver Bartsch authored
To not falsely show content as "unused" if not translated yet, content fetcher must respect the language, selected for columns mode, in the fluid based page module. Resolves: #91350 Releases: master, 10.4 Change-Id: If0abbc4572706c54d9b8bdc18b4bc02d0ec3240b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/64507 Tested-by:
-
Benni Mack authored
Since the removal of "pid=-1" in TYPO3 v10, it is not necessary to fix the versioning PID for all versioned records anymore. The checks in BackendUtility::fixVersioningPid() and PageRepository->fixVersioningPid() are cleaned up, because: * The only version type that has a DIFFERENT page ID than its online pendant is the MOVE_POINTER (t3ver_state=4) * The MOVE_PLACEHOLDER does not contain a t3ver_oid and is not evaluated ever in these methods * All other t3ver_state items have the same PID as the live version, and should not be evaluated. Resolves: #92314 Releases: master, 10.4 Change-Id: I0551547bd2bb9f469ed3a68396b74c0d4de1a18d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65705 Tested-by:
-
Christian Kuhn authored
There are 4 "drop record" scenarios in workspaces: * Delete a new or changed record in list/page module * Create a delete placeholder in list/page module to mark a live record as to-be-deleted on workspace publish * Discard (throw away) a change in workspace module * Flush all workspace changes by deleting a sys_workspace record. All these scenarios are handled with the same DataHandler code which leads to tons of bugs since especially "delete & create delete placeholder" compared to "discard & flush" are logically different things. The patch separates discard and flush to a new codebase. First patch sets started with a 1:1 copy of the delete code, then carefully refactored the code to its final state. The roughly 850 lines of delete code are streamlined to about 300 lines for discard and flush. The code is much easier to follow, recursions are simplified and access checks are in one place. Discard previously created a mixture of hard and soft deleted records in the database, leading to a huge mess. This changed: Discard now always means that records are dropped from database. The discard code now properly cascades down into relations, solving tons of bugs along the way. The functional DataHandler tests are refactored and heavily extended to cover discard. Two previously existing issues are not fixed yet: ManyToMany relations are not properly cleaned up on discard, and discarding does not fully follow localization overlays in 'connected' mode. Those scenarios are marked with @todo's in the .csv files and should be relatively easy to solve with dedicated single patches. Change-Id: Ie33dd2bdc333a4d8ed9314b7520212cc11942c89 Resolves: #85778 Resolves: #92336 Releases: master, 10.4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65638 Tested-by:
-
Oliver Bartsch authored
All FAL tags must be uppercase as otherwise they are suggested multiple times in the View Upgrade Documentation module. Resolves: #92342 Releases: master, 10.4 Change-Id: Ib86882151ccf19a40204e882eef3dca8c977244e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65765 Tested-by:
-
Frank Naegler authored
The existing console command can also be executed as a scheduler task, for this reason, we remove the scheduler task. Resolves: #92339 Releated: #91712 Releases: master Change-Id: Iab9d855360bf022a91e93b668ade912968844f62 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65760 Reviewed-by:
Simon Gilli <typo3@gilbertsoft.org> Reviewed-by:
-
Alexander Schnitzler authored
This patch fixes incompatible type usage in function arguments and is preparatory work for introducing native type hints and strict mode in all core files. Releases: master, 10.4 Resolves: #92266 Change-Id: I3668e18896478da791e606f240ed321f65d50e7d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65672 Tested-by:
-
Anja Leichsenring authored
used commands: composer remove rector/rector --no-update-with-dependencies The groundwork to use rector as a integrity check is not yet done. In order to remove a dependency from the set, the package is removed. Resolves: #92332 Related: #89785 Releases: master, 10.4 Change-Id: I7b965c9826dc45bb8409d4460e9dcb071aa83c68 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65750 Tested-by:
Richard Haeser <richard@richardhaeser.com> Tested-by:
-
Nikita Hovratov authored
The toggleContainerControls method of InlineControlContainer.ts now only toggles its immediate controls. Furthermore, the new record link control for creating inline records has gotten the required class to toggle its visibility, when reaching maxitems limit. Resolves: #91808 Releases: master, 10.4 Change-Id: Ic8988943c349c874b6d9b7427a42c224dca1ded1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65058 Tested-by:
-
- Sep 17, 2020
-
-
Benni Mack authored
The database fields "be_users.options" ("Mount from groups") and "be_users.workspace_perms" (Allow editing on live workspace) use the Page Permission class for checks, which is semantically incorrect. The patch adapts the according changes in BackendUserAuthentication. Resolves: #92208 Releases: master Change-Id: Iec805fbc3ff3a72cfcdbdb67e6868c4389e8e688 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65586 Tested-by:
-
