- Apr 16, 2022
-
-
Oliver Klee authored
Having a CODE_OF_CONDUCT.md document that links to the TYPO3 code of conduct provides users who view the project source on GitHub easy, direct access to the full text. Releases: main, 11.5, 10.4 Resolves: #97376 Change-Id: I6509b402a5229cbd926ce42b4fd6a1c0e60e0fc2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74291 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Mathias Bolt Lesniak <mathias@pixelant.no> Tested-by:
Nikita Hovratov <nikita.h@live.de> Tested-by:
Lina Wolf <112@linawolf.de> Reviewed-by:
-
Oliver Klee authored
The new version finds some new possible bugs and removes some incorrect ones. Also update phpstan/phpstan-phpunit. Used commands: > composer req --dev phpstan/phpstan:^1.5.6 > composer req --dev phpstan/phpstan-phpunit:^1.1.0 > Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97397 Releases: main, 11.5 Change-Id: I052ba01b33582f3f18f49c0ee2375f63d1048f4b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74325 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Benni Mack authored
This change uses constants from PageRepository to define possible doktypes. In addition, some minor details in the rest of the code (strict types, variable renaming) help to understand the code better. Resolves: #97399 Releases: main Change-Id: Id275edc131b2406f346418eecc099fd1f0b2ac05 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74328 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Nikita Hovratov authored
Resolves: #97394 Releases: main Change-Id: I635443e00d953543aa5950ac7516d97d61015a2d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74322 Tested-by:
Christoph Schwob <christoph@websailor.at> Tested-by:
-
Benni Mack authored
This change replaces the last occurrence in TSFE to avoid use GeneralUtility::getIndpEnv() Resolves: #97398 Releases: main Change-Id: I83686b89d05523eb53a695e855271490e70d06cc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74327 Tested-by:
Oliver Bartsch <bo@cedev.de> Tested-by:
-
- Apr 14, 2022
-
-
Imko Schumacher authored
The SlugHelper now receives the current workspace id and applies the correct workspace constraint. Resolves: #96853 Releases: main, 11.5 Change-Id: I3ab2bf850a5fa63300f6715a6dca9c223f524670 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73449 Tested-by:
-
Oliver Klee authored
This field actually is nullable and needs to be annotated accordingly. This change fixes a PHPStan warning. Resolves: #97385 Releases: main, 11.5 Change-Id: If64d64665e0ffd9419d51fcda2b84befa8ebceef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74320 Tested-by:
-
Nikita Hovratov authored
It can be very hard to debug, which field in particular has failed, when the DataHandler only mentions the invalid value without any context. Therefore, the field name and the table name are now always added to the log message. This has been done for the type "link" and type "email" field. Note: For FlexForm fields the name of the table column is logged, as it is not feasible to account for the full path, especially in sections. Resolves: #97351 Releases: main Change-Id: I9172e40a2af7947fd858fc8a9f2a6dc842205aa6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74263 Tested-by:
Susanne Moog <look@susi.dev> Reviewed-by:
Jörg Bösche <typo3@joergboesche.de> Reviewed-by:
-
Shehfinaz Kadavil authored
Different asset types could be collected using the central assets collector '\TYPO3\CMS\Core\Page\AssetCollector'. However, it was not possible to check if a specific assets has been added already. This patch adds corresponding has() methods for the asset types to the collector class to give extension developers the ability to check and react before adding assets under the same identifier. Added methods: * hasJavaScript(...) * hasInlineJavaScript(...) * hasStyleSheet(...) * hasInlineStyleSheet(...) * hasMedia(...)` Resolves: #91715 Releases: main Change-Id: I6b9de2249719cb56a55049116d74e5ae06fc7029 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74162 Tested-by:
-
Oliver Bartsch authored
* $parameters->additional might not be set, depending on the workspace configuration * There might be no "next" or "prev" stage, depending on the current stage Resolves: #97368 Releases: main, 11.5 Change-Id: Ic1a5452adb33f900bc2c8c0c86ee1d5d9849d290 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74283 Tested-by:
-
Oliver Bartsch authored
In some situations, "_page" might not be set in the Route. This patch prevents undefined array key warnings and also makes the code more readable. Resolves: #97369 Releases: main, 11.5 Change-Id: I47920cdeb641b52577590d710d692a91fca7c383 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74284 Reviewed-by:
-
- Apr 13, 2022
-
-
Stefan Bürk authored
doctrine/dbal has deprecated multiple methods in the class 'ExpressionBuilder'. Luckily, the core already implements a facade of this class and the proper forward-compatible implementation has been provided with #97081 to pave a seamless migration path for extension developers, which have to support multi-core versions without deprecation messages. Core usages have been replaced with #97110. Additionally, usages in typo3/cms-styleguide have been properly replaced as a preparation for the deprecation with: https://github.com/TYPO3/styleguide/pull/303 This patch finally deprecates these methods to avoid further usage. Resolves: #97354 Related: #97110 Related: #97081 Releases: main Change-Id: Ie2469faa65fe1e6553d83f2552743af85207f086 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74265 Tested-by:
-
- Apr 12, 2022
-
-
Oliver Bartsch authored
TCA type "datetime" allowed the value to be a native type (with `dbType`), a int with `eval=int` or a simple string. Since the value is always a timestamp - in case no native type is used - the `eval=int` option is removed and the value is always handled as integer. Note: Due to various problems with migration of existing fields, this patch does not yet enforce the database field to be of type "integer". This will be done step by step in further patches, e.g. https://review.typo3.org/c/Packages/TYPO3.CMS/+/74281 Resolves: #97358 Releases: main Change-Id: Ia8297854fb75241660ffa2a9df850b22dd7a0b84 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74205 Tested-by:
-
Eric Bode authored
The CropViewHelper does not have a "length" argument, but the "maxCharacters" argument is mandatory. From the context it is clear that the wrong argument was accidentally used here and that this needs to be renamed. Releases: main, 11.5, 10.4 Resolves: #97362 Change-Id: I4e8b443f48006024a5949a143f50ed309cdd3d9c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74276 Tested-by:
-
Josef Glatz authored
Releases: main Resolves: #97356 Change-Id: I23a2dae1c18af5746be20d30034ce89332088326 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74268 Tested-by:
Josef Glatz <josefglatz@gmail.com> Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Bartsch authored
The recently introduced buttons for the secondary action items in the record and filelist do now define a title, which is then displayed as tooltip. Also the translate file metadata control does now display a tooltip. Note: The tooltips are added to the container elements, since the button elements already define data-bs-toggle="dropdown" and bootstrap only allows one instance per element. Resolves: #97359 Releases: main, 11.5 Change-Id: Ib5ccc55c6c17b6d3e0c508c8e3b5819ce03944bb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74270 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Reviewed-by:
-
Susanne Moog authored
The TYPO3 request already contains a "disentangled" array of UploadedFile objects. With this change, these UploadedFile objects are now used instead of the superglobal $_FILES in extbase requests. Additionally, the FAL ResourceStorage has been adjusted for handling UploadedFile objects and the ExtensionManager upload handling has been adjusted. The next step would be to further adjust FAL to use only PSR provided methods for handling uploaded files and to implement an API for file uploads in Extbase. Resolves: #97214 Releases: main Change-Id: I4733c9c879ae3b27725f3546cc344d648dd8180a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73868 Tested-by:
-
- Apr 11, 2022
-
-
Oliver Bartsch authored
A check in the FormEngine JavaScript component is fixed, preventing a corresponding error when changing the value of a single option group field, e.g. the "content_from_pid" field in pages. Resolves: #97342 Related: #95137 Releases: main, 11.5 Change-Id: I8c27f9ee4eddb032ec51ef66db99da3bf3c5a8d3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74252 Tested-by:
-
Oliver Bartsch authored
The default duplication behaviour action for the file upload is now properly assigned to the view again. Resolves: #97357 Releases: main, 11.5 Change-Id: Id472dff8154dd4263827863a118f5da4390a7924 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74269 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Oliver Bartsch authored
The page module displays an information on pages, which use the content_from_pid ("Show Content from Page") feature. However, if the referenced page is invalid, e.g. because it does no longer exist, the infobox now informs the user accordingly like it's already done for invalid shortcut configurations. Resolves: #97341 Releases: main Change-Id: I89a8cb6e7e7b79aad19e69a5c8feff072e8e81f8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74231 Tested-by:Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
- Apr 09, 2022
-
-
Oliver Bartsch authored
Like for all other elements using the visible / hidden input field strategy, the visible field is initialized with an empty string. The $itemValue is only added to the hidden field. Resolves: #97304 Releases: main Change-Id: Id181a0d121375b6874657cbcf6665d9b9e6ab235 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74262 Tested-by:
-
- Apr 08, 2022
-
-
Nikita Hovratov authored
The "langLabel" field might be already translated instead of a "LLL-string". This causes the TranslateViewHelper to throw an exception, because it doesn't know what to do. The better way is to translate this field already in the controller, where LanguageService can be used directly, without failing if no extension key can be found. Resolves: #97349 Related: #97312 Releases: main Change-Id: I06f759b1c0961a26e5236d576948aecc1acc0d9b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74261 Tested-by:
-
Larry Garfield authored
Nothing particularly exciting, but does remove another PHPStan baseline message. A few bits of unnecessary code have been removed or cleaned up. Additionally, a few locations in code were calling CommandUtility::exec() incorrectly in a way that has always been incorrect. These are fixed now. Resolves: #97206 Related: #97210 Releases: main Change-Id: Ia590af575c432833097859a22f6674c4917e59a1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/73988 Tested-by:
-
Shehfinaz Kadavil authored
Warmup for frontend caches is not immplemented by TYPO3 core, but may be provided by third party extensions. Adapt the cache:warmup command description that frontend warmup may not be implemented/available. Resolves: #95058 Releases: main, 11.5 Change-Id: Iab4634ac96b3061876d970f6c38a88b8687648fe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74197 Tested-by:
-
Benjamin Franzke authored
The default light system-ui scrollbars are very distracting on the dark module menu surface. Therefore they are now replaced by a more appealing dark-mode scrollbar style, as provided by the browser vendor. Resolves: #95047 Releases: main, 11.5 Change-Id: Iecba9635118f4dc4ba612b286abe4562b53c5b75 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/68841 Tested-by:
Jonas Eberle <flightvision@googlemail.com> Tested-by:
-
Georg Ringer authored
Info boxes are shown in the page module for pages like "link to external url" or "Shortcut" if a relevant field is not filled. The current page title doesn't help at all and is shown below anyway. Therefore it can be removed. Resolves: #97334 Releases: main Change-Id: I33dc90e09129827d706fe7a85781071fa0af570b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74223 Tested-by:
-
Nikita Hovratov authored
It was forgotten to migrate the subtle TCA inside of form finisher YAML files. This has been done now. Resolves: #97338 Related: #97267 Related: #97035 Releases: main Change-Id: I8bf8f81bb34435359e6ff3508985f89cd000e5a8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74229 Tested-by:
-
Benjamin Franzke authored
This reverts commit a42649bd. Reasons for revert: * Missing commit message description: It deserves a description of the global scope/direction and a reference to the preparation by the UX initiative * The change was merged too quickly Resolves: #97319 Reverts: #97306 Releases: main Change-Id: I51eceefa913e13d169cafd69e9e04d08a77d1443 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74200 Tested-by:
Mathias Schreiber <mathias.schreiber@typo3.com> Tested-by:
Lidia Demin <typecat@gmx.net> Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Benjamin Franzke authored
All pagetree actions that use the "RecordCommit" endpoint (tce_db) (which is loaded in to the main list_frame) need to avoid requesting an explicit and too early page tree update from the server, as the page data may not have been updated at that point. The pagetree refresh actually is and needs to be triggered by an immediate action pushed by the RecordCommit endpoint. (in the list frame via <typo3-immediate-action> element) An early-refresh call – prior to the persistence of the record action – causes stale data to be fetched and displayed when that request ends up to be processed after the record commit request (that is the "race" that causes this to only happen sometimes). Example: Page icon sometimes doesn't change on deactivation. Affected page tree actions are: * disable/enable page * hide/show in menu * past into/after Note that these actions should ideally be migrated to AjaxDataHandler. Once that's done, the pagetree refresh can be added back. Resolves: #94393 Resolves: #95499 Releases: main, 11.5 Change-Id: I4e4059da78cf5b5bfebc5d67aacc89332a67d750 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74224 Tested-by:
-
Susanne Moog authored
Thanks to backend routing, we are now able to provide a direct link to the currently rendered backend page via the admin panel. Releases: main Resolves: #97326 Change-Id: Ibfabcf56139cdfefdd4e8a8bc315d9622c00f939 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74212 Tested-by:
-
Georg Ringer authored
Check if the fileTarget is set before using it. Resolves: #97329 Releases: main, 11.5 Change-Id: Ibf5bf12600717acf1b705773655bf2d35c352502 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74218 Tested-by:
-
Oliver Bartsch authored
- 'eval=int' does not exist for type=group - Empty 'eval' is superfluous Resolves: #97335 Releases: main, 11.5 Change-Id: Id12c15fcc6465def1836ff6c5c435c8be75ac4ba Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74225 Tested-by:
-
- Apr 07, 2022
-
-
Benjamin Franzke authored
The pagetree contextmenu click (right click) on node backgrounds must not trigger both, the system contextmenu and the TYPO3 context menu. This has already been done for node-texts, but the default event prevention was missing for node backgrounds. Therefore the native contextmenu is now also prevented whenever the custom context menu is triggered. Resolves: #97331 Releases: main, 11.5 Change-Id: I9a0ffcd6eb843fc2f13fa0da47480df2e99fdbe1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74220 Tested-by:
-
Oliver Bartsch authored
The SiteConfigurationController does its own evaluation of field values based on the "fake" TCA. With #97035, the required flag was added, which replaces the corresponding "eval" option. This patch adjusts the SiteConfigurationController to handle the new option accordingly. Resolves: #97332 Related: #97035 Releases: main Change-Id: I3d828f6318fc70b260d20d727bfc45cc60ec1164 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74221 Tested-by:
-
Oliver Bartsch authored
This migration was forgotten while introducing TCA type "number" in #97193. Resolves: #97333 Related: #97193 Releases: main Change-Id: I98a468a6938978969e79656cb3458f24faea90c3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74222 Tested-by:
-
Andreas Fernandez authored
The clipboard component uses a Bootstrap panel and is also wrapped by row/col elements, whose are superfluous. This patch removes the superfluous divs. Resolves: #97328 Releases: main, 11.5 Change-Id: Ic7c93592b5c8c2dc3315014bc8484af8c10b0aab Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74216 Tested-by:
-
Oliver Bartsch authored
Modules can use static strings instead of locallang labels. Therefore, all usages must also define the value as "default" to prevent a RuntimeException. This is now fixed in the About module. Resolves: #97325 Releases: main Change-Id: Ie6c4ac0ce973c5647e588c778929b10896eec100 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74213 Tested-by:
-
linawolf authored
Follow up on files not changed by https://review.typo3.org/c/Packages/TYPO3.CMS/+/74128 Releases: main Resolves: #97327 Related: #97258 Change-Id: Ie2b8536c180847928a67e20e23eaf46f48af4022 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74215 Tested-by:
-
Andreas Fernandez authored
The determination of the duration used in Notification.showMessage() now takes `SeverityEnum.error` into account and sets the duration to 0, which is the same behavior when using `Notification.error()`. Resolves: #97315 Releases: main, 11.5 Change-Id: I1d6f50cc81c8a92031a570eae4e0bffc2b5441a7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74195 Tested-by:
-
Oliver Bartsch authored
Resolves: #97322 Releases: main Change-Id: I0565905201bd7456dae171d2435925c996bfb1b3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74204 Tested-by:
-
