[TASK] Use File constants in sys_file TCA file

Resolves: #97394
Releases: main
Change-Id: I635443e00d953543aa5950ac7516d97d61015a2d
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74322


Tested-by: core-ci <typo3@b13.com>
Tested-by: Stefan Bürk <stefan@buerk.tech>
Tested-by: Christoph Schwob <christoph@websailor.at>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Stefan Bürk <stefan@buerk.tech>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christoph Schwob <christoph@websailor.at>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>

typo3/sysext/core/Configuration/TCA/sys_file.php

@@ -11,11 +11,11 @@ return [
         'default_sortby' => 'name ASC',
         'typeicon_column' => 'type',
         'typeicon_classes' => [
-            '1' => 'mimetypes-text-text',
-            '2' => 'mimetypes-media-image',
-            '3' => 'mimetypes-media-audio',
-            '4' => 'mimetypes-media-video',
-            '5' => 'mimetypes-application',
+            \TYPO3\CMS\Core\Resource\File::FILETYPE_TEXT => 'mimetypes-text-text',
+            \TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE => 'mimetypes-media-image',
+            \TYPO3\CMS\Core\Resource\File::FILETYPE_AUDIO => 'mimetypes-media-audio',
+            \TYPO3\CMS\Core\Resource\File::FILETYPE_VIDEO => 'mimetypes-media-video',
+            \TYPO3\CMS\Core\Resource\File::FILETYPE_APPLICATION => 'mimetypes-application',
             'default' => 'mimetypes-other-other',
         ],
         'security' => [
@@ -68,12 +68,12 @@ return [
                 'type' => 'select',
                 'renderType' => 'selectSingle',
                 'items' => [
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.unknown', 0],
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.text', 1],
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.image', 2],
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.audio', 3],
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.video', 4],
-                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.software', 5],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.unknown', \TYPO3\CMS\Core\Resource\File::FILETYPE_UNKNOWN],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.text', \TYPO3\CMS\Core\Resource\File::FILETYPE_TEXT],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.image', \TYPO3\CMS\Core\Resource\File::FILETYPE_IMAGE],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.audio', \TYPO3\CMS\Core\Resource\File::FILETYPE_AUDIO],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.video', \TYPO3\CMS\Core\Resource\File::FILETYPE_VIDEO],
+                    ['LLL:EXT:core/Resources/Private/Language/locallang_tca.xlf:sys_file.type.software', \TYPO3\CMS\Core\Resource\File::FILETYPE_APPLICATION],
                 ],
             ],
         ],