- Jul 19, 2022
-
-
Anja Leichsenring authored
These raises fix the bulk of PHP 8.2 unit test fails. We need to make webmozart/assert:^1.11.0 explicit to pin it as minimum version for PHP 8.2 composer update --prefer-lowest in nightlies. We don't strictly need the phpunit raise, but pick it as casual dev update along the way. $ composer require --dev phpunit/phpunit:^9.5.21 $ composer require --dev webmozart/assert:^1.11.0 Resolves: #97967 Releases: master, 11.5 Change-Id: I5c79a8577c5eb836566cb5c00bb6b63aa1b7ea1f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75241 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
ToGetATockenOnly authored
Releases: main, 11.5 Resolves: #97965 Change-Id: I6e03354925b4ecb9c3f72554862a01057851f48b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75239 Tested-by:
Stefan Bürk <stefan@buerk.tech> Tested-by:
-
- Jul 18, 2022
-
-
Sascha Egerer authored
If a page of type external link does not have a "target" defined the fallback should be used. This behavior has been changed in #96470 so the fallback is not used anymore as an empty string is also respected as a valid value but should not. Resolves: #97964 Related: #96470 Releases: main, 11.5 Change-Id: I8270aec774a342151eee47000386546e3d5ac70c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75234 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
With the new TypoScript parser, we should start phasing out TemplateService (tsfe->tmpl in FE). One of it's usages in Frontend is tmpl->rootLine. This property looks as if it's identical to tsfe->rootLine, but it isn't, since it's in a different order and stops at sys_template records with root flag. However, tmpl->rootLine is also assigned in Frontend as tsfe->config['rootLine']. The patch changes all usages of tmpl->rootLine to this and sanitizes access along the way. Additional comments now document the subtle differences. We do not add a deprecation at this point, since the entire class will be fully deprecated later. Note the new TypoScript parser construct can not expose this "local" or "partial" rootLine yet. The TypoScript/IncludeTree/TreeBuilder class will be refactored a bit with an additional patch when the new parser is being used in the Frontend. Change-Id: Ic97d0c7344711d07d2ff672ca3b2968ef9383c14 Resolves: #97963 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75232 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
Nikita Hovratov <nikita.h@live.de> Reviewed-by:
-
Chris Müller authored
Resolves: #97966 Related: #96515 Releases: main Change-Id: I057a73cc00ad5789aa998c845c16e04965c99ead Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75238 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Lina Wolf authored
Fix case and some additional syntax Releases: main Resolves: #97734 Change-Id: Iee717894e5d35255163e6cd4a665c3c75d90e6a5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74819 Tested-by:
Chris Müller <typo3@krue.ml> Reviewed-by:
-
- Jul 16, 2022
-
-
Oliver Klee authored
This allows us to see whether a new PHPStan version causes any baseline changes, or whether an update of any other dependency brings some interface changes that affect our type checks. Resolves: #97955 Releases: main Change-Id: I436acc5f25331db6783aebdc12c94edbe85f1eed Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75203 Tested-by:
-
Oliver Klee authored
Used commands: > composer req -W doctrine/annotations:^1.13.3 doctrine/dbal:^3.3.7 \ doctrine/event-manager:^1.1.1 > composer req doctrine/annotations:^1.13.3 doctrine/dbal:^3.3.7 \ doctrine/event-manager:^1.1.1 -d typo3/sysext/core --no-update > composer req doctrine/dbal:^3.3.7 -d typo3/sysext/install --no-update > composer req doctrine/dbal:^3.3.7 -d typo3/sysext/redirects --no-update Also make use of a Doctrine-DBAL-provided PHPStan/Psalm type to satisfy the required types for the new DBAL version. Resolves: #97956 Releases: main Change-Id: Ia193947df78c67c60f5861ca1f9912eacbf5b980 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75204 Tested-by:
-
Stefan Bürk authored
With #80398 support to set `tableoptions` to proper charset and collate has been added. This setting has been passed through the `doctrine/dbal` connection params and manually set to the schema config for database compare, if it has been set. The choosen key `tableoptions` however is not a valid key for `doctrine/dbal` connection params. `doctrine/dbal` ships proper PHPStan/Psalm type definitions for the param array now, and mumbles about this key. This patch transform the `tableoptions` to the proper `doctrine/dbal` `defaultTableOptions` in the `ConnectionPool`, only transporting the valid params with the connection. Places which handled the invalid `tableoptions` are changed to use `defaultTableOptions` instead. This prepares the ability to raise `doctrine/dbal` dependencies and phpstan with #97956. Full migration with configuration cleanup may be done in a dedicated patch with proper documentation of that change in v12 only. Resolves: #97961 Related: #80398 Related: #97956 Releases: main, 11.5 Change-Id: I33ddc1ae1bebb77e5d64d17e5fbc19eb0e2dc495 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75211 Tested-by:
-
Christian Kuhn authored
This establishes the first usage of the new TypoScript parser and leverages some of its improved functionality: A rewrite of the template analyzer backend module based on the new parser gives a series of new features. Most importantly, the TypoScript include tree now resolves all @import and INCLUDE_TYPOSCRIPT includes and shows them as single nodes within the include tree. Additionally, the template analyzer is now condition aware: It finds all conditions within the include tree and allows to simulate include tree restrictions based on condition verdicts. The major outcome of this is that the analyzer now shows in-depth includes and allows much more fine grained analysis of all includes that play a role on a single page. Known issue: t3editor (codemirror) sometimes fails to initialize properly to render TypoScript source when clicking a node in the include tree. This is probably some JavaScript load-order race condition and will be tackled with a dedicated patch. Change-Id: I2761e1dfc9e511904b73d48de41198b84aee6447 Resolves: #97941 Related: #97816 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75178 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Christian Kuhn authored
This resolves a mixup in ext:recordlist: The "Browser" classes are the "element browser" modals, used when adding FAL images to records and when adding relations for type="group". The "LinkHandler" classes are a distinct construct used to create the "t3://" syntax when linking record fields and RTE text to a page, telephone, external URL and so on. They are rendered as single tabs in the link handler modal. Class LinkHandler/RecordLinkHandler allows linking to arbitrary records. Typical example is linking to single ext:news records, which can be configured using PageTsConfig TCEMAIN.linkHandler. Class LinkHandler/RecordLinkHandler misuses the element browser abstraction to list records. This materializes in class Browser/RecordBrowser, which is not used as element browser as such, but is just a client class of LinkHandler/RecordLinkHandler. The two class namespaces however shouldn't interfere with each other. The patch resolves this by moving the code from Browser/RecordBrowser into LinkHandler/RecordLinkHandler and streamlining it to what is really needed. A series of changed and added comments should improve the overall constructs along the way. Resolves: #97957 Related: #66373 Related: #97188 Related: #96639 Releases: main Change-Id: I3028ce439e6ae68c4ed34c0c560b4980dad6ac29 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75205 Tested-by:
-
Oliver Klee authored
PHPStan 1.8.1 removes one warning. Used commands: > composer req --dev phpstan/phpstan:^1.8.1 > ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline Resolves: #97959 Releases: main, 11.5 Change-Id: Ifaaf37add767f98d16b3e847447a2882c3c77ee8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75208 Tested-by:
-
Christian Kuhn authored
Patch level raise of a monorepo --dev dependency as yet another raise to unblock psr/container:^2. $ composer req --dev bnf/phpstan-psr-container:^1.0.1 Change-Id: I73da5737bfbad6dfb739f5f56732d5d283e3e372 Resolves: #97958 Releases: main, 11.5 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75206 Tested-by:
-
Oliver Klee authored
Resolves: #97892 Releases: main Change-Id: Ib704bd1dbf8fb1be71ff80748c379273ded6552b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75096 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I80174038e54ce41dfbde5e5e35339b0a7429be4e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75199 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
Nikita Hovratov authored
Resolves: #97953 Releases: main, 11.5 Change-Id: Ie152dfdb8c08f20a835ac9a1c8cf56f1206c4fa1 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75201 Tested-by:
Björn Jacob <bjoern.jacob@tritum.de> Tested-by:
-
Oliver Bartsch authored
Resolves: #97767 Releases: main, 11.5 Change-Id: I1c874770ad1201e22a95d0af67e7caf4b09a8aa3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75198 Tested-by:
-
- Jul 15, 2022
-
-
Oliver Bartsch authored
The new PSR-14 AfterPageTreeItemsPreparedEvent is added. The Event gets dispatched in the TreeController and allows to further modify the resolved and already prepared page tree items before being returned. The new event is directly used by EXT:workspaces to apply the highlighting of versioned pages. Using this new event allows to remove another cross dependency of EXT:backend. Additionally, the hooks $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['hasPageRecordVersions'] and $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['TYPO3\CMS\Workspaces\Service\WorkspaceService']['fetchPagesWithVersionsInTable'] are now removed, since this can now be done using the new PSR-14 Event. Resolves: #97945 Releases: main Change-Id: I2fa8df42f1820c9d6592d5a0654de9ada050e71c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75184 Tested-by:
-
Oliver Bartsch authored
This reverts commit 88a8a246. Reason for revert: Accidentally merged without enough votes. Mixed up with a backport. Change-Id: Ice9ccc3cf27758673358f1b6501c3f71130e732d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75149 Tested-by:
-
Oliver Bartsch authored
Replace wrong null fallback for "width" and "height" with empty string and also cast the values before passing to GraphicalFunctions->getImageScale() which expects them to be string. Resolves: #97952 Releases: main, 11.5 Change-Id: I3c2eafd89f81f0b5d606a1c936c43a8bca57659c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75197 Tested-by:
-
Georg Ringer authored
The provided width and height must be cast to a string to avoid notices. Resolves: #97911 Releases: main, 11.5 Change-Id: Ifa7428571026fbd0b0905729ea8ad699ab080bcb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75196 Reviewed-by:
-
Andreas Fernandez authored
The templates used for the element browser are now separated into several templates, based on their usage. The element browser used in combination with FAL does not share the template with the folder-based element browser anymore. Resolves: #97933 Releases: main Change-Id: Ia1c4278c8fb656c8979dec9b60f2f892af18bd4d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75172 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Benni Mack authored
When AbstractContentObject is fetching ->getPageRepository() but TSFE hasn't been fully initialized yet, the Context from TSFE should be used, and not the global one. Resolves: #97951 Releases: main, 11.5 Change-Id: I99880839f5458469e7181467de6a8fb667ef9828 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75194 Tested-by:
Rafael Kähm <rafael.kaehm@dkd.de> Tested-by:
-
Stephan Großberndt authored
This change makes sure hyphens are kept as part of a word instead of removing them. Removing them led to "casesensitive" instead of "case-sensitive" being lexed and added to the index, which in turn led to that occurrence not being found when searching for "case-sensitive". Releases: main, 11.5 Resolves: #93401 Resolves: #77644 Change-Id: I72f8d297384cea002e1ca6cb8e3b1973774199f2 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/71885 Tested-by:
Tomas Norre Mikkelsen <tomasnorre@gmail.com> Tested-by:
-
Andreas Fernandez authored
FontAwesome will be phased out in a short while. As a precursor patch, login providers are prepared to accept a new option `iconIdentifier` which takes any icon from the Icon Registry. To ease the migration for 3rd party extension authors, this patch is aimed to be backported to v11. To make the login view itself a bit more logical, the link to reset a user's password is now moved above the available login providers. Resolves: #97950 Releases: main, 11.5 Change-Id: I96f6026c6726cf9dbc2635484bc7ad527f70b4d7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75191 Tested-by:
-
Christian Kuhn authored
Creating a version overlay of a record that has flexform sections and moving or deleting some of these sections at the same time fails in DataHandler due to a wrong uid lookup for the section command array. The patch fixes this scenario in the DataHandler flexform processing code and leaves an according explanation comment. Resolves: #73761 Releases: main, 11.5 Change-Id: Ib1c910c59a2ebfe9b7545cabb258f44bac2cd273 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75116 Tested-by:
Tina Westner <tina.westner@bgm-gmbh.de> Tested-by:
-
Jochen Roth authored
Resolves: #97931 Releases: main, 11.5 Change-Id: I745bffa0c6873f6b8ff5fb15f32da4cd6538959a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75170 Tested-by:
-
Andreas Fernandez authored
The CSS of @typo3/icons has changed with v3, but the web component `typo3-backend-icon` was not updated accordingly, which may cause glitches in the rendering. The CSS is now updated accordingly to match the CSS of @typo3/icons v3. Resolves: #97876 Releases: main Change-Id: I3149e3b1ef31d2766143589fc9fef4b0ee4b9616 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75051 Tested-by:
-
- Jul 14, 2022
-
-
Sybille Peters authored
Resolves: #97946 Releases: main Change-Id: I3454255329a5cac29fa5ee8ed78f78ca47133e89 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75185 Tested-by:
-
Oliver Klee authored
This helps static code analysis in extensions. Resolves: #97893 Releases: main, 11.5 Change-Id: Ie2eee8244438cc8d4624608ce261f5418540c672 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75097 Tested-by:
-
Frank Naegler authored
Resolves: #97036 Releases: main, 11.5 Change-Id: I4342011309a35233d278aec73e36a6dcf542babc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75131 Tested-by:
Oliver Hader <oliver.hader@typo3.org> Reviewed-by:
-
Benni Mack authored
This change adapts the QuerySettings functionality for Extbase in v12 to allow to work with a LanguageAspect which contains all information regarding the language ID and the overlay mode. For this reason, the following method definitions are removed within Extbase's QuerySettingsInterface - setLanguageOverlayMode() - getLanguageOverlayMode() - setLanguageUid() - getLanguageUid() However, it is still possible to use the existing methods on the QuerySettings implementation of TYPO3 for TYPO3 v12. It is now recommended to use ->getLanguageAspect() and ->setLanguageAspect(). This change is a pre-requisite to extend language handling across TYPO3 and Extbase. Resolves: #97926 Releases: main Change-Id: I38a685fcfdb98d5ec3c82b02e6cc78df12062fa0 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75093 Tested-by:
-
linawolf authored
The reference "Inside TYPO3" is not available anymore since TYPO3 8.7. The sentences are quite useless anyway. Releases: main, 11.5, 10.4 Resolves: #97913 Change-Id: I2d496726db8b22de667d230a99f7d17341fd309d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75157 Tested-by:
Sybille Peters <sypets@gmx.de> Tested-by:
-
Andreas Fernandez authored
To clean up cluttered severity definitions for flash messages and reports, a new `ContextualFeedback` enum is introduced. The enum is backed, means it holds actual values, which match the previously known integer values for severities. An internal `transform()` method may be used to maintain backward compatibility where needed and to trigger deprecation notices. Resolves: #97787 Releases: main Change-Id: I44b706c929277bc765bf302b2b1d32aa1da31f85 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74925 Tested-by:
Frank Nägler <frank.naegler@typo3.com> Tested-by:
Markus Klein <markus.klein@typo3.org> Reviewed-by:
-
Oliver Bartsch authored
In case GU::createVersionNumberedFilename() receives a file with an absolute path, no back path should be resolved since the resolved path will always be invalid, which led to no version number got added to the filename anymore. This is now fixed by checking for the path being absolute. Resolves: #97939 Releases: main, 11.5, 10.4 Change-Id: I5bb0150fa27b8c9c1af2aa99bd8baacd55889245 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75179 Reviewed-by:
-
Benni Mack authored
Symfony 5.4 ships with a new feature to add "aliases" to routes. TYPO3 can now replace legacy and complicated names for routes or modules with new ones while keeping backwards-compatibility with old links / references. See https://symfony.com/blog/new-in-symfony-5-4-route-aliasing for more details. Module registration now allows to define "aliases" (array), same for route registration. As an example, complicated module name such as "web_WorkspacesWorkspaces" is renamed to "workspaces_admin" which reflects the current possibilities for module identifiers much better. An upgrade wizard migrates the current backend user and backend group permissions ("userMods" and "groupMods") to the new logic. Resolves: #96515 Releases: main Change-Id: I3c6c9a3be3fddabe2910df4890528cc4f85a4586 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72960 Tested-by:
-
Nikita Hovratov authored
Resolves: #97938 Releases: main, 11.5 Change-Id: I711a541a9d38f7cd9ea2b1828a5353a8d1f7e0e3 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75176 Tested-by:
-
Christian Kuhn authored
The testing-framework functional test db snapshot helper expects the database to be empty when withDatabaseSnapshot() is called. Rows should only be populated within the create callback. There was a workaround in testing-framework to relax this restriction due to unfortunate backend user related setup code flow. This has been resolved with #97928, so the testing-framework snapshot can be more strict on this now. The patch adapts a couple of snapshot usages to align to this enforced restriction. $ composer req --dev typo3/testing-framework:dev-main Change-Id: I50d6dda3671729bd603899e37e7c7d0979c094fe Resolves: #97935 Related: #97928 Releases: main Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75174 Tested-by:
-
Nicole Cordes authored
If a record with associated inline records gets copied, the DataHandler always handles the record creation as new versions. This raises some warning when the corresponding table doesn't support workspaces. This patch prevents warnings when a corresponding irre-table cannot create any new version of a record. Resolves: #97712 Releases: main, 11.5 Change-Id: Iadcdf693f82d021eca5af1350855803ba433c37b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75166 Tested-by:
-
Christian Kuhn authored
Using functional test related .yaml scenario setup which uses DataHandler to prime the test database is pretty slow. TreeControllerTest can speed up using the withDatabaseSnapshot() method to cache db results for subsequent tests. Resolves: #97934 Releases: main Change-Id: I4c8f40f181f77bf07a0b26825138cb1577fe441e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/75173 Tested-by:
-
