- Sep 28, 2018
-
-
Benni Mack authored
In order to be in line with the new PageArguments object, this newly introduced class is now renamed. Resolves: #86431 Releases: master Change-Id: I96575338538641fc27a578c49868b21100b61ed3 Reviewed-on: https://review.typo3.org/58446 Reviewed-by:
Oliver Hader <oliver.hader@typo3.org> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Tymoteusz Motylewski authored
Resolves: #86423 Releases: master, 8.7 Change-Id: I5c1e0f92fe5f9d28eaaf0250677cd3dedcbd6082 Reviewed-on: https://review.typo3.org/58436 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Frank Naegler <frank.naegler@typo3.org> Tested-by:
-
Andreas Fernandez authored
To render the „Executing foo“ text in the progress bar when a upgrade wizard is executed correctly, a missing `data-title` attribute is added. Resolves: #86430 Releases: master Change-Id: I53f6f1a551de132452695a400561e46e9c1e4fb4 Reviewed-on: https://review.typo3.org/58442 Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Georg Ringer authored
The cropping element shows an information if no dimensions are known. The styling of this information is now improved. Resolves: #86429 Releases: master, 8.7 Change-Id: I28b6e4da560e591a57e6c849488f59ddf5cd5736 Reviewed-on: https://review.typo3.org/58441 Reviewed-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Tested-by:
-
Oliver Hader authored
When previewing translated pages in the backend, URLs contain `&L=x` at the end. This is due to a missing transformation into the `_language` parameter as well a missing SiteLanguage resolving. Resolves: #86421 Releases: master Change-Id: I5da496d0224635b1ee849dd7a724145ad2c0d408 Reviewed-on: https://review.typo3.org/58438 Reviewed-by:
Richard Haeser <richard@maxserv.com> Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Frank Naegler authored
Resolves: #86427 Related: #86404 Releases: master Change-Id: Iec990bd910ac62805d4584c468b265f57c0fd17d Reviewed-on: https://review.typo3.org/58437 Tested-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
-
Susanne Moog authored
A new key "site" for TypoScript "getText" has been introduced which allows accessing site configuration. Resolves: #86422 Releases: master Change-Id: Id0efae08445b8890021fb2b68a88c4ac8db5a6fa Reviewed-on: https://review.typo3.org/58434 Tested-by:
Jörg Bösche <typo3@joergboesche.de> Tested-by:
Tobi Kretschmann <tobi@tobishome.de> Tested-by:
-
Christian Kuhn authored
Using the element browser for a type=group, internal_type=file_reference TCA field leads to an exception due to a missing registration for this mode. Register the file browser, similar to internal_type=file. Resolves: #80541 Releases: master, 8.7 Change-Id: I54be7084f10d63ed262e903c296294589521f3df Reviewed-on: https://review.typo3.org/58431 Reviewed-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
-
Christian Kuhn authored
Properties $MOD_SETTINGS and $modTSconfig of RecordListController are still used by DatabaseRecordList through $GLOBALS['SOBE']. These two have to stay public for the time being to not trigger a bunch of deprecation log entries on each call of the list module. Change-Id: I87188b2065f4933e45203de58027f92db98bf840 Resolves: #86418 Related: #86198 Releases: master Reviewed-on: https://review.typo3.org/58430 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
Gianluigi Martino authored
During the translation process the option "disablePrependAtCopy" is not respected. With this patch the option is respected again for pages and tt_content. Resolves: #86293 Releases: master, 8.7 Change-Id: I821f3fed7d3e0637298262c4bd2c11003618f1c5 Reviewed-on: https://review.typo3.org/58424 Tested-by:
-
Guido Schmechel authored
Now it is also possible to add private Vimeo links. Releases: master, 8.7 Resolves: #83852 Change-Id: Icb425d4aea98a687b91216fefcd69b5fecc1a01e Reviewed-on: https://review.typo3.org/58404 Tested-by:
-
Jigal van Hemert authored
The Create Multiple Pages action now only displays the new structure in the default language and hides pages in other languages that are already in the pagetree. Resolves: #86378 Releases: master Change-Id: I14e45436d62300465d93ee87408523372007e394 Reviewed-on: https://review.typo3.org/58393 Tested-by:
-
Benjamin Franzke authored
FailsafePackageManager prevents saving PackageStates.php in failsafe mode by overwriting sortAndSavePackageStates(). That works to prevent saving, but also prevents sorting when initially loading packages when PackageStates.php is missing. Currently this does not really produce problems, as the install tool creates a new PackageStates.php later on and saves (and implicitly sorts them) using forceSortAndPackageStates(). To fix the intermediate state we now only prevent saving, but not the sorting of packages. Releases: master Resolves: #86408 Change-Id: I02ccb20653700e696d89b0a6ff39253f4f1ebc73 Reviewed-on: https://review.typo3.org/58416 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
Benjamin Franzke authored
CacheManager has a design problem: The CacheManager is used to create the core_cache. That core_cache is used to read the (possibly) cached CacheManager configuration, which is then used to configure the already-being-used CacheManager. That means the initialization sequence currently is like: new CacheManager(!$failsafe) | setInitialCacheConfiguration() | loadExtLocalconf() | setFinalCachingFrameworkConfiguration() Between initial creation of the CacheManager and setFinalCachingFrameworkConfiguration() the CacheManager is in a limbo state, as it may already be used to create a cache although the final configuration (which may be configured in ext_localconf.php) for that cache has not been set. The final configuration (for that created cache) will then be ignored, as the cache has already been created. This is not a theoretical problem, but is actually happening in core for two caches (introduced due to patches in the v9 development phase, more on those later). In v10 we want to change the sequence to the following: $coreCache = createCoreCache() | loadExtLocalconf | new CacheManager(!$failsafe, $cachingConfiguration, $coreCache); We want to delay CacheManager until ext_localconf.php has been loaded (maybe also after baseTca loading) in v10. Therefore GeneralUtility::makeInstance(CacheManager::class) usage in ext_localconf.php is deprecated now. Note: The core cache cannot be modified in ext_localconf.php - that was always the case and wouldn't make sense (as that cache is used to actually load the cached ext_localconf.php) Two caches are actually loaded too early during ext_localconf.php loading currently. We fix these as a drive-by: * extbase_reflection: the extbase Object\Container is instanciated in EXT:extbase/ext_localconf.php. The Object\Container then instanciates the ReflectionService in its constructor which itself creates the extbase_reflection using the CacheManager (all of that during ext_localconf.php loading). This is actually a regression introduced in https://review.typo3.org/54381 We change the Container to load the reflection cache on demand. * assets: * IconRegistry uses the 'assets' cache and loads cached backend icons during object construction. This cache was introduced in https://review.typo3.org/c/54020/ using the core cache, and was later changed to 'assets' in https://review.typo3.org/54061 * PageRenderer loads cached requireJS configuration from 'assets' We inject assetsCache to these services from Bootstrap for now. We'll only be able to properly refactor this, when dropping support for ext_localconf.php altogether. We also adapt the ExtensionManagementUtility to retrieve the coreCache as parameter, instead of statically. Although these methods are marked @internal, we keep them for 9LTS to not break extensions (using this regardless of being @internal, e.g. helhum/typo3-console) shortly before the release. Change-Id: I22935dae3acb6e8de14fa98a6b88f3477a3ea313 Releases: master Resolves: #86353 Resolves: #86371 Resolves: #86372 Reviewed-on: https://review.typo3.org/58371 Tested-by: -
Benni Mack authored
The functionality is moved into a new PSR-15 middleware to base the logic on the request object directly, and to make the validation more flexible when validating page parameters for site-based routing. The previous deprecation to add the request object to the method has been reverted. Resolves: #86411 Releases: master Change-Id: I294fae7e7c0f9eb1e128a88238dabdd8ed27619f Reviewed-on: https://review.typo3.org/58420 Reviewed-by:
Jan Helke <typo3@helke.de> Tested-by:
-
Josef Glatz authored
Make it impossible to select the page you are currently working on within the suggest wizard result set. Releases: master, 8.7 Resolves: #86412 Related: #54867 Change-Id: Ibeaacf86061f79cc3d75f181466e5caf96657401 Reviewed-on: https://review.typo3.org/58423 Tested-by:
Peter Kraume <peter.kraume@gmx.de> Tested-by:
-
Susanne Moog authored
To enable easy configuration of environment specific site setting, usage of environment variables in site configuration yaml has been introduced. The TYPO3 Core Yaml loader is now able to resolve variables from environment variables. Resolves: #86409 Releases: master Change-Id: Ic1e32d231aa7e92b3feb4ed4c31bed72520d71fb Reviewed-on: https://review.typo3.org/58358 Tested-by:
-
nebrot authored
Releases: master Resolves: #86415 Change-Id: Ib8002843376e651446a16143699844a98baebc0b Reviewed-on: https://review.typo3.org/58425 Reviewed-by:
Daniel Siepmann <daniel.siepmann@typo3.org> Tested-by:
-
- Sep 27, 2018
-
-
Richard Haeser authored
Cache the XML Sitemaps for 15 minutes by default. Resolves: #86060 Releases: master Change-Id: Ia8ded8d0885565e636519bcd92f51154e0817946 Reviewed-on: https://review.typo3.org/58417 Tested-by:
Riny van Tiggelen <info@online-gamer.nl> Tested-by:
-
Benni Mack authored
An additional trait for site languages and some minor simplifications when fetching the PageRouter from a Site. Resolves: #86410 Releases: master Change-Id: I88fd8fccbd19aada7014e7dca04c964e87fdd0cd Reviewed-on: https://review.typo3.org/58419 Tested-by:
-
Oliver Hader authored
In composer mode several directories are arranged outside the public root-path. When trying to copy to those folders, the public root-path is prefixed due an invalid check which is too strict. The expectation is to use public root-path (PATH_site) when resolving relative paths here. Resolves: #86407 Releases: master Change-Id: I666b08311e06289c64943518682ab4a970b35a2b Reviewed-on: https://review.typo3.org/58415 Tested-by:
-
Benni Mack authored
TCA "type=group" with "internal_type=file" and "internal_type=file_reference" are the last parts of content related file handling that circumvent FAL. All usages in the core have been changed since TYPO3 v6 until TYPO3 v9. To prepare and unlock further file system related works in v10, it is important we finally get rid of these parts that low level handles uploads/ and other legacy functionality. The patch finds any usages via TcaMigration, notes them as deprecated and adds a series of hints to core places that can be removed in v10. Note there is probably some hidden handling left in the core, this is partially hard to find. We may stumble upon more details in v10, but will have the freedom to remove them then. Resolves: #86406 Releases: master Change-Id: I94f2fa6364277497e85e513f1bfd34cc0acf1390 Reviewed-on: https://review.typo3.org/58414 Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
Benjamin Franzke authored
$GLOBALS['TYPO3_LOADED_EXT'] is defined as the "old" way since the introduction of the PackageManager in 2013: https://review.typo3.org/19605 (The class description of LoadExtensionArrayElement states: Class to simulate the "old" extension information array element) This old way should finally be removed to reduce site effects (pollution of the global scope) of the PackageManager class. It's marked as deprecated now, to be removed in v10. All existing usaged are rewritten to use the PackageManager API. Releases: master Resolves: #86404 Change-Id: Ic53f5155828ef2ea711a1961e08f8e020e3f836a Reviewed-on: https://review.typo3.org/58408 Tested-by:
-
Georg Ringer authored
To avoid exceptions the proper return type must be used. Resolves: #86390 Releases: master Change-Id: I3741582936cb1e1b530012a1c7fb8ff3ab6da934 Reviewed-on: https://review.typo3.org/58403 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #86152 Releases: master, 8.7 Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36 Reviewed-on: https://review.typo3.org/58389 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Tested-by:
-
Josef Glatz authored
This patch enables word-wrap in a form element `type=select` with `renderType=selectCheckBox` on small screen devices like tablet portrait. It prevents the list from sticking out of the right viewport border. Only the case when TYPO3_CONF_VARS/BE/debug = false was taken into account. Resolves: #86391 Releases: master Change-Id: Ia894b0a7481feb7a083bc583ff037063093f4e9c Reviewed-on: https://review.typo3.org/58400 Tested-by:
Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com> Tested-by:
Michael Oehlhof <typo3@oehlhof.de> Reviewed-by:
-
Christian Kuhn authored
On successful login to standalone install tool, the routing should jump to the silent upgraders and not to the main layout directy to make sure the upgraders are executed at least once before the maintenance view is loaded. Resolves: #86386 Releases: master Change-Id: I1246493671645d899780bb9ff1b08ed5682115a3 Reviewed-on: https://review.typo3.org/58398 Tested-by:
-
Susanne Moog authored
In case no current site exists in a context (for example currently eID or other scripting contexts), the pageLinkBuilder threw an error when linking to a page with a site configuration. The necessity for having a current site config has been removed, the pageLinkBuilder can now be used without a current site object and will then always generate absolute URLs to the target site. Resolves: #86384 Releases: master Change-Id: Id8c984c4ac3837d7b4da37a99d43410c6db34187 Reviewed-on: https://review.typo3.org/58397 Tested-by:
Henning Liebe <h.liebe@neusta.de> Tested-by:
-
Christian Kuhn authored
* Let the "stored hash uses not supported mechanism" bubble up. Instead of just a "login failed", an error is raised hinting that something is broken. * Improve exception message #1533818591: If an upgrade or new installation has been performed on a system that does support argon2i, users are upgraded to this mechanism. If the instance is later deployed to a server that does not support argon2i, the hash comparison will fail. * Improve exception message #1533822084: This one is usually only raised if a core upgrade from v8 to v9 has just been performed on an instance that does not support argon2i, and a backend login is executed before the install tool silent configuration upgrader configured the system properly. * Wiki pages with more details: https://wiki.typo3.org/Exception/CMS/1533818591 https://wiki.typo3.org/Exception/CMS/1533822084 Resolves: #86392 Releases: master Change-Id: I51e4ee9a198b9b92feec43c37a8b6b9b41c1b6f9 Reviewed-on: https://review.typo3.org/58402 Reviewed-by:
-
Josef Glatz authored
This patch enhances the self declaration of the site configuration form elements. - TCA descriptions were added to specific elements to provide a better clarity on how to use them. - First char uppercase on existing descriptions. - Input fields gets properly trimmed now. - Additional placeholders were added. Beside that, all missing PHPDoc blocks are added to the previously added UserFunctions class. Releases: master Resolves: #86387 Related: #85887 Change-Id: I684bb2044e4bb7ce3a6c60bf4656e83260fedafe Reviewed-on: https://review.typo3.org/58399 Tested-by:
Guido Schmechel <guido.schmechel@brandung.de> Tested-by:
-
Benni Mack authored
The functionality of _GETset() is really broken by design when thinking about having a non-global state. On top $TSFE->mergingWithGetVars(), which was mainly used in RealURL, is deprecated, as this needs to go within a PSR-15 middlware (I actually did that in a fork already for realurl v1). Resolves: #86389 Releases: master Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072 Reviewed-on: https://review.typo3.org/58344 Reviewed-by:
-
Daniel Siepmann authored
Use yaml as default highlighting. Add markup for code blocks. Also add highlighting for file names. Resolves: #86214 Releases: master Change-Id: I716c9bf80f86e3188409d173d767469a84a28e82 Reviewed-on: https://review.typo3.org/58409 Reviewed-by:
-
Josef Glatz authored
This patch prevents closing a form without showing the modal to inform the backend user about unsaved changes if values of an element with renderType `selectCheckBox` were changed through a „toggle all“ checkbox. Resolves: #86377 Releases: master, 8.7 Change-Id: I8a0ffd7ae0104739fdb66a1863e7012c0d30c84e Reviewed-on: https://review.typo3.org/58392 Tested-by:
Jigal van Hemert <jigal.van.hemert@typo3.org> Tested-by:
-
- Sep 26, 2018
-
-
Benni Mack authored
We heavily rely on Symfony Routing for TYPO3 routing, however we want to encapsulate this as much as possible to allow us to use a different routing system if a better one comes up. In order to proceed with Route Enhancers we introduce our own objects to extend them, and to typehint against these objects in the next patches. Some minor code preparations have been made as well. Resolves: #86393 Releases: master Change-Id: Id50186aa1a5ad57e097e6ff85e15d0f925bd63ef Reviewed-on: https://review.typo3.org/58401 Tested-by:
-
Susanne Moog authored
During upgrading missing information in some rst files has been added to ease upgrading for others. Resolves: #86376 Releases: master Change-Id: I4027e9b6e7da9ca663549fbe6489d1eea5671152 Reviewed-on: https://review.typo3.org/58391 Tested-by:
-
Oliver Hader authored
The PageUriBuilder is gone, as all is centralized in the PageRouter now, which acts as the centralized place to resolve Requests ("matchRequest") and to create URLs ("generateUri") for pages that have a site configuration. RouterInterface is the abstract interface which is intended to be used within Backend as well in the future, and provides a good basis for both cases (that's why page ID and SiteInterface is not hardcoded in the API). RouteResultInterface is introduced to allow further Result objects like page-specific results, useful for future routing improvements. Since PageUriBuilder was only used in cases where there was a site, the Router is now bound to a site (see constructor). When generating a URL, the PageRouter can receive a special argument called "_language" to hand over a SiteLanguage object. Resolves: #86388 Releases: master Change-Id: Ib090d3373a88cb7c534557ef21b46dce646078b5 Reviewed-on: https://review.typo3.org/58149 Tested-by: -
Frank Naegler authored
This patch put more information into IRRE titles of site configuration. Resolves: #85887 Releases: master Change-Id: I7d3df7b9513eb9cd591605eb450c4ae451b1fd75 Reviewed-on: https://review.typo3.org/58385 Tested-by:
-
Benjamin Franzke authored
Since https://review.typo3.org/56968 handing over arguments to getTSConfig() is deprecated. As a drive-by we also fix some related wrong getTSConfig() mocks in Unit/Middleware/AdminPanelInitiatorTest.php – they do not produce errors, but these mocks are too unspecific, as they still allow an argument to be passed. Releases: master Resolves: #86383 Related: #85016 Change-Id: I7254b5d0b87bc66da319728f7fe82aaa614b6a43 Reviewed-on: https://review.typo3.org/58396 Tested-by:
-
Josef Glatz authored
This patch prevents closing a form without showing the modal to inform the backend user about unsaved changes if values of an element with renderType `t3editor` were changed within the CodeMirror editor. In addition to the fix, a CSS border is added if the code editor content was changed to improve the user experience. Releases: master Resolves: #86380 Change-Id: I641180a531b879ece70e30d0a22c9e5878d02953 Reviewed-on: https://review.typo3.org/58394 Reviewed-by:
-
- Sep 25, 2018
-
-
Josef Glatz authored
Resolves: #86379 Releases: master Change-Id: I8eadc7d6cf242581601065ef780229e577149204 Reviewed-on: https://review.typo3.org/58395 Reviewed-by:
Alexander Grein <alexander.grein@gmail.com> Tested-by:
-
