- Jun 13, 2021
-
-
Christian Kuhn authored
Brings a composer conflict setting to prevent incompatible doctrine/dbal versions, and an acceptance test related fix. composer req --dev typo3/testing-framework:^6.8.3 composer req --dev typo3/testing-framework:^6.8.3 -d typo3/sysext/core --no-update Resolves: #94332 Releases: master, 10.4 Change-Id: Ib1192c5135c02d485c8f28b54755c22a1a50c10f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69481 Tested-by:
core-ci <typo3@b13.com> Tested-by:
Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by:
-
Christian Kuhn authored
Brings a PHP 8.0 related fix, backend module bug fixes and features representing more v11 related markup. composer req --dev typo3/cms-styleguide:~11.3.0 composer req --dev typo3/cms-styleguide:~11.3.0 -d typo3/sysext/core --no-update Change-Id: I716237ad6256db87f6b6e20081a67fa674c203d5 Resolves: #94331 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69479 Tested-by:
-
Christian Kuhn authored
It's TYPO3\CMS\Core\Tests\Acceptance\Backend\Site\SiteModuleCest not TYPO3\CMS\Core\Tests\Acceptance\Backend\Redirect\SiteModuleCest Resolves: #94330 Releases: master, 10.4 Change-Id: I0661feec976aeeddce179d9177e36e729fc0b72d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69477 Tested-by:
-
- Jun 12, 2021
-
-
Christian Kuhn authored
setControllerSubpackageKey(), getControllerSubpackageKey() and property controllerSubpackageKey of extbase Request are essentially an artifact from flow and unused in v11 core. The information is only carried around at one place but never actively used. This @internal handling is dropped with the patch. Change-Id: I546645b58cab351bac408e5772400f9cfe5d7b03 Resolves: #94326 Related: #86521 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69469 Tested-by:
Anja Leichsenring <aleichsenring@ab-softlab.de> Tested-by:
Benni Mack <benni@typo3.org> Reviewed-by:
-
Christian Kuhn authored
To further prepare towards a PSR-7 Request in extbase we have to get rid of as many setters as we possibly can. Both methods isCached() and setIsCached() were marked @internal in v10 and related to extbase internal handling. Internal usages have been dropped when extbase introduced PSR-7 Responses with #92502, the methods can be dropped now. Change-Id: I1b72cef669e4bc6bd75cac855bfb18fa47663b63 Resolves: #94319 Related: #94228 Related: #94231 Related: #94223 Related: #92502 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69466 Tested-by:
Oliver Klee <typo3-coding@oliverklee.de> Reviewed-by:
-
Christian Kuhn authored
One of the main classes. symfony DI does not support having a combination of constructor arguments plus autowired dependencies. This needs to be resolved for systems around FormDefinition: * FormDefinition itself looses its inject* method for ObjectManager. It's a class not meant to be sub classed by 3rd party extensions. The constructor arguments can be kept, FormDefinition is now instantiated using makeInstance(). * Domain/Model/FormElements/Page and classes extending this class and registering them using implementationClassName for a form must not rely on inject* and initializeObject methods since they need manual constructor arguments. A b/w compat layer detects this and falls back to ObjectManager, even though Page is marked as NOT to be extended by developers. * FormRuntime looses its inject* and initializeObject methods and is instantiated using makeInstance() keeping existing constructor arguments. The class is hardcoded and API does not consider overwriting, so no fallback layer. * Finishers are a bit more tricky: They are often extended in projects, reliable b/w compat is needed. They have one constructor argument and rely on injection. It's useful to keep the injection, so the constructor argument is dropped and substituted with a setter called after initializations. A compat layer detects not adapted classes and falls back to ObjectManager. Resolves: #94317 Related: #90803 Releases: master Change-Id: If157457a6bab568e1f8c32a6f09e60dba0b595f4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69462 Tested-by:
-
Christian Kuhn authored
Resolves: #94318 Releases: master Change-Id: I89b74b105c59c9a873b57a6ff3c0a149f888ef94 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69465 Tested-by:
Oliver Bartsch <bo@cedev.de> Reviewed-by:
-
Oliver Bartsch authored
The internal methods `generateItemList()` and `explodeItemList()` from `ExtensionManagementUtility` are unused since v7 and therefore now removed. Resolves: #94314 Releases: master Change-Id: I6db5cf6e198f7d69ecb58c5ca8dec1e24c9c55a4 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69463 Tested-by:
-
- Jun 11, 2021
-
-
Christian Kuhn authored
Class TYPO3\CMS\Core\Service\AbstractService as part of an ancient 'services' API has been rendered unused in core with #88646. To further streamline the authentication API and related helper methods, this class is marked deprecated now. This shouldn't have much impact for extensions in the wild, since the API never found many usages apart from core authentication related concerns. Resolves: #94313 Related: #88646 Releases: master Change-Id: I79e303937320f28667814644964acc4aeebd091e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69461 Tested-by:
Andreas Fernandez <a.fernandez@scripting-base.de> Reviewed-by:
-
Oliver Bartsch authored
Since removing the last remains of EXT:rsaauth in #94279 the `FE/loginSecurityLevel` and `BE/loginSecurityLevel` options became obsolete and are therefore now removed. Resolves: #94312 Related: #66997 Related: #87470 Related: #94279 Releases: master Change-Id: I03231f4ab798165e4820d67dea2cf44e32b8c4fa Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69460 Tested-by:
Markus Klein <markus.klein@typo3.org> Tested-by:
-
Oliver Bartsch authored
GeneralUtility::rmFromList is unused since v10. If at all, this method would better belong to StringUtility. Therefore, it's now deprecated in GeneralUtility, but could be reimplemented in a more performant way in StringUtility, when needed again. Resolves: #94311 Releases: master Change-Id: I2ea5ec57143d70fa2a0de2d2c34230764d3ce204 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69459 Tested-by:
-
Oliver Bartsch authored
GeneralUtility::stdAuthCode is unused since at least v9. As more appropriate methods for generating hashes, e.g. GeneralUtility::hmac() exists nowadays, the method is deprecated. Resolves: #94309 Releases: master Change-Id: I3d3678cd8c8c76462cc74b28f629b6679a4aea93 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69458 Tested-by:
Torben Hansen <derhansen@gmail.com> Tested-by:
-
Andreas Fernandez authored
The method `TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject->getUid()` is declared to return either an int or null, but the annotation mentions int only, which may cause issues with static code analysis tools. Therefore, the annotation is adjusted to reflect both return types. Resolves: #94305 Releases: master, 10.4 Change-Id: I71e8c407085708c473754a398ae2ecf08126274c Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69457 Tested-by:
-
Oliver Bartsch authored
All tables were previously wrapped by one form in the recordlist. Since #94218 this leads to problems because all tables now define another form for the "Show columns" selector. Nested forms are invalid markup. Therefore, effectively only the first table was wrapped by the general form. The remaining tables were not longer wrapped into a form, leading to problems when using the clipboard actions. This is now fixed by replacing the all-embracing form with dedicated forms for each displayed table. Besides fixing the mentioned problems, this change results in further improvements: * The forms are now dedicated to their table * The "Show columns" selector does not longer need to define a form itself * When updating the "Show columns" selection or when executing a clipboard action, the recordlist jumps to the correct table after reload, using an anchor tag * The clipboard related JavaScript can be simplified in an follow-up patch Resolves: #94302 Related: #94218 Releases: master Change-Id: Ib57abfe7bc9a2c9b6b3919a9ec78c25a87b8f08a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69453 Tested-by:
Jochen <rothjochen@gmail.com> Tested-by:
-
- Jun 10, 2021
-
-
Oliver Bartsch authored
This removes an invalid attribute from EXT:impexp default layout and furthermore removes unnecessary fluid namespace declarations, since they are defined globally. Resolves: #94306 Releases: master Change-Id: I0ec7181ccc5fb08708257499c969c1d27e783338 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69456 Tested-by:
-
Christian Kuhn authored
Inject a singleton service, makeInstance() prototypes. Resolves: #94304 Related: #90803 Releases: master Change-Id: I0645c06a5f5ae2b10f5e14aee08ed01f16720bac Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69455 Tested-by:
-
Christian Kuhn authored
Extbase ConfigurationManager is already configured to be injectable. Use this in TranslationService. Resolves: #94303 Related: #90803 Releases: master Change-Id: I6fa2a2e05a2c7b348b411142e8a44c2dad20c3f7 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69454 Tested-by:
-
Oliver Bartsch authored
Recordlist features the clipboard functionality. When activated, multiple clipboard actions, such as "copy" or "edit marked", are displayed in each tables' header. Since translated records can never be selected, this led to exceptions and JavaScript errors when using such action on the "Page Translations" table. This is now fixed by not rendering those actions for this special table. Resolves: #94296 Releases: master, 10.4 Change-Id: I47459cf1d82d90f634a4f8902ea04c958cbd1bdc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69427 Tested-by:
-
Torben Hansen authored
Usage of FriendsOfTYPO3/rsaauth is pretty low and there is no reason to support the extension any more in TYPO3 11. This patch removes all ext:rsaauth related code. Resolves: #94279 Releases: master Change-Id: I8e318bcc3c04fcc66a033507d0dddb931529c17d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69397 Tested-by:
-
Oliver Bartsch authored
This fixes a regression introduced in #94057, which effectively removed the possibility to toggle the clipboard in the recordlist. Resolves: #94301 Related: #94057 Releases: master Change-Id: I6d6ffe9a33bd96f8a41c3f23f3367cf750d29472 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69452 Tested-by:
-
Oliver Bartsch authored
Besides all available versions of a TER extension, the "Show all versions" view in EXT:extensionmanager also displays general information such as the category or the dependencies, making it more or less an extension detail view. Since those information are also relevant for already installed extensions, it's now possible to access this view in the "Installed extensions" list, using a new link on the extensions' version string. Resolves: #94298 Releases: master Change-Id: Iab131e5494f143315abd607de1a79f5f0571a2dc Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69429 Tested-by:
-
Christian Kuhn authored
Register an implementation and adapt consumers. Resolves: #94300 Related: #90803 Releases: master Change-Id: I43117cf3094e0784d05c97d7f28f3365d12bd1f9 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69431 Reviewed-by:
-
Christian Kuhn authored
An install tool upgrade wizard slated for removal has been forgotten during v11.0 cleanup: FormFileExtensionUpdate has been added for upgrade to v9 (and even backported to v8), has then been kept for update to v10 and can be removed now. Resolves: #94299 Releases: master Change-Id: I882e7ef3926895bcc1e455bc2c0cda287c822680 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69430 Tested-by:
-
Christian Kuhn authored
Make ext:form TypoScriptService injectable and adapt consumers. Fixes a broken $this->objectManager call from #94093 in ConfigurationManager. Resolves: #94297 Related: #90803 Related: #94093 Releases: master Change-Id: Ideaa5b0828d3148ba9cbd7287ab50ed51079ce21 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69428 Tested-by:
-
Christian Kuhn authored
The namespace of core TypoScriptService is TYPO3\CMS\Core\TypoScript, not TYPO3\CMS\Core\Service. The entry is thus obsolete and can be dropped. The service with correct name is already handled by ext:core ServiceProvider.php. Change-Id: Ia4a3ef02dd3490547a9379ad57930afdd974a2de Resolves: #94295 Related: #94093 Releases: master Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69426 Tested-by:
Georg Ringer <georg.ringer@gmail.com> Reviewed-by:
-
Oliver Bartsch authored
The method DatabaseRecordList::makeFieldList() creates a list of fields to select for a table. Since selector. This method however automatically adds some management fields, such as `crdate`. As those fields may also be included in TCA `columns`, e.g. for sys_redirects since #94143, they may be added multiple times, which leads to different errors. This is now fixed by applying array_unique to the final field list. Resolves: #94294 Releases: master Change-Id: I6e5cefaa4fb5d5a3dff9581105d19618143c1e79 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69424 Tested-by:
Daniel Goerz <daniel.goerz@posteo.de> Reviewed-by:
-
Oliver Bartsch authored
The "View" respectively "Save & View" functionality of EditDocumentController is as following: 1. Clicking the corresponding button saves the form and a JavaScript event handler opens a new blank window 2. After the data was persisted, the form reloads and the preview code (using the ImmediateAction component) is written to the module body. This update the previously opened window with the correct preview URL. However, since #94114, a redirect is performed as soon as the data has been persisted. This is done to ensure persisting is only done for POST requests. Since the information whether the form was stored using the "View" respectively "Save & View" is not forwarded in the redirect, the new window remains blank. This is now fixed by adding the corresponding information to the redirect URL. Also a now unnecessary code block in processRequest() is removed. Resolves: #94287 Releases: master Change-Id: I4f9be3fb286a6cdfe6e1d3e071eb0c6df0801f5e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69415 Tested-by:
Richard Haeser <richard@richardhaeser.com> Reviewed-by:
-
Larry Garfield authored
Manual testing found a bunch more cases of undefined variables that need to be addressed. Resolves: #94057 Releases: master Change-Id: I0f602d2de5fcfdc8b41545eafacc5ff79bbfdf86 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69393 Tested-by:
-
- Jun 09, 2021
-
-
Guido Schmechel authored
To avoid confusion for the editor, the "sha1" field is now removed from the searchFields of sys_file. Those who wish to continue searching this field can adapt the corresponding TCA via TCA overrides. Resolves: #94273 Releases: master, 10.4 Change-Id: I8b2676c868e97e67b5fa453fa53658fcadae9ce8 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69399 Tested-by:
-
Oliver Bartsch authored
Extension updates are important, since they may contain security fixes. Therefore, in non-composer based installations, the extension listing in the EXT:extensionmanager "Installed extensions" view is now always sorted by the extensions' update state, as soon as one extension can be updated. For composer based projects, the behaviour does not change, since updating extensions is usually done via CLI and chaning the sorting can still be done manually in the module. Resolves: #70157 Releases: master Change-Id: I25a28f3b1483ed736872e90e46939f30bca47f7f Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69400 Tested-by:
-
Oliver Bartsch authored
The shortcut links in the toolbar contain an icon, which gets calculated based on the backend module and the record type, the shortcut was created for. Since IconFactory->getIconForRecord() is used to fetch the correct record type icon, the database row has to be provided. This was previously done by simply querying the table with an uid constraint. In case the table, the shortcut was initially created for, does not longer exist, e.g. since a third-party extension was removed, this led to an exception. The database row is therefore now fetched using BackendUtility::getRecordWSOL(), which checks if the table is (still) configured in TCA, since this is anyways a prerequisite for using getIconForRecord() and for working with shortcuts - Especially when `record_edit` is the target module. As a positive side effect of this change, a possible workspace version is now also taken into account, when generating the record icon. Resolves: #94286 Releases: master, 10.4 Change-Id: I1d6e1327f10ad06863ef7f5bb1e3706a3f10bcfe Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69416 Tested-by:
-
Oliver Bartsch authored
Since #93508 additional information about the inline parent are available in the $parameters array of an itemsProcFunc. Those information are only available in FormEngine context and not in the DataHandler. This is now properly documented in the corresponding class. Resolves: #94290 Related: #93508 Releases: master, 10.4 Change-Id: Id20390b113f1cd9261a2b33413031233524f6623 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69417 Tested-by:
-
Oliver Bartsch authored
EXT:seo defines two additional types for "Page Overview" in the info module. Since the special uid field, which has a special treatment in PageInformationController, was previously missing, no view and no edit options were displayed. Besides the already existing special treatments, in master, the field is also used to determine the row tag to be used (either `<th>`or `<td>`). Therefore, the two EXT:seo types previously always used `<th>`, which leads to all cells were bold (in at least the chrome browser, due to user agent styles). This is now fixed by adding the special uid field to the mod.web_info.fieldDefinitions declaration in EXT:seo. Resolves: #94291 Releases: master, 10.4 Change-Id: I5c20528008160a2c5d853b6d70cc84e3cf3ad89a Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69418 Tested-by:
-
Benjamin Franzke authored
Symfony deprecation messages are prefixed by an @-sign in order to only be thrown if an explicit error handler for E_USER_DEPRECATED is registered. Other than for regular silenced errors, we want these deprecation messages to be logged in any case, and therefore ignore the @-sign for E_USER_DEPRECATED errors now. Releases: master Resolves: #94269 Change-Id: I2d1fb443ef0bf5d01361f1980ab74b94a116fb1d Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69366 Tested-by:
-
Oliver Bartsch authored
Since translated records do not contain a checkbox for the clipboard functionality, we have to check the element before accessing the "checked" property. Note: There is still a problem in master, which will be tackled in a separate patch. Resolves: #94293 Releases: master, 10.4 Change-Id: I795b99f7112e8ae5d8eef79b6161b19b5bb77e0e Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69420 Tested-by:
-
Simon Gilli authored
This patch introduces a new type for the Pagetree overview in the info module. It displays the relevant layout fields, e.g. backend layout and frontent layout, next to an additional field which contains the actually used backend layout, inherited from a parent page. This follows #94210, which already introduced a field information for the pages.backend_layout field. This effectively allows an editor to have a detailed overview of the configured and - more importantly - actually used backend layouts for a page or even a complete page tree. Resolves: #89700 Releases: master Change-Id: I4851cd8133d4dbac9ccc1e0d04b534077729c6cb Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/62338 Tested-by:
-
Christian Kuhn authored
RenderingContext is a good case for a class that creates "arbitrary" objects: The PreProcessor class names are retrieved from global configuration in order to be instantiated. This initialization is moved into a (install tool mode compatible) factory in order to transform ObjectManager into a fallback layer for PreProcessors that are not defined in the newer PSR container. Therefore $container->has() is used prior to $container->get(), in order to fallback to ObjectManager for objects that can't be retrieved – due to missing configuration – via ContainerInterface yet. Resolves: #94285 Related: #90803 Releases: master Change-Id: I3fd1751b8580de7c8307e9b84da38e1551c2c622 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69412 Tested-by:
Benjamin Franzke <bfr@qbus.de> Tested-by:
-
Oliver Hader authored
`GeneratorClassesResolver` used for the extension scanner preprocesses `GeneralUtility::makeInstance` calls, transforms class-string values to their corresponding class-constants and provides a low-level class instantiation using `new`. When modifying PHP parser nodes, only expected types shall be used, which is `ClassConstFetch` instead of `FullyQualified`. Resolves: #94283 Releases: master Change-Id: I3a802212dc067c5ced0e03aa2cce6519d5ed1dbd Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69403 Tested-by:
-
Oliver Bartsch authored
When dumping the ModuleTemplate with DebuggerUtility a property access exception is thrown, since the FlashMessageQueue is neither initialized nor declared as nullable. This is fixed by initializing the FlashMessageQueue in the constructor now. This instance can however still be overwritten by the corresponding setter method. Resolves: #94276 Releases: master Change-Id: I64bd52e05cd41112a4edb7cc9629db52a093764b Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69395 Tested-by:
-
- Jun 08, 2021
-
-
Oliver Bartsch authored
Atfer a lot of preperation in #93048 and #93988, it's finally possible to share URLs to TYPO3 backend modules. Even special modules such as FormEngine. To ease the use for editors, the ShortcutButton is extended for a new option. If enabled, which is the default behaviour, the shortcut button in the module header is replaced. The new button allows to open a dropdown with the additional possibility to copy the URL of the current page to the operating systems' clipboard. Next to the already exisiting "Add shortcut" option. Since those URLs should not contain the user specific token, the UriBuilder features a new constant "SHAREABLE_URL". If set as $referenceType in one of the supporting methods, e.g. buildUriFromRoute(), an absoulte URL without the token is returned. To copy the URL to the operating systems' clipboard, a new web component "CopyToClipboard" is introduced. This component is added without any dependency to the URL sharing functionality and can therefore be freely used for other backend components as well. For the new button, the font awesome "share-alt" icon is registered in the IconRegistry. Resolves: #93921 Releases: master Change-Id: Id1dcfe1f2af764fbe000659ddb49a7369322d5b6 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/69338 Tested-by:
-
