- Aug 31, 2017
-
-
Christian Kuhn authored
Brings a bug fix in frontend functional test parsing. Change-Id: I3e95f4ee12069bbbfc225fb5045793273eff6f95 Resolves: #82256 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53840 Tested-by:
TYPO3com <no-reply@typo3.com> Reviewed-by:
Christian Kuhn <lolli@schwarzbu.ch> Tested-by:
-
- Aug 30, 2017
-
-
Ludwig Rafelsberger authored
Releases: master,8.7 Resolves: #82239 Change-Id: I90d4ecdb4917c567a652a7bf5d24b55b39d646fd Reviewed-on: https://review.typo3.org/53833 Reviewed-by:
Wouter Wolters <typo3@wouterwolters.nl> Tested-by:
Tymoteusz Motylewski <t.motylewski@gmail.com> Tested-by:
-
Benni Mack authored
In order to get the controllers free of security checks, the logic of authentication/session handling is moved from various controllers into the RequestHandler and the Application. Additionally, a second RequestHandler (RecoveryRequestHandler) is introduced which acts as a fallback if TYPO3 is not installed yet, or the installation is broken (e.g. missing PackageStates.php). This brings a cleaner dispatching mechanism, having the RecoveryRequestHandler (which can handle any request) dealing with the StepController, and the regular RequestHandler (with higher priority) for handling the maintenance functionality for running installations. Resolves: #82238 Releases: master Change-Id: I906ab3f15479bbe70202608f6bd7838cc22d9e3a Reviewed-on: https://review.typo3.org/53800 Tested-by:
Susanne Moog <susanne.moog@typo3.org> Tested-by:
-
- Aug 29, 2017
-
-
Claus Due authored
This patch updates the composer Fluid dependency to version 2.4.0 and above. Fixes multiple bugs and performance issues - and adds a few new features. Full list of changes: https://github.com/TYPO3/Fluid/compare/2.3.4...2.4.0 Change-Id: I2d16c6c95ecb6c985da772736d066d8e10da8761 Resolves: #82230 Releases: master Reviewed-on: https://review.typo3.org/53823 Tested-by:
Benni Mack <benni@typo3.org> Tested-by:
-
Christian Kuhn authored
The database analyzer buttons "Run again" and "Apply" are now disabled when a scan is in progress. This prevents multiple ajax calls in parallel which lead to duplicate output. Change-Id: I28df15e2c7169960e0889aed903bbd72034f07cc Resolves: #82152 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53821 Reviewed-by:
Andreas Fernandez <typo3@scripting-base.de> Tested-by:
Georg Ringer <georg.ringer@gmail.com> Tested-by:
-
Benni Mack authored
The CmsVariableProvider within EXT:fluid extends a Fluid core class with the same functionality and can be removed. A class alias ensures that the PHP class is still available. Resolves: #82229 Releases: master Change-Id: I71eb7beaf0684631d9c7e857bbed91f08b75d47c Reviewed-on: https://review.typo3.org/53227 Tested-by:
Claus Due <claus@phpmind.net> Tested-by:
-
Anders Kostending authored
Update CKEditor to the lastest version that fixes a lot of bugs. Release notes: https://ckeditor.com/release-notes Fixes: * Added Advanced Content Filter integration with the Justify plugin. * [Chrome] Fixed: Clicking the scrollbar throws an Uncaught TypeError: element.is is not a functionerror. * Fixed: Widgets cannot be properly pasted into a table cell. * Fixed: Internal cke_table-faked-selection-table class is visible in the Stylesheet Classes field of the Table Properties dialog. * [Edge] Fixed: Error thrown when pressing the Select All button in Source Mode. * Fixed: Double slash in the path to stylesheet needed by the Table Selection plugin. * Fixed: Unnecessary dependency on the Editor Toolbar plugin inside the Notification plugin. * Fixed: Error thrown into the browser console after opening the Styles Combo plugin menu in the editor without any selection. * Fixed: Double click does not open the dialog for modifying anchors inserted via the Link pl...
-
Johannes Schlier authored
The trigger values can be hardcoded here, as the previous filtering only gives us fields for which we want to hide the explanation and show the input field. Previuosly each time a new link field was created (as an IRRE element for example) the input and explanation fields were triggered. This created confusion with editors and also broke the trigger button, so that fields that were in the explanation mode could not be triggered back to input mode. Resolves: #82179 Releases: master, 8.7 Change-Id: Ic92129c6cdafe5fab19fbc76b9e9b7713b9e8736 Reviewed-on: https://review.typo3.org/53790 Reviewed-by:
Henning Liebe <h.liebe@neusta.de> Reviewed-by:
Sascha Rademacher <sascha.rademacher+typo3@gmail.com> Reviewed-by:
Anja Leichsenring <anja.leichsenring@typo3.com> Tested-by:
-
Christian Kuhn authored
Fix "Find imagemagick / graphicsmagic in specific direcory" input field in image preset handling. The preset handling is still a bit ugly and does not integrate too well into the ajax based handling all other cards use. This needs a bigger refactoring and is not done with this patch. For now, submitting a path to the image preset path input field reloads the view and executes the path test, so the functionality is there, it's just a bit ugly to use. Change-Id: I2da1680b44ff34df05aecc4eb589a293bb8d72c2 Resolves: #82188 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53822 Tested-by:
Joerg Boesche <typo3@joergboesche.de> Tested-by:
-
- Aug 28, 2017
-
-
Markus Hoelzle authored
Render additionalAttributes and data-* attributes in VideoTag, YouTube, Vimeo and AudioRenderer if set in the Fluid MediaViewHelper. Releases: master Resolves: #81741 Change-Id: Ieef9eae905a33e09e225d3a563c3f31988a65a57 Reviewed-on: https://review.typo3.org/53488 Tested-by:
Frank Naegler <frank.naegler@typo3.org> Reviewed-by:
-
Andreas Fernandez authored
The install tool (/typo3/install.php) is at the same directory location as the backend interface. The links are fixed to point to the correct locations. Remove an obsolete f:if along the way, this partial is only loaded in non backend context anyway. Resolves: #82199 Related: #76084 Releases: master Change-Id: I73ff8b0a3bd22827fa2a2c319b0e0bb2ad4e5afa Reviewed-on: https://review.typo3.org/53803 Tested-by:
Mona Muzaffar <mona.muzaffar@gmx.de> Tested-by:
-
Tymoteusz Motylewski authored
During doctrine migration a change of behaviour was introduced. In v7 when a translated record is hidden, it's not shown, while before this patch, a record from default language was shown. Resolves: #82161 Releases: master, 8.7 Change-Id: Ib8127eff7218f9dd064febbab4956af44f3164b9 Reviewed-on: https://review.typo3.org/53796 Tested-by:
-
Andreas Fernandez authored
Due to invalid syntax used at the code blocks, the code is not rendered at all. This patch adds the missing blank linkes. Resolves: #82218 Related: #81901 Releases: master Change-Id: Iadb034f0cfd250cf1871b65d417844e999d836e5 Reviewed-on: https://review.typo3.org/53814 Tested-by:
Sebastian Fischer <typo3@evoweb.de> Reviewed-by:
-
- Aug 25, 2017
-
-
Benni Mack authored
The field pages.urltype contains "0", "1", "2" which maps to a protocol, however most people want to just paste the url in the "pages.url" field. This change drops the DB field "pages.urltype" and merges the value into "pages.url" directly. Resolves: #71306 Releases: master Change-Id: I309724ba48ac9c5674a75e79da6cbb6e4880e521 Reviewed-on: https://review.typo3.org/53198 Tested-by:
-
Andreas Fernandez authored
CodeMirror is offered as a minified version. As there is no benefit of using a "full-blown" version, switch to minified version instead. Resolves: #82204 Releases: master Change-Id: I8e15e1ea8266951430ebeb86445b3cd2db524caf Reviewed-on: https://review.typo3.org/53806 Tested-by:
-
Christian Kuhn authored
Before refactoring of the install tool with #76084, a 'fatal error handler' was in place to redirect to the extension checker if a fatal php error was detected during one of the main "tool" actions. Now, the main controllers of the install tool never load non-core extension data anymore, those can't fail due to issues with specific ext_localconf.php or ext_tables.php files. This extension loading now happens only in ajax actions and thus can't kill the whole install tool anymore. Left over error handler code is removed from the ToolController with this patch. Change-Id: I0d0398f7b66a6a2c64dec48fe60a722698688a59 Resolves: #82200 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53804 Tested-by:
-
Christian Kuhn authored
With the doctrine migration a signal formerly located in class SqlExpectedSchemaService has been moved to class SqlReader. The old SqlExpectedSchemaService has been removed with issue #82148. Slot for that moved signal should now switch to the string literal of the class name. Change-Id: Id1cb28b236c7025308b0f0be3f969903df4c4ea5 Resolves: #82197 Related: #82148 Releases: master Reviewed-on: https://review.typo3.org/53801 Reviewed-by:
-
Andreas Fernandez authored
Resolves: #82198 Releases: master Change-Id: I62e3f378031197d87c318b2062d434a99c9a71a4 Reviewed-on: https://review.typo3.org/53802 Tested-by:
Riccardo De Contardi <erredeco@gmail.com> Tested-by:
Josef Glatz <josef.glatz@typo3.org> Tested-by:
-
- Aug 24, 2017
-
-
Oliver Hader authored
Since Doctrine DBAL has been integrated into the TYPO3 core during version 8 development and Extbase queries have been adjusted with TYPO3 version 8.4.0, the behavior on distinct query results were mixed up as well. Extbase queries using the query-builder until TYPO3 7 LTS contained a dedicated `SELECT DISTINCT` when retrieving data which lead to unique entities, especially when implicit `LEFT JOIN` statements have been added to the query to resolve cardinalities of the types one-to-many and many-to-many. Besides that using `GROUP BY` is not reliable in this particular Extbase scenario. Further details can be found in MySQL documentation: https://dev.mysql.com/doc/refman/5.7/en/group-by-handling.html Change-Id: Ic5fd1d4752eefec7fcff37d8d62f55ea7299e8d6 Resolves: #80380 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53658 Tested-by:
Morton Jonuschat <m.jonuschat@mojocode.de> Tested-by:
-
Christian Kuhn authored
If im / gm are not configured, the Environment module may throw a fatal since refactoring. The patch sanitizes that and fixes the "Current configuration" view in "Image Processing" card which broke during refactoring, too. Change-Id: I6180a10150e63182c23dd7d7e8257e99a8652533 Resolves: #82160 Related: #76084 Releases: master Reviewed-on: https://review.typo3.org/53797 Tested-by:
-
- Aug 23, 2017
-
-
Frank Naegler authored
Some install tool cards load content on opening the card. The patch now fires events on open and modules single card JS binds to those events to load content. This fixes the prev/next buttons in docheader to init card content correctly. Resolves: #82185 Releases: master Change-Id: Iad04a0fc560df8511f716982456b2ac3ae0644bb Reviewed-on: https://review.typo3.org/53794 Reviewed-by:
-
Wouter Wolters authored
Add 2 new rules * no_superfluous_elseif * no_useless_else Both rules only apply if the if-statement contains a return. If this is the case the obsolete else/elseif part is dropped. Resolves: #82183 Releases: master,8.7 Change-Id: I94dfa6b5b96cbc3e350bd778f1796dda1a4d955a Reviewed-on: https://review.typo3.org/53791 Tested-by:
-
Mathias Brodala authored
Change-Id: I9e5a04c3ef0ee8fed53d22df4d6ea472266145e7 Resolves: #82131 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53731 Reviewed-by:
Daniel Goerz <ervaude@gmail.com> Tested-by:
-
Christian Kuhn authored
Change a series of cgl details after update of php-cs-fixer from 1.0 to 1.4. Change-Id: Iba289f530e2df2c6fc73e5f5b705a673b4b3db0f Resolves: #82171 Related: #82164 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53776 Tested-by:
-
- Aug 22, 2017
-
-
Frans Saris authored
To completely disable the Install Tool you can just leave the `installToolPassword` value empty in your LocalConfiguration. Problem here is that not all password hashing methods can handle an empty value without giving PHP warnings. This patch changes the password check in reporting to skip the install password hashing/check when there is no password. Releases: master, 8.7 Resolves: #82147 Change-Id: I399a505544203fc40435f8e82b3baa5b6abd0da5 Reviewed-on: https://review.typo3.org/53757 Reviewed-by:
Wolfgang Klinger <wolfgang@wazum.com> Reviewed-by:
-
Anders Kostending authored
Updates D3.js to the latest release version, 4.10.0. Release notes: https://github.com/d3/d3/releases/tag/v4.10.0 Fixes: * Add d3.areaRadial; deprecate d3.radialArea. * Add d3.lineRadial; deprecate d3.radialLine. * Add d3.pointRadial. * Add zoom.translateTo. * Re-implement d3.packEnclose using Matoušek-Sharir-Welzl. * Fix d3.packSiblings to center the circles more consistently around a fixed origin. * Fix axis rendering when a scale has a non-numeric range. * Fix interval.offset on filtered time intervals when step is negative. * Fix invocation of requestAnimationFrame in Edge. * Invoke nest.sortValues comparator prior to nest.rollup aggregator. * Drag & zoom behaviors now only register touch event listeners when touch is supported. * Drag & zoom behaviors now set the touch-action style to “none” when touch is supported. Resolves: #81945 Releases: master, 8.7 Change-Id: Idcd0826d2bd50467558d1bd6229d84651b93f4b0 Reviewed-on: https://review.typo3.org/53574 Tested-by:
Kasper Ligaard <kasperligaard+typo3.org@gmail.com> Reviewed-by:
Morten Pless <mpl@systime.dk> Tested-by:
Faton Haliti <fha@systime.dk> Reviewed-by:
-
Helmut Hummel authored
The encryption key is a vital part to ensure security of TYPO3. Not having it set (by accident) can lead to severe security issues. Therefore enforce it to be set and throw an exception in case it isn't, instead of just reporting a warning. Releases: master, 8.7, 7.6 Resolves: #82169 Change-Id: I79c73558d0968ae89a2867d6d5264530f434e1a3 Reviewed-on: https://review.typo3.org/53724 Tested-by:
-
Jigal van Hemert authored
The extension scanner now also works on windows, as the paths have been fixed to contain only one type of slashes. Change-Id: I9859f28029931f19f06873145e1de572fbb8bdfa Resolves: #82153 Releases: master Reviewed-on: https://review.typo3.org/53763 Tested-by:
-
Christian Kuhn authored
Executing 'npm run build-js' in Build/ directory reveals an update to tsconfig.json which has not been applied to core yet. Change-Id: Ida813943c3c8dc13059a707a9ea89954a14b3fd4 Resolves: #82173 Related: #81847 Releases: master Reviewed-on: https://review.typo3.org/53782 Tested-by:
-
Christian Kuhn authored
The em in "Installed Extensions" has a button "Download SQL Dump" for all extensions that provide ext_tables.sql. On click, an sql dump file is sent. This feature is severely flawed: * Dumps of extensions that add fields to existing tables contain a 'drop table' of these tables, the 'import into' statements are broken and only (try to) add these fields again. This easily leads to hazard in DB if importing such a dump. * There are no charset specs and other meta data whatsoever in the dump. * The dump is not dbal compatible, field definitions and imports are incomplete. We assume nobody really used this feature in a sane way, even at this prominent position in em. The lack of bug reports to this broken feature and the fact there have been zero changes in this area since main em refactoring years ago support this view. There are way better options to retrieve proper data specifications: * The list module has a csv export * Ext:impexp supports export and import in a much better way including proper relation handling and other options. * Low level db exports and backups should be done on cli or with more powerful guis like phpmyadmin or other db engine specific tools. The feature is dropped without substitution. The v8 backport of this patch will just remove the button from the em list view, but keep all code. Change-Id: Ia027e7498c5464af04c49675987a696ee3a06070 Resolves: #82148 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53764 Tested-by:
-
Benni Mack authored
Drop three error related constants from bootstrap: TYPO3_DLOG, TYPO3_ERROR_DLOG, TYPO3_EXCEPTION_DLOG Removal of these constants has been prepared in v8 and can be done now. This unblocks further logging related works. Along the way, the two TYPO3_CONF_VARS "enable_errorDLOG" and "enable_exceptionDLOG" can be dropped. The extension scanner can find usages of these constants, making the patch not less breaking, but usage detection within extensions is safe and thus helps a lot to spot them. A new matcher is added to the extension scanner to scan for usages of global constants. Resolves: #82162 Releases: master Change-Id: I6310866738e5cda79a807239846f64996ec76974 Reviewed-on: https://review.typo3.org/53212 Reviewed-by:
-
Christian Kuhn authored
travis-ci still chockes on executing the functional tests which take ages, even with various tricks in place. The patch reduces the travis execution to unit tests only since all main tests are executed via our bamboo environment anyway beforehand. Change-Id: I809f38d79f0ac7848e6b7e155d35aab575f4d81a Resolves: #82172 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53780 Reviewed-by:
-
Jan Helke authored
This file is only used by typo3/testing-framework and has been moved to that repository since version 1.1.1. Releases: master, 8.7 Resolves: #81900 Change-Id: I5f88bd89c4cadd2fe65f4d0bc9f4494e172f4d2a Reviewed-on: https://review.typo3.org/53643 Tested-by:
-
Christian Kuhn authored
travis-ci still chockes on functional tests, even if splitting them among lots of single tasks. Run less tests in parallel and split to ever more jobs to have a higher chance for 10 minute output with given cpu constraints. Change-Id: Iafc984aaef96ec59422f9c48a74b7308dd7cd7d7 Resolves: #82170 Releases: master, 8.7, 7.6 Reviewed-on: https://review.typo3.org/53775 Tested-by:
-
Christian Kuhn authored
Fix three issues blocking core patches. Change-Id: I07deff6294061d04e15bd1a7707e504413bb30c9 Resolves: #82168 Releases: master, 8.7 Reviewed-on: https://review.typo3.org/53773 Tested-by:
-
Wouter Wolters authored
* codeception/codeception (2.3.3 => 2.3.5) * enm1989/chromedriver (2.30 => 2.31) * friendsofphp/php-cs-fixer (v2.0.0 => v2.4.1) Resolves: #82164 Releases: master, 8.7 Change-Id: I2543b99a7e4751c09ebd733335cc3eddc025d189 Reviewed-on: https://review.typo3.org/53769 Tested-by:
-
Christian Kuhn authored
The bamboo nightly job [1] fails due to a minor CGL issue which somehow slipped through. [1] https://bamboo.typo3.com/browse/CORE-GTN Change-Id: I9e0af185e757192846185c0b7e601ff33e05e491 Resolves: #82165 Releases: master Reviewed-on: https://review.typo3.org/53771 Tested-by:
-
Christian Kuhn authored
Remove <hr> of last wizard. Change-Id: I25a52d882e99333d4598e1dcc632300e2a8860ac Resolves: #82158 Releases: master Reviewed-on: https://review.typo3.org/53768 Tested-by:
Frans Saris <franssaris@gmail.com> Reviewed-by:
-
Frank Naegler authored
This patch makes the Notification module in standalone install tool usable by adding the required CSS and fixing the dependency to the global TYPO3 object, which only exist in backend context. Resolves: #82138 Releases: master Change-Id: I954324e9d19569eedb1eb5e0ecfaf821fcecb070 Reviewed-on: https://review.typo3.org/53760 Reviewed-by:
-
Susanne Moog authored
In various places throughout the core we are using timestamps followed by a dot as unique identifiers for array keys (for example the avatar service is registered that way). The ArrayUtility renumbering function renumbers these keys on writing configuration, meaning that you cannot overwrite services registered like that via the configuration manager. ArrayUtility should not re-order strings containing a number ending with a single dot. Change-Id: I7dc1625cfdbab6704df87a8cc06f331d92992d24 Releases: master Resolves: #82155 Reviewed-on: https://review.typo3.org/53767 Tested-by:
Mathias Brodala <mbrodala@pagemachine.de> Tested-by:
-
